alamb closed issue #14649: Enable `used_underscore_binding` clippy lint
URL: https://github.com/apache/datafusion/issues/14649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
ding-young commented on issue #14649:
URL: https://github.com/apache/datafusion/issues/14649#issuecomment-2708867108
@Standing-Man I’ve already added a lint to suppress the conflict (the second
option) locally, but I couldn’t submit a PR because I think the first
approach(moving the logic a
Standing-Man commented on issue #14649:
URL: https://github.com/apache/datafusion/issues/14649#issuecomment-2708093680
Hi @ding-young, how is this going? If you aren't planning on working on
them in the near term perhaps i can help you fix it.
--
This is an automated message from the Apa
ding-young commented on issue #14649:
URL: https://github.com/apache/datafusion/issues/14649#issuecomment-2671028126
Hi @Ramjee194, I assigned myself with writing "take" (you can also do this
for other issues, too!) and already working on this issue. :)
--
This is an automated message fr
Ramjee194 commented on issue #14649:
URL: https://github.com/apache/datafusion/issues/14649#issuecomment-2671014453
can you assign this issue #14649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
findepi commented on issue #14649:
URL: https://github.com/apache/datafusion/issues/14649#issuecomment-2667781939
We could move logic of `PushDownLimit::rewrite` to make it inherent method
(`impl PushDownLimit` block).
This way we could recurse without threading useless `config` parameter
ding-young commented on issue #14649:
URL: https://github.com/apache/datafusion/issues/14649#issuecomment-2667701042
Hi, @findepi
I've set `used_underscore_binding=deny` and renamed each `_var` that was
actually used or passed down as fn arg to `var`. However, this gives another
clippy
