Re: [I] Discussion: public some aggregate related function and struct [datafusion]

2025-07-13 Thread via GitHub
alamb closed issue #16724: Discussion: public some aggregate related function and struct URL: https://github.com/apache/datafusion/issues/16724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [I] Discussion: public some aggregate related function and struct [datafusion]

2025-07-09 Thread via GitHub
haohuaijin commented on issue #16724: URL: https://github.com/apache/datafusion/issues/16724#issuecomment-3055055932 Thanks for you reply and understanding @alamb > If this is not a problem, I think making the pub is a good idea this is not a problem, i already submit the pr #16

Re: [I] Discussion: public some aggregate related function and struct [datafusion]

2025-07-09 Thread via GitHub
alamb commented on issue #16724: URL: https://github.com/apache/datafusion/issues/16724#issuecomment-3053653608 I think making these functions public is fine from my perspective My biggest concern with doing that is that we may break your application if you are relying on the interfac

[I] Discussion: public some aggregate related function and struct [datafusion]

2025-07-09 Thread via GitHub
haohuaijin opened a new issue, #16724: URL: https://github.com/apache/datafusion/issues/16724 ### Is your feature request related to a problem or challenge? DataFusion employs a two-phase aggregation process. In the first phase, it produces intermediate results, and in the second phas