Re: [PATCH] test-path-utils: use xsnprintf in favor of strcpy

2016-02-08 Thread Eric Wong
Jeff King wrote: > Repost of <20160114202608.ga8...@sigill.intra.peff.net> from a few weeks > ago (sorry, gmane is down so I can't generate a link). I prefer we use links derived from Message-IDs anyways. This prevents reliance on gmane article numbers being a central point of failure: http://m

Re: [PATCH] mergetool: reorder vim/gvim buffers in three-way diffs

2016-02-11 Thread Dickson Wong
Thanks for looking into the patch. > Thanks. I, being a non-user of vim, was wondering if people who had > their own user-defined commands (macros? and possibly short-cut keys > to invoke them) built around the old (and odd) numbering need to > adjust--in which case we may need to forewarn. > Vim

Re: [PATCH] mergetool: reorder vim/gvim buffers in three-way diffs

2016-02-11 Thread Dickson Wong
On 11 February 2016 at 11:31, Junio C Hamano wrote: > So it should suffice to mention it in the release notes as one > bullet item that describes one positive change, among all other > updates described in a simlar way. And there is no special > "warnings for existing users" necessary, I would sa

Re: [PATCH v2 2/1] support -4 and -6 switches for remote operations

2016-02-12 Thread Eric Wong
Eric Wong wrote: > (no rush to review this, unlikely to be around the next few days) Ping on v2. I will be online the next few days and likely working on some other git stuff anyways :) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a mess

Re: Interim "What's cooking"

2016-02-12 Thread Eric Wong
Junio C Hamano wrote: > * ew/connect-verbose (2016-01-28) 1 commit > (merged to 'next' on 2016-02-03 at ceac37e) > + pass transport verbosity down to git_connect Btw, I posted v2 of this with tests added to t/t5570-git-daemon.sh http://mid.gmane.org/20160130085056.ga20...@dcvr.yhbt.net Can

[PATCH] t5570: add tests for "git fetch -v"

2016-02-12 Thread Eric Wong
Now that git_connect is more information about connectivity progress after: ("pass transport verbosity down to git_connect") we should ensure it remains so for future users who need to to diagnose networking problems. Signed-off-by: Eric Wong --- Junio C Hamano wrote: > On Fri,

[PATCH v2] t5570: add tests for "git {clone,fetch,pull} -v"

2016-02-14 Thread Eric Wong
Now that git_connect is more information about connectivity progress after: ("pass transport verbosity down to git_connect") we should ensure it remains so for future users who need to to diagnose networking problems. Signed-off-by: Eric Wong --- Thanks for the feedback, v2

Re: [PATCH 1/2] git-svn: enable "svn.pathnameencoding" on dcommit

2016-02-14 Thread Eric Wong
Kazutoshi Satoda wrote: > Signed-off-by: Kazutoshi SATODA Signed-off-by: Eric Wong Thanks, it took me some time to figure out the test case which I will amend: diff --git a/t/t9115-git-svn-dcommit-funky-renames.sh b/t/t9115-git-svn-dcommit-funky-renames.sh index 6a48e40..8fd 100

Re: [PATCH 2/2] git-svn: apply "svn.pathnameencoding" before URL encoding

2016-02-14 Thread Eric Wong
error from Subversion such as > "Filesystem has no item: '...' path not found" when sending a rename (or > a copy) from non-ASCII path. > > Signed-off-by: Kazutoshi SATODA Thanks, running full SVN tests now. Signed-off-by: Eric Wong > --- a/perl/Git/SVN/Edit

[PULL] svn pathnameencoding for git svn dcommit

2016-02-14 Thread Eric Wong
I've amended tests to both commits, but the URL encoding one requires an HTTP server to test effectively. I couldn't find a test prereq for httpd, but perhaps it's good to test by default regardless in case a future SVN changes file:// behavior. I've only tested this with SVN 1.6.17 under Debian

Re: git svn dcommit doesn't support --username option for file:/// urls

2016-02-15 Thread Eric Wong
Tim Ringenbach wrote: > Hi, > > 'git svn dcommit' doesn't seem to honor the --username argument when > my svn repository url is a file:/// url. It doesn't complain either, > it just seems to silently ignore the option. My dcommits show up as > the user I'm logged in as. The only way I found to c

Re: git svn dcommit doesn't support --username option for file:/// urls

2016-02-15 Thread Eric Wong
Tim Ringenbach wrote: > On Mon, Feb 15, 2016 at 4:06 AM, Eric Wong wrote: > [snip] > > Totally untested, but does flipping the order of auth providers > > help at all? > > Thanks for looking into this. Unfortunately, that didn't seem to make > a difference. Tha

Re: [PULL] svn pathnameencoding for git svn dcommit

2016-02-15 Thread Eric Wong
Junio, sorry about basing on next, I somehow thought I was going to need to depend on something there. Updated pull below if Kazutoshi can run the test effectively. Kazutoshi Satoda wrote: > Thank you for the tests. But, on my environment, both of them failed > unexpectedly. (Windows 7 SP1, x86_6

Re: [PULL] svn pathnameencoding for git svn dcommit

2016-02-20 Thread Eric Wong
Kazutoshi Satoda wrote: > (Shouldn't the branch be based on maint, as these are bugfixes?) I'm not sure if it being previously left-out/untested feature would qualify for maint. Maybe it does, but I suppose I'll let Junio decide. > Thank you. I tried it but got similar problem: > I found how

Re: [PATCH v5 23/27] svn: learn ref-storage argument

2016-02-20 Thread Eric Wong
David Turner wrote: > +++ b/git-svn.perl > + if (defined $_ref_storage) { > + push @init_db, "--ref-storage=" . $_ref_storage; > + } Minor nit: git-svn uses tabs for indentation. Otherwise, if we go this route, consider it: Si

[PATCH v4 0/3] git-svn: svn.pathnameencoding for dcommit

2016-02-21 Thread Eric Wong
nges up to 1b42f45255de5844b7fe8d0c60fea74cd5b9f954: git-svn: apply "svn.pathnameencoding" before URL encoding (2016-02-22 02:29:36 +) ---- Eric Wong (1): git-svn: hoist out utf8 prep from t9129 to lib-git-svn Kazutoshi Satoda (2):

[PATCH v4 1/3] git-svn: hoist out utf8 prep from t9129 to lib-git-svn

2016-02-21 Thread Eric Wong
We will be reusing this in t9115. Suggested-by: Kazutoshi Satoda Signed-off-by: Eric Wong --- t/lib-git-svn.sh | 12 t/t9129-git-svn-i18n-commitencoding.sh | 12 +--- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/t/lib-git-svn.sh b

[PATCH v4 3/3] git-svn: apply "svn.pathnameencoding" before URL encoding

2016-02-21 Thread Eric Wong
on such as "Filesystem has no item: '...' path not found" when sending a rename (or a copy) from non-ASCII path. [ew: t9115 test case added (requires SVN_HTTPD_PORT set to test), squash LC_ALL=$a_utf8_locale export from Kazutoshi for Cygwin] Signed-off-by: Kazutoshi SATODA Signe

[PATCH v4 2/3] git-svn: enable "svn.pathnameencoding" on dcommit

2016-02-21 Thread Eric Wong
(e.g. "Malformed XML") which happen only when a commit involves a change on non-ASCII path. [ew: add test case to t9115, squash LC_ALL=$a_utf8_locale export from Kazutoshi for Cygwin] Signed-off-by: Kazutoshi SATODA Signed-off-by: Eric Wong --- perl/Git/SVN/Editor.pm

[PATCH] tests: remove unused full-svn-test target

2016-02-21 Thread Eric Wong
ne.jp Signed-off-by: Eric Wong --- t/Makefile | 5 - 1 file changed, 5 deletions(-) diff --git a/t/Makefile b/t/Makefile index 43b15e3..ad97a7e 100644 --- a/t/Makefile +++ b/t/Makefile @@ -77,11 +77,6 @@ aggregate-results: echo "$$f"; \ done | '$(SHE

[PATCH v2] tests: remove no-op full-svn-test target

2016-02-22 Thread Eric Wong
030...@f2.dion.ne.jp Helped-by: Kazutoshi Satoda Signed-off-by: Eric Wong --- v2: remove TSVN, too. Kazutoshi Satoda wrote: > The variable TSVN becomes unused by this removal. It should be removed > together, shouldn't it? Yes, thanks :) I also noticed the contrib/sub

Re: [PATCH 1/1] t9115: Skip pathnameencoding=cp932 under HFS

2016-02-27 Thread Eric Wong
tbo...@web.de wrote: > --- a/t/t9115-git-svn-dcommit-funky-renames.sh > +++ b/t/t9115-git-svn-dcommit-funky-renames.sh > @@ -93,7 +93,7 @@ test_expect_success 'git svn rebase works inside a > fresh-cloned repository' ' > # > to special UNICODE characters in the range 0xf000 to 0xf0ff (the > # >

Re: [Q] updates to gitk, git-gui and git-svn for 2.8?

2016-03-14 Thread Eric Wong
- Eric Wong (1): git-svn: shorten glob error message Torsten Bögershausen (1): t9115: Skip pathnameencoding=cp932 under HFS Victor Leschuk (1): git-svn: loosen config globs limitations Documentation/git-svn.txt | 12 ++ perl/Git/SVN/GlobSpec.pm

Re: [PATCH 1/1] t9115: Skip pathnameencoding=cp932 under HFS

2016-03-14 Thread Eric Wong
Torsten Bögershausen wrote: > On 28.02.16 05:59, Eric Wong wrote: > > tbo...@web.de wrote: > > Please keep lines wrapped at 80 cols or less. > > (I need big fonts) > OK > > > >> @@ -105,10 +105,10 @@ test_expect_success UTF8 'svn.path

Re: [PATCH 1/1] t9115: Skip pathnameencoding=cp932 under HFS

2016-03-15 Thread Eric Wong
Torsten Bögershausen wrote: > On 03/15/2016 02:59 AM, Eric Wong wrote: > >[] > >I just edited locally and pushed those out to Junio: > > > >http://mid.gmane.org/20160315015726.ga25...@dcvr.yhbt.net > > > > The new TC 11/12 don't pass under cygwin. &

Re: [Q] updates to gitk, git-gui and git-svn for 2.8?

2016-03-15 Thread Eric Wong
Eric Wong wrote: > Junio C Hamano wrote: > > If there are pending updates for the upcoming release, please let me > > know and tell me what to pull. > > The following changes since commit db6696f653b917509dac1ac13b922e12773a84ff: > > Merge branch 'mg/wt-st

[PATCH 2/1] git-svn: fix URL canonicalization during init w/ SVN 1.7+

2016-03-19 Thread Eric Wong
in SVN. Tested with the following commands: git svn init -T svn://svn.code.sf.net/p/squirrelmail/code/trunk git svn init -b svn://svn.code.sf.net/p/squirrelmail/code/branches Reported-by: Adam Dinwoodie http://mid.gmane.org/20160315162344.gm29...@dinwoodie.org Signed-off-by: Eric Wong

[PULL] git-svn URL canonicalization fixes for 2.8

2016-03-19 Thread Eric Wong
t9117: test specifying full url to git svn init -T Eric Wong (1): git-svn: fix URL canonicalization during init w/ SVN 1.7+ git-svn.perl | 14 -- t/t9117-git-svn-init-clone.sh | 6 ++ 2 files changed, 14 insertions(+), 6 deletions(-) -- To unsubscribe

Re: [PATCH] t9117: test specifying full url to git svn init -T

2016-03-19 Thread Eric Wong
; > Signed-off-by: Adam Dinwoodie Thanks, I was just working on a patch to fix this problem when I got this patch :) Signed-off-by: Eric Wong > --- > > I think the bug here is in using perl/Git/SVN/Utils.pm's > `canonicalize_path` on the `-T` argument. If it's availabl

Re: [GSoC] A late proposal: a modern send-email

2016-03-27 Thread Eric Wong
Junio C Hamano wrote: > 惠轶群 writes: > > - Build a simple email client (maybe a web components based web app or > > wxwidgets based GUI client, they are both cross-platform) which is > > easy to use for sending patch without disrupting the mailbox format. > > I suspect it would yield a better res

Re: [GSoC] A late proposal: a modern send-email

2016-04-04 Thread Eric Wong
惠轶群 wrote: > 2016-03-28 6:00 GMT+08:00 Eric Wong : > > While Gmail provides SMTP access, it was (last I was told) > > incompatible with two-factor auth; so I've encountered users > > unable to send patches with their normal 2FA-enabled accounts. > > That'

[PATCH] send-email: more meaningful Message-ID

2016-04-05 Thread Eric Wong
g the Message-ID by 15 characters can make for unpleasant Message-ID-based URLs to archive sites. Signed-off-by: Eric Wong --- git-send-email.perl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/git-send-email.perl b/git-send-email.perl index d356901..23141e7 100755 --- a/git

Re: [PATCH] send-email: more meaningful Message-ID

2016-04-05 Thread Eric Wong
Junio C Hamano wrote: > Eric Wong writes: > > > Using a mmddHHMMSS date representation is more meaningful to > > humans, especially when used for lookups on NNTP servers or linking > > to archive sites via Message-ID (e.g. mid.gmane.org or > > mid.mail-archiv

[PATCH v2] send-email: more meaningful Message-ID

2016-04-06 Thread Eric Wong
g the Message-ID by 15 characters can make for unpleasant Message-ID-based URLs to archive sites. Signed-off-by: Eric Wong --- v2 - moved "use" to the top Thanks to Dscho for addressing Windows comments: http://mid.gmane.org/alpine.DEB.2.20.1604061505010.3371@virtualbox git-send

[PATCH] send-email: do not load Data::Dumper

2016-04-06 Thread Eric Wong
We never used Data::Dumper in this script. The only reference of it was always commented out and removed over a decade ago in commit 4bc87a28be020a6bf7387161c65ea3d8e4a0228b ("send-email: Change from Mail::Sendmail to Net::SMTP") Signed-off-by: Eric Wong --- While I'm in the are

Re: log --pretty accepts incomplete pre-defined formats

2016-04-06 Thread Eric Wong
Junio C Hamano wrote: > Sidhant Sharma writes: > > > Recently while playing around with git log, I realized that it is possible > > to > > pass incomplete (pre-defined) format names. For example, it is possible to > > use > > `git log --pretty=one` instead of oneline and it would still output

Re: clone hang prevention / timeout?

2016-04-12 Thread Eric Wong
Jason Vas Dias wrote: > It appears GIT has no way of specifying a timeout for a clone operation - > if the server decides not to complete a get request, the clone can > hang forever - > is this correct ? git uses SO_KEEPALIVE for all connections it makes, so whatever your kernel TCP keepalive kno

[PATCH] fast-import: implement --min-pack-size parameter

2016-04-22 Thread Eric Wong
packs were aggressively optimized and marked with .keep files. In those cases, users may be better served with loose objects and relying on "git gc --auto". Signed-off-by: Eric Wong --- There should be a matching config file directive, but I'm not sure how/if it should affect

[PATCH v2] fast-import: implement unpack limit

2016-04-23 Thread Eric Wong
e initial packs were aggressively optimized and marked with .keep files. In those cases, users may be better served with loose objects and relying on "git gc --auto". This changes the default behavior of fast-import for small imports found in test cases, so adjustments to t9300 were nec

Re: [PATCH v2] fast-import: implement unpack limit

2016-04-24 Thread Eric Wong
Junio C Hamano wrote: > Eric Wong writes: > > + argv_array_push(&unpack.args, "unpack-objects"); > > + argv_array_push(&unpack.args, "-q"); > > + > > + return run_command(&unpack); > Looks good. I haven't thought i

Re: [git send-email] Less secure?

2016-04-24 Thread Eric Wong
Neven Sajko wrote: > Gmail by default doesn't allow usage through send-email. > They say that send-email is "less secure" and that enabling it > makes it easier to break into my account. > > Is send-email really less secure than the Gmail web browser > interface? Like any email client, git send-

[PATCH v3] fast-import: implement unpack limit

2016-04-25 Thread Eric Wong
ned-off-by: Eric Wong --- v2 changes: implemented as a git-config directive v3 changes: * honor --quiet for fast-import as -q for unpack-objects * minor style adjustment when calling loosen_small_pack Documentation/config.txt| 9 +++ Documentation/git-fast-import.

[PATCH] pack-objects: warn on split packs disabling bitmaps

2016-04-27 Thread Eric Wong
21134714787a02a37da15424d72c0119b2b8ed71 ("pack-objects: turn off bitmaps when we split packs"). Tested the warning by inspecting the output of: make -C t t5310-pack-bitmaps.sh GIT_TEST_OPTS=-v Signed-off-by: Eric Wong --- Fwiw, I'm hoping to publish an ~800MB git-clone-able repo of

[PATCH v2] pack-objects: warn on split packs disabling bitmaps

2016-04-28 Thread Eric Wong
Junio C Hamano wrote: > Eric Wong writes: > > +++ b/Documentation/git-pack-objects.txt > > @@ -110,7 +110,8 @@ base-name:: > > --max-pack-size=:: > > Maximum size of each output pack file. The size can be suffixed with > > "k", "m",

Re: [PATCH] pack-objects: warn on split packs disabling bitmaps

2016-04-28 Thread Eric Wong
Jeff King wrote: > On Wed, Apr 27, 2016 at 09:53:24PM +, Eric Wong wrote: > > > It can be tempting for a server admin to want a stable set of > > long-lived packs for dumb clients; but also want to enable > > bitmaps to serve smart clients more quickly. > But I di

Re: clone hang prevention / timeout?

2016-04-30 Thread Eric Wong
Jason Vas Dias wrote: > Thanks very much Eric & Jeff for your reply . > > Personally, I would recommend setting the SO_RECVTIMEO for GIT server > sockets to a fixed default (eg. 5mins) , settable by a > '--receive-timeout' argument or configuration parameter . (apologies for the delay, I thoug

[PATCH] .mailmap: update to my shorter email address

2016-05-02 Thread Eric Wong
Following f916ab0ccc ("send-email: more meaningful Message-ID"), my own email address is too long :x While I could have an even shorter address by one character with "yhbt.net", "80x24.org" is more representative of my hacking-related pursuits. Signed-off-by: Eric

Re: [PATCH] git-svn: improve rebase/mkdirs performance

2015-11-09 Thread Eric Wong
ives. This takes 10 minutes to process when using a single hash, vs 3 seconds with a hash of hashes. [ew: wrap comments, shorten initializations, avoid unnecessary spaces] Signed-off-by: Dair Grant Signed-off-by: Eric Wong --- perl/Git/SVN.pm | 84 +++--

[PULL] git-svn: improve rebase/mkdirs performance

2015-11-11 Thread Eric Wong
Hi Jeff/Junio, nothing urgent, please pull at your convenience. Thanks. The following changes since commit f34be46e47773d03e9d09641209121591a6b37c8: Eleventh batch for 2.7 (2015-11-05 15:26:08 -0800) are available in the git repository at: git://git.bogomips.org/git-svn.git master for you

Re: [RFPR] updates for 2.7?

2015-12-15 Thread Eric Wong
Junio C Hamano wrote: > Git 2.7-rc1 has just been tagged, and the remainder of the year will > be for the stabilization, fixes to brown-paper-bag bugs, reverts of > regressions, etc., but I haven't seen updates to the various > subsystems you guys maintain for some time. Please throw me "this > i

Re: Help debugging git-svn

2015-12-15 Thread Eric Wong
Edmundo Carmona Antoranz wrote: > 1 [main] perl 5652 cygwin_exception::open_stackdumpfile: Dumping stack > trace to perl.exe.stackdump > > And then, in the file: > > Exception: STATUS_ACCESS_VIOLATION at rip=0048360C10C > rax=000601E4BFF8 rbx=5219E248 rcx=00060003A590 > rdx=0

Re: [PATCH 2/2] git-svn: test for git-svn prefixed globs

2015-12-16 Thread Eric Wong
Thanks for this work. Most things look fine with 1/2, comments on 2/2 below... Victor Leschuk wrote: > Add test for git-svn prefixed globs. Why a separate patch? Unless there's some documentation purpose for a regression, usually tests and a feature should be added atomically in the same commi

Re: [PATCH 2/2] git-svn: test for git-svn prefixed globs

2015-12-16 Thread Eric Wong
Victor Leschuk wrote: > Hello Eric, sorry, I just copy pasted your old > t9108-git-svn-glob.sh, changed branch names to be prefixed and added > test for "exact" prefix match. If it is necessary I can rewrite it > according to current guidelines. Yes, please do if you can. I can do it if you're w

Re: [PATCH v3] git-svn: add support for prefixed globs in config

2015-12-17 Thread Eric Wong
Victor Leschuk wrote: > --- /dev/null > +++ b/t/t9168-git-svn-prefixed-glob.sh > @@ -0,0 +1,136 @@ > +#!/bin/sh > +test_description='git svn globbing refspecs with prefixed globs' > +. ./lib-git-svn.sh > + > +cat >expect.end < +the end > +hi > +start a new branch > +initial > +EOF > + > +test_expe

[RFC] git-send-email: do not double-escape quotes from mutt

2015-12-26 Thread Eric Wong
mutt saves aliases with escaped quotes in the form of: alias dot \"Dot U. Sir\" When we pass through our sanitize_address routine, we end up with double-escaping: To: "\\\"Dot U. Sir\\\" Remove the escaping in mutt only for now, as I am not sure if other mailers can do this o

Re: [RFC] git-send-email: do not double-escape quotes from mutt

2015-12-28 Thread Eric Wong
Junio C Hamano wrote: > Eric Wong writes: > > > -# commas delimit multiple addresses > > - $aliases{$alias} = [ split_addrs($addr) ]; > > + # commas delimit multiple addresses > > +

[PATCH v2] git-send-email: do not double-escape quotes from mutt

2016-01-04 Thread Eric Wong
mutt saves aliases with escaped quotes in the form of: alias dot \"Dot U. Sir\" When we pass through our sanitize_address routine, we end up with double-escaping: To: "\\\"Dot U. Sir\\\" Remove the escaping in mutt only for now, as I am not sure if other mailers can do this o

Re: [PATCH v2] git-send-email: do not double-escape quotes from mutt

2016-01-04 Thread Eric Wong
Junio C Hamano wrote: > Forgot to sign-off (I could forge it, though, but anyway)? Oops :x Signed-off-by: Eric Wong -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.

[PATCH] for-each-ref: document `creatordate` and `creator` fields

2016-01-04 Thread Eric Wong
These were introduced back in 2006 at 3175aa1ec28c but never documented. Signed-off-by: Eric Wong --- And I just found these very useful, today! I also noticed creator{name,email} aren't supported, yet. Perhaps they're worth implementing for consistency. Documentation/git-for-ea

Re: [PATCH v4] git-svn: add support for prefixed globs in config

2016-01-05 Thread Eric Wong
Junio C Hamano wrote: > Victor Leschuk writes: > > + branches = branches/release_*:refs/remotes/project-a/branches/release_* > > Hmph, if you are going this route, I wonder if there is a reason to > limit yourself only to "prefix". Would allowing something like this: > > branches = bra

Re: a git svn bug

2018-12-28 Thread Eric Wong
肖建晶 <06271...@bjtu.edu.cn> wrote: > hi, >git developers. I found a bug when i want to convert webkit to git >there are some branch named safari... in webkit svn repo. >when i want to convert them to branch in git. a problem happen. > >if you want to reproduce the problem, just foll

"IMAP IDLE"-like long-polling "git fetch"

2018-12-28 Thread Eric Wong
Hey all, I just added this to the TODO file for public-inbox[1] but obviously it's intended for git.git (meta@public-inbox cc-ed): > +* Contribute something like IMAP IDLE for "git fetch". > + Inboxes (and any git repos) can be kept up-to-date without > + relying on polling. I would've thought

Re: "IMAP IDLE"-like long-polling "git fetch"

2018-12-28 Thread Eric Wong
Konstantin Ryabitsev wrote: > On Sat, Dec 29, 2018 at 03:56:21AM +, Eric Wong wrote: > > Hey all, I just added this to the TODO file for public-inbox[1] but > > obviously it's intended for git.git (meta@public-inbox cc-ed): > > > > > +* Contribute some

[PATCH] banned.h: mark strncat() as banned

2019-01-02 Thread Eric Wong
strncat() has the same quadratic behavior as strcat() and is difficult-to-read and bug-prone. While it hasn't yet been a problem in git iself, strncat() found it's way into 'master' of cgit and caused segfaults on my system. Signed-off-by: Eric Wong --- banned.h | 2 +

Re: What's cooking in git.git (Jan 2019, #02; Tue, 15)

2019-01-15 Thread Eric Wong
Junio C Hamano wrote: > * ew/ban-strncat (2019-01-02) 1 commit > (merged to 'next' on 2019-01-08 at 3bba2ae2bb) > + banned.h: mark strncat() as banned Can you squash in Eric Sunshine's speling fix in my commit message? (s/iself/itself/) https://public-inbox.org/git/CAPig+cR2w3S==3-zstjmuB9jw4H

cat-file ambiguity prints "dangling"

2019-01-17 Thread Eric Wong
Hi David, Perhaps I'm confused, the cat-file manpage seems to indicate "dangling" only gets printed if I use "--follow-symlinks". However, I'm not using "--follow-symlinks" and I get "dangling" when passing ambiguous object IDs: Trying to check the ambiguous "dead" against git.git, I get:

Re: cat-file ambiguity prints "dangling"

2019-01-18 Thread Eric Wong
David Turner wrote: > It appears that get_oid_with_context calls into get_short_oid for that > case, and get_short_oid returns SHORT_NAME_AMBIGUOUS, which is -2. We > treat that as DANGLING_SYMLINK, which also seems to have the value -2. > So, it's an ambiguity in ambiguity resolution. > > Fix

[PATCH] t1512: test ambiguous cat-file --batch and --batch-output

2019-01-18 Thread Eric Wong
David Turner wrote: > Let's try this version. Thanks! Tested-by: Eric Wong Not sure if t1512 would be the best place to put the test, but having a repo with ambiguous data already at hand was easiest. -8<--- Subject: [PATCH] t1512: test ambiguous cat-file --batch

Re: How to convert SVN tags to git tags?

2019-01-18 Thread Eric Wong
Steve Keller wrote: > After converting from SVN to git using git svn init + git svn fetch, > my SVN tags appear as remote branches in git. I find many suggestions > to convert these to git tags by calling git tag -a > but this gives something like this Hi Steve, instead of an annotated tag ("-

Re: How do I get rid of unneeded objects?

2019-01-18 Thread Eric Wong
Steve Keller wrote: > $ git reflog expire --all I've never used "git reflog" directly, but I think you need to add "--expire=all" to cover all time. "--all" is only for all branches, so you need "--expire=" is for a time range. Fwiw, I use a single command: git -c gc.reflogExpire=n

Re: Missing patch?

2019-01-21 Thread Eric Wong
Stefan Xenos wrote: > I've tried to upload a patch twice but it doesn't seem to be showing > up in my mailbox or in the mailing list archives. The patch title was > "[RFC PATCH] evolve: Implement the git change command". > > Has anyone seen it? Is there a reason the mailing list would reject a pa

testing some changes to a public-inbox .onion

2019-01-21 Thread Eric Wong
WITHOUT reading m...@public-inbox.org, maybe some of you can spot some differences :) You'll need to use Tor to access .onions, of course: http://hjrcffqmbrq6wope.onion/git/ Tested with Netsurf and dillo. People with machines powerful enough to run Firefox (or Tor Browser Bundle) can us

Re: testing some changes to a public-inbox .onion

2019-01-23 Thread Eric Wong
Johannes Schindelin wrote: > On Mon, 21 Jan 2019, Eric Wong wrote: > >http://hjrcffqmbrq6wope.onion/git/ > > > > Tested with Netsurf and dillo. > > Nice. > > Do you also plan on taking care of the regular thread view? I still find > it *very* hard

Re: [PATCH (Apple Git) 11/13] Fix problem found from running the test suite.

2019-01-29 Thread Eric Wong
Jeremy Huddleston Sequoia wrote: > From: Matt Wright > > Signed-off-by: Matt Wright Hi Jeremy/Matt: I expect to see a description of said "problem" More comments inline below... > diff --git a/git-svn.perl b/git-svn.perl > index 050f2a36f4..d29730be3b 100755 > --- a/git-svn.perl > +++ b/git-

[PATCH v2] t1512: test ambiguous cat-file --batch and --batch-output

2019-01-30 Thread Eric Wong
batch and --batch-output Test the new "ambiguous" result from cat-file --batch and --batch-check. This is in t1512 instead of t1006 since we need a repo with ambiguous object_id names. Signed-off-by: Eric Wong --- t/t1512-rev-parse-disambiguation.sh | 10 ++ 1 file changed

Re: Proposal: Remembering message IDs sent with git send-email

2019-05-09 Thread Eric Wong
Drew DeVault wrote: > --in-reply-to=ask doesn't exist, that's what I'm looking to add. This > convenient storage mechanism is exactly what I'm talking about. Sorry > for the confusion. Using Net::NNTP to query NNTP servers using ->xover([recent-ish range]) to scan for Message-IDs and Subjects mat

[PATCH] update-server-info: avoid needless overwrites

2019-05-10 Thread Eric Wong
be able to avoid block layer writes and reduce wear. Signed-off-by: Eric Wong --- server-info.c | 61 +-- t/t5200-update-server-info.sh | 41 +++ 2 files changed, 92 insertions(+), 10 deletions(-) create mode 100755 t/t5200

[PATCH v2] update-server-info: avoid needless overwrites

2019-05-11 Thread Eric Wong
Eric Sunshine wrote: > On Fri, May 10, 2019 at 9:35 PM Eric Wong wrote: > > + if (strbuf_fread(&tmp, (size_t)new_len, fp) != (size_t)new_len) > > + return 1; > > Although strbuf_fread() will release 'tmp' automatically if the read > ac

new segfault in master (6a6c0f10a70a6eb1)

2019-05-11 Thread Eric Wong
This test-tool submodule segfault seems new. Noticed it while checking dmesg for other things. There's also "name-rev HEAD~4000" (bottom), which is old, I think... Core was generated by `$WT/t/helper/test-tool submodule-nested-repo-config submodule sub'. Program terminated with signal SIGSEGV, S

Re: [PATCH] update-server-info: avoid needless overwrites

2019-05-11 Thread Eric Wong
Eric Wong wrote: > Combined with stdio and kernel buffering; the kernel should be > able to avoid block layer writes and reduce wear. Along the same lines, I'd like to get repack to stop recreating identical packs at some point (but that could be months from now...)

Re: [PATCH] update-server-info: avoid needless overwrites

2019-05-11 Thread Eric Wong
Ævar Arnfjörð Bjarmason wrote: > On Sat, May 11 2019, Eric Wong wrote: > > +static int files_differ(FILE *fp, const char *path) > > +{ > > + struct stat st; > > + git_hash_ctx c; > > + struct object_id oid_old, oid_new; > > + struct strbuf tmp = ST

[PATCH v3] update-server-info: avoid needless overwrites

2019-05-13 Thread Eric Wong
files. Remove documentation for --force. Signed-off-by: Eric Wong --- OK, performing the incremental comparison wasn't nearly as bad as thought it'd be. I might be suffering from compiler-linker-slowness PTSD :x Interdiff: diff --git a/Documentation/git-update-server-i

Re: [PATCH] update-server-info: avoid needless overwrites

2019-05-14 Thread Eric Wong
Jeff King wrote: > Yeah, I think there's sort of an open question here of who is calling > update-server-info when nothing got updated. I think the only place we > call it automatically is via receive-pack, but I'd guess Eric runs it as > part of public-inbox scripts. Correct. post-update doesn'

dumb HTTP things I want to do

2019-05-14 Thread Eric Wong
Eric Wong wrote: > Jeff King wrote: > > That's my reading, too, but I didn't want to be responsible for > > regressing some obscure case. At least Eric seems to _use_ > > update-server-info. ;) > > I also have something else on my mind for abusing info fil

Re: [PATCH] get_oid: handle NULL repo->index

2019-05-14 Thread Eric Wong
Jeff King wrote: > +++ b/sha1-name.c > @@ -1837,7 +1837,7 @@ static enum get_oid_result > get_oid_with_context_1(struct repository *repo, > if (flags & GET_OID_RECORD_PATH) > oc->path = xstrdup(cp); > > - if (!repo->index->cache) > + i

[PATCH 2/1] server-info: conditionally update on fetch

2019-05-14 Thread Eric Wong
the new `updated_refs' counter to update server info files iff info/refs already exists. Note: this depends on Ævar's WIP in: https://public-inbox.org/git/87ftphw7mv@evledraar.gmail.com/ Signed-off-by: Eric Wong --- builtin/fetch.c| 3 +++ server-info.c

[WIP] repack leaving stale entries in objects/info/packs

2019-05-15 Thread Eric Wong
I've also noticed objects/info/packs contains stale entries after repack/gc runs on current git. Tried adding reprepare_packed_git before update_server_info, but that didn't seem to work; so maybe something isn't cleared. Might have time to investigate more this week, might not... diff --git a/bu

[PATCH] server-info: do not list unlinked packs

2019-05-23 Thread Eric Wong
Jeff King wrote: > On Wed, May 15, 2019 at 08:38:39PM +, Eric Wong wrote: > > > I've also noticed objects/info/packs contains stale entries > > after repack/gc runs on current git. > > > > Tried adding reprepare_packed_git before update_server_info, &

[PATCH v2] server-info: do not list unlinked packs

2019-05-23 Thread Eric Wong
Jeff King wrote: > On Thu, May 23, 2019 at 08:59:59AM +, Eric Wong wrote: > > > > We never delete entries from the in-memory packed_git list; a reprepare > > > only adds to the list. You'd need to teach update_server_info() to > > > ignore packs which ar

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread Eric Wong
Chris Mayo wrote: > git-send-email uses the TLS support in the Net::SMTP core module from > recent versions of Perl. Documenting the minimum version is complex > because of separate numbering for Perl (5.21.5~169), Net:SMTP (2.34) > and libnet (3.01). Version numbers from commit: > bfbfc9a953 ("se

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread Eric Wong
Ævar Arnfjörð Bjarmason wrote: > On Mon, May 27 2019, Eric Wong wrote: > > Chris Mayo wrote: > >> git-send-email uses the TLS support in the Net::SMTP core module from > >> recent versions of Perl. Documenting the minimum version is complex > >> because of sep

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread Eric Wong
Todd Zullinger wrote: > I wonder if it's (separately from this change) worth > adjusting the conditional which sets $use_net_smtp_ssl to > use "Net::SMTP->can('starttls')" rather than a strict > version check? (It might not be if using 'can' is too > fragile or would only benefit the Red Hat 7 pa

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread Eric Wong
Ævar Arnfjörð Bjarmason wrote: > On Tue, May 28 2019, Eric Wong wrote: > > Todd Zullinger wrote: > >> Something like: > >> > >> diff --git i/git-send-email.perl w/git-send-email.perl > >> index 24859a7bc3..84ac03994d 100755 > >> --

nntp://news.public-inbox.org/ may be unstable

2019-06-21 Thread Eric Wong
Hopefully I didn't break anything, stress testing some stuff and my own Internet connection is intermittent :<

Re: 2.22.0 repack -a duplicating pack contents

2019-06-23 Thread Eric Wong
Jeff King wrote: > On Sun, Jun 23, 2019 at 04:54:50PM +0200, Ævar Arnfjörð Bjarmason wrote: > > > I haven't looked at this for more than a couple of minutes (and don't > > have more time now), but this is almost certainly due to 36eba0323d > > ("repack: enable bitmaps by default on bare repos", 2

TLS on news.public-inbox.org [was: may be unstable]

2019-06-24 Thread Eric Wong
Eric Wong wrote: > Hopefully I didn't break anything, stress testing some stuff > and my own Internet connection is intermittent :< STARTTLS is now available on port 119, and NNTPS on 563. I think it works... :x No idea if it's actually secure or not; but it might help get

[PATCH] repack: disable bitmaps-by-default if .keep files exist

2019-06-28 Thread Eric Wong
Jeff King wrote: > On Sun, Jun 23, 2019 at 06:08:25PM +, Eric Wong wrote: > > > > I'm not sure of the right solution. For maximal backwards-compatibility, > > > the default for bitmaps could become "if not bare and if there are no > > > .keep files&

[PATCH v2] repack: disable bitmaps-by-default if .keep files exist

2019-06-29 Thread Eric Wong
SZEDER Gábor wrote: > On Fri, Jun 28, 2019 at 07:02:11AM +, Eric Wong wrote: > > diff --git a/t/t7700-repack.sh b/t/t7700-repack.sh > > index 86d05160a3..0acde3b1f8 100755 > > --- a/t/t7700-repack.sh > > +++ b/t/t7700-repack.sh > > @@ -239,4 +239,14 @@ te

[PATCH 2/1] repack: warn if bitmaps are explicitly enabled with keep files

2019-06-29 Thread Eric Wong
r explicitly enables bitmaps, we should warn if .keep files exist or are specified via --keep-pack Signed-off-by: Eric Wong --- builtin/repack.c | 8 t/t7700-repack.sh | 16 2 files changed, 24 insertions(+) diff --git a/builtin/repack.c b/builtin/repack.c index 73250b2

Re: Surprising use of memory and time when repacking mozilla's gecko repository

2019-07-04 Thread Eric Wong
Mike Hommey wrote: > I'm puzzled by the fact writing objects is so much faster with 1 thread. I/O contention in the multi-threaded cases? "public-inbox-index" (reading from git, writing to Xapian+SQLite) on a dev machine got slow because core count exceeded what SATA could handle and had to cap

<    1   2   3   4   5   6   7   8   9   10   >