[PATCH] git-compat-util.h: reduce optimization level to 1 on MinGW env.

2013-09-25 Thread Wataru Noguchi
optimization level from O2 to O1 when MinGW Windows environment. Signed-off-by: Wataru Noguchi --- git-compat-util.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/git-compat-util.h b/git-compat-util.h index a31127f..394c23b 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -90,6 +90,8

Re: [msysGit] Re: [PATCH] git-compat-util.h: reduce optimization level to 1 on MinGW env.

2013-09-25 Thread Wataru Noguchi
made in the Makefile instead of > git-compat-util.h. Yes, I see. I think so. I shuld write optimization level change code to Makefile instead of git-compat-util.h. 2013/9/26 Jonathan Nieder : > (cc-ing the Git for Windows maintainers) > Hi, > > Wataru Noguchi wrote: > >> Git for

[PATCH] mingw-multibyte: fix memory acces violation and path length limits.

2013-09-28 Thread Wataru Noguchi
ent. This length is Windows full path limits. But for relative path is too short. This commit fixes: - convert_attrs() in convert.c: initialize ccheck[0].attr with NULL. - git-compat-util.h: redifine PATH_MAX value to 4096 when MinGW environment. Signed-off-by: Wataru Noguchi --- conver

Re: [msysGit] [PATCH] mingw-multibyte: fix memory acces violation and path length limits.

2013-09-28 Thread Wataru Noguchi
ue to 4096 if MinGW environment.(6cae216) Works fine. Is this failure caused by PATH_MAX length too short? or my repository directory depth too deep? But when optimization disabled(O0) in Makefile , works fine...(bf0acff) Do you know what's happen? Thanks. (2013/09/29 8:18), Johannes Schind

Re: [PATCH] mingw-multibyte: fix memory acces violation and path length limits.

2013-10-01 Thread Wataru Noguchi
Hi, Thanks for your patch. Unfortunately, in my case still crash... But PATH_MAX length kinds issues interesting. I'll try investigate a little more. - PATH_MAX and O2 Thanks. (2013/10/01 2:00), René Scharfe wrote: Am 29.09.2013 04:56, schrieb Wataru Noguchi: Hi, Thanks for com

Re: [msysGit] [PATCH] mingw-multibyte: fix memory acces violation and path length limits.

2013-10-01 Thread Wataru Noguchi
Hi, Thanks for your advice. I see. I'll try following tool for optimization affection. Thanks. (2013/09/29 20:01), Stefan Beller wrote: On 09/29/2013 04:56 AM, Wataru Noguchi wrote: - gcc optimization level is O2.(fail) - gcc O0, O1 works fine. Maybe you could try to compile with

Re: [PATCH] mingw-multibyte: fix memory acces violation and path length limits.

2013-10-02 Thread Wataru Noguchi
]; //-- struct stat st; int len = state->base_dir_len; if (topath) return write_entry(ce, topath, state, 1); Thanks. (2013/10/01 22:35), Wataru Noguchi wrote: Hi, Thanks for your pa

Re: [PATCH] mingw-multibyte: fix memory acces violation and path length limits.

2013-10-05 Thread Wataru Noguchi
line-small-functions -Wall Following optimization option cause crash, -finline-small-functions -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --