fnmatch vs regex

2014-03-05 Thread Vincenzo di Cicco
Hi there, I'm NaN. Recently I enrolled to this mailing list thanks to the GSoC. I've looked the Ideas Page but -unfortunately- some projects are very difficult for me. I've looked the source code and I've seen that to perform a search with a pattern to the branches list (and other commands) git use

[PATCH][GSoC] branch.c:install_branch_config Simplified long chain of if statements

2014-03-10 Thread Vincenzo di Cicco
ned-off-by: Vincenzo di Cicco --- Table-driven approach to avoid the long chain of if statements. branch.c | 37 ++--- 1 file changed, 14 insertions(+), 23 deletions(-) diff --git a/branch.c b/branch.c index 723a36b..cb8a544 100644 --- a/branch.c +++ b/branch.

Re: [PATCH][GSoC] branch.c:install_branch_config Simplified long chain of if statements

2014-03-10 Thread Vincenzo di Cicco
Thank you very much for the answer! I've learned a lot in this few rows. > If we take the time to trace through the code, we can see that > remote_is_branch is indeed either 0 or 1, thus this expression is safe > today, however, if the implementation of starts_with() ever changes so > that it retu

Re: Reference to a commit inside a commit message

2014-04-28 Thread Vincenzo di Cicco
Thank you very much > Why not? the reason is to avoid mistakes with the hash. An automatic approach can verify the existence of the commit. > See the output of > > git log --grep='In commit ' > > and > > git log --grep='In v' I've just tried the commands and noticed that this ca

Re: Reference to a commit inside a commit message

2014-04-29 Thread Vincenzo di Cicco
Thanks to all. With interpret-trailers has been easy to make a simple script, also it checks if the Hash passed is a valid Object. I haven't found a simple way to mantain the blank line above the output of interpet-trailers (not even through cleanup). Follows the script, maybe could be usefull for

Re: Reference to a commit inside a commit message

2014-04-30 Thread Vincenzo di Cicco
> You should use the latest version of the patch series (v11), because the > blank line is now automatically added. Yes interpret-trailers add the blank line, but when call `git commit -m "$MSG" -e` it isn't displayed. I think this happens due to the default value of 'cleanup' option of git-commit