[PATCH] branch: fix --verbose output column alignment

2013-11-14 Thread Torstein Hegge
branch -v * master f5eb3da commit pushed to upstream topic f935eb6 unpublished topic Instead, only add the trailing space if a decoration have been added. To catch this kind of whitespace breakage in the tests, be a bit less smart when filtering the output through sed. Signed-off-by: Tors

[PATCH] reflog: handle lightweight and annotated tags equally

2013-10-27 Thread Torstein Hegge
d tag is quiet, like it is for lightweight tags, commits and blobs. Signed-off-by: Torstein Hegge --- Try 'GIT_PAGER=cat git reflog v1.8.4' on git.git to see an example of this rather unexpected behavior. revision.c | 2 +- t/t1411-reflog-show.sh | 28 +++

[PATCH] test-lib: fix typo in comment

2013-10-27 Thread Torstein Hegge
Point test writers to the test_expect_* functions properly. Signed-off-by: Torstein Hegge --- t/test-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index 0fa7dfd..3dc1792 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -325,7 +325,7

Re: What's cooking in git.git (Nov 2013, #01; Fri, 1)

2013-11-03 Thread Torstein Hegge
On Fri, Nov 01, 2013 at 15:52:06 -0700, Junio C Hamano wrote: > * th/reflog-annotated-tag (2013-10-28) 1 commit > (merged to 'next' on 2013-11-01 at 8b154cc) > + reflog: handle lightweight and annotated tags equally > > "git log -g $annotated_tag", when there is no reflog history, should > ha

Re: [PATCH v6 0/4] commit: Add commit.verbose configuration

2015-02-27 Thread Torstein Hegge
On Tue, Jun 17, 2014 at 14:38:56 -0500, Caleb Thompson wrote: > This patch allows people to set commit.verbose to implicitly send > --verbose to git-commit. > > It introduces several cleanup patches to t/t7505-commit-verbose.sh to > bring it closer to the current state of the tests as they have be

[PATCH] Documentation/rev-list-options: add missing word in --*-parents

2013-08-02 Thread Torstein Hegge
A commit has "parent commits" or "parents", not "commits". Signed-off-by: Torstein Hegge --- Documentation/rev-list-options.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/rev-list-options.txt b/Documentation/rev-list-opti

[PATCH] bisect: Fix log output for multi-parent skip ranges

2013-05-22 Thread Torstein Hegge
On Mon, Apr 22, 2013 at 23:02:29 +0200, Torstein Hegge wrote: > There has to be a better way to get the range of possible first bad > commits, similar to the output of 'git log --bisect --format="%H"'. I just realized that this felt clunky because I didn't understa

[PATCH] t9903: Don't fail when run from path accessed through symlink

2013-04-11 Thread Torstein Hegge
t. When __gitdir looks up the path through 'git rev-parse --git-dir', it will return paths similar to $(pwd -P). This behavior is already tested in t9903 'gitdir - resulting path avoids symlinks'. Signed-off-by: Torstein Hegge --- t/t9903-bash-prompt.sh | 10 +-

[PATCH] bisect: Store first bad commit as comment in log file

2013-04-13 Thread Torstein Hegge
see from $(git bisect log)". Signed-off-by: Torstein Hegge --- I don't know how useful the added test is, I didn't find any existing tests that looks at the comment parts of bisect log. git-bisect.sh |8 +++- t/t6030-bisect-porcelain.sh | 18 +

Re: [PATCH] bisect: Store first bad commit as comment in log file

2013-04-15 Thread Torstein Hegge
On Mon, Apr 15, 2013 at 06:38:09 +0200, Christian Couder wrote: > I wonder if we should also write something into the bisect log if for > example the bisection stopped because there are only 'skip'ped commits > left to test. But maybe this could go into another patch after this > one. Yes, that wo

Re: [PATCH] bisect: Store first bad commit as comment in log file

2013-04-22 Thread Torstein Hegge
On Mon, Apr 15, 2013 at 11:53:39 +0200, Torstein Hegge wrote: > On Mon, Apr 15, 2013 at 06:38:09 +0200, Christian Couder wrote: > > I wonder if we should also write something into the bisect log if for > > example the bisection stopped because there are only 'skip'ped comm

Re: [PATCH] bisect: Store first bad commit as comment in log file

2013-04-22 Thread Torstein Hegge
On Mon, Apr 22, 2013 at 14:13:00 -0700, Junio C Hamano wrote: > Torstein Hegge writes: > > > I took another look at this. I wasn't able to come up with anything > > useful for the "The merge base $rev is bad" case, but for the "only > > skipped commi