[PATCH] git_connect: allow passing arguments to ssh in GIT_SSH_ARGS

enclosed in quotes, or escaped with a backslash. Signed-off-by: Thomas Quinot --- Dear fellow GIT developers, I hope I won't stray too far away from established procedures with my first contribution to git. This patch adds support for a GIT_SSH_ARGS environment variable, providing a w

[PATCH] Documentation/config.txt: fix minor typo

Add a missing capital at the beginning of a sentence, and rephrase slightly. Signed-off-by: Thomas Quinot --- Documentation/config.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/config.txt b/Documentation/config.txt index e8dd76d..588d024 100644 --- a

Re: [PATCH] git_connect: allow passing arguments to ssh in GIT_SSH_ARGS

Jeff, Thanks for your feedback! * Jeff King, 2014-11-08 : > What do you think of adding an alternate variable that is not ssh > _arguments_, but rather just a full shell command for running ssh? > I'm not sure what it could be called (GIT_SSH_SH is probably too > confusing). Interesting idea, I

[PATCH v2 1/2] git_connect: set ssh shell command in GIT_SSH_CMD

passed to the shell. Signed-off-by: Thomas Quinot --- As suggested by Jeff, here is a second version introducing a GIT_SSH_CMD variable that overrides GIT_SSH, and is processed by the shell. Note that with this first patch only, the special processing for PuTTY/plink looks at the whole command in

[PATCH v2 2/2] git_connect: when using GIT_SSH_CMD, check for plink in argv[0] only

shell command to run for ssh connections, look for these substrings only in the program name (not in subsequent arguments). Signed-off-by: Thomas Quinot --- connect.c | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/connect.c b/connect.c inde

Re: [PATCH v2 1/2] git_connect: set ssh shell command in GIT_SSH_CMD

* Jeff King, 2014-11-09 : > Thanks, I like this much better. The name GIT_SSH_CMD is not too bad. > Personally, of the two (GIT_SSH and GIT_SSH_CMD) I would expect the > "_CMD" form to be the one that does not use the shell. Right, except of course we're stuck with the compatibility issue in any

[PATCH v3] git_connect: set ssh shell command in GIT_SSH_CMD

g ssh implementation. Signed-off-by: Thomas Quinot --- Third version: disabling the complicated plink circuitry altogether when using GIT_SSH_CMD, as discussed. This keeps the change very simple, which is nice. Keepin GIT_SSH_CMD for the variable name for the time being, as I'm not very enthusi

Re: [PATCH v2 1/2] git_connect: set ssh shell command in GIT_SSH_CMD

* Junio C Hamano, 2014-11-09 : > Whatever. I loathe the CMD abbreviation, though. Why spell out > SHELL but not COMMAND? I.e. GIT_SSH_[SHELL_]COMMAND No strong opinion :-) GIT_SSH_COMMAND looks just fine to me. (GIT_SSH_SHELL_COMMAND starts to feel a bit long...) Thomas. -- To unsubscribe f

[PATCH v4] git_connect: set ssh shell command in GIT_SSH_COMMAND

g the underlying ssh implementation. Signed-off-by: Thomas Quinot --- Amended patch as per discussion with Junio: change variable name to GIT_SSH_COMMAND, keep plink special circuitry disabled for this case (leaving it enabled only when using GIT_SSH, thus preserving compatibility with legacy usage). T

Re: [PATCH v4] git_connect: set ssh shell command in GIT_SSH_COMMAND

* Jeff King, 2014-11-10 : > I think this version looks good. Thanks for working on it. Thanks! > Two style micro-nits (that I do not think even merit a re-roll by > themselves, but Junio may want to mark up as he applies): OK, committed locally, I can resend a PATCH v5 if that's more convenient