Bug Report: Subtrees and GPG Signed Commits

2018-01-06 Thread Stephen R Guglielmo
Hi all, I've noticed an issue regarding the use of `git subtree add` and `git subtree pull` when the subtree repository's commit (either HEAD or whatever commit specified by the subtree command) is signed with GPG. It seems to work properly if the commit is not signed but previous commits are. Th

Re: Bug Report: Subtrees and GPG Signed Commits

2018-01-18 Thread Stephen R Guglielmo
Hi, just following up on this bug report. I have not heard back. Is there additional information that's needed? Is there a better place to file bug reports? Thanks On Sat, Jan 6, 2018 at 5:45 PM, Stephen R Guglielmo wrote: > Hi all, > > I've noticed an issue regarding the

Re: Bug Report: Subtrees and GPG Signed Commits

2018-01-30 Thread Stephen R Guglielmo
hen R Guglielmo wrote: > Hi, just following up on this bug report. I have not heard back. Is > there additional information that's needed? Is there a better place to > file bug reports? > > Thanks > > On Sat, Jan 6, 2018 at 5:45 PM, Stephen R Guglielmo > wrote: >

Re: Bug Report: Subtrees and GPG Signed Commits

2018-01-31 Thread Stephen R Guglielmo
On Tue, Jan 30, 2018 at 6:37 PM, Avery Pennarun wrote: > On Tue, Jan 30, 2018 at 6:24 PM, Junio C Hamano wrote: >> Stefan Beller writes: >>> There has not been feedback for a while on this thread. >>> I think that is because subtrees are not in anyone's hot >>> interest area currently. >>> >>> T

Re: Bug Report: Subtrees and GPG Signed Commits

2018-02-05 Thread Stephen R Guglielmo
On Wed, Jan 31, 2018 at 7:33 AM, Stephen R Guglielmo wrote: > On Tue, Jan 30, 2018 at 6:37 PM, Avery Pennarun wrote: >> On Tue, Jan 30, 2018 at 6:24 PM, Junio C Hamano wrote: >>> Stefan Beller writes: >>>> There has not been feedback for a while on this thread

Re: Bug Report: Subtrees and GPG Signed Commits

2018-02-05 Thread Stephen R Guglielmo
On Mon, Feb 5, 2018 at 9:30 AM, Stephen R Guglielmo wrote: > On Wed, Jan 31, 2018 at 7:33 AM, Stephen R Guglielmo > wrote: >> On Tue, Jan 30, 2018 at 6:37 PM, Avery Pennarun wrote: >>> On Tue, Jan 30, 2018 at 6:24 PM, Junio C Hamano wrote: >>>> Stefan Beller

Re: Bug Report: Subtrees and GPG Signed Commits

2018-02-08 Thread Stephen R Guglielmo
On Mon, Feb 5, 2018 at 1:45 PM, Junio C Hamano wrote: > Given that all references to this shell function seem to do > > sometree=$(toptree_for_commit $something) > > and then $sometree is used as if it were a tree object name, I can > understand why the lack of --no-show-signature in the o

Re: Automatic parameters completion

2018-02-08 Thread Stephen R Guglielmo
On Thu, Feb 8, 2018 at 9:03 AM, Andrzej wrote: > I have Linux Mint and its terminal besides usual completion (add file name > when type first letter and press tab) also can complete git parameters. How > is doing this? Bash knows git or bash has special interface to completion > and git uses it? >

[PATCH] subtree: hide GPG signatures in calls to log

2018-02-15 Thread Stephen R Guglielmo
This fixes `add` and `pull` for GPG signed objects. Signed-off-by: Stephen R Guglielmo --- contrib/subtree/git-subtree.sh | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh index dec085a23..9594ca4b5

[PATCH v2] subtree: fix add and pull for GPG-signed commits

2018-02-23 Thread Stephen R Guglielmo
commit fixes the issue by adding --no-show-signature to `log` calls in a few places, as well as using the more appropriate `rev-parse` instead where possible. Signed-off-by: Stephen R Guglielmo --- contrib/subtree/git-subtree.sh | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

Re: [PATCH v2] subtree: fix add and pull for GPG-signed commits

2018-02-26 Thread Stephen R Guglielmo
On Fri, Feb 23, 2018 at 5:45 PM, Junio C Hamano wrote: > Stephen R Guglielmo writes: > >> If log.showsignature is true (or --show-signature is passed) while >> performing a `subtree add` or `subtree pull`, the command fails. >> >> toptree_for_commit() calls `log` an