[PATCH v2 3/6] Warn if the Windows console font doesn't support Unicode

Johannes Schindelin Signed-off-by: Stepan Kasal --- compat/winansi.c | 66 1 file changed, 66 insertions(+) diff --git a/compat/winansi.c b/compat/winansi.c index c4be401..bec6713 100644 --- a/compat/winansi.c +++ b/compat/win

[PATCH v2 2/6] Detect console streams more reliably on Windows

ue of GetConsoleScreenBufferInfo instead to reliably detect console handles (also don't initialize internal state from an uninitialized CONSOLE_SCREEN_BUFFER_INFO structure if the function fails). Signed-off-by: Karsten Blees Signed-off-by: Johannes Schindelin Signed-off-by: Stepan Kasal --- compat

[PATCH] send-email: do not insert third header

second header already inserted in the patch file. Signed-off-by: Stepan Kasal --- git-send-email.perl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/git-send-email.perl b/git-send-email.perl index 9949db0..891df13 100755 --- a/git-send-email.perl +++ b/git-send-email.perl

Re: [PATCH] send-email: do not insert third header

On Mon, Jun 09, 2014 at 10:38:14PM -0700, Junio C Hamano wrote: > two new options [..] > would support the recent kernel submission convention better. indeed, but they are not there and I do not volunteer to write them. Instead, I edit the generated patches to add the necessary headers. But if se

[PATCH 1/7] Let mingw_execve() return an int

From: Johannes Schindelin Date: Mon, 28 May 2012 21:21:39 -0500 This is in the great tradition of POSIX. Original fix by Olivier Refalo. Signed-off-by: Johannes Schindelin Signed-off-by: Stepan Kasal --- compat/mingw.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a

[PATCH 5/7] Win32: Unicode arguments (outgoing)

From: Karsten Blees Date: Sun, 16 Jan 2011 18:27:53 +0100 Convert command line arguments from UTF-8 to UTF-16 when creating other processes. Signed-off-by: Karsten Blees Signed-off-by: Stepan Kasal --- compat/mingw.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions

[PATCH 6/7] Win32: Unicode arguments (incoming)

From: Karsten Blees Date: Sun, 16 Jan 2011 18:28:27 +0100 Convert command line arguments from UTF-16 to UTF-8 on startup. Signed-off-by: Karsten Blees Signed-off-by: Stepan Kasal --- compat/mingw.c | 42 -- 1 file changed, 40 insertions(+), 2 deletions

[PATCH 3/7] Win32: fix potential multi-threading issue

From: Karsten Blees Date: Fri, 7 Jan 2011 18:04:16 +0100 ...by removing a static buffer in do_stat_internal. Signed-off-by: Karsten Blees Signed-off-by: Erik Faye-Lund Signed-off-by: Stepan Kasal --- compat/mingw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat

[PATCH 4/7] MinGW: disable CRT command line globbing

and t7810. Signed-off-by: Karsten Blees Signed-off-by: Erik Faye-Lund Signed-off-by: Stepan Kasal --- compat/mingw.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/compat/mingw.c b/compat/mingw.c index 6849815..1140a13 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -1927,6 +1927,12 @

[PATCH 0/7] Second part of msysgit/unicode

This is the second part of the time-proven unicode suport branch from msysgit. This batch is a collection of small independent changes, limited to mingw.c. The only exception is the last patch: it changes gitk and git-gui. (The third and last part of msysgit/unicode branch will all be about enviro

[PATCH 2/7] Win32: simplify internal mingw_spawn* APIs

. Remove the env parameter where it's not needed. This removes the internal mingw_execve abstraction, which is no longer needed. Signed-off-by: Karsten Blees Signed-off-by: Stepan Kasal --- compat/mingw.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) diff --

[PATCH 7/7] Unicode file name support (gitk and git-gui)

system encoding to UTF-8. Changing the TCL system encoding (via 'encoding system ...', e.g. in the startup code) is explicitly discouraged by the TCL docs. Change gitk and git-gui functions dealing with file names to always convert from and to UTF-8. Signed-off-by: Karsten Blees Signed-off-

Re: [PATCH 0/7] Second part of msysgit/unicode

Hello Karsten, On Tue, Jun 17, 2014 at 11:06:52AM +0200, Karsten Blees wrote: > Am 11.06.2014 11:37, schrieb Stepan Kasal: > > This is the second part of the time-proven unicode suport branch from > > msysgit. > > This batch is a collection of small independent change

Re: Topic sk/mingw-unicode-spawn-args breaks tests

Hello Hannes, > Am 10.07.2014 22:05, schrieb Johannes Sixt: > > It looks like I totally missed the topic sk/mingw-unicode-spawn-args. ... > > Am I doing something wrong? Does the topic depend on a particular > > version of MSYS (or DLL)? unfortunately, I paused my submissions at random point. I'

[PATCH 2/3] Win32: Unicode file name support (dirent)

by factor three in the worst case). Signed-off-by: Karsten Blees Signed-off-by: Stepan Kasal --- compat/win32/dirent.c | 30 ++ compat/win32/dirent.h | 2 +- 2 files changed, 11 insertions(+), 21 deletions(-) diff --git a/compat/win32/dirent.c b/compat/win32/dire

[PATCH 0/3] fix test suite with mingw-unicode patches

name support (except dirent) Win32: Unicode file name support (dirent) Pat Thoyts and Stepan Kasal(1): tests: do not pass iso8859-1 encoded parameter compat/mingw.c | 198 +-- compat/mingw.h | 18 +++- compat/win32/dirent.c

[PATCH 3/3] tests: do not pass iso8859-1 encoded parameter

using a file or a pipe. Thanks-to: Karsten Blees Author: Stepan Kasal Signed-off-by: Stepan Kasal --- t/t4041-diff-submodule-option.sh | 6 -- t/t4205-log-pretty-formats.sh| 2 +- t/t6006-rev-list-format.sh | 4 ++-- t/t7102-reset.sh | 8 ++-- 4 files change

[PATCH 1/3] Win32: Unicode file name support (except dirent)

due to strbuf_free in is_dir_empty resetting GetLastError to ERROR_SUCCESS. Close the find handle in is_dir_empty so that git doesn't block deletion of the directory even after all other applications have released it. Reported-by: John Chen Signed-off-by: Karsten Blees Signe

Re: [PATCH 0/3] fix test suite with mingw-unicode patches

> Win32: Unicode file name support (dirent) Both of theese patches are in msysgit for more than 2 years. > Pat Thoyts and Stepan Kasal(1): > tests: do not pass iso8859-1 encoded parameter This one is relatively new: replaces "git commit -m" by "git commit -F -" t

Re: [PATCH 0/3] fix test suite with mingw-unicode patches

Hello Karsten, thanks for your analysis. Most of the patches you refer to are simply switching off tests for MINGW; let me comment on the remaining ones: > * t0110-urlmatch-normalization: 1 > > Passing binary data on the command line...would have to > teach test-urlmatch-normalization.c to read

[PATCH 4/6] t4210: skip command-line encoding tests on mingw

-by: Stepan Kasal --- t/t4210-log-i18n.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t4210-log-i18n.sh b/t/t4210-log-i18n.sh index 52a7472..9110404 100755 --- a/t/t4210-log-i18n.sh +++ b/t/t4210-log-i18n.sh @@ -34,7 +34,7 @@ test_expect_success 'log --grep search

[PATCH 0/6] mingw test fixes

Hello, this is a collection of quality test suite fixes, hand picked with care, following the expert advice by Karsten. :-) Most of them just switch off the tests on MinGW, one uses `pwd -W' to get the reeal windows path. All of these are time proven, they have been in msysgit since Dec 2013, at

[PATCH 3/6] MinGW: disable legacy encoding tests

ng in setup, so don't switch to ISO-8859-1 on MinGW. Note that i18n tests that do their encoding tricks via encoded files (such as t3900) are not affected by this. Signed-off-by: Karsten Blees Signed-off-by: Stepan Kasal --- t/t3901-i18n-patch.sh | 19 +++ t/t4201-shortlog

[PATCH 2/6] Disable t0110's high-bit test on Windows

"$(echo -e '\x80')" (where strings.exe is a MinGW program, not an MSys one) it will complain about not finding the file called "80". Signed-off-by: Johannes Schindelin Signed-off-by: Stepan Kasal --- t/t0110-urlmatch-normalization.sh | 2 +- 1 file changed, 1 insertion

[PATCH 6/6] t800[12]: work around MSys limitation

ed to the executable. This version does not modify the body of the tests and is active on MinGW only. Commit-message-by: Johannes Schindelin Author: Stepan Kasal Signed-off-by: Johannes Schindelin Signed-off-by: Stepan Kasal --- t/annotate-tests.sh | 12 1 file changed, 1

[PATCH 5/6] t9902: mingw-specific fix for gitfile link files

From: Pat Thoyts The path in a .git platform independent link file needs to be absolute and under mingw we need it to be a windows type path, not a unix style path so it should start with a drive letter and not a /. Signed-off-by: Pat Thoyts Signed-off-by: Stepan Kasal --- t/t9902

[PATCH 1/6] MinGW: Skip test redirecting to fd 4

From: Johannes Schindelin ... because that does not work in MinGW. Signed-off-by: Johannes Schindelin Signed-off-by: Stepan Kasal --- t/t0081-line-buffer.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t0081-line-buffer.sh b/t/t0081-line-buffer.sh index bd83ed3

[PATCH 12/13] Win32: patch Windows environment on startup

Blees Signed-off-by: Stepan Kasal --- compat/mingw.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/compat/mingw.c b/compat/mingw.c index 9dc6bf6..6d4ec56 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -1250,7 +1250,7 @@ static int do_putenv(char

[PATCH 00/13] mingw unicode environment

Hello, this is the remainder of Karsten's unicode branch, that is a time proven part of msysGit. (If this code is accepted, only one patch would only remain: gitk and git-gui fixes.) When rebasing Karsten's work, I have eliminated two commits: https://github.com/msysgit/git/commit/f967550 https:

[PATCH 01/13] Revert "Windows: teach getenv to do a case-sensitive search"

-submodule.sh, so that it works on Windows (i.e. with case-insensitive environment, regardless of the toolset). Revert to the documented behaviour of case-insensitive environment on Windows. Signed-off-by: Karsten Blees Signed-off-by: Stepan Kasal --- compat/mingw.c | 23 +++--

[PATCH 04/13] Win32: fix environment memory leaks

depends on taking control of char **environ and having our own mingw_putenv (both introduced in "Win32: Unicode environment (incoming)"). Signed-off-by: Karsten Blees Signed-off-by: Stepan Kasal --- compat/mingw.c | 10 ++ compat/mingw.h | 1 + config.mak.uname | 2 --

[PATCH 02/13] Win32: Unicode environment (outgoing)

From: Karsten Blees Convert environment from UTF-8 to UTF-16 when creating other processes. Signed-off-by: Karsten Blees Signed-off-by: Stepan Kasal --- compat/mingw.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/compat/mingw.c b/compat

[PATCH 09/13] Win32: reduce environment array reallocations

reallocations. Signed-off-by: Karsten Blees Signed-off-by: Stepan Kasal --- compat/mingw.c | 62 +- 1 file changed, 35 insertions(+), 27 deletions(-) diff --git a/compat/mingw.c b/compat/mingw.c index 592..e63fd6a 100644 --- a/compat

[PATCH 08/13] Win32: don't copy the environment twice when spawning child processes

make_augmented_environ / free_environ API. Signed-off-by: Karsten Blees Signed-off-by: Stepan Kasal --- compat/mingw.c | 76 -- compat/mingw.h | 8 ++- run-command.c | 10 ++-- 3 files changed, 30 insertions(+), 64 deletions(-) diff --git a/compat

[PATCH 13/13] Enable color output in Windows cmd.exe

From: Karsten Blees Git requires the TERM environment variable to be set for all color* settings. Simulate the TERM variable if it is not set (default on Windows). Signed-off-by: Karsten Blees Signed-off-by: Johannes Schindelin Signed-off-by: Stepan Kasal --- compat/mingw.c | 4 1 file

[PATCH 06/13] Win32: unify environment function names

Signed-off-by: Karsten Blees Signed-off-by: Stepan Kasal --- compat/mingw.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/compat/mingw.c b/compat/mingw.c index fe869ed..89fe62b 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -898,7 +898,7 @@ static char *

[PATCH 10/13] Win32: use low-level memory allocation during initialization

This patch is in preparation of the sorted environment feature, which completely replaces MSVCRT's getenv() implementation. Signed-off-by: Karsten Blees Signed-off-by: Stepan Kasal --- compat/mingw.c | 43 --- 1 file changed, 28 insertions(+), 15 dele

[PATCH 03/13] Win32: Unicode environment (incoming)

-off-by: Stepan Kasal --- compat/mingw.c | 15 +++ compat/mingw.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/compat/mingw.c b/compat/mingw.c index bd45950..eadba8a 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -1259,6 +1259,12 @@ char *mingw_getenv(const char *name

[PATCH 05/13] Win32: unify environment case-sensitivity

inconsistencies by using case-insensitive comparison in lookup_env (used by putenv, unsetenv and make_augmented_environ). Signed-off-by: Karsten Blees Signed-off-by: Stepan Kasal --- compat/mingw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/compat/mingw.c b/compat/mingw.c index

[PATCH 07/13] Win32: factor out environment block creation

From: Karsten Blees Signed-off-by: Karsten Blees Signed-off-by: Stepan Kasal --- compat/mingw.c | 55 --- 1 file changed, 32 insertions(+), 23 deletions(-) diff --git a/compat/mingw.c b/compat/mingw.c index 89fe62b..3f81c90 100644 --- a

[PATCH 11/13] Win32: keep the environment sorted

implementation are better than that in that they are thread-safe with respect to other getenv calls as long as the environment is not modified. Git's indiscriminate use of getenv in background threads currently requires this property. Signed-off-by: Karsten Blees Signed-off-by: Step

Re: [PATCH 00/13] mingw unicode environment

Hi, > Karsten Blees writes: > > I believe we prefer moving code to the right place over forward > > declarations (IIRC I got bashed for the latter in one of the first rounds > > of this patch series). If only to justify 'git-blame -M' :-D indeed, my position is the same, generally. But it turne

Re: [msysGit] Re: [PATCH 00/13] mingw unicode environment

Hello Karsten, you wrote: > However, if it *did* compile for you, I wonder where ALLOC_GROW (as of #02/13) > and alloc_nr (as of #10/13) came from? Or did we recently remove '#include > "cache.h"' > from upstream mingw.c? you are right, the include needs to be added. To test my modifications, I

gitk "Parent" is wrong

"Previous" and "Next", as they point to the neighbours is the displayed list of commits. Have a nice day, Stepan Kasal -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

git gui clone bug

When I start by "git clone", I can immediately proceed with "git pull" The difference can be checked in .git/config, in section branch.master. Have a nice day, Stepan Kasal -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a messa

Re: [PATCH/RFC] blame: CRLF in the working tree and LF in the repo

physically_ are the same as the files in the repo. Have a nice day, Stepan Kasal -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH/RFC] blame: CRLF in the working tree and LF in the repo

Hello, On Sun, Apr 26, 2015 at 10:31:11PM -0700, Junio C Hamano wrote: > [...] the commit you are proposing to revert [4d4813a5] > was a misguided attempt to "fix" a non issue, [...] yes, it was this. So I propose to remove the whole commit, including the test case and add two new test cases. D

Re: [PATCH/RFC] blame: CRLF in the working tree and LF in the repo

rks. You will not encounter any problem. (Supposing you do not change the line ending options, of course.) Finally, let me explain my previous statement: > Am 27.04.2015 um 08:11 schrieb Stepan Kasal: >> Git does not support CRLF as the internal line separator. I'm often asked: &q

<    1   2