[PATCH] revision.c: fix possible null pointer access

2015-12-03 Thread Stefan Naewe
Two functions dereference a tree pointer before checking if the pointer is valid. Fix that by doing the check first. Signed-off-by: Stefan Naewe --- This has been reported through the CppHints newsletter (http://cpphints.com/hints/40) but doesn't seem to have made its way to the ones who

Re: [PATCH] revision.c: fix possible null pointer access

2015-12-03 Thread Stefan Naewe
On Thu, Dec 3, 2015 at 9:06 PM, Junio C Hamano wrote: > > Stefan Naewe writes: > > > Two functions dereference a tree pointer before checking > > Reading them a bit carefully, a reader would notice that they > actually do not dereference the pointer at all. It just co

[PATCH v2] revision.c: fix possible null pointer access

2015-12-05 Thread Stefan Naewe
mark_tree_uninteresting dereferences a tree pointer before checking if the pointer is valid. Fix that by doing the check first. Signed-off-by: Stefan Naewe --- revision.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/revision.c b/revision.c index 0fbb684..8c569cc 100644

[PATCH] ls-remote: document the '--get-url' option

2012-09-06 Thread Stefan Naewe
While looking for a way to expand the URL of a remote that uses a 'url..insteadOf' config option I stumbled over the undocumented '--get-url' option of 'git ls-remote'. This adds some minimum documentation for that option. Signed-off-by: Stefan Naewe --- Docum

[PATCH] ls-remote: document the '--get-url' option

2012-09-06 Thread Stefan Naewe
he '-h' output. Signed-off-by: Stefan Naewe --- Documentation/git-ls-remote.txt | 4 builtin/ls-remote.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Documentation/git-ls-remote.txt b/Documentation/git-ls-remote.txt index 7a9b86a..a2ebf1d 1006

Re: [PATCH] ls-remote: document the '--get-url' option

2012-09-07 Thread Stefan Naewe
On Fri, Sep 7, 2012 at 10:28 AM, Andreas Schwab wrote: > Stefan Naewe writes: > >> +--get-url:: >> + Expand the URL of the given remote repository taking into account any >> + "url..insteadOf" config setting (See linkgit:git-config[1]). > > T

Re: [RFC] Add a new email notification script to "contrib"

2012-07-14 Thread Stefan Naewe
On Sat, Jul 14, 2012 at 12:37 PM, Tay Ray Chuan wrote: > Hi Stefan, > > On Sat, Jul 14, 2012 at 5:46 PM, Stefan Näwe wrote: >> >> Do you have a fork of git.git somewhere that contains the script? >> (I find it so much easier these days to simply fetch another repo instead >> of applying patches w

[PATCH] RelNotes/1.8.1.5: mention correct 'Fixes since'

2013-02-25 Thread Stefan Naewe
RelNotes/1.8.1.5.txt mentions 'Fixes since v1.8.1.5' which should obviously be empty. This fixes it. Signed-off-by: Stefan Naewe --- Documentation/RelNotes/1.8.1.5.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/RelNotes/1.8.1.5.txt b/Doc