On 23/11/14 23:15, Ramsay Jones wrote:
> On 23/11/14 18:53, Junio C Hamano wrote:
>> Ramsay Jones writes:
>>
>>> On 23/11/14 14:16, Torsten Bögershausen wrote:
>>>> gcc under cygwin reports several warnings like this:
>>>> warning: implicit dec
On 24/11/14 21:44, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> I updated from cygwin 1.5 to cygwin 1.7 at the beginning of the year.
>> Since it is no longer supported, I don't think we need to worry about
>> version 1.5. When I said 'old installation
On 24/11/14 22:50, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> ...
>> Although I have not done an actual diff of the various cdef.h files, they
>> do appear to be more or less the same. In other words, I no longer think
>> that the change results from a '
#x27; test, which used to fail
prior to this commit, to now (unexpectedly) pass. Mark this test as
passing.
Signed-off-by: Ramsay Jones
---
Hi Junio,
I noticed this last week while testing on cygwin. I have only tested
this on (64-bit) cygwin/ntfs, but I would assume that other case
insensitive
in the git codebase). Also, it triggers a warning from
sparse. In order to suppress the warning, simply remove the
extern keyword from reflog_expire() definition.
Signed-off-by: Ramsay Jones
---
Hi Michael,
If you need to re-roll your 'mh/reflog-expire' series, could you
please squash th
(msgid)
>
> #endif
>
Hmm, see commit 642f85faa ("i18n: avoid parenthesized string as
array initializer", 07-04-2011), for a counter-point. :-P
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
uccess ULIMIT_FILE_DESCRIPTORS 'large transaction creating
> branches does not burst open file limit' '
> (
> for i in $(test_seq 33)
> do
> @@ -990,7 +990,7 @@ test_expect_failure ULIMIT_FILE_DESCRIPTORS 'large
> transaction creating branches
, I am simply building the 'pu' branch (currently @ 028c360).
>
> As for the fix, would it be sufficient to check != NULL instead of < 0?
Hmm, I didn't give it any thought, but don't you want that to be '== NULL'?
(you don't want to use a NULL lock->lk-&
On 22/01/15 19:51, Ramsay Jones wrote:
> On 22/01/15 19:16, Stefan Beller wrote:
>> How do you run sparse on git?
>
> $ make sparse >sp-out 2>&1
>
BTW, you can get gcc to warn about this also:
$ rm refs.o
$ make CFLAGS='-Wall -Wextra' refs.o
*
On 22/01/15 20:20, Stefan Beller wrote:
> On Thu, Jan 22, 2015 at 12:13 PM, Ramsay Jones
> wrote:
>>
>> Notice the [-Wextra] warnings above. ;-)
>>
>> ATB,
>> Ramsay Jones
>>
>
> Thanks, I put that into my config.mak
> Though recompiling
n the missing verb, rather than a colon, would
> also make more sense:
>
> --author '%s' is neither 'Name ' nor a match for an existing author
>
I usually don't like to add anything to the bikeshed, but ...
This sounds odd to me, so maybe:
--author
commit 41b20017 ("Fix an "implicit function
definition" warning", 03-03-2007).
Signed-off-by: Ramsay Jones
---
Hi Junio,
I have a very vague recollection (back in March 2007) of trying to fix
the problem from commit 41b20017 using the solution in commit 3a0a3a89.
However,
Sparse issues an "'prepare_transport' was not declared. Should it
be static?" warning. In order to suppress the warning, since this
symbol only requires file scope, we simply add the static modifier
to it's declaration.
Signed-off-by: Ramsay Jones
---
Hi Junio,
W
g, I solved the problem by building highlight
v3.15 from source and installing in $HOME.
This patch is marked RFC because this bug does not seem to have
affected too many people (given that Heiko reported the problem
back in 2011) ... :-D
[Also, note that I didn't fix up the form of the conditiona
tionally,
depending on the compiler being gcc, but I found that clang and tcc just
ignored it ...
> cc-disable-warning = $(call try-run,\
> $(CC) $(CFLAGS) -W$(strip $(1)) -c -x c /dev/null -o "$$TMP",-Wno-$(strip
> $(1)))
>
> CFLAGS = -g -O2 -Wall $(call cc-disable-warni
ago, when I last did this! :-P )
ATB,
Ramsay Jones
Ramsay Jones (6):
config.c: Fix a sparse warning
refs.c: Fix a sparse warning
wrapper.c: Fix a sparse warning
t9500-*.sh: Fix highlight test hang on Linux Mint
git-format-patch.txt: Add to Thunderbird configuration
sparse: Fix som
Sparse issues an "'git_parse_unsigned' was not declared. Should it
be static?" warning. In order to suppress this warning, since this
symbol only requires file scope, we simply add the static modifier
to its declaration.
Signed-off-by: Ramsay Jones
---
config.c | 2 +
Sparse issues an "Using plain integer as NULL pointer" warning
against a call to update_ref_lock() which passes '0' to the
'int *type_p' parameter. In order to suppress the warning, we
simply change the argument to 'NULL'.
Signed-off-by: Ramsay Jone
ocessor conditional to include the definition only
when needed.
Signed-off-by: Ramsay Jones
---
wrapper.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/wrapper.c b/wrapper.c
index f92b147..9a6aaaf 100644
--- a/wrapper.c
+++ b/wrapper.c
@@ -360,10 +360,12 @@ int git_mkstemp_mode(char *pat
Linux Mint has an implementation of the highlight command (unrelated
to the one from http://www.andre-simon.de) that works as a simple
filter. The script uses 'sed' to add terminal colour escape codes
around text matching a regular expression. When t9500-*.sh attempts
to run "highlight --version",
cular, the "mailnews.wraplength" configuration variable needs
to be set to zero. Update the documentation to add the missing
setting.
Signed-off-by: Ramsay Jones
---
Documentation/git-format-patch.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/git-format-patch.txt
ttp-push.c, http.c, http-walker.c and
remote-curl.c).
Signed-off-by: Ramsay Jones
---
Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Makefile b/Makefile
index de3d72c..4fde227 100644
--- a/Makefile
+++ b/Makefile
@@ -2018,6 +2018,9 @@ gettext.sp gettext.s gettext.o: GIT-PRE
Several uses of the '^' operator are being interpreted by asciidoc
as requests to show the following text as a superscript. In order
to fix this problem, use backticks (`) to quote the text of the
affected git command invocations.
Signed-off-by: Ramsay Jones
---
Hi Jonathan,
Just no
the
affected 'grep' command invocations.
Signed-off-by: Ramsay Jones
---
Hi Jonathan,
$ git grep '\^' Documentation/howto
pointed me to some other candidates, but only this one needed a
similar fix ... :-D
ATB,
Ramsay Jones
Documentation/howto/setup-git-server-over-htt
On 15/10/13 00:25, Jonathan Nieder wrote:
> Ramsay Jones wrote:
>
>> These patches don't have too much in common, hence the subject
>> line, except perhaps that 4 of them fix sparse warnings.
>
> Thanks. These look good.
>
> I tweaked the descriptions a bit
s
call was passing '0' to that argument, it was (correctly) being
interpreted as a null pointer. Change to argument to NULL.
Noticed by sparse. ("Using plain integer as NULL pointer")
Signed-off-by: Ramsay Jones
---
Hi Jonathan, Junio,
I'm a little puzzled by not having no
s
call was passing '0' to that argument, it was (correctly) being
interpreted as a null pointer. Change to argument to NULL.
Noticed by sparse. ("Using plain integer as NULL pointer")
Signed-off-by: Ramsay Jones
---
Hi Junio,
This is a repost of:
http://article.gmane.org/gma
to introduce functions which may have a
> name clash.
> Using the git_ prefix for function names is a good practice.
> So in order to unbrake the compilation error under cygwin 17,
> the "hotfix" can be used.
heh, my patch (given below) took a different approach, but
AT
der to unbrake the compilation error under cygwin 17,
>> the "hotfix" can be used.
>> /Torsten
> I just realized that there seem to problems to compile pu under msysgit.
> More investigation needed here.
... I noticed this too, and my patch is given below (I have a
On 30/10/13 20:30, Torsten Bögershausen wrote:
> On 2013-10-30 20.06, Ramsay Jones wrote:
>> On 30/10/13 17:14, Torsten Bögershausen wrote:
>>> On 2013-10-30 18.01, Vicent Martí wrote:
>>>> On Wed, Oct 30, 2013 at 5:51 PM, Torsten Bögershausen
>>>> wrote
30ef ("fast-export: add new --refspec option", 31-10-2013)
causes sparse to complain:
SP builtin/fast-export.c
builtin/fast-export.c:739:55: warning: Variable length array is used.
Do we want to use this C99 feature?
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 31/10/13 13:24, Torsten Bögershausen wrote:
> On 2013-10-30 22.07, Ramsay Jones wrote:
[ ... ]
>> Yep, this was the first thing I did as well! ;-) (*late* last night)
>>
>> I haven't had time today to look into fixing up the msvc build
>> (or a complete re-wri
Signed-off-by: Ramsay Jones
---
compat/bswap.h | 97 --
1 file changed, 68 insertions(+), 29 deletions(-)
diff --git a/compat/bswap.h b/compat/bswap.h
index ea1a9ed..c18a78e 100644
--- a/compat/bswap.h
+++ b/compat/bswap.h
@@ -17,7 +17,20
on top of the 'pu' branch
as of yesterday (pu @ 2b65d9ebc).
So, could you please squash these patches into the relevant commits
on your branch.
Thanks!
ATB,
Ramsay Jones
Ramsay Jones (5):
compat/bswap.h: Fix build on cygwin, MinGW and msvc
Makefile: Add object files in ewah/ to cl
Noticed by sparse. ("Using plain integer as NULL pointer")
Signed-off-by: Ramsay Jones
---
khash.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/khash.h b/khash.h
index 0fdf39d..c4c1613 100644
--- a/khash.h
+++ b/khash.h
@@ -114,7 +114,7 @@ static co
the warnings, use the PRIuMAX and PRIx64 macros
from the header file.
Signed-off-by: Ramsay Jones
---
ewah/ewah_bitmap.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/ewah/ewah_bitmap.c b/ewah/ewah_bitmap.c
index 625f5a6..1e363b9 100644
--- a/ewah/ewah_bitmap.c
Signed-off-by: Ramsay Jones
---
Makefile | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 07b0626..1950858 100644
--- a/Makefile
+++ b/Makefile
@@ -2484,8 +2484,9 @@ profile-clean:
$(RM) $(addsuffix *.gcno,$(addprefix $(PROFILE_DIR
Noticed by sparse. ("symbol '...' was not declared. Should it be
static?")
Signed-off-by: Ramsay Jones
---
builtin/pack-objects.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index 423e85a..
On 08/11/13 17:10, Torsten Bögershausen wrote:
> On 2013-11-07 23.19, Jeff King wrote:
>> On Thu, Nov 07, 2013 at 09:58:02PM +0000, Ramsay Jones wrote:
>>
>>> These patches fix various errors/warnings on the cygwin, MinGW and
>>> msvc builds, provoked by the jk
/* 1 is file that is deleted */
> + d1 = noindex_filespec(name1, mode2);
-----^
I have not been following the discussion (or even really
studied this patch), but the asymmetry here caught my eye
as
}
if (listen_addr->nr > 0 || !systemd_mode)
socksetup(listen_addr, listen_port, &socklist);
#else
socksetup(listen_addr, listen_port, &socklist);
#endif
Or, maybe:
#if !defined(HAVE_SYSTEMD)
socksetup(listen_addr, listen_
the static qualifier to the function definition.
[An alternative solution, if this symbol should have external scope,
is to add an external declaration for the function to the "cache.h"
header file (next to the one for parse_sha1_header()).]
Signed-off-by: Ramsay Jones
---
Hi Karthik
mentation/git-log.txt
> +++ b/Documentation/git-log.txt
> @@ -62,7 +62,7 @@ produced by `--stat`, etc.
> output by allowing them to allocate space in advance.
>
> -L ,:::
> --L
> +-L
> Trace the evolution of the line range given by ","
Signed-off-by: Ramsay Jones
---
Hi Junio,
This test recently started failing for me. I haven't heard anyone
else complaining about this, so maybe I should look into why my
environment may be different to everyone else ... :-D (when I can
find some time, of course!)
ATB,
Ramsay Jones
t/
documentation of 'get_tree_entry_follow_symlinks' regarding the
'result_path' parameter is observed by callers (ie that the
parameter points to an _unitialized_ strbuf), a better solution
is to simply call the 'strbuf_init' function.
Signed-off-by: Ramsay Jones
ate (see also: git help revisions)
>logShow commit logs
>status Show the working tree status
>
>[...]
>
> Helped-by: Eric Sunshine
> Signed-off-by: Ramsay Jones
This should be (at most) 'Helped-by:' - my 'contribution' was
e any known problems with the current implementation ?
Yes. The next branch is currently broken. (see reply to Junio)
> Does speed matter ?
>
> One vote to keep the special cygwin functions.
> (And have a look how to improve the core.filemode)
I don't understand this (parenthetical) c
Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> Michael Haggerty and Jeff King have been re-vamping the reference
>> handling code. The failures noted above were provoked by patches
>> in the 'mh/ref-races' branch. At the time I wrote this patch, that
>>
Michael Haggerty wrote:
> On 06/25/2013 07:07 AM, Junio C Hamano wrote:
>> Ramsay Jones writes:
>>
>>> Michael Haggerty and Jeff King have been re-vamping the reference
>>> handling code. The failures noted above were provoked by patches
>>> in the '
Jeff King wrote:
> On Wed, Jun 26, 2013 at 10:45:48PM +0100, Ramsay Jones wrote:
[ ... ]
> I think Michael's assessment above is missing one thing. It is true that
> a false positive is just a performance problem in most cases, as we
> unnecessarily reload the file, thinki
e used.
I have already written the first pass at this patch, but I'm having
difficulty with naming (get_cached_stat_data, get_index_stat_data,
get_stat_data, ... ;-)
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
by hand after a
git-clone or git-init.
> But that seems to be wrong, a quick test shows that core.filemode=true.
Hmm, it shouldn't - confused!
> Sorry for confusion.
ATB
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a
tation. The patch to do so is given below, just
for illustration purposes.
This fixes the failures to t3210, t3211 and t5500. However, I
have not run the full test suite. This may cause some further
*subtle* problems (just grep for fstat and consider
Ramsay Jones wrote:
> Michael Haggerty wrote:
>> On 06/27/2013 12:35 AM, Jeff King wrote:
> [ ... ]
>>> I think Michael's assessment above is missing one thing.
>>
>> Peff is absolutely right; for some unknown reason I was thinking of the
>> co
&st);
}
return 0;
--
I would need to do some timing tests (on Linux) to see what effect this
would have on performance. (I noticed that the test suite ran about 2%
slower with the above applied).
A simple pass-though fast_fstat(), including on cygwin, is probably the
way to go.
Sorry for being a bit slow on this - I'm very busy at the moment. :(
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> Yes, I will send a v2 (soon-ish, I hope).
>
> Ping?
>
> No need to hurry, but just to make sure this didn't disappear from
> everybody's radar.
Yep, this is still on my TODO list.
Sorry for being tardy on
fast_fstat() necessary; should we remove the use of
fstat() in write_entry() instead. (I don't think so).
- Is the 5% slowdown on MinGW a real problem? (are the
static inline functions being in-lined?)
- I need to double check that I have replaced all relevant
, 452993c2, 085479e7, b8a97333, 924aaf3e, 05bab3ea and 0117c2f0.
In order to limit the adverse effects caused by this implementation,
we provide a new "fast stat" interface, which allows us to use this
only for interactions with the index (i.e. the cached stat data).
Signed-off-by: Rams
Torsten Bögershausen wrote:
> On 30.06.13 19:28, Ramsay Jones wrote:
[ ... ]
>>> You have just described my second patch! :D
>> Unfortunately, I have not had any time to work on the patch this weekend.
>> However, despite the patch being a bit rough around the edges, I d
it is unclear what
> basic setting needs to be read for which exact operation.
>
> Waiting for clarification.
> $gmane/228294
Sorry, still on my TODO list. (Having said that, I'm no longer sure
that these patches do the right thing! ;-)
ATB,
Ramsay Jones
--
To unsubscri
these
warnings, we replace the initialiser expression with '{NULL}'.
Signed-off-by: Ramsay Jones
---
Hi Jeff,
If you need to re-roll the patches in your 'jk/in-pack-size-measurement'
branch, could you please squash this (or something like it) into the
patches equivalent to commit 7
Signed-off-by: Ramsay Jones
---
Hi Jeff,
One of the three gcc compilers that I use does not understand the
sentinel function attribute. (so, it spews 108 warning messages)
Is this, or something like it, too ugly for you to squash into
your patch? :-D
ATB,
Ramsay Jones
Makefile
Mark Levedahl wrote:
> On 07/10/2013 04:23 PM, Ramsay Jones wrote:
>> Commit adbc0b6b ("cygwin: Use native Win32 API for stat", 30-09-2008)
>> added a Win32 specific implementation of the stat functions. In order
>> to handle absolute paths, cygwin mount
and not so elsewhere.
>
Should you revert commit c869753e ("Force core.filemode to false
on Cygwin.", 30-12-2006) instead?
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
compat/mmap.c code will attempt to free() the allocated memory block
twice, with unpredictable results.
I wrote a patch to address this at the time (Hmm, seems to be built
on v1.8.1), but didn't submit it since your patch didn't progress. :-D
I have included the patch below.
ATB,
Ramsay
in 1.5 and cygwin 1.7.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Jonathan Nieder wrote:
> Ramsay Jones wrote:
>
>> One of the three gcc compilers that I use does not understand the
>> sentinel function attribute. (so, it spews 108 warning messages)
>
> Do you know what version of gcc introduced the sentinel attribute?
> Would it
the sentinel attribute
for gcc v4.0 and newer.
Signed-off-by: Ramsay Jones
---
This was built on the next branch
ATB,
Ramsay Jones
argv-array.h | 2 +-
builtin/revert.c | 4 ++--
exec_cmd.h| 2 +-
git-compat-util.h | 7 +++
run-command.h | 2 +-
5 files changed, 12
these
warnings, we replace the initialiser expression with '{NULL}'.
Signed-off-by: Ramsay Jones
---
This was built on the next branch.
ATB,
Ramsay Jones
sha1_file.c | 2 +-
streaming.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sha1_file.c b/sha1_file.c
index 4
at the top of
that test file, you will see:
test_have_prereq SED_STRIPS_CR && SED_OPTIONS=-b
test_have_prereq MINGW && export GREP_OPTIONS=-U
which may explain why it works for me on MinGW, but not why it works on
cygwin 1.5.
ATB,
Ramsay Jones
--
To unsubscribe from this list: s
Jeff King wrote:
> On Tue, Jul 16, 2013 at 07:57:20AM +0200, Johannes Sixt wrote:
>
>> Am 7/15/2013 19:31, schrieb Ramsay Jones:
>>> Sparse issues three "Using plain integer as NULL pointer" warnings.
>>> Each warning relates to the use of an '{0}'
ovide a new "fast stat" interface, which allows us to use this
>>>>> only for interactions with the index (i.e. the cached stat data).
>>>>>
>>>>> Signed-off-by: Ramsay Jones
>>>>> ---
>>>> I've tested this on Cy
6e65 7373 2061 6e64 2069 7320 holiness and is
020: 7468 6520 6e75 7273 6520 6f66 2068 6973 the nurse of his
030: 2061 6765 2061 6e64 2074 6865 0d0aage and the..
$ exit
...
# passed all 11 test(s)
1..11
$
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
igned-off-by: Mark Levedahl
> ---
> This replaces my earlier patch against t3032 (8896b287 on pu)
Yep, this looks good and (as expected) it works on cygwin 1.5 too. :-D
Thanks.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a me
t, I'll create a patch series with the above and
> justifications for the different settings that I know.
As far as I can see, only the pread() and maybe MMAP and regex setting
need to change from the current setup.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> Jonathan Nieder wrote:
>>> Ramsay Jones wrote:
>>>
>>>> One of the three gcc compilers that I use does not understand the
>>>> sentinel function attribute. (so, it spews 108 warning messages)
Jeff King wrote:
> On Thu, Jul 18, 2013 at 09:25:50PM +0100, Ramsay Jones wrote:
>
>> Sparse issues some "Using plain integer as NULL pointer" warnings.
>> Each warning relates to the use of an '{0}' initialiser expression
>> in the declaration of
Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> The sentinel function attribute is not understood by versions of
>> the gcc compiler prior to v4.0. At present, for earlier versions
>> of gcc, the build issues 108 warnings related to the unknown
>> attribute. In
the NO_TRUSTABLE_FILEMODE build variable, and no real prospect of anyone else
wanting to use it.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> Junio C Hamano wrote:
>> [ ... ]
>>> * rr/send-email-ssl-verify (2013-07-06) 6 commits
>>> - SQUASH??? update to support SSL_ca_file as well as SSL_ca_path
>>> - SQUASH??? send-email: cover both smtp
unction it appears in.)
make: *** [test-url-normalize.o] Error 1
In order to fix the error, we simply protect the use of the 'max_requests'
variable with an preprocessor conditional.
Signed-off-by: Ramsay Jones
---
Hi Kyle,
When you next update the patches in your 'km/http-curl-co
stat (2013-07-18) 1 commit
>> - cygwin: Remove the Win32 l/stat() implementation
>
>> I am personally in favor of this simpler solution. Comments?
> Me too, thanks to all contributors
Thank you for taking the time to help address this issue!
ATB,
Ramsay Jones
--
To unsubscribe fr
t;slab)) by the s->stride.
Having changed the calculation of the slot#, we now need to convert
the logical 'nth_slot', by scaling with s->stride, into the correct
physical address.
Signed-off-by: Ramsay Jones
---
Hi Junio,
While looking into a sparse warning, which involved the use
Sparse issues an "symbol 'saved_parents_slab' was not declared. Should
it be static?" warning. In order to suppress the warning, since this
symbol does not require more than file visibility, we simply add the
static modifier to its declaration.
Signed-off-by: Ramsay Jones
patch? If so, then I need to find another solution
very quickly [1] (before v1.8.4). At this time, despite passing the
test suite [2], the cygwin build is still very much broken.
ATB,
Ramsay Jones
[1] I do have another patch, patch #0 actually, which I said I didn't
want applied! :-P
[2]
test-url-normalize is coming soon, could I request that
you apply my patch (or squash it into this series)? At present, I have
to apply the patch before building the next and pu branches; OK it's not
too onerous, but still ... :-P
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the
Junio C Hamano wrote:
> Ramsay Jones writes:
>
>>> I am personally in favor of this simpler solution. Comments?
>>
>> I had expected this to me marked for 'master'.
>>
>> Has this simply been overlooked, or do you have reservations about
>>
t though... Just a simple correction would break
> all script depending on that.
$path is part of the public API, so we can't just remove it. It would
require a deprecation period, etc,. (Adding/documenting $sm_path as an
alternative *may* be worth doing. dunno.)
HTH
ATB,
Ramsay Jones
Win32 l/stat()
implementation", 22-06-2013), this patch is no longer necessary and
can simply be dropped from this series.
[I have not had time to read your new patches yet, but I seem to remember
being concerned about those platforms which have UNRELIABLE_FSTAT set.
(ie cygwin, MinGW and
Jeff King wrote:
> On Fri, Nov 02, 2012 at 09:33:14PM +0000, Ramsay Jones wrote:
>
>> (Linux is my main platform, but I like to keep cygwin working because it has
>> kept me sane on Windows ever since (about) 1995 ...)
>> "Stranger in a strange land" ;-)
>
ninitialized.
However, in order to suppress the warning, we simply initialize the
variable to zero in it's declaration.
Signed-off-by: Ramsay Jones
---
Hi Jeff,
Could you please squash this into commit df126e108 ("remote-curl: hoist
gzip buffer size to top of post_rpc", 31-10-2012), w
Jeff King wrote:
> On Sat, Nov 10, 2012 at 06:33:38PM +0000, Ramsay Jones wrote:
>
>>> We should probably wrap it. I'm planning to queue this on top of Chris's
>>> patch:
>>
>> Unfortunately, I haven't had time yet to test this patch. (Ea
pack: Disable threading on cygwin", 26-06-2012).
I didn't notice which platform you are on, but maybe you also have a
thread-unsafe pread()? Could you try re-building git with the
NO_THREAD_SAFE_PREAD build variable set?
HTH.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send
).
However, as a first step could you try running the test program
(given below) on your system to determine if your pread() is thread-safe
or not. (gcc -I. -o test-pread test-pread.c; ./test-pread)
Also, what is the output of "uname -a".
ATB,
Ramsay Jones
-- >8 --
#include &quo
sh installed cygwin,
> but failed to compile under 1.7.7, see below.
> Is there a way we can achieve to compile git both under "old" and "new"
> cygwin 1.7 ?
> Or is this not worth the effort?
Did the cygwin project not bump an api version number somewhere?
ATB,
Ramsa
Torsten Bögershausen wrote:
> On 13.11.12 19:55, Ramsay Jones wrote:
>> Douglas Mencken wrote:
>>> *Any* git clone fails with:
>>>
>>> fatal: premature end of pack file, 106 bytes missing
>>> fatal: index-pack failed
>>>
>>> At firs
at looks like a Windows style absolute path.
>
> OTOH, it could be argued that Maven should not treat a Cygwin program like
> a DOS program, and it should pass the path in the POSIXy form
> /c/cygwin/tmp/commit or /tmp/commit.
I would argue precisely this! :-D
ATB,
Ramsay Jones
--
T
e the variable to
zero in it's declaration.
Signed-off-by: Ramsay Jones
---
Hi Junio,
This is on top of next. (commit df126e108: "remote-curl: hoist gzip
buffer size to top of post_rpc", 31-10-2012).
Thanks!
ATB,
Ramsay Jones
remote-curl.c | 2 +-
1 file changed, 1 insertion(
rompt', while t/t0007-ignores.sh is added by branch 'as/check-ignore'.
Also:
$ make test-lint-executable
non-executable tests: t5801-remote-helpers.sh
make: *** [test-lint-executable] Error 1
$
(added in branch 'fc/fast-export-fixes').
HTH
ATB,
Ramsay Jone
/git
>
I fetch git from 'git://git.kernel.org/pub/scm/git/git.git' which has
commit ee26a6e2 ("Git 1.8.1-rc0", 03-12-2012), but is missing the v1.8.1-rc0
tag. Is this just an oversight (the above list suggests not), or should I not
be using kernel.org?
ATB,
Ramsay Jones
-
801 - 900 of 1047 matches
Mail list logo
