This causes sparse to
complain ('symbol not declared. Should it be static?').
In order to suppress the warning, move the external declaration to the
"bisect.h" header file and '#include' the header in 'revision.c'.
Signed-off-by: Ramsay Jones
---
Hi Junio
Signed-off-by: Ramsay Jones
---
Hi Junio,
Sorry for this hit-n-run patch, but I'm in a hurry ... :-D
Could you please squash this (or something like it) into
the relevant patch; Thanks!
[I noticed this simply because I have '-Wdeclaration-after-statement'
and '-Werror&#x
On 06/08/15 10:53, Ramsay Jones wrote:
>
> Signed-off-by: Ramsay Jones
> ---
>
> Hi Junio,
>
> Sorry for this hit-n-run patch, but I'm in a hurry ... :-D
> Could you please squash this (or something like it) into
> the relevant patch; Thanks!
Ah, I've just
by: Ramsay Jones
---
Hi Junio,
So, my home move caused a (reluctant) change in ISP too. :(
This, in turn, left me without any internet access for just over
three weeks; I was climbing the walls!
ATB,
Ramsay Jones
.mailmap | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
the
symbol from file local to external.
In order to revert the visibility of the symbol to file local, add
the static modifier to the declaration of 'common_list'.
Noticed by sparse (symbol 'common_list' was not declared. Should it
be static?).
Signed-off-by: Ramsay Jones
---
Hi
Hi Johannes,
On 01/09/15 17:11, Johannes Schindelin wrote:
> Hi Ramsay,
>
> On 2015-09-01 17:50, Ramsay Jones wrote:
>
>> diff --git a/.mailmap b/.mailmap
>> index ece2951..e5b4126 100644
>> --- a/.mailmap
>> +++ b/.mailmap
>> @@ -186,7 +186,7 @@ Phil
On 07/09/15 13:31, Gábor Bernát wrote:
> From: Gabor Bernat
>
> adds seconds progress and estimated seconds time if getting the current
> timestamp is supported by the date %+s command
s/%+s/+%s/
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe
I haven't read any other patches yet (including those which use these
new '_to' functions), but I can't help feeling they should be named something
like 'sha1_to_hex_str()' and 'find_unique_abbrev_str()' instead. i.e. I don't
get
the '_to' thing
ER;
> mode = 0100666;
> - strcpy(header.name, "pax_global_header");
> + xsnprintf(header.name, sizeof(header.name), "pax_global_header");
How about using strlcpy() instead? Thus:
- strcpy(header.name, "pax_global_header");
+
return mkstemp(path);
> } else {
> return create_file(path, !symlink ? ce->ce_mode : 0666);
Hmm, I was going to suggest strlcpy() again. However, if you expect an overflow
to
occur, then xsnprintf() will at least bring it to your attention! Ch
On 15/09/15 19:42, Jeff King wrote:
> On Tue, Sep 15, 2015 at 07:32:29PM +0100, Ramsay Jones wrote:
>
>>> diff --git a/archive-tar.c b/archive-tar.c
>>> index b6b30bb..d543f93 100644
>>> --- a/archive-tar.c
>>> +++ b/archive-tar.c
>>> @@ -301,
Commits 9c0b9f6 ("worktree: add 'list' command", 18-09-2015) and
40ca3d3 ("worktree: add functions to get worktree details", 18-08-2015)
both introduce the use of a C99 feature (declare the loop control
variable in the loop header initializer section).
Signed-off-b
Signed-off-by: Ramsay Jones
---
Hi Stefan,
When you next re-roll the patches for your
'sb/submodule-parallel-fetch' branch, could you please squash
parts of this into the relevant patches. [which would correspond
to commits a93fb7a ("run-command: add an asynchronous parallel
he static keyword to the declaration
of the 'root' symbol.
Signed-off-by: Ramsay Jones
---
Hi Jeff,
If you need to re-roll your 'jk/war-on-sprintf' series, could you
please squash this into the relevant patch.
Thanks!
ATB,
Ramsay Jones
builtin/apply.c | 2 +-
1 file chan
lementations
as well as provide a 'git' version which would work on MinGW, cygwin and
linux. Note that some of the existing implementations didn't all agree on
what the tests should report! I don't remember if I looked at the POSIX
spec or not.
So, I don't know how use
he
visibility, apply the static keyword to their declarations.
Signed-off-by: Ramsay Jones
---
Hi Stefan,
No, despite the same subject, this is not the same patch that I sent
you last week! :-D
Could you please squash parts of this into the patches corresponding
to the above mentioned commits.
T
On 01/10/15 18:05, Stefan Beller wrote:
> On Thu, Oct 1, 2015 at 5:02 AM, Ramsay Jones
> wrote:
>>
[snip]
>> diff --git a/run-command.c b/run-command.c
>> index 341b23b..347d22e 100644
>> --- a/run-command.c
>> +++ b/run-command.c
>> @@ -865,7 +865,7 @
p->children[i].err))
> +&pp->children[i].err,
> +pp->data))
> return 1;
... the above hunk caught my eye. I don't know that it matters that
much, but since you have reordered parameters on some functi
rder to suppress the
warnings, we simply pass 'NULL', rather than '0', to the OPT_PASSTHRU
macro.
Signed-off-by: Ramsay Jones
---
Hi Paul,
If you need to re-roll your patches on the 'pt/pull-builtin' branch,
could you please squash this into the patch which corres
Any changes listed in the logs relate to
>> ensuring that the MSVC compiler will run as part of a regular Makefile
>> run (IIUC). The last significant commit was 74cf9bd (engine.pl: Fix a
>> recent breakage of the buildsystem generator, 2010-01-22) Ramsay Jones,
>> so that&#
Commit 6d41edc6 ("refs: add methods for reflog", 24-02-2016), moved the
reflog handling into the ref-storage backend. In particular, the
files_reflog_iterator_begin() API was removed from internal refs API
header, resulting in sparse warnings.
Signed-off-by: Ramsay Jones
---
Hi Mi
to store references.
>
> Is everybody happy with this version?
> If so, will merge to 'next'.
A small fixup required for this one.
see http://thread.gmane.org/gmane.comp.version-control.git/298137
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signed-off-by: Ramsay Jones
---
Hi Christian,
If you need to re-roll your 'cc/apply-am' branch, could you please
squash this into the relevant patch. Commit 95a3b0ba ("apply: move
libified code from builtin/apply.c to apply.{c,h}", 22-04-2016)
removed this '#include
ret &= write_in_full(process->in, src,
> len) == len;
> + else if (fd >= 0)
> + ret &= copy_fd(fd, process->in) == 0;
> + else
> +
Hi Lars,
On 23/07/16 00:19, Ramsay Jones wrote:
>
>
> On 22/07/16 16:49, larsxschnei...@gmail.com wrote:
>> From: Lars Schneider
>>
>> Git's clean/smudge mechanism invokes an external filter process for every
>> single blob that is affected by a filter.
On 24/07/16 18:16, Lars Schneider wrote:
>
> On 23 Jul 2016, at 01:19, Ramsay Jones wrote:
>
>> On 22/07/16 16:49, larsxschnei...@gmail.com wrote:
>>> From: Lars Schneider
>>>
>>> Git's clean/smudge mechanism invokes an external filter process
Signed-off-by: Ramsay Jones
---
Hi Christian,
I had intended to ask you to squash this into your 'cc/apply-am'
branch, specifically commit 4d18b33a (apply: move libified code
from builtin/apply.c to apply.{c,h}, 30-07-2016).
However, having read that commit a little closer, it seem
On 03/08/16 10:47, Christian Couder wrote:
> Hi Ramsay,
>
> On Wed, Aug 3, 2016 at 12:44 AM, Junio C Hamano wrote:
>> On Tue, Aug 2, 2016 at 3:33 PM, Ramsay Jones
>> wrote:
>>>
>>> Signed-off-by: Ramsay Jones
>>> ---
>>>
>>> H
Signed-off-by: Ramsay Jones
---
Hi Jeff,
If you need to re-roll your 'jh/status-v2-porcelain' branch, could
you please squash this into the relevant patch (37f7104f, "status:
print per-file porcelain v2 status data", 02-08-2016).
Thanks!
ATB,
Ramsay Jones
wt-status.c |
Signed-off-by: Ramsay Jones
---
Hi Michael,
If you need to re-roll your 'mh/diff-indent-heuristic' branch, could
you please squash this into the relevant patch (e199b6e2, "diff: improve
positioning of add/delete blocks in diffs", 04-08-2016).
Thanks!
ATB,
Ramsay Jones
fined
before this declaration. One solution could be to #include "iterator.h"
prior to _all_ #include "refs/refs-internal.h" in all compilation units
(Note it is in the opposite order in refs/iterator.c). Alternatively, you
could put the #include "../iterator.h" in
On 08/08/16 17:30, Johannes Sixt wrote:
> Am 07.08.2016 um 22:34 schrieb Ramsay Jones:
>> On 05/08/16 23:26, Johannes Sixt wrote:
[snip]
>> At this point 'enum iterator_selection' is an incomplete type and may
>> be used when the size of the object is not req
On 08/08/16 19:28, Ramsay Jones wrote:
>
>
> On 08/08/16 17:30, Johannes Sixt wrote:
>> Am 07.08.2016 um 22:34 schrieb Ramsay Jones:
>>> On 05/08/16 23:26, Johannes Sixt wrote:
> [snip]
>>> At this point 'enum iterator_selection' is an incomplete
hanged in a couple of weeks!]
I don't have time to investigate further tonight and, since I had not
heard anyone else complain, I thought I should let you know.
See below for the output from a failing run. [Note: this is on Linux
Mint 18, tonight's pu branch @7c7984401].
ATB,
Ramsay Jones
c.info/?l=git&m=148112502029302&w=2) I'll start working on
> returning
> empty rather than die.
>
> Also Jeff suggested some changes, which I've incorporated into my local
> branch.
> (http://marc.info/?t=14811250361&r=1&w=2). I'll reroll if no
> further changes are
> suggested soon :)
Not forgetting to make 'quote_literal_for_format()' static. ;-)
ATB,
Ramsay Jones
x27;\''sq'\'',\$x=.r $S3 [OK]
> -- OUT: $S3 . [OK]
> - STOP
> - EOF
> - test_cmp_count expected.log rot13-filter.log &&
> -
> + git commit -m "test commit 2" &&
> rm -f test2.r "testsubdir/test3 '\''sq'\'',\$x=.r" &&
>
> filter_git checkout --quiet --no-progress . &&
>
I applied this to the pu branch and ran the test by hand
48 times in a row without failure. (the most trials without
error beforehand was 24).
Thanks.
ATB,
Ramsay Jones
Signed-off-by: Ramsay Jones
---
Hi Christian,
If you need to re-roll your 'cc/split-index-config' branch, could
you please squash this into the relevant patch (commit 8a7e3ef9a6,
"read-cache: touch shared index files when used", 26-12-2016).
Thanks!
ATB,
Ramsay Jones
re
Signed-off-by: Ramsay Jones
---
Hi Duy,
If you need to re-roll your 'nd/worktree-move' branch, could you
please squash this into the relevant patch. (commit 62985f75c1
"worktree move: refuse to move worktrees with submodules", 08-01-2017).
[BTW, this is a sparse warning, j
Signed-off-by: Ramsay Jones
---
Hi Brandon,
If you need to re-roll your 'bw/attr' branch, could you please
squash this into the relevant patch (commit 8908457159,
"attr: use hashmap for attribute dictionary", 12-01-2017).
Also, I note that, although they are declared a
On 18/01/17 23:05, Brandon Williams wrote:
> On 01/18, Ramsay Jones wrote:
>>
>> Signed-off-by: Ramsay Jones
>> ---
>>
>> Hi Brandon,
>>
>> If you need to re-roll your 'bw/attr' branch, could you please
>> squash this into the
quot;cache.h"
> +#include "oidset.h"
> +
> +struct oidset_entry {
> + struct hashmap_entry hash;
> + struct object_id oid;
> +};
> +
> +int oidset_hashcmp(const void *va, const void *vb,
static int oidset_hashcmp( ...
ATB,
Ramsay Jones
two '.git/sharedindex.*' files and that their
timestamps had not been changed.
I can't devote any time to looking at this further tonight
(it's 2-45am here, I'm off to bed!). Can you reproduce the
problem, or is it just me? :)
ATB,
Ramsay Jones
rompted by this note, I just
built tcc from the current mob branch (@5420bb8) and built git OK,
but, yes, lots of tests now fail. :(
ATB,
Ramsay Jones
(ie mutually recursive functions),
and even in the current 'pu' branch (@c04899d50), the
definition of this function appears before all uses in
this file. (ie, just add static to the definition).
What am I missing?
ATB,
Ramsay Jones
>
> static struct ref_dir *get_ref_dir(struct re
gt; *ref_store,
> log_all_ref_updates = flag;
>
> rollbacklog:
> - if (logmoved && rename(git_path("logs/%s", newrefname),
> git_path("logs/%s", oldrefname)))
> + strbuf_git_path(&sb_newref, "logs/%s", newrefname);
> + strbuf_git_path(&sb_oldref, "logs/%s", oldrefname);
> + if (logmoved && rename(sb_newref.buf, sb_oldref.buf))
ditto
> error("unable to restore logfile %s from %s: %s",
> oldrefname, newrefname, strerror(errno));
> + strbuf_git_path(&tmp_renamed_log, TMP_RENAMED_LOG);
> if (!logmoved && log &&
> - rename(git_path(TMP_RENAMED_LOG), git_path("logs/%s", oldrefname)))
> + rename(tmp_renamed_log.buf, sb_oldref.buf))
similar
> error("unable to restore logfile %s from "TMP_RENAMED_LOG": %s",
> oldrefname, strerror(errno));
> + strbuf_release(&sb_newref);
> + strbuf_release(&sb_oldref);
> + strbuf_release(&tmp_renamed_log);
>
> return 1;
> }
ATB,
Ramsay Jones
"%s", tmp.buf);
> + else
> + strbuf_git_path(sb, "%s", tmp.buf);
> + strbuf_release(&tmp);
> +}
> +
> /*
> * Increment the reference count of *packed_refs.
> */
>
ATB,
Ramsay Jones
e {
> /* Lock used for the main packed-refs file: */
> static struct lock_file packlock;
>
> -void files_path(struct files_ref_store *refs, struct strbuf *sb,
> - const char *fmt, ...)
> +static void files_path(struct files_ref_store *refs, struct strbuf *sb,
> +const char *fmt, ...)
> {
> struct strbuf tmp = STRBUF_INIT;
> va_list vap;
ATB,
Ramsay Jones
t;\n>'. So your
'chunk' would be a plus one 'char' of some sort. Except that the
caller of this function has already replaced the newline character with
a '\0' char (so strlen(line) would return 81), but still passes the
original line length
ke nth_packed_object_sha1, but ...
Having said that, if the intent is to eventually replace that function with
the new nth_packed_object_oid(), then it is probably not a good idea to
describe this function in terms of the function it will obsolete. ;-)
ATB,
Ramsay Jones
> + * the the first argumen
Signed-off-by: Ramsay Jones
---
Hi Lars,
Commit 6007c69e ("run-command: add wait_on_exit", 04-10-2016), which
is part of your 'ls/filter-process' branch, causes the build to fail
on cygwin, since 'stdin' is defined as a macro thus:
#define stdin (_REENT->
re the cygwin native
regex library matches '.' in a pattern with the NUL character. ie the
test_expect_failure test passes.]
ATB,
Ramsay Jones
Signed-off-by: Ramsay Jones
---
Hi Lars,
If you need to re-roll your 'ls/filter-process' branch, could you
please squash this into commit 85290197
("convert: add filter..process option", 08-10-2016).
Thanks.
ATB,
Ramsay Jones
convert.c | 2 +-
1 file changed, 1 inse
Signed-off-by: Ramsay Jones
---
Hi Johannes,
If you need to re-roll your 'js/prepare-sequencer' branch, could you
please squash this into commit 53f8024e ("sequencer: completely revamp
the "todo" script parsing", 10-10-2016).
Thanks.
ATB,
Ramsay Jones
sequenc
Signed-off-by: Ramsay Jones
---
Hi Jonathan,
If you need to re-roll your 'jt/trailer-with-cruft' branch, could you
please squash this into the relevant patch. [commit 3fb120de ("trailer:
use list.h for doubly-linked list", 14-10-2016)]
Thanks!
ATB,
Ramsay Jones
trai
On 15/10/16 16:05, Lars Schneider wrote:
>> On 11 Oct 2016, at 16:46, Ramsay Jones wrote:
[snip]
>> -void stop_multi_file_filter(struct child_process *process)
>> +static void stop_multi_file_filter(struct child_process *process)
>
> Done! Do you have some kind of scrip
On 16/10/16 01:15, Lars Schneider wrote:
>> On 15 Oct 2016, at 14:01, Ramsay Jones wrote:
>> On 15/10/16 16:05, Lars Schneider wrote:
>>>> On 11 Oct 2016, at 16:46, Ramsay Jones wrote:
>> [snip]
>>>> -void stop_multi_file_filter(struct
On 17/10/16 03:18, Jeff King wrote:
> On Mon, Oct 17, 2016 at 02:37:58AM +0100, Ramsay Jones wrote:
>
>> Hmm, well, you have to remember that 'make clean' sometimes
>> doesn't make clean. Ever since the Makefile was changed to only
>> remove $(OBJECTS), r
y config.mak already:
extra-clean: clean
find . -iname '*.o' -exec rm {} \;
But for some reason I _always_ type 'make clean' and then, to top
it off, I _always_ type the 'find' command by hand (I have no idea
why) :-D
ATB,
Ramsay Jones
On 17/10/16 21:07, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> Heh, I actually have the following in my config.mak already:
>>
>> extra-clean: clean
>> find . -iname '*.o' -exec rm {} \;
>>
>> But for some reason I _always_ type
I have not even looked, but I suspect that it simply requires
a change from expect_fail to expect_success, since your commit
has 'fixed' these tests ... would you mind taking a quick look?
Thanks!
ATB,
Ramsay Jones
ing it to
>> Mail::Address now pass, but e3fdbcc8e1 forgot to update the test.
>>
>> Signed-off-by: Matthieu Moy
>> ---
>
> Thanks.
Yep, thanks for looking into this Matthieu.
I applied these cleanly (to both next and pu) and tested
on Linux and cygwin.
Thanks again.
ATB,
Ramsay Jones
t, the 'invalid_attr_name_message()' function is called
from code in pathspec.c, which relies on 'git_attr_counted()' to
call 'attr_name_valid()' internally to check for validity. :-D
ATB,
Ramsay Jones
;
> char *origin;
> size_t originlen;
> unsigned num_matches;
> unsigned alloc;
> struct match_attr **attrs;
> -} *attr_stack;
> +};
> +
> +struct hashmap all_attr_stacks;
> +int all_attr_stacks_init;
Mark symbols 'all_attr_stacks' and 'all_attr_stacks_init' with
the static keyword. (ie. these are file-local symbols).
ATB,
Ramsay Jones
@ static int write_shared_index(struct index_state
> *istate,
> return ret;
> }
>
> +static const int default_max_percent_split_change = 20;
> +
> +int too_many_not_shared_entries(struct index_state *istate)
This function is a file-loacal symbol; could you please make it
a static function.
Thanks.
ATB,
Ramsay Jones
ng "stash@{n}" explicitly, make it possible to
> simply reference as "n". Most users only reference stashes by their
> position in the stash stask (what I refer to as the "index" here).
s/stask/stack/
ATB,
Ramsay Jones
s about to have a moan about PTHREAD_MUTEX_INITIALIZER, since it
causes sparse to issue some warnings, but I see that you have decided
not to use it. So, phew! ;-)
ATB,
Ramsay Jones
Signed-off-by: Ramsay Jones
---
Hi Stefan,
If you need to re-roll your 'sb/attr' branch, could you please
squash this into the relevant patch.
Alternatively, since there is only a single call site for git_attr()
(on line #1005), you could perhaps remove git_attr() and inline
ter still is to make a patch that can either be applied on top, or
> squashed as appropriate.
No patch this time, but it simply requires those variables to be
initialised to NULL in their declarations. :-D
>I know that Ramsay Jones does this, for
> example, wi
Signed-off-by: Ramsay Jones
---
Hi Duy,
If you need to re-roll your 'nd/worktree-move' branch, could you
please squash this into the relevant patch [commit c49e92f5c
("worktree move: refuse to move worktrees with submodules", 12-11-2016)].
Also, one of the new tests
On 15/11/16 20:28, Ramsay Jones wrote:
>
> Signed-off-by: Ramsay Jones
> ---
>
> Hi Duy,
>
> If you need to re-roll your 'nd/worktree-move' branch, could you
> please squash this into the relevant patch [commit c49e92f5c
> ("worktree move: refuse
Signed-off-by: Ramsay Jones
---
Hi Johannes,
If you need to re-roll your 'js/difftool-builtin' branch, could
you please squash this into the relevant patch.
Thanks!
Also, due to a problem in my config.mak file on Linux (a commented
out line that had a line continuation '\&
On 30/11/16 11:07, Johannes Schindelin wrote:
> Hi Ramsay,
>
> On Tue, 29 Nov 2016, Ramsay Jones wrote:
>> Also, due to a problem in my config.mak file on Linux (a commented
>> out line that had a line continuation '\', gr!), gcc issued a
>> warning,
On 30/11/16 21:25, Jeff King wrote:
> On Wed, Nov 30, 2016 at 12:40:25PM -0800, Junio C Hamano wrote:
>
>> Ramsay Jones writes:
>>
>>> [I have fixed my config.mak file now, so I don't see the warning
>>> anymore! Having -Wno-format-zero-length in DE
we should be doing:
>>
>> warning("%s", "");
>>
>> here.
>
> I forgot too. Thanks for digging up that thread.
Yes, I blamed wt-status.c:227 and came up with commit 7d7d68022
as well.
So, by the same rationale, we should remove -Wno-format-zero-length
from DEVELOPER_CFLAGS. yes?
ATB,
Ramsay Jones
on Bob's server. Mallory runs her own server and
Ahem, so Mallory is female? (-blush-) :(
ATB,
Ramsay Jones
ing to fetch, she then follows up by asking
> the server for one or more sha1 objects. But who is the
> server?
>
> If it is still Mallory's server, then Alice will leak the
> existence of those sha1s to her.
--^^^
... to _him_ ? (again Mallory)
ATB,
Ramsay Jones
ve learnt something.
>
> "baby name Mallory" in search engine gave me several sites, most of
> them telling me that is a girl's name except for one.
>
> Didn't think of doing image search, but that's a good way ;-)
Heh, I didn't think about any of this.
On 02/12/16 00:18, Jeff King wrote:
> On Fri, Dec 02, 2016 at 12:07:50AM +0000, Ramsay Jones wrote:
>
>>>> In a British context "Mallory and Irvine" were two (male) climbers who
>>>> died on Everest in 1924 (tales of daring...), so it's easy to
Signed-off-by: Ramsay Jones
---
Hi Stefan,
If you need to re-roll your 'sb/submodule-intern-gitdir'
branch, could you please squash something similar to this
into the relevant patch (commit 2529715dc, "worktree: get
worktrees from submodules", 01-12-2016).
[This is based
Signed-off-by: Ramsay Jones
---
Hi Junio,
I recently noticed that:
$ make >pout 2>&1
$ ./git version
git version 2.11.0.286.g109e8a9
$ git describe
v2.11.0-286-g109e8a99d
$
... for non-release builds, the commit part of the version
string was still using an
On 05/12/16 05:32, Jeff King wrote:
> On Sun, Dec 04, 2016 at 08:45:59PM +0000, Ramsay Jones wrote:
>> I recently noticed that:
>>
>> $ make >pout 2>&1
>> $ ./git version
>> git version 2.11.0.286.g109e8a9
>> $ git describe
>>
On 05/12/16 18:10, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> Heh, that was the first version of the patch. However, I got to thinking
>> about why --abbrev=7 was there in the first place; the only reason I
>> could think of was to defeat local configura
On 05/12/16 22:24, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> As I said, the original version of the patch just removed the
>> --abbrev=7, but then I started to think about why you might have
>> used --abbrev in the first place (first in commit 9b88fcef7 and
>
g --abbrev and letting describe do its default thing (as
>> configured by whoever is doing the build), let's do so.
>>
>> -- >8 --
>> From: Ramsay Jones
>> Date: Sun, 4 Dec 2016 20:45:59 +
>> Subject: [PATCH] GIT-VERSION-GEN: do not force abbrevi
too
much outside of windows networks! (where it is usually denoted by
\\servername\path).
You can see the relics of unix UNC paths if you look at the wording
for basename() in the POSIX standard. Note the special treatment of
the path which 'is exactly "//"', see
http://pubs.opengroup.org/onlinepubs/009695399/functions/basename.html
ATB,
Ramsay Jones
Signed-off-by: Ramsay Jones
---
Hi Karthik,
If you need to re-roll your 'kn/ref-filter-branch-list' branch, could
you please squash this into the relevant patch (commit 715a4826ab,
"branch: use ref-filter printing APIs", 07-12-2016).
Thanks!
ATB,
Ramsay Jones
builti
_ext symbols?
- is index-helper any use/help without watchman support?
- is '! grep -q . err' meant to determine if the err file is
empty (ie git status did not issue an error message)?
[if yes, maybe 'test_must_be_empty err &&' would read bette
9a85998 100644
>> --- a/Documentation/git-check-ignore.txt
>> +++ b/Documentation/git-check-ignore.txt
>> @@ -112,7 +112,7 @@ EXIT STATUS
>> SEE ALSO
>>
>> linkgit:gitignore[5]
>> -linkgit:gitconfig[5]
>> +linkgit:git-config[5]
I think Junio already noted, git-config is in section 1 not 5.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
n core.filemode is not specified in the config file).
>
> +core.hideDotFiles::
> + (Windows-only) If true (which is the default), mark newly-created
The patch (if I'm reading it correctly) and the commit message indicate that
the default is 'dotGitOnly'.
> + di
ved_namelen =
>> 0;" in this case.
>> --
> Thanks,
>
> I'll try and work up a patch - probably next week as I'm away for the weekend.
Yeah, I don't remember why these were left over from the previous
attempt to clean these up (maybe they conflicted with in
On 06/05/16 19:54, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> The patch below applies to master (I haven't checked for any more
>> additions).
>>
>> if (bisect_list) {
>> -int reaches = reaches, all = all;
>> +i
On 06/05/16 21:21, Ramsay Jones wrote:
> On 06/05/16 19:54, Junio C Hamano wrote:
>> Ramsay Jones writes:
>>
[snip]
> I still can't get gcc to complain, e.g. (on top of above):
>
> $ git diff
> diff --git a/builtin/rev-list.c b/builtin/rev-list.c
&
seq 1 10 >a &&
>> + printf 1 2 3 4 5 7 8 9 10 >a &&
>
> $ printf 1 2 3 4 5 7 8 9 10
> 1
yep, I think:
printf "%d\n" 1 2 3 4 5 6 7 8 9 10 >a &&
would be equivalent.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/05/16 14:15, Ramsay Jones wrote:
>
>
> On 07/05/16 13:19, Andreas Schwab wrote:
>> Torsten Bögershausen writes:
>>
>>> The "seq" is not understood by all shells,
>>> using printf fixes this,
>>>
>>> index 20a3ffe
test.
I haven't been able to debug it too much, but I can tell you that it is
not failing at exactly the same place every time (so it may be time
sensitive). However, it often fails in poke_and_wait_for_reply() at the
first packet_flush() (which in turn calls write_or_die() which calls
e here, except ext4 instead of ext3. Failing on a virtual machine,
> not failing on a physical one.
I can confirm the trend:
Linux Mint 17.3, ext4 - bare-metal pass, (Virtual Box) VM fail.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git&
On 10/05/16 21:30, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> On 10/05/16 12:52, Dennis Kaarsemaker wrote:
>>> On ma, 2016-05-09 at 15:22 -0700, Junio C Hamano wrote:
>>>> It passes on one box and fails on another. They both run the same
>>>
return -1;
Why are you sending a flush packet - doesn't the index-helper
simply ignore it?
I haven't tried this yet BTW, just reading patches as they float
on past... ;-)
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
723,88 @@ static void post_read_index_from(struct index_state
> *istate)
> tweak_untracked_cache(istate);
> }
>
> +/* in ms */
> +#define WATCHMAN_TIMEOUT 1000
> +
> +static int poke_and_wait_for_reply(int fd)
> +{
> + int ret = -1;
> + struct pollfd poll
Signed-off-by: Ramsay Jones
---
Hi Stefan,
If you need to re-roll your 'sb/submodule-default-paths' branch, could
you please squash this into the relevant patch. (commit 8efbe28b,
"clone: add --init-submodule= switch", 23-05-2016).
Thanks!
ATB,
Ramsay Jones
builtin/cl
1 - 100 of 1047 matches
Mail list logo
