This extra test was introduced erroneously by
f9c0181 (t7502: test commit.status, --status and
--no-status, 2010-01-13)
Signed-off-by: Pranit Bauva
---
t/t7502-commit.sh | 5 -
1 file changed, 5 deletions(-)
diff --git a/t/t7502-commit.sh b/t/t7502-commit.sh
index b39e313..725687d 100755
The older version of this patch :
- [v1] http://thread.gmane.org/gmane.comp.version-control.git/288662
The changes between the patches :
- Improved the language construct of the commit message
- Provided more details about the cited commit in the commit message
Regards,
Pranit Bauva
IIT
On Fri, Mar 11, 2016 at 11:14 AM, Eric Sunshine wrote:
> It's a bit tricky if you're not used to it, but check-for-diff
> actually does what you want, and does so in a more direct way. While
> it's true that it's not an "editor" per se, it does get access to the
> entire block of text that would
Add commit.verbose configuration variable as a convenience for those
who always prefer --verbose.
Signed-off-by: Pranit Bauva
Mentored-by: Eric Sunshine
---
The previous versions of this patch are:
- [v4] $gmane/288652
- [v3] $gmane/288634
- [v2] $gmane/288569
- [v1] $gmane/287540
The
On Mon, Mar 14, 2016 at 1:54 PM, Eric Sunshine wrote:
> On Sat, Mar 12, 2016 at 1:41 AM, Pranit Bauva wrote:
>> Add commit.verbose configuration variable as a convenience for those
>> who always prefer --verbose.
>>
>> Signed-off-by: Pranit Bauva
>> Mentored-b
Add commit.verbose configuration variable as a convenience for those
who always prefer --verbose.
Helped-by: Eric Sunshine
Signed-off-by: Pranit Bauva
---
The previous versions of this patch are:
- [v5] $gmane/288728
- [v4] $gmane/288652
- [v3] $gmane/288634
- [v2] $gmane/288569
- [v1
Add commit.verbose configuration variable as a convenience for those
who always prefer --verbose.
Helped-by: Eric Sunshine
Signed-off-by: Pranit Bauva
---
The previous versions of this patch are:
- [v6] $gmane/288811
- [v5] $gmane/288728
- [v4] $gmane/288652
- [v3] $gmane/288634
- [v2
narios and mention them in the
documentation as to how `commit` will react as this cannot be known by
intuition. This would complicate things for the user who is reading
the man pages.
Regards,
Pranit Bauva
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Mar 16, 2016 at 12:54 AM, Eric Sunshine wrote:
>> As Eric Sunshine mentioned ($gmane.org/288811), it would react
>> according to the multiple verbosity level and since its not currently
>> defined in `commit` it will react as it is reacting when verbosity
>> level is 1.
>
> I get the feeli
On Wed, Mar 16, 2016 at 1:54 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> First one to introduce a new variable `config_verbose` to store the
>> value read by the config. Till then the value of verbose can be set
>> through command line options. Depending
On Wed, Mar 16, 2016 at 2:46 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> ... But then I am still not convinced for the
>> requirement of another variable `opt-verbose` as I believe that the
>> `verbose` and `config_verbose` are quite enough for this.
>>
Hey,
Open Source projects run because of people who contribute in their
free time (mainly). It might not be possible for someone to be active
all times Sometimes it may take around 2-3 days. Give it a little more
time.
On Wed, Mar 16, 2016 at 2:30 AM, Saurabh Jain
wrote:
> hi,
>
> I am Saurabh J
On Thu, Mar 17, 2016 at 12:58 PM, Eric Sunshine wrote:
> On Wed, Mar 16, 2016 at 9:50 PM, Jeff King wrote:
>> On Wed, Mar 16, 2016 at 11:16:58PM +0000, Pranit Bauva wrote:
>>> The reason to make it consider negative values or more specifically
>>> "unspecified&quo
ption have multiple levels of that option.
Eg. :
initialize verbose = -1
`git commit` => verbose = -1
`git commit -v` => verbose = 1
`git commit -v -v` => verbose = 1
`git commit --no-verbose` => verbose = 0
Signed-off-by: Pranit Bauva
---
The discussion on the mailing list[1] suggested
On Sat, Mar 19, 2016 at 4:29 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> The reason to make it consider negative values or more specifically
>> "unspecified" values is to give the ability to differentiate between
>> once, multiple time or with --no
v -v` => verbose = 2
`git commit --no-verbose` => verbose = 0
Signed-off-by: Pranit Bauva
---
The discussion about this patch:
[1] : http://thread.gmane.org/gmane.comp.version-control.git/289027
Previous version of the patch:
[v1] : http://thread.gmane.org/gmane.comp.version-contr
On Thu, Mar 17, 2016 at 2:19 AM, Jeff King wrote:
> On Thu, Mar 17, 2016 at 01:21:49AM +0530, Pranit Bauva wrote:
>
>> I noticed that parse-options does not recognize the variable which is
>> set to -1 so as to denote the "unspecified" value.
>
> Right. L
Hey!
I noticed that parse-options does not recognize the variable which is
set to -1 so as to denote the "unspecified" value.
I did the following changes in builtin/commit.c (in master branch not
the patch I am working on) :
- static int verbose = -1
- introduced a printf statement after parsin
Add commit.verbose configuration variable as a convenience for those
who always prefer --verbose.
Helped-by: Junio C Hamano
Helped-by: Eric Sunshine
Signed-off-by: Pranit Bauva
---
The previous version of the patch are:
- [v7] $gmane/288820
- [v6] $gmane/288728
- [v5] $gmane/288728
- [v4
Hey everyone!
I am Pranit Bauva. I am studying Mining Engineering at IIT Kharagpur.
I am interested in participating in Google Summer of Code under Git
organization. I have attempted a micro-project to add configuration to
commonly used command line options `git commit -v` ($gmane/288820).
I am
On Sat, Mar 19, 2016 at 1:35 PM, Torsten Bögershausen wrote:
> On 2016-03-19 02.19, David Turner wrote:
>> Each write() has syscall overhead, and writing a large index entails
>> many such calls. A larger write buffer reduces the overhead,
>> leading to increased performance.
>>
>> On my repo, wh
Sorry for a little late reply. I was under the impression that I had
replied before.
On Thu, Mar 17, 2016 at 7:20 AM, Jeff King wrote:
> That aside, this patch does mean that one can no longer use
> OPT_COUNTUP() for negative values (i.e., the caller must start it at
> either 0 or 1, and it must
On Sat, Mar 19, 2016 at 9:44 PM, Christian Couder
wrote:
> Hi,
>
> On Sat, Mar 19, 2016 at 1:48 PM, Matthieu Moy
> wrote:
>>> Subject: Re: GSoC Project | Improvise git bisect
>>
>>
>> "Improve" I guess
; line option(s) and state that '-v|--verbose' is a synonym to
> '--show-diff' (maybe even deprecate '--verbose'), but I don't want to
> squeeze even more into a GSOC micro project.
Its perfectly fine. It hardly a half an hour job. Though I like the
id
On Sat, Mar 19, 2016 at 10:19 PM, Chirayu Desai wrote:
> Hi, I want to work on this as my GSoC micro project.
>
>> On Mon, Jan 18, 2016 at 10:24:31PM +0100, Toralf Förster wrote:
>> > very first line is "error: malformed object name " which tells all, or
>> > ?
>> Yeah, I agree that showing the "
On Thu, Mar 17, 2016 at 3:07 AM, Eric Sunshine wrote:
> The goal comes from his GSoC microproject. Specifically, Pranit wants
> an "unspecified" value. The reason is that he is adding a
> commit.verbose= config variable to back the existing git-commit
> --verbose option. Any use of --verbose (one
On Thu, Mar 17, 2016 at 2:53 AM, Jeff King wrote:
> I don't think that would produce the wrong behavior, but it seems like a
> very complicated solution to a problem that can easily be solved by just
> following the usual conventions (that verbose starts at 0, options make
> it go up or down, and
On Fri, Mar 18, 2016 at 12:40 AM, Junio C Hamano wrote:
> Stefan Beller writes:
>
>> For now I would just go with 3 directories:
>>
>> non-git/ (or util, helpers, or anything that could be ripped out and be
>> useful
>> e.g. strbufs, argv-array run-command, lockfile
>> git/ (maybe called lib
On Sun, Mar 20, 2016 at 3:35 AM, Stefan Beller wrote:
> Once upon a time, a discussion produced this proposal[1],
> which tries to split up the set as good as possible (50:50) instead
> of inspecting the branch/merging structure of the underlying graph.
>
Thanks! This helped me in getting to know
ainful, as almost nobody uses COUNTUP
> directly, so we'd need OPT__VERBOSE_DEFAULT().
This is quite new to me. It took me some time to digest it.
> Which in the end is the same as ignoring the problem in the first place,
> but there is a big difference between not thinking about the
On Sun, Mar 20, 2016 at 9:26 AM, Eric Sunshine wrote:
> On Fri, Mar 18, 2016 at 5:19 PM, Pranit Bauva wrote:
>> Add commit.verbose configuration variable as a convenience for those
>> who always prefer --verbose.
>>
>> Signed-off-by: Pranit Bauva
>> ---
&
The project Idea: Incremental Rewrite from shell to C of git-bisect.sh
The plan:
- Place bisect.c in builtin/
- Implement a skeletal cmd_bisect() which will redirect to
git-bisect.sh (1e1ea69f)
- Introduce a structure for parsing the command line flags.
- Start converting individual functions
I didn't mention it before, I was thinking to move directly everything
from git-bisect.sh to bisect.c . But then I would have to redirect to
a shell script. And ultimately remove bisect--helper.c
Your suggestions is a lot better. I could first move individual
functions to bisect--helper.c. This wo
On Sun, Mar 20, 2016 at 11:04 PM, Eric Sunshine wrote:
> On Sun, Mar 20, 2016 at 7:05 AM, Pranit Bauva wrote:
>> On Sun, Mar 20, 2016 at 9:26 AM, Eric Sunshine
>> wrote:
>>> However, more intuitive would probably be to create another "editor"
>>>
this.
Regards,
Pranit Bauva
On Fri, Feb 26, 2016 at 7:34 AM, Stephan Beyer wrote:
> Hi,
>
> this set of patches provides improvements for git bisect.
>
> Quick summary of changes
> - relevant for users:
>- `git bisect next` is documented and motivated
>- git bisec
On Mon, Mar 21, 2016 at 12:48 PM, Johannes Schindelin
wrote:
> Hi Pranit,
>
> On Sun, 20 Mar 2016, Pranit Bauva wrote:
>
>> I could first move individual functions to bisect--helper.c.
>
> My suggestion would be to give it a try already with some functionality
> you d
On Mon, Mar 21, 2016 at 11:23 PM, Christian Couder
wrote:
> Hi Pranit,
>
> On Mon, Mar 21, 2016 at 8:29 AM, Pranit Bauva wrote:
>> On Mon, Mar 21, 2016 at 12:48 PM, Johannes Schindelin
>> wrote:
>>> Hi Pranit,
>>>
>>> On Sun, 20 Mar 2016,
Convert the code literally without changing its design even though it
seems that its obscure as to the use of comparing revision to different bisect
arguments which seems like a problem in shell because of the way
function arguments are handled.
Signed-off-by: Pranit Bauva
---
builtin/bisect
On Tue, Mar 22, 2016 at 5:58 AM, Stefan Beller wrote:
> On Mon, Mar 21, 2016 at 12:00 PM, Pranit Bauva wrote:
>> Convert the code literally without changing its design even though it
>> seems that its obscure as to the use of comparing revision to different
>> bisect
>
On Tue, Mar 22, 2016 at 11:40 AM, Christian Couder
wrote:
> On Tue, Mar 22, 2016 at 1:28 AM, Stefan Beller wrote:
>> On Mon, Mar 21, 2016 at 12:00 PM, Pranit Bauva
>> wrote:
>>> Convert the code literally without changing its design even though it
>>> seems
now because it is not
really be meant to be used like this and this is just for testing
purposes whether this new method is as functional as its counter part.
The shell counter part of the method has been retained for historical
purposes.
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c
On Tue, Mar 22, 2016 at 3:52 AM, Stephan Beyer wrote:
>> If it is okay with you then can I work more upon these
>> patches in my GSoC project.
>
> I'm totally fine with that, of course. :)
Thanks! :)
I will try and fix the left over bug if time persists.
Regards,
Pranit
On Tue, Mar 22, 2016 at 8:39 PM, Johannes Schindelin
wrote:
> Hi,
>
> On Tue, 22 Mar 2016, Pranit Bauva wrote:
>
>> Convert the code literally without changing its design even though it
>> seems that its obscure as to the use of comparing revision to different
>
&
On Tue, Mar 22, 2016 at 8:41 PM, Johannes Schindelin
wrote:
> Hi,
>
> On Tue, 22 Mar 2016, Johannes Schindelin wrote:
>
>> On Tue, 22 Mar 2016, Pranit Bauva wrote:
>>
>> > + if (!strcmp(term, "bad") || !strcmp(term, "
On Tue, Mar 22, 2016 at 9:33 PM, Junio C Hamano wrote:
> Johannes Schindelin writes:
>
>> static int one_of(const char *term, ...)
>> {
>> va_list matches;
>> const char *match;
>>
>> va_start(matches, term);
>> while ((match = va_arg(matches, const char *)))
>>
/git/blob/v2.8.0-rc4/git-bisect.sh#L572-L597
Signed-off-by: Pranit Bauva
---
Changes wrt v1:
- Remove the function declaration
- Introduce another method one_of() to reduce the clutter in if
- Add the documentation as to which part should remain untouched
- Use OPT_CMDMODE() for --check-term
On Wed, Mar 23, 2016 at 5:27 PM, Johannes Schindelin
wrote:
> Hi Pranit,
>
> On Wed, 23 Mar 2016, Pranit Bauva wrote:
>
>> Convert the code literally without changing its design even though it
>> seems that it is obscure as to the use of comparing revision to different
&
On Wed, Mar 23, 2016 at 4:52 PM, Johannes Schindelin
wrote:
> Hi Pranit,
>
> On Tue, 22 Mar 2016, Pranit Bauva wrote:
>
>> I did run the tests. They produce the same results as they did before.
>> To ease review I will next time include these the output of the tests
>
On Wed, Mar 23, 2016 at 9:54 PM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> On Wed, Mar 23, 2016 at 5:27 PM, Johannes Schindelin
>> wrote:
>>> Hi Pranit,
>>>
>>> On Wed, 23 Mar 2016, Pranit Bauva wrote:
>>>
>>>> Con
On Wed, Mar 23, 2016 at 9:45 PM, Junio C Hamano wrote:
> Johannes Schindelin writes:
>
>>> +if (one_of(term, "help", "start", "skip", "next", "reset", "visualize",
>>> +"replay", "log", "run", NULL))
>>
>> If I understood Junio correctly, he meant to line up the second line with
>> th
On Thu, Mar 24, 2016 at 12:49 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> On Sun, Mar 20, 2016 at 11:04 PM, Eric Sunshine
>> wrote:
>> ...
>>> Alternatively, combine #1 and #2 into a single patch which drops the
>>> global test_set_editor
:
---
Incremental rewrite of Git bisect
About Me
Basic Information
Name Pranit Bauva
University IIT Kharagpur
MajorMining Engineering
Emailpranit.ba...@gmail.com
IRC pungi-man
This is my first review. It can contain some mistakes.
On Thu, Mar 24, 2016 at 7:33 AM, Diwas Joshi wrote:
> Subject : [PATCH/GSoC 3/3] Nousage message in error
Mention about GSoC in the notes section (the one followed by the 3
dashes ie. "---") rather than in the subject.
> - To show only erro
On Thu, Mar 24, 2016 at 7:33 AM, Diwas Joshi wrote:
> - To show only error text instead of full usage message
> - Adds exits to callback function in parse-options-cb.c instead of returning
> -1 which results in display of usage message.
I forgot to mention that this microproject is already picke
Also remove test_set_editor from global scope and use it in whichever
test it is required.
---
t/t7507-commit-verbose.sh | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh
index 2ddf28c..cf95efb 100755
--- a/t/t750
v -v` => verbose = 2
`git commit --no-verbose` => verbose = 0
Signed-off-by: Pranit Bauva
---
The discussion about this patch:
[1] : http://thread.gmane.org/gmane.comp.version-control.git/289027
Previous version of the patch:
[v1] : http://thread.gmane.org/gmane.comp.version-contr
Add commit.verbose configuration variable as a convenience for those
who always prefer --verbose.
Helped-by: Junio C Hamano
Helped-by: Eric Sunshine
Signed-off-by: Pranit Bauva
---
The previous version of the patch are:
- [v8] $gmane/288820
- [v7] $gmane/288820
- [v6] $gmane/288728
- [v5
OPT_CMDMODE() was introduced in the release of 1.8.5 which makes the use
of subcommands in the form of arguments a lot cleaner and easier.
---
Documentation/technical/api-parse-options.txt | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/technical/api-parse-options.txt
b/Do
On Thu, Mar 24, 2016 at 3:34 PM, SZEDER Gábor wrote:
>> Add commit.verbose configuration variable as a convenience for those
>> who always prefer --verbose.
>>
>> Helped-by: Junio C Hamano
>> Helped-by: Eric Sunshine
>> Signed-off-by: Pranit Bauva
>>
&
which reinitialises it to 0 or positive
depending on the situation will solve the problem.
On Thu, Mar 24, 2016 at 3:52 PM, Pranit Bauva wrote:
> On Thu, Mar 24, 2016 at 3:34 PM, SZEDER Gábor wrote:
>>> Add commit.verbose configuration variable as a convenience for those
>>&
gt;> initialize verbose = -1
>> `git commit` => verbose = -1
>> `git commit -v` => verbose = 1
>> `git commit -v -v` => verbose = 2
>> `git commit --no-verbose` => verbose = 0
>>
>> Signed-off-by: Pranit Bauva
>>
>> ---
>> The di
On Thu, Mar 24, 2016 at 9:53 PM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> A general convention followed by git users it to write the commit
>> message as "What he did to the code?" rather than "What problem was
>> there in the code?"
>
>
On Thu, Mar 24, 2016 at 9:37 PM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> OPT_CMDMODE() was introduced in the release of 1.8.5 which makes the use
>> of subcommands in the form of arguments a lot cleaner and easier.
>> ---
>
> Sign-off?
Will include this
On Thu, Mar 24, 2016 at 10:46 PM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>>>> +`OPT_CMDMODE(short, long, &int_var, description, enum_val)`::
>>>> + Introduce an option for subcommands. It is useful when you want to
>>>> use
>>>
Some developers are already working on that[1].
[1]: http://thread.gmane.org/gmane.comp.version-control.git/288306
On Fri, Mar 25, 2016 at 10:12 AM, 惠轶群 wrote:
> There is an interesting idea as an idea for GSoC of 2008, is it still
> proposable?
>
> https://git.wiki.kernel.org/index.php/SoC2008I
On Fri, Mar 25, 2016 at 5:27 AM, Eric Sunshine wrote:
> On Thu, Mar 24, 2016 at 7:00 AM, SZEDER Gábor wrote:
>>> Also remove test_set_editor from global scope and use it in whichever
>>> test it is required.
>>
>> Why?
>>
>> test_set_editor sets and exports shell variables. Since you don't
>> in
On Fri, Mar 25, 2016 at 5:35 AM, Eric Sunshine wrote:
> On Thu, Mar 24, 2016 at 4:25 AM, Pranit Bauva wrote:
>> Add commit.verbose configuration variable as a convenience for those
>> who always prefer --verbose.
>
> The implementation looks better in this version. A co
On Fri, Mar 25, 2016 at 11:54 AM, Eric Sunshine wrote:
> On Fri, Mar 25, 2016 at 2:06 AM, Pranit Bauva wrote:
>> On Fri, Mar 25, 2016 at 5:27 AM, Eric Sunshine
>> wrote:
>>> Agreed that this needs proper justification in the commit message.
>>> And, the justif
On Fri, Mar 25, 2016 at 2:32 PM, Christian Couder
wrote:
> On Thu, Mar 24, 2016 at 12:27 AM, Pranit Bauva wrote:
>> Hey!
>>
>> I have prepared a proposal for Google Summer of Code 2016. I know this
>> is a bit late, but please try to give your comments and sugges
On Fri, Mar 25, 2016 at 2:45 PM, Matthieu Moy
wrote:
> Christian Couder writes:
>
>> On Thu, Mar 24, 2016 at 12:27 AM, Pranit Bauva
>> wrote:
>>
>>> Unification of bisect.c and bisect--helper.c
>>>
>>> This will unify the algorithmic and non-
out that
it would be much better to use the existing test suite rather than
creating one which can lead to less coverage.
Thanks,
Pranit Bauva
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Mar 25, 2016 at 5:10 PM, Christian Couder
wrote:
> On Fri, Mar 25, 2016 at 11:15 AM, Pranit Bauva wrote:
>>> - you will add an option to "git bisect--helper" to perform what the
>>> git-bisect.sh function did, and
>>> - you will create a test scri
On Fri, Mar 25, 2016 at 8:16 PM, SZEDER Gábor wrote:
> By redirecting grep's output to a file in the editor script, like this
> patch wanted to, we can count the lines in the test script itself after
> 'git commit' finished. This way we could use test_line_count, with
> all its error reporting b
> Deprecating doesn't mean "removing". It merely means that we add a note
> to the documentation stating that the option in question is deprecated,
> but we will keep supporting it for several years and releases to come.
Okay. Didn't know.
> This means that '--verbose' and '--show-diff' must coe
On Fri, Mar 25, 2016 at 10:34 PM, Eric Sunshine wrote:
> That works too, simplifying the overall implementation, and
> eliminating the need for the introductory patch which moves
> 'test_set_editor' into each test.
Wouldn't it be cleaner if the introductory patch contain:
1. using write_script()
OPT_CMDMODE mechanism was introduced in the release of 1.8.5 to actively
notice when multiple "operation mode" options that specify mutually
incompatible operation modes are given.
Signed-off-by: Pranit Bauva
---
Documentation/technical/api-parse-options.txt | 7 +++
1 file
I have used bits from your email. I forgot to add "Helped-by: Junio C
Hamano " . Could you squash it in?
On Sat, Mar 26, 2016 at 12:28 AM, Pranit Bauva wrote:
> OPT_CMDMODE mechanism was introduced in the release of 1.8.5 to actively
> notice when multiple "operation mode&
OPT_CMDMODE mechanism was introduced in the release of 1.8.5 to actively
notice when multiple "operation mode" options that specify mutually
incompatible operation modes are given.
Helped-by: Junio C Hamano
Signed-off-by: Pranit Bauva
---
Documentation/technical/api-parse-optio
On Sat, Mar 26, 2016 at 7:43 AM, 惠轶群 wrote:
> 2016-03-26 2:16 GMT+08:00 Junio C Hamano :
>> 惠轶群 writes:
>>
>>> # Purpose
>>> The current implementation of send-email is based on perl and has only
>>> a tui, it has two problems:
>>> - user must install a ton of dependencies before submit a single
Add commit.verbose configuration variable as a convenience for those
who always prefer --verbose taking care of multiple levels of verbosity.
Helped-by: Junio C Hamano
Helped-by: Eric Sunshine
Signed-off-by: Pranit Bauva
---
The previous version of the patch are:
- [v9] $gmane/288820
- [v8
d-by: Junio C Hamano
Signed-off-by: Pranit Bauva
---
The discussion about this patch:
[1] : http://thread.gmane.org/gmane.comp.version-control.git/289027
Previous version of the patch:
[v1] : http://thread.gmane.org/gmane.comp.version-control.git/289061
Changes introduced:
Use a different language i
So that we can see how many diffs were contained in the message and use
them in individual tests where ever it is required. Also use
write_script() to create the fake "editor".
Helped-by: Eric Sunshine
Signed-off-by: Pranit Bauva
---
t/t7507-commit-verbose.sh | 17 +++
On Sun, Mar 27, 2016 at 8:15 AM, Eric Sunshine wrote:
> On Sat, Mar 26, 2016 at 3:48 PM, Pranit Bauva wrote:
>> parse-options.c: make OPTION__COUNTUP understand "unspecified" values
>
> A bit clearer: s/understand/respect/
> Also: s/__/_/
Sure.
>> The rea
On Sun, Mar 27, 2016 at 9:04 AM, Eric Sunshine wrote:
> On Sat, Mar 26, 2016 at 3:48 PM, Pranit Bauva wrote:
>> Add commit.verbose configuration variable as a convenience for those
>> who always prefer --verbose taking care of multiple levels of verbosity.
>
> What does &qu
On Sun, Mar 27, 2016 at 1:47 PM, Eric Sunshine wrote:
> On Sun, Mar 27, 2016 at 3:00 AM, Pranit Bauva wrote:
>> On Sun, Mar 27, 2016 at 9:04 AM, Eric Sunshine
>> wrote:
>>> On Sat, Mar 26, 2016 at 3:48 PM, Pranit Bauva
>>> wrote:
>>>> +test_expe
On Sun, Mar 27, 2016 at 5:21 PM, SZEDER Gábor wrote:
>> +test_expect_success 'commit.verbose true and --no-verbose' '
>> + git -c commit.verbose=true commit --amend --no-verbose &&
>> + ! test -s out
>
> Please use the test_must_be_empty helper instead, because it has a
> nice, human-reada
On Sun, Mar 27, 2016 at 5:37 PM, SZEDER Gábor wrote:
> t/test-lib-functions.sh contains all our test helpers functions, that's
> where you can look for a suitable helper, should it be necessary.
Thanks. I will surely look into it.
--
To unsubscribe from this list: send the line "unsubscribe git" i
On Sun, Mar 27, 2016 at 6:57 PM, SZEDER Gábor wrote:
>> > +! test -s out ||
>> > +rm out &&
>>
>> Why not just "rm -f out"? But, more importantly, why do you need to
>> remove the file at all? The '>' redirection operator (used below) will
>> overwrite the file, so no need to remove it beforehand.
On Sun, Mar 27, 2016 at 10:57 PM, Eric Sunshine wrote:
> On Sun, Mar 27, 2016 at 03:27:25PM +0200, SZEDER Gábor wrote:
>> > > +! test -s out ||
>> > > +rm out &&
>> >
>> > Why not just "rm -f out"? But, more importantly, why do you need to
>> > remove the file at all? The '>' redirection operator
> A couple of new tests to t0040-parse-options.sh would be great to
> ensure that starting from a negative value works as advertised, i.e.
> at least that '--option' jumps to 1 and '--no-option' resets to 0.
I think adding tests to t0040-parse-options.sh cannot reflect the
behavior introduced by t
On Thu, Mar 31, 2016 at 6:05 PM, Miklos Vajna wrote:
> Hi,
>
> Some projects like LibreOffice don't use Signed-off-by, instead usually
> use Gerrit for code review, and reviewers add a Reviewed-by line when
> they are OK with a patch. In this workflow it's a bit unfortunate that
> adding a Signed
Current implementation of parse-options.c treats OPT__QUIET() as integer
and not boolean and thus it is more appropriate to print it as integer
to avoid confusion.
While at it, fix some style issues.
---
t/t0040-parse-options.sh | 94
test-parse-op
here it is important to be
able to exactly determine how many diffs were present.
Helped-by: Eric Sunshine
Signed-off-by: Pranit Bauva
Previous version of this patch:
- [v10]: $gmane/288820
Changes this version wrt previous one:
I decided to include no of diffs in every test and rewrote the
quiet is
set to 0 which will test the new behavior with all sets of values.
Helped-by: Jeff King
Helped-by: Eric Sunshine
Helped-by: Junio C Hamano
Signed-off-by: Pranit Bauva
---
The discussion about this patch:
[1] : http://thread.gmane.org/gmane.comp.version-control.git/289027
Pr
Add commit.verbose configuration variable as a convenience for those
who always prefer --verbose.
Helped-by: Junio C Hamano
Helped-by: Eric Sunshine
Signed-off-by: Pranit Bauva
---
The previous version of the patch are:
- [v10] $gmane/288820
- [v9] $gmane/288820
- [v8] $gmane/288820
- [v7
On Thu, Mar 31, 2016 at 11:49 PM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> Current implementation of parse-options.c treats OPT__QUIET() as integer
>> and not boolean and thus it is more appropriate to print it as integer
>> to avoid confusion.
>>
>>
On Thu, Mar 31, 2016 at 11:53 PM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> Make the fake "editor" store output of grep in a file so that we can
>> see how many diffs were contained in the message and use them in
>> individual tests where ever it
On Fri, Apr 1, 2016 at 12:11 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> This change will not affect existing users of COUNTUP at all, as long as
>> they use the initial value of 0 (or more).
>>
>> Force uses the "unspecified" value in conjuncti
On Fri, Apr 1, 2016 at 1:36 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> On Fri, Apr 1, 2016 at 12:11 AM, Junio C Hamano wrote:
>>>
>>> case OPTION_COUNTUP:
>>> + if (*(int *)opt->value < 0)
>&
On Sat, Apr 2, 2016 at 9:18 PM, マッチョコ太郎 wrote:
> hi
> I downloaded tarball (tar.gz) from git web site and tried to make rpm file.
> But, when I run command "$rpmbuild -tb --clean git-2.8.0.tar.gz",
> error message is displayed and rpm file creation stopped.
> The error message is looks like this:
401 - 500 of 603 matches
Mail list logo
