ported, this subcommand will be retired and will be called by
bisect_reset() and bisect_start().
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 54 +++-
git-bisect.sh| 26
ting test suite. As more
functions are ported, this subcommand would be retired and will be
called by some other method.
Helped-by: Eric Sunshine
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c
subcommand would be retired and will be called by some
other method.
Note: --bisect-clean-state subcommand has not been retired as there are
still a function namely `bisect_start()` which still uses this
subcommand.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit
Hey Eric,
On Wed, Jun 15, 2016 at 11:23 PM, Eric Sunshine wrote:
> On Wed, Jun 15, 2016 at 10:00 AM, Pranit Bauva wrote:
>> Changes wrt previous version:
>> * Use STRING_LIST_INIT_NODUP to avoid leaks in bisect_clean_state()
>> * Use test_path_is_missing in the patch 2/6
Hey Junio,
On Wed, Jun 15, 2016 at 11:42 PM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> diff --git a/builtin/am.c b/builtin/am.c
>> index 3dfe70b..84f21d0 100644
>> --- a/builtin/am.c
>> +++ b/builtin/am.c
>> @@ -30,22 +30,6 @@
>> #include "
Hey Eric,
On Wed, Jun 15, 2016 at 11:52 PM, Eric Sunshine wrote:
> On Wed, Jun 15, 2016 at 10:00 AM, Pranit Bauva wrote:
>> is_empty_file() can help to refactor a lot of code. Also it is quite
>> helpful while converting shell scripts which use `test -s`. Since
>
> As jus
Hey Eric,
On Wed, Jun 15, 2016 at 11:34 PM, Eric Sunshine wrote:
> On Wed, Jun 15, 2016 at 10:00 AM, Pranit Bauva wrote:
>> Reimplement `bisect_clean_state` shell function in C and add a
>> `bisect-clean-state` subcommand to `git bisect--helper` to call it from
&
Hey Eric,
On Fri, Jun 17, 2016 at 12:25 AM, Eric Sunshine wrote:
> On Wed, Jun 15, 2016 at 10:00 AM, Pranit Bauva wrote:
>> Reimplement the `bisect_write` shell function in C and add a
>> `bisect-write` subcommand to `git bisect--helper` to call it from
>> git-bisect.sh
Hey Eric,
On Thu, Jun 16, 2016 at 2:44 AM, Eric Sunshine wrote:
> On Wed, Jun 15, 2016 at 10:00 AM, Pranit Bauva wrote:
>> Reimplement `is_expected_rev` & `check_expected_revs` shell function in
>> C and add a `--check-expected-revs` subcommand to `git bisect--helper` to
Hey Eric,
On Thu, Jun 16, 2016 at 2:35 AM, Eric Sunshine wrote:
> On Wed, Jun 15, 2016 at 10:00 AM, Pranit Bauva wrote:
>> Reimplement `bisect_reset` shell function in C and add a `--bisect-reset`
>> subcommand to `git bisect--helper` to call it from git-bisect.sh .
>> [
Hey Eric,
On Fri, Jun 17, 2016 at 12:46 AM, Eric Sunshine wrote:
> On Thu, Jun 16, 2016 at 3:05 PM, Pranit Bauva wrote:
>> On Thu, Jun 16, 2016 at 2:44 AM, Eric Sunshine
>> wrote:
>>> On Wed, Jun 15, 2016 at 10:00 AM, Pranit Bauva
>>> wrote:
Hey Lars,
Hope you enjoyed your vacations. :)
On Thu, Jun 16, 2016 at 12:40 PM, Lars Schneider
wrote:
>
> On 24 May 2016, at 09:21, Pranit Bauva wrote:
>
>> Reimplement the `check_term_format` shell function in C and add
>> a `--check-term-format` subcommand to `git bisec
Hey Christian,
On Fri, Jun 17, 2016 at 2:17 AM, Christian Couder
wrote:
> On Thu, Jun 16, 2016 at 9:25 PM, Pranit Bauva wrote:
>> Hey Eric,
>>
>> On Fri, Jun 17, 2016 at 12:46 AM, Eric Sunshine
>> wrote:
>>> On Thu, Jun 16, 2016 at 3:05 PM, Pranit Bauva
Hey Christian,
On Fri, Jun 17, 2016 at 2:08 AM, Christian Couder
wrote:
> On Thu, Jun 16, 2016 at 9:01 PM, Pranit Bauva wrote:
>> Hey Eric,
>>
>> On Fri, Jun 17, 2016 at 12:25 AM, Eric Sunshine
>> wrote:
>>> On Wed, Jun 15, 2016 at 10:00 AM, Pran
than setting up a coverage tool for shell scripts.
[1]: http://thread.gmane.org/gmane.comp.version-control.git/295518
Regards,
Pranit Bauva
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
Collecting reviews. This patch is based on my previous series. I will also
include this the next time I reroll the series.
builtin/bisect--helper.c | 44 +++-
git
Hey Junio,
On Sat, Aug 13, 2016 at 12:19 AM, Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> Pranit Bauva writes:
>>
>>> +static int bisect_next_check(const struct bisect_terms *terms,
>>> + const char *current_term)
>>>
Hey Junio,
On Sat, Aug 13, 2016 at 12:55 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> + ...
>> + /*
>> + * Write new start state
>> + */
>> + if (write_file(git_path_bisect_start(), "%s\n", start_head.buf)) {
>
Hey Christian,
On Sat, Aug 13, 2016 at 1:04 PM, Christian Couder
wrote:
> On Wed, Aug 10, 2016 at 11:57 PM, Pranit Bauva wrote:
>>
>> @@ -431,6 +434,244 @@ static int bisect_terms(struct bisect_terms *terms,
>> const char **argv, int argc)
>> return
From: Pranit Bauva
Subject: [GSOC Update] Week 15
=== SUMMARY ==
My public git.git is available here[1]. I regularly keep pushing my work so
anyone interested can track me there. Feel free to participate in the
discussions going on PRs with my mentors. Your comments
will be introduced for write_terms().
Helped-by: Johannes Schindelein
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 60 +++-
git-bisect.sh| 31
: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 252 +--
git-bisect.sh| 133 +
2 files changed, 246 insertions(+), 139 deletions(-)
diff --git a/builtin/bisect--helper.c b/builtin/bisect
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 48 +++-
git-bisect.sh| 28 ++--
2 files changed, 49 insertions(+), 27 deletions(-)
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index
d-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index 3324229..8111c91 100644
--- a/builtin/bisect
temporary measure to port shell
function to C so as to use the existing test suite. As more functions
are ported, this subcommand will be retired but its implementation will
be called by some other methods.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
are ported, this subcommand will be retired but its implementation will
be called by some other methods.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 59 ++--
git-bisect.sh
ting test suite. As more
functions are ported, this subcommand would be retired but its
implementation will be called by some other method.
Helped-by: Eric Sunshine
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c
pass the memory address around functions.
This patch also introduces new methods namely bisect_state_init() and
bisect_terms_release() for easy memory management for the struct
bisect_terms.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin
implementation will
be called by some other method.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 36 +---
git-bisect.sh| 22 +++---
2 files changed, 36 insertions(+), 22
is_empty_file() can help to refactor a lot of code. This will be very
helpful in porting "git bisect" to C.
Suggested-by: Torsten Bögershausen
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/am.c | 20 ++--
cache.h
ported, this subcommand will be retired but its implementation will
be called by bisect_reset() and bisect_start().
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
bisect.c | 43 +++
bisect.h
`
and `term_bad` of `struct bisect_terms`.
Also introduce set_terms() to copy the `term_good` and `term_bad` into
`struct bisect_terms` and write it out to the file BISECT_TERMS.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c
Add test to explicitly check that 'git bisect reset' is working as
expected. This is already covered implicitly by the test suite.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
I faced this problem while converting `bisect_clean_state` and
Hey everyone,
On Sat, Aug 20, 2016 at 2:02 AM, Pranit Bauva wrote:
> `--next-all` is meant to be used as a subcommand to support multiple
> "operation mode" though the current implementation does not contain any
> other subcommand along side with `--next-all` but further com
Hey,
On Sat, Aug 20, 2016 at 2:02 AM, Pranit Bauva wrote:
> Reimplement `bisect_clean_state` shell function in C and add a
> `bisect-clean-state` subcommand to `git bisect--helper` to call it from
> git-bisect.sh .
>
> Using `--bisect-clean-state` subcommand is a measure to port s
mmands functions in a particular way (in which you think
it should not) or you find a possible bug then feel free to discuss it
on this mailing list. Also to save other people's time, first search
for the doubt in the archives or google about it.
[1]: https://groups.google.com/forum/#!forum/git
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 48 +++-
git-bisect.sh| 28 ++--
2 files changed, 49 insertions(+), 27 deletions(-)
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index
The `--bisect-autostart` subcommand is no longer used in the shell
script and the function `bisect_autostart()` is called from the C
implementation.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 11 ---
1 file
The `--check-and-set-terms` subcommand is no longer used in the shell
script and the function `check_and_set_terms()` is called from the C
implementation.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 11 ---
1
pass the memory address around functions.
This patch also introduces new methods namely bisect_state_init() and
bisect_terms_release() for easy memory management for the struct
bisect_terms.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin
The `--next-all` subcommand is no longer used in the shell script and
the function `bisect_next_all()` is called from the C implementation of
`bisect_next()`.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 8 +---
1
, this subcommand will be retired and will be called by some
other method.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 25 -
git-bisect.sh| 7 +--
2 files changed, 25 insertions(+), 7
function to C so as to use the existing
test suite. As more functions are ported, this subcommand will be
retired and will be called by some other methods.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
bisect.c | 80
ported, this subcommand will be retired and will be called by some
other methods.
`bisect_head` is called from `bisect_state` thus its not required to
introduce another subcommand.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c
: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 238 ++-
git-bisect.sh| 133 +-
2 files changed, 238 insertions(+), 133 deletions(-)
diff --git a/builtin/bisect--helper.c b/builtin/bisect
is_empty_file() can help to refactor a lot of code. This will be very
helpful in porting "git bisect" to C.
Suggested-by: Torsten Bögershausen
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/am.c | 20 ++--
cache.h
The `--check-expected-revs` subcommand is no longer used in the shell
script and the function `check_expected_revs()` is called from the C
implementation of `bisect_next()`.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 6
;deqouting" code introduced by the commit 25b48b5c.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 59
1 file changed, 20 insertions(+), 39 deletions(-)
diff --git a
are ported, this subcommand will be retired but its implementation will
be called by some other methods.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 59 ++--
git-bisect.sh
The `--write-terms` subcommand is no longer used in the shell script and
the function `write_terms()` is called from the C implementation of
`set_terms()` and `bisect_start()`.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c
Add test to explicitly check that 'git bisect reset' is working as
expected. This is already covered implicitly by the test suite.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
I faced this problem while converting `bisect_clean_state` and
d-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index 3324229..8111c91 100644
--- a/builtin/bisect
` subcommand is a temporary measure to port
shell function to C so as to use the existing test suite. As more
functions are ported, this subcommand will be retired and will be called
by `bisect_state()`.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin
ported, this subcommand will be retired but its implementation will
be called by bisect_reset() and bisect_start().
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
bisect.c | 43 +++
bisect.h
The `bisect-clean-state` subcommand is no longer used in the shell
script while the C code uses `bisect_clean_state()` thus remove the
subcommand.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 9 -
1 file changed
The `--bisect-write` subcommand is no longer used in the shell script
and the function `bisect_write()` is called from the C implementation.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 13 -
1 file changed
`
and `term_bad` of `struct bisect_terms`.
Also introduce set_terms() to copy the `term_good` and `term_bad` into
`struct bisect_terms` and write it out to the file BISECT_TERMS.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c
implementation will
be called by some other method.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 36 +---
git-bisect.sh| 22 +++---
2 files changed, 36 insertions(+), 22
The `--bisect-auto-next` subcommand is no longer used in the shell
script and the function `bisect_auto_next` is called from the C
implementation.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 10 --
1 file changed
will be introduced for write_terms().
Helped-by: Johannes Schindelein
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 60 +++-
git-bisect.sh| 31
ting test suite. As more
functions are ported, this subcommand would be retired but its
implementation will be called by some other method.
Helped-by: Eric Sunshine
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c
ported, this subcommand will be retired and will be called by some
other method.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 100 ++-
git-bisect.sh| 32
temporary measure to port shell
function to C so as to use the existing test suite. As more functions
are ported, this subcommand will be retired but its implementation will
be called by some other methods.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
cc4-000...@eu-west-1.amazonses.com/
[2]:
http://public-inbox.org/git/01020156b73fe66f-bfad6316-39d4-4577-8f75-d1b4b2031263-000...@eu-west-1.amazonses.com/
[3]:
http://public-inbox.org/git/01020156b73fe6ce-3b204354-849b-40fd-93ff-2ebcf77df91c-000...@eu-west-1.amazonses.com/
Regards,
Pranit Bauva
--
To u
Hey Junio,
On Wed, Aug 24, 2016 at 1:58 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> `--next-all` is meant to be used as a subcommand to support multiple
>> "operation mode" though the current implementation does not contain any
>> other subcomman
Hey Junio,
On Thu, Aug 25, 2016 at 2:42 AM, Junio C Hamano wrote:
>
> Pranit Bauva writes:
>
> > +static int bisect_reset(const char *commit)
> > +{
> > + struct strbuf branch = STRBUF_INIT;
> > +
> > + if (!commit) {
> > + if (st
Hey Junio,
On Thu, Aug 25, 2016 at 3:43 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> +static int is_expected_rev(const char *expected_hex)
>> +{
>> + struct strbuf actual_hex = STRBUF_INIT;
>> + int res = 0;
>> +
Hey Junio,
On Thu, Aug 25, 2016 at 4:00 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> +struct bisect_terms {
>> + struct strbuf term_good;
>> + struct strbuf term_bad;
>> +};
>
> I think "struct strbuf" is overrated. For things lik
Hey Junio,
On Thu, Aug 25, 2016 at 4:10 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> +static int mark_good(const char *refname, const struct object_id *oid,
>> + int flag, void *cb_data)
>> +{
>> + int *m_good = (int *)cb_data;
>>
Hey Junio,
On Thu, Aug 25, 2016 at 11:35 PM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> +static int bisect_terms(struct bisect_terms *terms, const char **argv, int
>> argc)
>> +{
>> + int i;
>> +
>> + if (get_terms(terms)) {
>> +
Hey Junio,
On Fri, Aug 26, 2016 at 9:59 PM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>>> Also this version fails to catch "bisect reset a b c" as an error, I
>>> suspect.
>>
>> It didn't when I tried it right now. Could you please elabor
Hey Junio,
On Fri, Aug 26, 2016 at 12:32 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> +static int bisect_start(struct bisect_terms *terms, int no_checkout,
>> + const char **argv, int argc)
>> +{
>> + int i, has_double_dash = 0,
Hey Junio,
On Sat, Aug 27, 2016 at 4:37 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> +static int bisect_log(void)
>> +{
>> + struct strbuf buf = STRBUF_INIT;
>> +
>> + if (strbuf_read_file(&buf, git_path_bisect_log(), 256) <
Hey Junio,
On Sun, Aug 28, 2016 at 2:52 AM, Junio C Hamano wrote:
>
> Pranit Bauva writes:
>
> >>> +struct bisect_terms {
> >>> + struct strbuf term_good;
> >>> + struct strbuf term_bad;
> >>> +};
> >>
> >> I th
Hey Junio,
Sorry for a late replay.
On Fri, Aug 26, 2016 at 2:00 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> A lot of parts of bisect.c uses exit() and these signals are then
>> trapped in the `bisect_start` function. Since the shell script ceases
>> i
Hey Junio,
On Tue, Aug 30, 2016 at 11:55 PM, Pranit Bauva wrote:
>
>>> @@ -729,7 +735,7 @@ static struct commit **get_bad_and_good_commits(int
>>> *rev_nr)
>>> return rev;
>>> }
>>>
>>> -static void handle_bad_me
Hey Junio,
On Wed, Aug 31, 2016 at 1:03 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> This is a very tricky one. I have purposely not included this after a
>> lot of testing. I have hand tested with the original git and with this
>> branch. The reason why an
rly days!
These days a lot of my fellow students don't really use IRC for
communication and see you can see there were really less number of
people inquiring about GSoC in #git-devel. We can prefer slack or any
other alternative.
Regards,
Pranit Bauva
dn't error out. I am
currently using git 2.9.3 on Ubuntu 15.04 while he is using git 1.9.1
on Ubuntu 16.04. What might have gone wrong?
Regards,
Pranit Bauva
Hey Thomas,
On Mon, Sep 12, 2016 at 1:09 AM, Thomas Gummerer wrote:
> Hi,
>
> On 09/12, Pranit Bauva wrote:
>> Hey everyone,
>>
>> One of my friend was trying to add files using the command `git add
>> .*` and got an error that "fatal: ..: '..' i
-n=, -, --max-number= shows the last n commits
specified in irrespective of whether --reverse is used or not.
With --reverse, it just shows the last n commits in reverse order.
Reported-by: Ruediger Meier
Signed-off-by: Pranit Bauva
---
Hey Ruegiger,
The description is a bit inappropriate
Hey Junio,
On Tue, Sep 27, 2016 at 10:21 PM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> -n=, -, --max-number= shows the last n commits
>> specified in irrespective of whether --reverse is used or not.
>> With --reverse, it just shows the last n commits in rever
Specify even more clearly that --reverse works only with the commits
which are chosen to be shown so as to eliminate the confusion as to
whether the first n or the last n commits with be shown when used
with `-n --reverse`.
Reported-by: Ruediger Meier
Signed-off-by: Pranit Bauva
Hey Junio,
On Wed, Sep 28, 2016 at 3:42 AM, Junio C Hamano wrote:
> "Philip Oakley" writes:
>
>> micro-nit: 'first' and 'last' can be tricky to distinguish for lists...
>
> Let's do this then.
>
> -- >8 --
> From: Pranit Bauva
&g
>From c273a02fc9cab9305cedf6e37422e257a1cc3b1e Mon Sep 17 00:00:00 2001
From: Pranit Bauva
Date: Fri, 26 Feb 2016 07:14:18 +0530
Subject: [PATCH/RFC] git-commit: add a commit.verbose config variable
Since many people always run the command with this option, and would
prefer not to use
ride any value that --verbose or --no-verbose may >
have set before?
Yes, this was the problem. I have fixed it now. But there is a glitch.
See below.
Eric Sunshine:
> On Thu, Feb 25, 2016 at 9:57 PM, Pranit Bauva wrote:
>> From c273a02fc9cab9305cedf6e37422e257a1cc3b1e Mon Se
---
Documentation/SubmittingPatches | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/SubmittingPatches
b/Documentation/SubmittingPatches
index 98fc4cc..b2c7664 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -168,7 +168,9 @
Eric Sunshine:
> On Fri, Feb 26, 2016 at 9:05 AM, Pranit Bauva wrote:
>> ---
>
> Missing sign-off.
>
I have to inoculate the habit of signing off every time.
>> diff --git a/Documentation/SubmittingPatches
>> @@ -168,7 +168,9 @@ the closing bracket to mark the
file.
Signed-off-by: Pranit Bauva
---
Documentation/config.txt | 4
Documentation/git-commit.txt | 7 ++-
builtin/commit.c | 7 +++
3 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index 01cca0a..cf2f48b
the patch together but I could not find the
test examples that could be used from the existing code base. If
someone has an idea in mind then I could probably write the tests.
Though I have tested this personally for all the cases but I think it
would be preferable to automate the job.
R
Since many people always run the command with this option, it would be
preferrable to specify it in the configuration file instead of passing
the option with `git commit` again and again.
Signed-off-by: Pranit Bauva
---
Documentation/config.txt | 4
Documentation/git-commit.txt | 3
git_status_config instead of cmd_commit
I have to yet figure out how to write the tests for this. I will see
the examples that Matthieu Moy mentioned for their implementation.
Regards,
Pranit Bauva,
IIT Kharagpur
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a
On Fri, Mar 11, 2016 at 3:04 AM, Junio C Hamano
wrote:
> But doesn't this belong to git_commit_config(), not
> git_STATUS_config()? Should "commit.verbose" make output from "git
> status" verbose?
True. It should belong to git_commit_config(). My bad. But
surprisingly this code works. I have no
I figured it out, It first runs status_init_config(). I might have
thought "status" as status of the options and thus I may have edited
there.
On Fri, Mar 11, 2016 at 3:08 AM, Pranit Bauva wrote:
> On Fri, Mar 11, 2016 at 3:04 AM, Junio C Hamano
> wrote:
>> But
Since many people always run the command with this option, it would be
preferrable to specify it in the configuration file instead of passing
the option with `git commit` again and again.
Signed-off-by: Pranit Bauva
---
Documentation/config.txt | 4
Documentation/git-commit.txt | 3
version are :
- put the code in git_commit_config() instead of git_status_config()
- Add test to cover all possible scenarios
Regards,
Pranit Bauva
IIT Kharagpur
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majo
> + if (!strcmp(k, "commit.verbose")){
> v3 did this line correctly but you somehow lost the SP between
> "){". What happened?
I will include the SP between )) and { .
> Don't you need a test that status is not broken when the variable is
> set?
I will include the test for status too. But
This extra test was introducted in the commit f9c01817
Signed-off-by: Pranit Bauva
---
t/t7502-commit.sh | 5 -
1 file changed, 5 deletions(-)
diff --git a/t/t7502-commit.sh b/t/t7502-commit.sh
index b39e313..725687d 100755
--- a/t/t7502-commit.sh
+++ b/t/t7502-commit.sh
@@ -527,11 +527,6
On Fri, Mar 11, 2016 at 4:51 AM, Eric Sunshine wrote:
>> t/t7502-commit.sh : remove a repeated test
>
> Or:
>
> t7502: drop duplicate test
>
Sure!
>> This extra test was introducted in the commit f9c01817
>
> We normally add some parenthetical context when mentioning commits:
>
> This ex
On Fri, Mar 11, 2016 at 4:31 AM, Eric Sunshine wrote:
> Add commit.verbose configuration variable as a convenience
> for those who always prefer --verbose.
>
> or something.
Sure!
> As a convenience to reviewers, please use this area below the "---"
> line to provide links and explain w
301 - 400 of 603 matches
Mail list logo
