but I was unable to
find appearances of "COMMIT_EDITMSG". If COMMIT_EDITMSG was coming
into picture, the commit.verbose could not affect it. And that is not
the case.
I guess this would be a desirable trait for most of the consumers of
commit.verbose (like Ævar) so there would not be a nee
On Sat, May 7, 2016 at 3:45 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> A very interesting fact to note:
>> I made a mistake by dropping of the first argument 'term' in the function
>> one_of() and compiled and the test suite passed fully (which was
On Sun, May 8, 2016 at 7:55 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> I completely missed your point and you want me to go the Eric Sunshine's way?
>
> I am neutral.
>
> When I read your response to Eric's "top down" suggestion, I didn&#
On Sun, May 8, 2016 at 12:34 PM, Johannes Schindelin
wrote:
> Hi Pranit,
>
> On Fri, 6 May 2016, Pranit Bauva wrote:
>
>> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
>> index 3324229..d8de651 100644
>> --- a/builtin/bisect--helper.c
>
My public git.git is available here[1]. I regularly keep pushing my work so
anyone interested can track me there. Feel free to participate in the
discussions going on PRs with my mentors. Your comments are valuable.
The things I was able to do:
* Finish off with my micro project[2] about adding
On Sun, May 8, 2016 at 11:53 AM, Pranit Bauva wrote:
> On Sun, May 8, 2016 at 7:55 AM, Junio C Hamano wrote:
>> Pranit Bauva writes:
>>
>>> I completely missed your point and you want me to go the Eric Sunshine's
>>> way?
>>
>> I am neutral.
&
On Sun, May 8, 2016 at 9:00 PM, Christian Couder
wrote:
> On Sun, May 8, 2016 at 9:17 AM, Pranit Bauva wrote:
>> On Sun, May 8, 2016 at 12:34 PM, Johannes Schindelin
>> wrote:
>>> Hi Pranit,
>>>
>>> On Fri, 6 May 2016, Pranit Bauva wrote:
>>>
&
Hey Johannes,
On Mon, May 9, 2016 at 8:29 PM, Johannes Schindelin
wrote:
> Hi Pranit,
>
> On Sun, 8 May 2016, Pranit Bauva wrote:
>
>> On Sun, May 8, 2016 at 12:34 PM, Johannes Schindelin
>> wrote:
>> >
>> > On Fri, 6 May 2016, Pranit Bauva wro
xpect.)
>
> "git commit" learned to pay attention to "commit.verbose"
> configuration variable and act as if "--verbose" option was
> given from the command line.
>
> Almost there.
> ($gmane/293663).
I like the change you have made so you could s
rsion-control.git/293785
Pranit Bauva (3):
bisect--helper: use OPT_CMDMODE instead of OPT_BOOL
bisect: rewrite `check_term_format` shell function in C
bisect--helper: `write_terms` shell function in C
builtin/bisect--helper.c | 97 +---
git-bise
for write_terms().
Helped-by: Johannes Schindelein
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 59 +++-
git-bisect.sh| 31 ++---
2 files changed
d-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index 3324229..8111c91 100644
--- a/builtin/bisect
` subcommand is a temporary measure to port shell
function to C so as to use the existing test suite. As more functions
are ported, this subcommand will be retired and will be called by some
other method.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
On Thu, May 12, 2016 at 12:20 PM, Fox in the shell
wrote:
>
> Hi,
>
> Here is a second attempt at this patch.
> Sorry for the delay, life somewhat got in the way.
>
Its okay! We understand that things might take a little more time than expected!
> --
> Clarify which commits need to be signed.
>
On Thu, May 12, 2016 at 1:34 PM, Pranit Bauva wrote:
> On Thu, May 12, 2016 at 12:20 PM, Fox in the shell
> wrote:
>>
>> Hi,
>>
>> Here is a second attempt at this patch.
>> Sorry for the delay, life somewhat got in the way.
>>
>
> Its okay! We
On Thu, May 12, 2016 at 10:08 PM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> Seems like Junio was waiting for someone to point this out[2].
>
> Thanks. I think you covered most of them correctly; I only have one
> thing to add.
>
>> * Comments are pu
t merge A
$ git checkout B
$ git rebase master
This shows that some merge conflicts needs resolving. Did I follow
your steps or I missed something? It would be better if you could
reproduce your steps like I did so as to make things more clear to us.
Regards,
Pranit Bauva
--
To unsub
uot;Add one
line" and the commit on the B branch "Add one line too" are doing the
same thing which is removing the line "hello" and adding the line
"world". Then it applies the commit "modify one line" on top of this
which removes the line "world" and adds the line "git". So finally,
README.md will contain only "git".
Regards,
Pranit Bauva
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, May 13, 2016 at 4:06 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> + /*
>> + * In theory, nothing prevents swapping completely good and bad,
>> + * but this situation could be confusing and hasn't been tested
>>
always did warn me.
> Thanks.
I will recommend you reading this article[1]. I know its a bit of a
long read but it will help a lot.
[1]: http://tedfelix.com/software/git-conflict-resolution.html
Regards,
Pranit Bauva
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
This is not an improvement in the test coverage but it helps in making
it explicit as to know what exactly is the error as other tests are
focussed on testing other things but they do indirectly test for this.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
subcommand will be retired and will be called by some
other method.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
This can be applied on the pb/bisect branch
builtin/bisect--helper.c | 22 +-
git-bisect.sh| 7
Reimplement the `bisect_voc` shell function in C. This is a too small
function to be called as a subcommand though the working of this
function has been tested by calling it as a subcommand.
Mentored-by: Lars Schneider
Mentored-by: Pranit Bauva
Signed-off-by: Pranit Bauva
---
The PR for
On Sat, May 14, 2016 at 1:32 AM, Pranit Bauva wrote:
> Reimplement the `bisect_voc` shell function in C. This is a too small
> function to be called as a subcommand though the working of this
> function has been tested by calling it as a subcommand.
>
> Mentored-by: Lars Schneider
ect: rewrite `check_term_format` shell function in C
> - bisect--helper: use OPT_CMDMODE instead of OPT_BOOL
>
> Beginning of GSoC "git bisect" project.
Regards,
Pranit Bauva
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord.
ttp://thread.gmane.org/gmane.comp.version-control.git/294520
[6]: https://github.com/pranitbauva1997/git/pull/8
PS: Thanks to Andrew Ardill on providing his comments
of how to improve the format of this update email. I have tried to make it
as exhaustive as possible.
Regards,
Pranit Bauva
--
To un
Hey Junio,
On Mon, May 16, 2016 at 12:41 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>>is available for testing on the pu branch. I am encouraging people to
>>test it and provide useful comments.
>
> Do not encourage people to "TEST". In genera
Hey Eric,
Sorry for the late reply. I was on vacation.
On Mon, May 16, 2016 at 6:05 AM, Eric Sunshine wrote:
> On Sun, May 8, 2016 at 9:34 AM, Pranit Bauva wrote:
>> On Sun, May 8, 2016 at 11:53 AM, Pranit Bauva wrote:
>>> On Sun, May 8, 2016 at 7:55 AM, Junio C Hamano
Hey Eric,
On Mon, May 16, 2016 at 12:37 PM, Eric Sunshine wrote:
> On Thu, May 12, 2016 at 1:32 AM, Pranit Bauva wrote:
>> `--next-all` is meant to be used as a subcommand to support multiple
>> "operation mode" though the current implementation does not contain any
Hey Johannes,
On Mon, May 16, 2016 at 12:10 PM, Johannes Schindelin
wrote:
> Hi Pranit,
>
> On Sat, 14 May 2016, Pranit Bauva wrote:
>
>> Reimplement the `bisect_voc` shell function in C. This is a too small
>> function to be called as a subcommand though the working of t
Hey Eric,
On Mon, May 16, 2016 at 1:06 PM, Eric Sunshine wrote:
> On Fri, May 13, 2016 at 4:02 PM, Pranit Bauva wrote:
>> bisect--helper: `bisect_log` shell function in C
>
> Do you need to insert "rewrite" or "reimplement" in the subject?
>
>> Reim
Hey Eric,
On Mon, May 16, 2016 at 12:58 PM, Eric Sunshine wrote:
> On Thu, May 12, 2016 at 1:32 AM, Pranit Bauva wrote:
>> Reimplement the `write_terms` shell function in C and add a `write-terms`
>> subcommand to `git bisect--helper` to call it from git-bisect.sh . Als
Hey Johannes,
On Mon, May 16, 2016 at 6:46 PM, Johannes Schindelin
wrote:
> Hi,
>
> On Mon, 16 May 2016, Eric Sunshine wrote:
>
>> On Thu, May 12, 2016 at 1:32 AM, Pranit Bauva wrote:
>>
>> > + fp = fopen(".git/BISECT_TERMS", "w"
TABLE_BRANCH"
> + git fetch --unshallow --quiet
> + LAST_GOOD_REV=$(git merge-base $BAD_REV
> "remotes/origin/$STABLE_BRANCH")
> +
> + for TEST_EXIT in t/test-results/*.exit
> + do
> + if test "$(cat "$TEST_EXIT")" != "0&quo
Hey Matthieu,
Sorry for the late reply. Somehow your email didn't receive my
mailbox. I got to see this mail when I was going through the gmane
archives.
Matthieu Moy grenoble-inp.fr> writes:
Pranit Bauva gmail.com> writes:
>> +int bisect_voc(const char *term)
>> +
INTRODUCTION ==
The purpose of this project is to convert the git-bisect utility which
partly exists in the form of shell scripts to C code so as to make it more
portable. I plan to do this by converting each function to C and then
calling it
Hey Johannes,
On Mon, May 23, 2016 at 4:37 PM, Johannes Schindelin
wrote:
> Hi Pranit,
>
> On Fri, 20 May 2016, Pranit Bauva wrote:
>
>> Frankly, I have no idea what you mean by libification but I will use
>> error() since efforts for libification have already started.
&g
d-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index 3324229..8111c91 100644
--- a/builtin/bisect
* Previously ".git/" was hardcoded. Now it uses GIT_PATH_FUNC
* Use error() instead of die.
[1]: http://thread.gmane.org/gmane.comp.version-control.git/294388
Pranit Bauva (3):
bisect--helper: use OPT_CMDMODE instead of OPT_BOOL
bisect: rewrite `check_term_format` shell function in
` subcommand is a temporary measure to port shell
function to C so as to use the existing test suite. As more functions
are ported, this subcommand will be retired and will be called by some
other method.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
for write_terms().
Helped-by: Johannes Schindelein
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 59 +++-
git-bisect.sh| 31 ++---
2 files changed
On Mon, May 23, 2016 at 9:31 PM, Eric Sunshine wrote:
> On Mon, May 23, 2016 at 10:48 AM, Pranit Bauva wrote:
>> Reimplement the `write_terms` shell function in C and add a `write-terms`
>> subcommand to `git bisect--helper` to call it from git-bisect.sh . Also
>> remove th
d-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/commit.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/builtin/commit.c b/builtin/commit.c
index 391126e..ffa242c 100644
--- a/builtin/commit.c
+++ b/builtin/commit.
Hey Junio,
On Tue, May 24, 2016 at 12:46 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> This is a follow up commit for f932729c (memoize common git-path
>> "constant" files, 10-Aug-2015).
>>
>> It serves two purposes:
>> 1. It reduces the
Hey Junio
On Tue, May 24, 2016 at 11:24 AM, Pranit Bauva wrote:
>> And you do not free its return value.
> This is one of the thing that bugging me with GIT_PATH_FUNC. Wouldn't
> not freeing the memory lead to memory leaks?
Slight misunderstanding. I got it now. Thanks!
&g
for write_terms().
Helped-by: Johannes Schindelein
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 59 +++-
git-bisect.sh| 31 ++---
2 files changed
Here is the link to v7[1]. This has a few modifications.
Changes wrt v7 as suggested by Eric are:
* Include the name of the file in the error message which couldn't be opened.
* Use error_errno() with which we can make the error message more valuable.
Pranit Bauva (3):
bisect--helper
d-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index 3324229..8111c91 100644
--- a/builtin/bisect
by some
other method.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 36 +---
git-bisect.sh| 22 +++---
2 files changed, 36 insertions(+), 22 deletions(-)
diff --git
Hey Matthieu,
On Tue, May 24, 2016 at 1:41 PM, Matthieu Moy
wrote:
> Junio C Hamano writes:
>
>> Pranit Bauva writes:
>>
>>> static const char *use_message_buffer;
>>> -static const char commit_editmsg[] = "COMMIT_EDITMSG&quo
Hey Christian,
On Tue, May 24, 2016 at 1:03 PM, Christian Couder
wrote:
> On Tue, May 24, 2016 at 9:21 AM, Pranit Bauva wrote:
>> diff --git a/git-bisect.sh b/git-bisect.sh
>> index 7d7965d..cd39bd0 100755
>> --- a/git-bisect.sh
>> +++ b/git-bisect.sh
>>
Here is the link to v8[1]. This has a few modifications.
Changes wrt v8 as suggested by Christian are:
* Remove the redundant `|| exit`
Pranit Bauva (3):
bisect--helper: use OPT_CMDMODE instead of OPT_BOOL
bisect: rewrite `check_term_format` shell function in C
bisect--helper
for write_terms().
Helped-by: Johannes Schindelein
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 59 +++-
git-bisect.sh| 31 ++---
2 files changed
d-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index 3324229..8111c91 100644
--- a/builtin/bisect
by some
other method.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 36 +---
git-bisect.sh| 22 +++---
2 files changed, 36 insertions(+), 22 deletions(-)
diff --git
d-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
Link for v1[1].
Changes wrt v1:
* Remove the call to git_path_commit_editmsg() which would directly assign
the value to the string.
* Remove the string commit_editmsg[] as it is redundant now.
* Call git
Hey Johannes,
On Wed, May 25, 2016 at 10:34 AM, Johannes Schindelin
wrote:
> Hi Pranit,
>
> I think this patch series is now in a fine shape. Just one minor nit:
Thanks!
> On Tue, 24 May 2016, Pranit Bauva wrote:
>
>> + OPT_CMDMODE(0, "ch
don't use test_config like in the
>> first test?
>
> None, actually. It was just that I forgot to use test_config while
> writing the tests. I will make changes accordingly as test_config
> automatically unset the config variable, which is necessary.
Or you could probably
On Fri, May 13, 2016 at 3:44 PM, Pranit Bauva wrote:
> This is not an improvement in the test coverage but it helps in making
> it explicit as to know what exactly is the error as other tests are
> focussed on testing other things but they do indirectly test for this.
>
> Me
Hey Christian,
On Sat, May 28, 2016 at 12:30 AM, Christian Couder
wrote:
> On Fri, May 27, 2016 at 7:57 PM, Pranit Bauva wrote:
>>
>> Anyone any comments?
>
> Maybe you could add this patch to, or squash it into, the patch that
> convert bisect_clean_state to C.
Sure
as a subcommand.
* Convert bisect_reset() and add it as a subcommand.
* Convert get_terms() and add the variables TERM_GOOD and TERM_BAD in a struct
in the global state.
Regards,
Pranit Bauva
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a me
On Mon, May 30, 2016 at 11:07 AM, Pranit Bauva wrote:
> = SUMMARY ==
> My public git.git is available here[1]. I regularly keep pushing my work so
> anyone interested can track me there. Feel free to participate in the
>
, this subcommand will be retired and will be called by
bisect_reset() and bisect_start().
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
This patch contains a bug. I have tried to identify the bug and I suppose it
exists in do_for_each_entry_in_dir(). I
Hey Christian,
On Tue, May 31, 2016 at 3:18 AM, Christian Couder
wrote:
> On Mon, May 30, 2016 at 8:21 PM, Pranit Bauva wrote:
>> ---
>> This patch contains a bug. I have tried to identify the bug and I suppose it
>> exists in do_for_each_entry_in_dir(). I have reproduced
Hey Michael,
On Tue, May 31, 2016 at 9:55 AM, Michael Haggerty wrote:
> On 05/30/2016 08:21 PM, Pranit Bauva wrote:
>> Reimplement `bisect_clean_state` shell function in C and add a
>> `bisect-clean-state` subcommand to `git bisect--helper` to call it from
>> git-bi
://github.com/pranitbauva1997/git/pull/10
[5]: http://thread.gmane.org/gmane.comp.version-control.git/295524
[6]: https://github.com/pranitbauva1997/git/pull/11
Regards,
Pranit Bauva
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kerne
On Wed, May 25, 2016 at 12:49 AM, Pranit Bauva wrote:
> This is a follow up commit for f932729c (memoize common git-path
> "constant" files, 10-Aug-2015).
>
> The many function calls to git_path() are replaced by
> git_path_commit_editmsg() and which thus eliminat
, this subcommand will be retired and will be called by
bisect_reset() and bisect_start().
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 49 +++-
git-bisect.sh| 26
This is not an improvement in the test coverage but it helps in making
it explicit as to what exactly would be the error as other tests are
focussed on testing other things.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
I faced this problem while
At times we require to see if the file is empty and get the size of the
file. By using stat we can get the file size without actually having to
open the file to check for its contents.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
dir.c | 8
subcommand would be retired and will be called by some
other method.
Note: --bisect-clean-state subcommand has not been retired as there are
still a function namely `bisect_start()` which still uses this
subcommand.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit
Hey Eric,
On Wed, Jun 8, 2016 at 4:01 AM, Eric Sunshine wrote:
> On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote:
>> Reimplement `bisect_clean_state` shell function in C and add a
>> `bisect-clean-state` subcommand to `git bisect--helper` to call it from
>> git-bisect.sh
Hey Eric,
On Wed, Jun 8, 2016 at 1:07 PM, Eric Sunshine wrote:
> On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote:
>> dir: introduce file_size() to check the size of file
>>
>> At times we require to see if the file is empty and get the size of the
>> file. By usi
Hey Eric,
On Wed, Jun 8, 2016 at 4:51 AM, Eric Sunshine wrote:
> On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote:
>> This is not an improvement in the test coverage but it helps in making
>> it explicit as to what exactly would be the error as other tests are
>> focu
Hey Eric,
On Wed, Jun 8, 2016 at 1:32 PM, Eric Sunshine wrote:
> On Wed, Jun 8, 2016 at 3:46 AM, Pranit Bauva wrote:
>> On Wed, Jun 8, 2016 at 4:01 AM, Eric Sunshine
>> wrote:
>>> On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote:
>>>> +
Hey Eric,
On Wed, Jun 8, 2016 at 1:47 PM, Eric Sunshine wrote:
> On Wed, Jun 8, 2016 at 4:07 AM, Pranit Bauva wrote:
>> On Wed, Jun 8, 2016 at 4:51 AM, Eric Sunshine
>> wrote:
>>> On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote:
>>>> diff --git a/t
t;)" ;;
>> + die "Please call 'bisect_state' with at least one argument." ;;
>
> OK. This should have had "bug:" prefix from the beginning, but that
> is outside the topic.
I can probably include this with the rewrite of git-bisect.sh .
Regards,
Pranit Bauva
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hey Torsten,
On Wed, Jun 8, 2016 at 1:47 PM, Torsten Bögershausen wrote:
> On 06/08/2016 09:57 AM, Pranit Bauva wrote:
>>
>> Hey Eric,
>>
>> On Wed, Jun 8, 2016 at 1:07 PM, Eric Sunshine
>> wrote:
>>>
>>> On Tue, Jun 7, 2016 at 4:54 PM
Hey Eric,
On Wed, Jun 8, 2016 at 1:29 PM, Eric Sunshine wrote:
> On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote:
>> Reimplement `bisect_reset` shell function in C and add a `--bisect-reset`
>> subcommand to `git bisect--helper` to call it from git-bisect.sh .
>>
&
7;s C implementation, we can safely delete the
shell implementation.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 21 -
git-bisect.sh| 20 ++--
2 files changed, 22 insertions(+), 19 dele
Reimplement `is_expected_rev` shell function in C. This will further be
called from `check_expected_revs` function. This is a quite small
function thus subcommand facility is redundant.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
This applies on
Hey Eric,
On Wed, Jun 8, 2016 at 11:23 PM, Eric Sunshine wrote:
> On Wed, Jun 8, 2016 at 9:20 AM, Pranit Bauva wrote:
>> On Wed, Jun 8, 2016 at 1:29 PM, Eric Sunshine
>> wrote:
>>> On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote:
>>>> + i
Hey Eric,
On Wed, Jun 8, 2016 at 11:29 PM, Eric Sunshine wrote:
> On Wed, Jun 8, 2016 at 5:41 AM, Christian Couder
> wrote:
>> On Wed, Jun 8, 2016 at 10:02 AM, Eric Sunshine
>> wrote:
>>> On Wed, Jun 8, 2016 at 3:46 AM, Pranit Bauva wrote:
>>>> On Wed
Hey Jeff,
On Thu, Jun 9, 2016 at 12:28 PM, Jeff King wrote:
> On Tue, Jun 07, 2016 at 08:25:17PM +0530, Pranit Bauva wrote:
>
>> On Wed, May 25, 2016 at 12:49 AM, Pranit Bauva
>> wrote:
>> > This is a follow up commit for f932729c (memoize common git-path
>>
Hey Eric,
On Fri, Jun 10, 2016 at 3:24 AM, Eric Sunshine wrote:
> On Wed, Jun 8, 2016 at 11:24 AM, Pranit Bauva wrote:
>> Reimplement the `check_expected_revs` shell function in C and add a
>> `--check-expected-revs` subcommand to `git bisect--helper` to call it
>&g
Hey Eric,
On Fri, Jun 10, 2016 at 3:03 AM, Eric Sunshine wrote:
> On Wed, Jun 8, 2016 at 11:24 AM, Pranit Bauva wrote:
>> Reimplement `is_expected_rev` shell function in C. This will further be
>> called from `check_expected_revs` function. This is a quite small
>> fun
ators take care of everything else.
Thanks for your contribution.
Regards,
Pranit Bauva
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hey Eric,
On Sat, Jun 11, 2016 at 12:44 AM, Eric Sunshine wrote:
> On Fri, Jun 10, 2016 at 9:39 AM, Pranit Bauva wrote:
>> On Fri, Jun 10, 2016 at 3:03 AM, Eric Sunshine
>> wrote:
>>> On Wed, Jun 8, 2016 at 11:24 AM, Pranit Bauva
>>> wrote:
>>>>
filename, &st) < 0)
> + return 0;
> + return xsize_t(st.st_size);
> +}
>
> Or, more git-ish:
>
> size_t file_size(const char *filename)
> +{
> + struct stat st;
> + if (stat(filename, &st))
> + return 0;
> +
ill set the property 'svn:keywords' to 'FreeBSD=%H' for the file
> +'devel/py-tipper/Makefile'.
> +
> 'show-externals'::
> Shows the Subversion externals. Use -r/--revision to specify a
> specific revision.
Regards,
Pranit Bauva
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
]: http://thread.gmane.org/gmane.comp.version-control.git/295524
Regards,
Pranit Bauva
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Alfred Perlstein
Though I will still recommend you to go through [1] properly.
Regards,
Pranit Bauva
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hey Alfred,
On Mon, Jun 13, 2016 at 7:54 PM, Pranit Bauva wrote:
> Hey Alfred,
>
> On Mon, Jun 13, 2016 at 6:22 PM, Alfred Perlstein wrote:
>> Thank you Pranit. I thought that "signed off by" is used once someone
>> approved my patch as opposed to when it'
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
It is easy to be misguided on the return value of the function
strbuf_read_file(). It does follow the pattern of other standard functions
for reading files but its better to explicitly specify it
> Good thing to do; I wonder if we want to explicitly say -1 or
> leave it at "negative values are errors", though (my knee-jerk
> reaction being "do not over-specify more than absolute minimum
> to write callers correctly").
Sure I will re-roll with specifying ab
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
strbuf.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/strbuf.h b/strbuf.h
index 7987405..83c5c98 100644
--- a/strbuf.h
+++ b/strbuf.h
@@ -377,6 +377,8 @@ extern ssize_t strbuf_read_once(struct
make the method use the two variables from the global scope
within the C code.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 61 +++-
git-bisect.sh| 25
this series I have tried to output error wherever
possible. What are your views?
[1]: http://thread.gmane.org/gmane.comp.version-control.git/296717
Pranit Bauva (6):
bisect--helper: `bisect_clean_state` shell function in C
t6030: explicitly test for bisection cleanup
wrapper: move is_empty_file
ppropriate boolean value is returned.
Suggested-by: Torsten Bögershausen
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/am.c | 16
cache.h | 3 +++
wrapper.c| 13 +
3 files changed, 16 insertions(+), 16
This is not an improvement in the test coverage but it helps in making
it explicit as to what exactly would be the error as other tests are
focussed on testing other things.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
I faced this problem while
201 - 300 of 603 matches
Mail list logo
