[PATCH/RFC] launch_editor: ignore SIGINT while the editor has control

the user's editor likely catches SIGINT (ctrl-C). but if the user spawns a command from the editor and uses ctrl-C to kill that command, the SIGINT will likely also kill git itself. (depending on the editor, this can leave the terminal in an unusable state.) Signed-off-by: Paul Fox -

Re: [PATCH/RFC] launch_editor: ignore SIGINT while the editor has control

the user's editor likely catches SIGINT (ctrl-C). but if the user spawns a command from the editor and uses ctrl-C to kill that command, the SIGINT will likely also kill git itself. (depending on the editor, this can leave the terminal in an unusable state.) Signed-off-by: Pau

Re: What's cooking in git.git (Nov 2012, #02; Fri, 9)

it behavior is bad for non-emacs users, and git itself provides an abort-the-operation mechanism (i.e., writing an empty message), so i'm not convinced your use case invalidates the new behavior. (though it might spotlight a need for this being prominent in release notes.) paul =-

Re: What's cooking in git.git (Nov 2012, #02; Fri, 9)

kalle olavi niemitalo wrote: > Paul Fox writes: > > > when i implemented the change, i wondered if some twisted emacs > > workflow would be an issue. ;-) and i almost blocked SIGQUIT as > > well -- the two programs i looked at for precedent (CVS and MH) both &g

[PATCH 2/5] launch_editor: ignore SIGINT while the editor has control

The user's editor likely catches SIGINT (ctrl-C). but if the user spawns a command from the editor and uses ctrl-C to kill that command, the SIGINT will likely also kill git itself (depending on the editor, this can leave the terminal in an unusable state). Signed-off-by: Paul Fox Signed-o

Re: [PATCH 0/5] ignore SIGINT while editor runs

; -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html =- paul fox, p...@foxharp.boston.ma.us (arlington, ma, w

Re: [PATCH 0/5] ignore SIGINT while editor runs

6.) paul > > Krzysiek > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html =- paul fox, p...@foxharp.bo

Re: What's cooking in git.git (Nov 2012, #06; Mon, 19)

Expecting a re-roll. i don't have strong feelings on any of the later review comments (though i guess the check on finish_command()'s return code needed attention), and wasn't the last submitter, but would certainly like to see this move forward. paul =- pau

Re: Topics currently in the Stalled category

ould prefer, i can probably finish it. (but i won't guarantee not to mess up the "From:" lines. :-) paul =- paul fox, p...@foxharp.boston.ma.us (arlington, ma, where it's 36.0 degrees) -- To unsubscribe from this list: send the line "unsubscr

Re: Topics currently in the Stalled category

GQUIT, essentially translating the SIGQUIT to SIGTERM for the editor. (please correct me if i misunderstood.) since well-behaved editors will die quickly anyway (they get EIO on their next read from stdin), i'm not sure there's a compelling reason for that extra step. but i have no

Re: [PATCH 0/5] ignore SIG{INT,QUIT} when launching editor

> So I do not think we care about this behavior except for launching the > editor. And the signal-propagation behavior of 5/5 is really so weirdly > editor-specific (because it is about behaving well whether the child > blocks signals or not). > > -Peff =-