Re: send-email and in-reply-to = n

2012-08-14 Thread Martin von Zweigbergk
On Mon, Aug 13, 2012 at 4:53 PM, Junio C Hamano wrote: > Stephen Boyd writes: > >> Can we throw up a big warning or just outright fail if someone types >> 'n' or 'y' and hits enter for the in-reply-to question in >> git-send-email? I saw a git-send-email sent patch with an In-Reply-To >> header c

Re: [PATCH] send-email: validate & reconfirm interactive responses

2012-08-14 Thread Martin von Zweigbergk
On Tue, Aug 14, 2012 at 3:25 PM, Junio C Hamano wrote: > People answer 'y' to "Who should the emails appear to be from?" and > 'n' to "Message-ID to be used as In-Reply-To for the first email?" > for some unknown reason. Yeah, I know :-(. I did feel stupid already. Thanks for improving. -- To un

Re: [PATCH 2/4] revisions passed to cherry-pick should be in "default" order

2012-08-14 Thread Martin von Zweigbergk
On Mon, Aug 13, 2012 at 2:05 PM, Junio C Hamano wrote: > Martin von Zweigbergk writes: > >> To connect to the other mail I sent on this thread (in parallel with >> yours), do you think "git cherrry-pick HEAD HEAD~1" should apply the >> commits in the same orde

Re: [PATCH 2/4] revisions passed to cherry-pick should be in "default" order

2012-08-15 Thread Martin von Zweigbergk
On Wed, Aug 15, 2012 at 10:16 AM, Junio C Hamano wrote: > Martin von Zweigbergk writes: > >> So all of the above case give the right result in the end as long >> as the timestamps are chronological, and case 1) gives the right >> result regardless. The other two cases

Re: [PATCH 2/4] revisions passed to cherry-pick should be in "default" order

2012-08-15 Thread Martin von Zweigbergk
On Wed, Aug 15, 2012 at 11:39 AM, Junio C Hamano wrote: > Martin von Zweigbergk writes: > >> Makes sense, I'll try to implement it that way. I was afraid that >> we would need to call prepare_revision_walk() once first and then >> if we afterwards find out that we s

Re: [PATCH v2] rev-list docs: clarify --topo-order description

2012-08-15 Thread Martin von Zweigbergk
On Wed, Aug 15, 2012 at 1:02 PM, Junio C Hamano wrote: > diff --git a/Documentation/rev-list-options.txt > b/Documentation/rev-list-options.txt > index 6a4b635..9404d08 100644 > --- a/Documentation/rev-list-options.txt > +++ b/Documentation/rev-list-options.txt > @@ -578,16 +578,33 @@ Commit Orde

Re: [RFC] git rm -u

2013-01-20 Thread Martin von Zweigbergk
On Sun, Jan 20, 2013 at 1:27 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Matthieu Moy writes: >> >>> "git add -u" is one of the only exceptions (with "git grep"). I consider >>> this as a bug, and think this should be changed. This has been discussed >>> several times here, but no on

Re: [PATCH v3 08/31] parse_pathspec: add PATHSPEC_EMPTY_MATCH_ALL

2013-01-21 Thread Martin von Zweigbergk
Hi, I was tempted to ask this before, and the recent thread regarding "add -u/A" [1] convinced me to. On Sun, Jan 13, 2013 at 4:35 AM, Nguyễn Thái Ngọc Duy wrote: > We have two ways of dealing with empty pathspec: > > 1. limit it to current prefix > 2. match the entire working directory > > Some

Re: [PATCH 1/3] git-am: record full index line in the patch used while rebasing

2013-01-31 Thread Martin von Zweigbergk
On Thu, Jan 31, 2013 at 8:32 PM, Junio C Hamano wrote: > Earlier, a230949 (am --rebasing: get patch body from commit, not > from mailbox, 2012-06-26) learned to regenerate patch body from the > commit object while rebasing, instead of reading from the rebase-am > front-end. While doing so, it use

Re: [PATCH] rebase --preserve-merges keeps empty merge commits

2013-02-01 Thread Martin von Zweigbergk
I'm working on a re-roll of http://thread.gmane.org/gmane.comp.version-control.git/205796 and finally got around to including test cases for what you fixed in this patch. I want to make sure I'm testing what you fixed here. See questions below. On Sat, Jan 12, 2013 at 12:46 PM, Phil Hord wrote:

Re: [PATCH] rebase --preserve-merges keeps empty merge commits

2013-02-02 Thread Martin von Zweigbergk
On Fri, Feb 1, 2013 at 1:05 PM, Phil Hord wrote: > > This is probably right, but it is not exactly the case that caused my itch. > I think my branch looked like [...] That also makes sense. I'll add tests for both cases. Your patch makes both of them pass. >> # a---b---c >> # \ \ >> #

Re: `git checkout --orpan` leaves a dirty worktree

2013-02-08 Thread Martin von Zweigbergk
I'm curious what your use case is. The behavior has been inconvenient for me too, but I have only used it in test cases; I have no real use case where I wanted to create an unborn/orphan branch. On Fri, Feb 8, 2013 at 11:50 AM, Ramkumar Ramachandra wrote: > Hi, > > Why should I have to `git rm -

<    1   2   3