Re: [PATCH v2] completion: Add '--edit-todo' to rebase

2015-07-30 Thread John Keeping
On Thu, Jul 30, 2015 at 01:24:03PM +0200, SZEDER Gábor wrote: > > Quoting Thomas Braun : > > > Signed-off-by: Thomas Braun > > --- > >> John Keeping hat am 13. Juli 2015 um 15:11 > >> geschrieben: > >> git-rebase.sh contains: > >&g

Re: Merging after directory got turned into submodule

2015-08-11 Thread John Keeping
On Tue, Aug 11, 2015 at 03:02:41PM +0200, Martin von Gagern wrote: > I've noticed that if I turn a subdirectory into a submodule, I'm having > severe trouble merging branches from before that change, even if they > don't modify that subdirectory at all. > > I've posted this problem on Stack Overfl

Re: git-remote-helper behavior on Windows, not recognizing blank line as terminator

2015-08-24 Thread John Keeping
On Sun, Aug 23, 2015 at 11:40:17AM -0700, Anish Athalye wrote: > I'm having some issues with git remote helper behavior on Windows. > > According to the protocol > (https://www.kernel.org/pub/software/scm/git/docs/gitremote-helpers.html), > when doing things like listing capabilities, git expects

Re: index file list files not found in working tree

2015-08-25 Thread John Keeping
On Tue, Aug 25, 2015 at 12:16:43PM +0200, Rafik E Younan wrote: > I got a recommendation to use reset --hard. I tried it and it says the > HEAD is now at correct commit, but missing files are not restored! > > I tried `ls-tree --name-only` and it lists missing files and folders, > but the actual

[RFC/PATCH] date: allow any format to display local time

2015-08-30 Thread John Keeping
Make DATE_LOCAL a bit flag that may be combined with the other formats. In order to keep date_mode_type as a true enumeration the possible combinations are included explicitly (except "relative local time" which is nonsensical). Signed-off-by: John Keeping --- I primarily want this to

Re: [RFC/PATCH] date: allow any format to display local time

2015-08-31 Thread John Keeping
On Mon, Aug 31, 2015 at 02:50:18PM -0400, Jeff King wrote: > On Mon, Aug 31, 2015 at 10:28:24AM -0700, Junio C Hamano wrote: > > I am unhappy with the change to blame.c, and that is not because I > > do not want "blame" to be touched. > > > > The fact that this change has to touch it indicates tha

Re: [PATCH 2/2] date: make "local" orthogonal to date format

2015-08-31 Thread John Keeping
On Mon, Aug 31, 2015 at 04:48:32PM -0400, Jeff King wrote: > Most of our "--date" modes are about the format of the date: > which items we show and in what order. But "--date=local" is > a bit of an oddball. It means "show the date in the normal > format, but using the local timezone". The timezone

Re: [PATCH 2/2] date: make "local" orthogonal to date format

2015-09-01 Thread John Keeping
On Mon, Aug 31, 2015 at 06:05:09PM -0400, Jeff King wrote: > On Mon, Aug 31, 2015 at 05:33:37PM -0400, Jeff King wrote: > > > > diff --git a/date.c b/date.c > > > index aa57cad..3aa8002 100644 > > > --- a/date.c > > > +++ b/date.c > > > @@ -817,9 +817,7 @@ void parse_date_format(const char *format

[PATCH v2 0/6] Make "local" orthogonal to date format

2015-09-01 Thread John Keeping
King (2): fast-import: switch crash-report date to iso8601 date: make "local" orthogonal to date format John Keeping (4): t6300: introduce test_date() helper t6300: make UTC and local dates different t6300: add test for "raw" date format t6300: add tests for

[PATCH v2 1/6] fast-import: switch crash-report date to iso8601

2015-09-01 Thread John Keeping
ss likely to be of interest. Signed-off-by: Jeff King Signed-off-by: John Keeping --- fast-import.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fast-import.c b/fast-import.c index 6c7c3c9..adcbfc6 100644 --- a/fast-import.c +++ b/fast-import.c @@ -424,7 +424,7

[PATCH v2 2/6] date: make "local" orthogonal to date format

2015-09-01 Thread John Keeping
new feature is accessible to users by adding "-local" to any date mode (e.g., "iso-local"), and we retain "local" as an alias for "default-local" for backwards compatibility. Signed-off-by: Jeff King Signed-off-by: John Keeping --- This is Jeff

[PATCH v2 3/6] t6300: introduce test_date() helper

2015-09-01 Thread John Keeping
This moves the setup of the "expected" file inside the test case. The helper function has the advantage that we can use SQ in the file content without needing to escape the quotes. Signed-off-by: John Keeping --- I considered moving the test_expect_success into the helper, like with

[PATCH v2 5/6] t6300: add test for "raw" date format

2015-09-01 Thread John Keeping
Signed-off-by: John Keeping --- t/t6300-for-each-ref.sh | 4 1 file changed, 4 insertions(+) diff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh index 9e0096f..2e76ca9 100755 --- a/t/t6300-for-each-ref.sh +++ b/t/t6300-for-each-ref.sh @@ -196,6 +196,10 @@ test_expect_success

[PATCH v2 4/6] t6300: make UTC and local dates different

2015-09-01 Thread John Keeping
By setting the UTC time to 23:18:43 the date in +0200 is the following day, 2006-07-04. This will ensure that the test for "short-local" to be added in a following patch tests for different output from the "short" format. Signed-off-by: John Keeping --- t/t6300-

[PATCH v2 6/6] t6300: add tests for "-local" date formats

2015-09-01 Thread John Keeping
Signed-off-by: John Keeping --- t/t6300-for-each-ref.sh | 32 1 file changed, 32 insertions(+) diff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh index 2e76ca9..c3aee70 100755 --- a/t/t6300-for-each-ref.sh +++ b/t/t6300-for-each-ref.sh @@ -170,6

Re: [PATCH v2 2/6] date: make "local" orthogonal to date format

2015-09-01 Thread John Keeping
On Tue, Sep 01, 2015 at 03:16:50PM -0700, Junio C Hamano wrote: > John Keeping writes: > > > This is Jeff's original patch with my fixup for DATE_STRFTIME squashed > > in and a new change to reject "raw-local" (in both Documentation/ and > > date.c).

Re: [PATCH v2 3/6] t6300: introduce test_date() helper

2015-09-01 Thread John Keeping
On Tue, Sep 01, 2015 at 06:31:58PM -0400, Jeff King wrote: > On Tue, Sep 01, 2015 at 10:55:41PM +0100, John Keeping wrote: > > > I considered moving the test_expect_success into the helper, like with > > test_atom earlier in the file, but it doesn't make the code much

Re: [PATCH v2 0/6] Make "local" orthogonal to date format

2015-09-02 Thread John Keeping
On Tue, Sep 01, 2015 at 06:44:31PM -0400, Jeff King wrote: > [1] I do think the error message for "relative-local is nonsense" could > perhaps be more explanatory, but I couldn't come up with any better > wording. But if you have ideas, feel free to switch it. My only suggestion would be t

Re: [PATCH v2 0/6] Make "local" orthogonal to date format

2015-09-02 Thread John Keeping
On Wed, Sep 02, 2015 at 08:16:59AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > On Wed, Sep 02, 2015 at 08:48:26AM +0100, John Keeping wrote: > > > >> On Tue, Sep 01, 2015 at 06:44:31PM -0400, Jeff King wrote: > >> > [1] I do think the error

Re: [PATCH v2 0/6] Make "local" orthogonal to date format

2015-09-02 Thread John Keeping
On Wed, Sep 02, 2015 at 01:11:35PM -0700, Junio C Hamano wrote: > John Keeping writes: > > OTOH, I don't think there's any disagreement about what "relative-local" > > and "raw-local" would output were they supported, just whether they are >

Re: [PATCH 2/2] date: make "local" orthogonal to date format

2015-09-02 Thread John Keeping
On Wed, Sep 02, 2015 at 05:30:14PM -0400, Jeff King wrote: > On Wed, Sep 02, 2015 at 10:41:34AM -0700, Junio C Hamano wrote: > > > Jeff King writes: > > > > > + /* historical alias */ > > > + if (!strcmp(format, "local")) > > > + format = "default-local"; > > > + > > > + mode->type = par

Re: [RFC PATCH] git-p4: add option to store files in Git LFS on import

2015-09-03 Thread John Keeping
On Thu, Sep 03, 2015 at 11:40:20AM +0200, Lars Schneider wrote: > > On 30 Aug 2015, at 18:36, Luke Diamand wrote: > > > On 30 August 2015 at 11:18, Lars Schneider wrote: > >> Thanks for your feedback! > >> > >> I like the “handle big files” plugin kind of idea. However, I > >> wonder if it mak

[PATCH v3 00/11] Make "local" orthogonal to date format

2015-09-03 Thread John Keeping
hat if there is no valid prefix. Jeff King (2): fast-import: switch crash-report date to iso8601 date: make "local" orthogonal to date format John Keeping (9): Documentation/blame-options: don't list date formats Documentation/config: don't list date formats Docum

[PATCH v3 01/11] Documentation/blame-options: don't list date formats

2015-09-03 Thread John Keeping
This list is already incomplete (missing "raw") and we're about to add new formats. Remove it and refer to the canonical documentation in git-log(1). Signed-off-by: John Keeping --- Documentation/blame-options.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-

[PATCH v3 02/11] Documentation/config: don't list date formats

2015-09-03 Thread John Keeping
This list is already incomplete (missing "raw") and we're about to add new formats. Since this option sets a default for git-log's --date option, just refer to git-log(1). Signed-off-by: John Keeping --- Documentation/config.txt | 4 +--- 1 file changed, 1 insertion(+),

[PATCH v3 03/11] Documentation/git-for-each-ref: don't list date formats

2015-09-03 Thread John Keeping
We are about to add a new set of supported date formats and do not want to have to maintain the same list in several different bits of documentation. Refer to git-rev-list(1) which contains the full list of supported formats. Signed-off-by: John Keeping --- Documentation/git-for-each-ref.txt

[PATCH v3 05/11] fast-import: switch crash-report date to iso8601

2015-09-03 Thread John Keeping
ss likely to be of interest. Signed-off-by: Jeff King Signed-off-by: John Keeping --- fast-import.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fast-import.c b/fast-import.c index 6c7c3c9..adcbfc6 100644 --- a/fast-import.c +++ b/fast-import.c @@ -424,7 +424,7

[PATCH v3 04/11] Documentation/rev-list: don't list date formats

2015-09-03 Thread John Keeping
We are about to add several new date formats which will make this list too long to display in a single line. Signed-off-by: John Keeping --- Documentation/git-rev-list.txt | 2 +- Documentation/rev-list-options.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH v3 07/11] t6300: add test for "raw" date format

2015-09-03 Thread John Keeping
Signed-off-by: John Keeping --- t/t6300-for-each-ref.sh | 4 1 file changed, 4 insertions(+) diff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh index 0bf709b..6afcff6 100755 --- a/t/t6300-for-each-ref.sh +++ b/t/t6300-for-each-ref.sh @@ -215,6 +215,10 @@ test_expect_success

[PATCH v3 06/11] t6300: introduce test_date() helper

2015-09-03 Thread John Keeping
This moves the setup of the "expected" file inside the test case. The helper function has the advantage that we can use SQ in the file content without needing to escape the quotes. Signed-off-by: John Keeping --- Changes since v2: - add missing "&&" after "f=$1

[PATCH v3 08/11] date: check for "local" before anything else

2015-09-03 Thread John Keeping
In a following commit we will make "local" orthogonal to the format. Although this will not apply to "relative", which does not use the timezone, it applies to all other formats so move the timezone conversion to the start of the function. Signed-off-by: John Keeping ---

[PATCH v3 09/11] date: make "local" orthogonal to date format

2015-09-03 Thread John Keeping
new feature is accessible to users by adding "-local" to any date mode (e.g., "iso-local"), and we retain "local" as an alias for "default-local" for backwards compatibility. Signed-off-by: Jeff King Signed-off-by: John Keeping --- Changes since v2: - &

[PATCH v3 11/11] t6300: add tests for "-local" date formats

2015-09-03 Thread John Keeping
Signed-off-by: John Keeping --- Changes since v2: - "relative-local" and "raw-local" are now allowed t/t6300-for-each-ref.sh | 36 1 file changed, 36 insertions(+) diff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh index 899

[PATCH v3 10/11] t6300: make UTC and local dates different

2015-09-03 Thread John Keeping
By setting the UTC time to 23:18:43 the date in +0200 is the following day, 2006-07-04. This will ensure that the test for "short-local" to be added in the following patch tests for different output from the "short" format. Signed-off-by: John Keeping --- t/t6300-

Re: determine name of tag used for checkout when multiple tags exist?

2015-09-04 Thread John Keeping
On Thu, Sep 03, 2015 at 08:53:16PM -0600, Jesse Hopkins wrote: > Looking for suggestions on how to determine the tag that was used to > checkout a git repo to its associated commit, particularly in the case > where multiple tags might point to the same commit. > > I've had a look at git-name-rev a

Re: determine name of tag used for checkout when multiple tags exist?

2015-09-04 Thread John Keeping
[It looks like your reply didn't get through to the mailing list, presumably because it contained a text/html part.] On Fri, Sep 04, 2015 at 04:22:04AM -0600, Jesse Hopkins wrote: > On Sep 4, 2015 1:54 AM, "John Keeping" wrote: > > When I checkout a tag, "git re

[RFC] test_when_finished in subshells

2015-09-04 Thread John Keeping
A recent thread [0] made me realise that using test_when_finished in a subshell is likely to be a bug, since the change to $test_cleanup will be lost when the subshell exits. There is no POSIX way to detect that we are in a subshell ($$ and $PPID are specified to remain unchanged), but we can dete

[PATCH] Makefile: fix MAKEFLAGS tests with multiple flags

2015-09-05 Thread John Keeping
findstring is defined as $(findstring FIND,IN) so if multiple flags are set these tests do the wrong thing unless $(MAKEFLAGS) is the second argument. Signed-off-by: John Keeping --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index

[PATCH 0/5] disallow test_when_finished in subshells

2015-09-05 Thread John Keeping
the more generic solution will be better for the future. I don't think it's worth trying to clear $BASH_SUBSHELL before the tests start because to do so we have to reliably detect that we're not running under Bash, and if we don't trust people not to set $BASH_SUBSHELL why do we

[PATCH 2/5] t5801: don't use test_when_finished in a subshell

2015-09-05 Thread John Keeping
test_when_finished has no effect in a subshell. Since the cmp_marks function is only used once, inline it at its call site and move the test_when_finished invocation to the start of the test. Signed-off-by: John Keeping --- t/t5801-remote-helpers.sh | 12 1 file changed, 4

[PATCH 1/5] t7610: don't use test_config in a subshell

2015-09-05 Thread John Keeping
test_when_finished is used in a subshell. In this case, "subdir" not a submodule so test_config has the same effect when run at the top level and can simply be moved out of the subshell. Signed-off-by: John Keeping --- t/t7610-mergetool.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH 4/5] t7800: don't use test_config in a subshell

2015-09-05 Thread John Keeping
Use the new "-C" option to test_config to change the configuration in the submodule from the top level of the test so that it can be unset correctly when the test finishes. Signed-off-by: John Keeping --- t/t7800-difftool.sh | 8 1 file changed, 4 insertions(+), 4 deletion

[PATCH 3/5] test-lib-functions: support "test_config -C ..."

2015-09-05 Thread John Keeping
st_unconfig) so that test_config can be kept outside subshells and still affect subrepositories. Signed-off-by: John Keeping --- t/test-lib-functions.sh | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh in

[PATCH 5/5] test-lib-functions: detect test_when_finished in subshell

2015-09-05 Thread John Keeping
. Signed-off-by: John Keeping --- t/test-lib-functions.sh | 5 + 1 file changed, 5 insertions(+) diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh index 0e80f37..6dffb8b 100644 --- a/t/test-lib-functions.sh +++ b/t/test-lib-functions.sh @@ -736,6 +736,11 @@ test_seq () { # what

Re: [L10N] Kickoff of translation for Git 2.6.0 round 1

2015-09-05 Thread John Keeping
On Sat, Sep 05, 2015 at 09:14:18PM +0800, Jiang Xin wrote: > 2015-09-05 18:02 GMT+08:00 Jean-Noël AVILA : > > Le samedi 5 septembre 2015, 10:17:54 Jiang Xin a écrit : > >> Hi, > >> > >> Git v2.6.0-rc0 has been released, and it's time to start new round of git > >> l10n. This time there are 123 upda

[PATCH] interpret-trailers: allow running outside a repository

2015-09-05 Thread John Keeping
It may be useful to run git-interpret-trailers without needing to be in a repository. Signed-off-by: John Keeping --- git.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git.c b/git.c index 82d7a1c..2431cb0 100644 --- a/git.c +++ b/git.c @@ -417,7 +417,7 @@ static struct

Re: [PATCH 0/5] disallow test_when_finished in subshells

2015-09-05 Thread John Keeping
On Sat, Sep 05, 2015 at 10:36:29AM -0700, Junio C Hamano wrote: > On Sat, Sep 5, 2015 at 6:12 AM, John Keeping wrote: > > > > I don't think it's worth trying to clear $BASH_SUBSHELL before the tests > > start because to do so we have to reliably detect that we

Re: [PATCH 5/5] test-lib-functions: detect test_when_finished in subshell

2015-09-06 Thread John Keeping
On Sun, Sep 06, 2015 at 05:51:43AM -0400, Eric Sunshine wrote: > On Sat, Sep 5, 2015 at 9:12 AM, John Keeping wrote: > > test_when_finished does nothing in a subshell because the change to > > test_cleanup does not affect the parent. > > > > There is no POSIX way

[PATCH 2/2] Documentation/git-rebase: fix --no-autostash formatting

2015-09-10 Thread John Keeping
All of the other "--option" and "--no-option" pairs in this file are formatted as separate options. Signed-off-by: John Keeping --- Documentation/git-rebase.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/git-rebase.txt b/Document

[PATCH 1/2] rebase: support --no-autostash

2015-09-10 Thread John Keeping
This is documented as an option but we don't actually accept it. Support it so that it is possible to override the "rebase.autostash" config variable. Reported-by: Daniel Hahler Signed-off-by: John Keeping --- git-rebase.sh | 5 - t/t3420-rebase-au

[PATCH 0/2] rebase: support --no-autostash

2015-09-10 Thread John Keeping
The first patch is the fix so that git-rebase supports the --no-autostash option that it's documentation claims it does. The second is a slight tweak to the documentation to make it consistent with the remainder of the file. John Keeping (2): rebase: support --no-autostash Documentatio

Re: git submodule ignores --git-dir

2015-09-11 Thread John Keeping
On Fri, Sep 11, 2015 at 05:15:52PM +0200, Jens Lehmann wrote: > Am 10.09.2015 um 22:06 schrieb Filip Gospodinov: > > I know that for this particular use case I can just use `git clone > > --recursive` > > and that other use cases can be worked around by using `cd`. Still, I > > wonder if > > the

Re: [PATCH v17 14/14] tag.c: implement '--merged' and '--no-merged' options

2015-09-17 Thread John Keeping
On Thu, Sep 10, 2015 at 09:52:49PM +0530, Karthik Nayak wrote: > Use 'ref-filter' APIs to implement the '--merged' and '--no-merged' > options into 'tag.c'. The '--merged' option lets the user to only list > tags merged into the named commit. The '--no-merged' option lets the > user to only list ta

Re: [PATCH v17 14/14] tag.c: implement '--merged' and '--no-merged' options

2015-09-18 Thread John Keeping
On Fri, Sep 18, 2015 at 09:10:08AM +0200, Matthieu Moy wrote: > Junio C Hamano writes: > > > John Keeping writes: > > > >>> +--[no-]merged []:: > >> > >> We prefer to write --[no-]* as: > >> > >>--option:: > >>

Re: Formatting error in page http://git-scm.com/docs/user-manual

2015-09-25 Thread John Keeping
>8 -- Subject: [PATCH] Documentation/user-manual: fix header underline Asciidoctor is stricter than AsciiDoc when deciding if underlining is a section title or the start of preformatted text. Make the length of the underlining match the text to ensure that it renders correctly in all implem

Re: How can I ignore insignificant change during merge ?

2015-10-05 Thread John Keeping
On Mon, Oct 05, 2015 at 10:13:00PM +0200, Jens Brejner wrote: > I need to merge a branch, +100k changes. The vast majority of changes > are insignificant, because they only represent a screen position in > the editor, so these changes should never have been in git - but but > MadCap Flare already p

Re: [BUG?] parallel make interdepencies

2015-10-06 Thread John Keeping
On Tue, Oct 06, 2015 at 03:13:05PM +0200, Johannes Schindelin wrote: > Hi Michael, > > On 2015-10-06 10:12, Michael J Gruber wrote: > > "make -j3" just errored out on me, a follow-up "make" succeeded". This > > looks like an interdependency issue, but I don't know how to track it: > > > > GEN

Re: Using clean/smudge filters with difftool

2015-06-18 Thread John Keeping
[Please don't top-post on this list.] On Thu, Jun 18, 2015 at 03:15:38PM +0200, Florian Aspart wrote: > 2015-06-18 14:31 GMT+02:00 Michael J Gruber : > > Florian Aspart venit, vidit, dixit 16.06.2015 16:11: > >> Hi everyone, > >> > >> I created a clean filter to apply on some files before commitin

Re: Using clean/smudge filters with difftool

2015-06-18 Thread John Keeping
On Thu, Jun 18, 2015 at 03:51:25PM +0200, Florian Aspart wrote: > 2015-06-18 15:26 GMT+02:00 John Keeping : > > [Please don't top-post on this list.] > > > > On Thu, Jun 18, 2015 at 03:15:38PM +0200, Florian Aspart wrote: > >> 2015-06-18 14:31 GMT+02:00 Micha

Re: Using clean/smudge filters with difftool

2015-06-18 Thread John Keeping
On Thu, Jun 18, 2015 at 04:17:52PM +0200, Florian Aspart wrote: > 2015-06-18 16:11 GMT+02:00 John Keeping : > > On Thu, Jun 18, 2015 at 03:51:25PM +0200, Florian Aspart wrote: > >> 2015-06-18 15:26 GMT+02:00 John Keeping : > >> > [Please don't top-post on this

Re: Using clean/smudge filters with difftool

2015-06-18 Thread John Keeping
On Thu, Jun 18, 2015 at 05:39:18PM +0200, Florian Aspart wrote: > 2015-06-18 16:28 GMT+02:00 John Keeping : > > On Thu, Jun 18, 2015 at 04:17:52PM +0200, Florian Aspart wrote: > >> 2015-06-18 16:11 GMT+02:00 John Keeping : > >> > On Thu, Jun 18, 2015 at 03:51:25

Re: Using clean/smudge filters with difftool

2015-06-18 Thread John Keeping
On Thu, Jun 18, 2015 at 01:00:36PM -0700, Junio C Hamano wrote: > John Keeping writes: > > > I think this is a difference between git-diff's internal and external > > diff modes which is working correctly, although possibly not desirably > > in this case. The in

Re: Using clean/smudge filters with difftool

2015-06-19 Thread John Keeping
On Fri, Jun 19, 2015 at 10:57:55AM +0200, Michael J Gruber wrote: > Junio C Hamano venit, vidit, dixit 19.06.2015 00:55: > > John Keeping writes: > > > >> I think the summary is that there are some scenarios where the external > >> diff tool should see the smu

Re: [PATCH 3/3] Add filter-objects command

2015-06-19 Thread John Keeping
On Fri, Jun 19, 2015 at 11:33:24AM +0100, Charles Bailey wrote: > So, yes, performance is definitely an issue and I could have called this > command "git magically-generate-all-object-for-scripts" but then, as it > was so easy to provide exactly the filtering that I was looking for in > the C code,

Re: [PATCH 2/3] convert "enum date_mode" into a struct

2015-06-25 Thread John Keeping
On Thu, Jun 25, 2015 at 12:55:02PM -0400, Jeff King wrote: > In preparation for adding date modes that may carry extra > information beyond the mode itself, this patch converts the > date_mode enum into a struct. > > Most of the conversion is fairly straightforward; we pass > the struct as a point

Re: [PATCH] --count feature for git shortlog

2015-06-30 Thread John Keeping
On Tue, Jun 30, 2015 at 02:10:49PM +0200, Johannes Schindelin wrote: > On 2015-06-29 18:46, Lawrence Siebert wrote: > > > I appreciate your help. Okay, That all makes sense. > > > > I would note that something like: > > git shortlog -s "$FILENAME: | cut -f 1 | paste -sd+ - | bc > > > > seems l

Re: undocumented core.sharedRepository=2 set by git init --shared=world

2015-07-07 Thread John Keeping
On Tue, Jul 07, 2015 at 10:14:28AM +0200, Johannes Schindelin wrote: > Hi Joey, > > On 2015-07-06 21:25, Joey Hess wrote: > > joey@darkstar:~/tmp>git init --shared=world testrepo > > Initialized empty shared Git repository in /home/joey/tmp/testrepo/.git/ > > joey@darkstar:~/tmp>grep shared testre

Re: undocumented core.sharedRepository=2 set by git init --shared=world

2015-07-07 Thread John Keeping
On Tue, Jul 07, 2015 at 01:32:13PM +0200, Johannes Schindelin wrote: > Hi John, > > On 2015-07-07 11:10, John Keeping wrote: > > On Tue, Jul 07, 2015 at 10:14:28AM +0200, Johannes Schindelin wrote: > >> Hi Joey, > >> > >> On 2015-07-06 21:25, Joey Hess

Re: [PATCH] completion: Add '--edit-todo' to rebase

2015-07-13 Thread John Keeping
On Mon, Jul 13, 2015 at 01:27:56PM +0200, Thomas Braun wrote: > Signed-off-by: Thomas Braun > --- > contrib/completion/git-completion.bash | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/completion/git-completion.bash > b/contrib/completion/git-completion.bash >

Re: git log fails to show all changes for a file

2015-07-14 Thread John Keeping
On Tue, Jul 14, 2015 at 09:30:35AM +0200, Olaf Hering wrote: > > I wonder why this command fails to show all commits that modify a given > function: > > linux.git $ git log -p -M --stat -- drivers/hv/channel_mgmt.c > > With commit 1f656ff3fdddc2f59649cc84b633b799908f1f7b init_vp_index() has >

Re: unexplained behavior/issue with git archive?

2015-07-23 Thread John Keeping
On Thu, Jul 23, 2015 at 05:23:49PM +0200, Jan Vales wrote: > i seem to trigger behavior i do not understand with git archive. > > I have this little 3 liner (vmdiff.sh): > #!/bin/bash > git diff --name-status "$2" "$3" > "$1.files" > git diff --name-only "$2" "$3" |xargs -d'\n' git archive -o "$1"

[PATCH] difftool: fix argument handling in subdirs

2016-07-05 Thread John Keeping
uments should be interpreted relative to the current directory not the root of the working tree. The Git::repository object passed into setup_dir_diff() is configured to handle this correctly but we create a new Git::repository here without setting the WorkingSubdir argument. By simply using t

[PATCH] push: allow pushing new branches with --force-with-lease

2016-07-23 Thread John Keeping
null SHA-1 as the expected value. In fact, it is already possible to push new branches using the explicit --force-with-lease=: syntax, so all we do here is make this behaviour the default if no explicit "expect" value is specified. Signed-off-by: John Keeping --- remote.c

[PATCH v2 3/3] push: allow pushing new branches with --force-with-lease

2016-07-25 Thread John Keeping
null SHA-1 as the expected value. In fact, it is already possible to push new branches using the explicit --force-with-lease=: syntax, so all we do here is make this behaviour the default if no explicit "expect" value is specified. Signed-off-by: John Keeping --- Changes in v2: - The

[PATCH v2 1/3] Documentation/git-push: fix placeholder formatting

2016-07-25 Thread John Keeping
Format the placeholder as monospace to match other occurrences in this file and obey CodingGuidelines. Signed-off-by: John Keeping --- New in v2. Documentation/git-push.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/git-push.txt b/Documentation/git

[PATCH v2 2/3] push: add shorthand for --force-with-lease branch creation

2016-07-25 Thread John Keeping
: origin new-branch Signed-off-by: John Keeping --- New in v2. Documentation/git-push.txt | 3 ++- remote.c | 2 ++ t/t5533-push-cas.sh| 12 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt

[PATCH v2 0/3] push: allow pushing new branches with --force-with-lease

2016-07-25 Thread John Keeping
On Mon, Jul 25, 2016 at 10:28:01AM -0700, Junio C Hamano wrote: > John Keeping writes: > > > If there is no upstream information for a branch, it is likely that it > > is newly created and can safely be pushed under the normal fast-forward > > rules. Relax the --force-

Re: [PATCH v2 2/3] push: add shorthand for --force-with-lease branch creation

2016-07-26 Thread John Keeping
On Mon, Jul 25, 2016 at 03:22:48PM -0700, Junio C Hamano wrote: > John Keeping writes: > > > Allow the empty string to stand in for the null SHA-1 when pushing a new > > branch, like we do when deleting branches. > > > > This means that the following comman

Re: [PATCH v2 2/3] push: add shorthand for --force-with-lease branch creation

2016-07-26 Thread John Keeping
On Tue, Jul 26, 2016 at 12:30:05PM +0200, Jakub Narębski wrote: > W dniu 2016-07-25 o 23:59, John Keeping pisze: > > > +test_expect_success 'new branch covered by force-with-lease (explicit)' ' > > + setup_srcdst_basic && > > + ( > > +

Re: [PATCH v2 2/3] push: add shorthand for --force-with-lease branch creation

2016-07-26 Thread John Keeping
On Tue, Jul 26, 2016 at 12:59:04PM -0700, Junio C Hamano wrote: > John Keeping writes: > > >> > @@ -2294,6 +2294,8 @@ int parse_push_cas_option(struct push_cas_option > >> > *cas, const char *arg, int unse > >> > entry = add_cas_entry(cas, arg,

[PATCH v3 2/3] push: add shorthand for --force-with-lease branch creation

2016-07-26 Thread John Keeping
: origin new-branch Signed-off-by: John Keeping --- Changes in v3: - use hashclr() - pull 'new branch already exists' test forward from patch 3 and use explicit --force-with-lease syntax Documentation/git-push.txt | 3 ++- remote.c | 2 ++ t/t5533-push-cas.sh

[PATCH v3 0/3] push: allow pushing new branches with --force-with-lease

2016-07-26 Thread John Keeping
Changes in v3: - Use hashclr() and oidclr() where appropriate instead of memset() - Pull a test forward from patch 3 to patch 2 John Keeping (3): Documentation/git-push: fix placeholder formatting push: add shorthand for --force-with-lease branch creation push: allow pushing new branches

[PATCH v3 1/3] Documentation/git-push: fix placeholder formatting

2016-07-26 Thread John Keeping
Format the placeholder as monospace to match other occurrences in this file and obey CodingGuidelines. Signed-off-by: John Keeping --- No changes in v3. Documentation/git-push.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/git-push.txt b/Documentation/git

[PATCH v3 3/3] push: allow pushing new branches with --force-with-lease

2016-07-26 Thread John Keeping
null SHA-1 as the expected value. In fact, it is already possible to push new branches using the explicit --force-with-lease=: syntax, so all we do here is make this behaviour the default if no explicit "expect" value is specified. Signed-off-by: John Keeping --- Changes in v3: -

Re: What's cooking in git.git (Aug 2016, #01; Tue, 2)

2016-08-04 Thread John Keeping
On Thu, Aug 04, 2016 at 10:03:39AM +0200, Lars Schneider wrote: > > > > > * jk/push-force-with-lease-creation (2016-07-26) 3 commits > > - push: allow pushing new branches with --force-with-lease > > - push: add shorthand for --force-with-lease branch creation > > - Documentation/git-push: fix pl

Re: storing cover letter of a patch series?

2016-08-07 Thread John Keeping
On Sun, Aug 07, 2016 at 08:12:23AM +0300, Michael S. Tsirkin wrote: > On Fri, Aug 05, 2016 at 08:39:58AM -0700, Junio C Hamano wrote: > > * When you updated an existing topic, you tell a tool like "rebase > >-i -p" to recreate "lit" branch on top of the mainline. This > >would give you an

Re: Is there a way to have local changes in a branch 'bake' while working in different branches?

2016-12-16 Thread John Keeping
On Thu, Dec 15, 2016 at 08:14:58PM +, Larry Minton wrote: > My question: > > Let's say I have a code change that I want to 'bake' for a while > locally, just to make sure some edge case doesn't pop up while I am > working on other things.  Is there any practical way of doing that? I > could c

Force-with-lease and new branches

2016-05-07 Thread John Keeping
I've noticed a slightly annoying behaviour of git-push's --force-with-lease option around branch creation. I'd like to be able to do: git push --force-with-lease origin refs/heads/jk/* to push out a load of topic branches safely in case I've switched client machines and forgotten to pull

Re: [BUG] git-submodule has bash-ism?

2016-06-01 Thread John Keeping
& > > git config remote.origin.url "$root/submodule" > > Hmm. Isn't $root always just going to be $TRASH_DIRECTORY here? There's > only one caller, which appears to pass an argument which is ignored (?). > > It's probably worth doing

Re: [BUG] git-submodule has bash-ism?

2016-06-01 Thread John Keeping
On Wed, Jun 01, 2016 at 03:07:59PM -0400, Jeff King wrote: > On Wed, Jun 01, 2016 at 07:31:00PM +0100, John Keeping wrote: > > > > > reset_submodule_urls () { > > > > - local root > > > > - root=$(pwd) && &g

Re: [BUG] git-submodule has bash-ism?

2016-06-01 Thread John Keeping
On Wed, Jun 01, 2016 at 12:45:11PM -0700, Junio C Hamano wrote: > John Keeping writes: > > > On Wed, Jun 01, 2016 at 03:07:59PM -0400, Jeff King wrote: > >> On Wed, Jun 01, 2016 at 07:31:00PM +0100, John Keeping wrote: > >> > >> > > > rese

Re: git difftool and git mergetool aren't returning errors when the tool has issues

2016-08-13 Thread John Keeping
On Fri, Aug 12, 2016 at 07:13:41AM -, Tom Tanner (BLOOMBERG/ LONDON) wrote: > For instance, if you set your diff/mergetool to meld and you don't have it > installed: > > git difftool > > Viewing (1/1): 'blah' > Launch 'meld' [Y/n]? y > /home/ttanner/bin/meld[8]: /opt/swt/bin/meld: not found >

[PATCH] difftool: always honor "command not found" exit code

2016-08-13 Thread John Keeping
the exit status we want to ignore. Handle 126 and 127 as special values, assuming that they always mean that the command could not be executed. [1] http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_08_02 Signed-off-by: John Keeping --- On Sat, Aug 13, 2016 at 11:36:

Re: git-mergetool reverse file ordering

2016-08-14 Thread John Keeping
On Sat, Aug 13, 2016 at 08:42:21PM -0700, David Aguilar wrote: > This use case makes me wonder whether the sorting we do here is > something that should be opened up a bit so that the it's not > quite so set in stone. > > For example, an extension to the approach taken by this patch > would be to

Re: storing cover letter of a patch series?

2016-08-15 Thread John Keeping
On Mon, Aug 15, 2016 at 08:30:03PM +0700, Duy Nguyen wrote: > On Mon, Aug 15, 2016 at 7:37 PM, Philip Oakley wrote: > > I appreciate there has been a lot of discussion, but it mainly appears to be > > about an upstream / integration viewpoint. > > > > I'd hate it if there was a one size fits all s

Re: [PATCH] difftool: always honor "command not found" exit code

2016-08-15 Thread John Keeping
On Mon, Aug 15, 2016 at 01:21:22PM -0700, Junio C Hamano wrote: > "Tom Tanner (BLOOMBERG/ LONDON)" writes: > > > From: gits...@pobox.com > > To: j...@keeping.me.uk > > Cc: Tom Tanner (BLOOMBERG/ LONDON), dav...@gmail.com, git@vger.kernel.org > > At: 08/14/

[PATCH v2] difftool: always honor fatal error exit codes

2016-08-15 Thread John Keeping
llow this specification, while diff utilities generally use "1" for the exit status we want to ignore. Handle any value of 126 or greater as a special value indicating that some form of fatal error occurred. [1] http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#ta

Re: [PATCH v2] help: make option --help open man pages only for Git commands

2016-08-16 Thread John Keeping
On Mon, Aug 15, 2016 at 09:40:54PM +0100, Philip Oakley wrote: > From: "Junio C Hamano" > > "Philip Oakley" writes: > > > >> I'm still not sure this is enough. One of the problems back when I > >> introduced the --guides option (65f9835 (builtin/help.c: add --guide > >> option, 2013-04-02)) was t

Re: [PATCH v3] help: make option --help open man pages only for Git commands

2016-08-16 Thread John Keeping
On Tue, Aug 16, 2016 at 06:20:30PM +0200, Ralf Thielow wrote: > If option --help is passed to a Git command, we try to open > the man page of that command. However, we do it even for commands > we don't know. Make sure it is a Git command by using "help_unknown_cmd" > which is even able to assume

Re: Re: Homebrew and Git

2016-09-20 Thread John Keeping
On Tue, Sep 20, 2016 at 01:07:00PM +0200, Heiko Voigt wrote: > On Tue, Sep 20, 2016 at 01:02:28PM +0200, Heiko Voigt wrote: > > Hi, > > > > On Sun, Sep 18, 2016 at 05:50:28PM +0200, Jonas Thiel wrote: > > > A while ago I have described my problem with Homebrew at the following > > > GitHub channel

  1   2   3   4   5   6   7   8   9   >