[PATCH v1] send-email: provide whitelist of SMTP AUTH mechanisms

2015-07-31 Thread Jan Viktorin
defined, it works as a whitelist of allowed mechanisms for authentication. There are four mechanisms supported: PLAIN, LOGIN, CRAM-MD5, DIGEST-MD5. However, their availability depends on the installed SASL library. Signed-off-by: Jan Viktorin --- git-send-email.perl | 31

Re: [PATCH v1] send-email: provide whitelist of SMTP AUTH mechanisms

2015-08-01 Thread Jan Viktorin
at, 1 Aug 2015 05:33:28 -0400 Eric Sunshine wrote: > On Fri, Jul 31, 2015 at 7:33 PM, Jan Viktorin > wrote: > > When sending an e-mail, the client and server must > > agree on an authentication mechanism. Some servers > > (due to misconfiguration or a bug) denies vali

Re: [PATCH v1] send-email: provide whitelist of SMTP AUTH mechanisms

2015-08-01 Thread Jan Viktorin
Hello Brian, thanks for your note. I think, I will remove the check of list of mechanisms and put there a regex check. On Sat, 1 Aug 2015 16:49:59 + "brian m. carlson" wrote: > On Sat, Aug 01, 2015 at 01:33:37AM +0200, Jan Viktorin wrote: > > + # Do not allo

[PATCH v2] send-email: provide whitelist of SMTP AUTH mechanisms

2015-08-02 Thread Jan Viktorin
, it works as a whitelist of allowed mechanisms for authentication selected from the ones supported by the installed SASL perl library. Signed-off-by: Jan Viktorin --- Changes v1 -> v2: - check user input by regex - added documentation - still missing a test Documentation/git-send-email.

Re: [PATCH v1] send-email: provide whitelist of SMTP AUTH mechanisms

2015-08-02 Thread Jan Viktorin
I've already mentioned. at least, it filters out the unwanted characters like '/', '.', etc. Regards Jan On Sun, 2 Aug 2015 05:41:29 -0400 Eric Sunshine wrote: > On Sat, Aug 1, 2015 at 2:19 PM, Jan Viktorin > wrote: > > On Sat, 1 Aug 2015 05:33:28 -0400 Eric Suns

Re: [PATCH v1] send-email: provide whitelist of SMTP AUTH mechanisms

2015-08-03 Thread Jan Viktorin
On Sun, 02 Aug 2015 11:28:49 -0700 Junio C Hamano wrote: > Jan Viktorin writes: > > > Authen::SASL gives: > > > > No SASL mechanism found > > at /usr/share/perl5/vendor_perl/Authen/SASL.pm line 77. > > at /usr/share/perl5/core_perl/Net/SMTP.pm line 20

Re: [PATCH v2] send-email: provide whitelist of SMTP AUTH mechanisms

2015-08-05 Thread Jan Viktorin
however, the errors file is always empty.) * Is there any other place where the files out, errors are placed? * I have no idea what the fake.sendmail does (I could see its contents but still...). Is it suitable for my tests? * Should I check the behaviour '--smtp-auth overrides sendemail.s

Re: [PATCH v2] send-email: provide whitelist of SMTP AUTH mechanisms

2015-08-10 Thread Jan Viktorin
On Sun, 9 Aug 2015 14:13:33 -0400 Eric Sunshine wrote: > On Wed, Aug 5, 2015 at 3:17 AM, Jan Viktorin > wrote: > > Do I understand well that you are complaining about too > > narrow commmit message? > > Yes, I'm a complainer. ;-) It's minor, though, not a big

[PATCH v3] send-email: provide whitelist of SMTP AUTH mechanisms

2015-08-11 Thread Jan Viktorin
, it works as a whitelist of allowed mechanisms for authentication selected from the ones supported by the installed SASL perl library. Signed-off-by: Jan Viktorin --- Documentation/git-send-email.txt | 11 +++ git-send-email.perl | 26 +- 2 files

Re: [PATCH v2] send-email: new options to walkaround email server limits

2017-05-01 Thread Jan Viktorin
Hello, thank you for posting this improvement. I've been missing such feature in git. I hope to test it soon. Jan Viktorin RehiveTech Sent from a mobile device   Původní zpráva   Od: xiaoqiang zhao Odesláno: pondělí, 1. května 2017 15:00 Komu: git@vger.kernel.org Kopie: gits...@pobox.com;

Re: [PATCH v4] send-email: --batch-size to work around some SMTP server limit

2017-05-16 Thread Jan Viktorin
Hello, with this patch applied to git 2.12, I could see: Use of uninitialized value $batch_size in numeric eq (==) at /usr/lib/git-core/git-send-email line 1679 when --batch-size is NOT used. See below... On Sat, 13 May 2017 09:57:26 +0800 xiaoqiang zhao wrote: > Some email servers (e.g. smt

Re: [PATCH v5] send-email: --batch-size to work around some SMTP server limit

2017-05-23 Thread Jan Viktorin
On Tue, 23 May 2017 16:46:27 +0900 Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > > > Looking at this the Nth time now though I wonder about this approach > > in general. In all your E-Mails I don't think you ever said /what/ > > sort of error you had from the SMTP server, you just s

bad behaviour while using git rebase -i -p

2018-02-08 Thread Jan Viktorin
Hello, since Git 2.16.1, I've noticed a bad behaviour of git rebase -i -p. It screws up merge commits created with --log (or config merge.log = true) in my history. A good merge commit with message like: Merge branch 'test' * test: c b is changed after rebase (without to