Re: [RFC] t5516 "75 - deny fetch unreachable SHA1, allowtipsha1inwant=true" flaky?

I think the following happens: 1. The remote upload-pack finds out "not our ref" 2. The remote send a response and close the pipe 3. fetch-pack still tries to write commands to the remote upload-pack 4. Because the connection has already been closed, writing will fail with EPIPE which is detected b

[PATCH] rebase-i-exec: Allow space in SHELL_PATH

On Windows, when Git is installed under "C:\Program Files\Git", SHELL_PATH will include a space. Fix "git rebase --interactive --exec" so that it works with spaces in SHELL_PATH. Signed-off-by: Fredrik Medley --- git-rebase--interactive.sh | 2 +- 1 file changed, 1 inse

Re: [PATCH] rebase-i-exec: Allow space in SHELL_PATH

2015-11-13 7:25 GMT+01:00 Jeff King : > On Fri, Nov 13, 2015 at 07:03:19AM +0100, Fredrik Medley wrote: > >> On Windows, when Git is installed under "C:\Program Files\Git", SHELL_PATH >> will include a space. Fix "git rebase --interactive --exec" so that

Re: [PATCH] rebase-i-exec: Allow space in SHELL_PATH

2015-11-13 23:27 GMT+01:00 Jeff King : > On Fri, Nov 13, 2015 at 04:25:18PM +0100, Fredrik Medley wrote: > >> >> - ${SHELL:-@SHELL_PATH@} -c "$rest" # Actual execution >> >> + "${SHELL:-@SHELL_PATH@}" -c "$rest"

Re: [PATCH 2/3] upload-pack: prepare to extend allow-tip-sha1-in-want

2015-05-20 0:00 GMT+02:00 Junio C Hamano : > Fredrik Medley writes: > >> static int upload_pack_config(const char *var, const char *value, void >> *unused) >> { >> - if (!strcmp("uploadpack.allowtipsha1inwant", var)) >> - allow

[PATCH v5 2/3] upload-pack: prepare to extend allow-tip-sha1-in-want

To allow future extensions, e.g. allowing non-tip sha1, replace the boolean allow_tip_sha1_in_want variable with the flag-style allow_request_with_bare_object_name variable. Signed-off-by: Fredrik Medley --- fetch-pack.c | 9 ++--- upload-pack.c | 20 +--- 2 files changed

[PATCH v5 3/3] upload-pack: optionally allow fetching reachable sha1

ch it belongs to and in Gerrit, if you think in terms of commits instead of change numbers. (The Gerrit case has already been solved through allowTipSHA1InWant as every Gerrit change has a ref.) Signed-off-by: Fredrik Medley --- Documentation/config.txt | 6 +++ Document

[PATCH v5 1/3] config.txt: clarify allowTipSHA1InWant with camelCase

Most of the options in config.txt are camelCase. Improve the readability for allowtipsha1inwant by changing to allowTipSHA1InWant. Signed-off-by: Fredrik Medley --- This patch is optional. There has been work on fixing the whole Documentation/config.txt which has not been merged yet. When adding

Re: [PATCH v5 2/3] upload-pack: prepare to extend allow-tip-sha1-in-want

2015-05-22 0:07 GMT+02:00 Junio C Hamano : > Fredrik Medley writes: > >> To allow future extensions, e.g. allowing non-tip sha1, replace the >> boolean allow_tip_sha1_in_want variable with the flag-style >> allow_request_with_bare_object_name variable. >> &g

Re: [PATCH v5 3/3] upload-pack: optionally allow fetching reachable sha1

2015-05-22 0:15 GMT+02:00 Junio C Hamano : > Fredrik Medley writes: > >> --- a/Documentation/technical/protocol-capabilities.txt >> +++ b/Documentation/technical/protocol-capabilities.txt >> @@ -260,6 +260,13 @@ If the upload-pack server advertises this capability, &g