Re: [RFC PATCH] git-submodule.sh:cmd_update: if submodule branch exists, fetch that instead of default

2018-03-08 Thread Eddy Petrișor
2018-03-06 22:21 GMT+02:00 Jonathan Nieder : > > (cc list snipped) > Hi, > > Eddy Petrișor wrote: > > > Cc: [a lot of people] > > Can you say a little about how this cc list was created? E.g. should > "git send-email" get a feature to warn about

Re: [RFC PATCH] git-submodule.sh:cmd_update: if submodule branch exists, fetch that instead of default

2018-03-08 Thread Eddy Petrișor
2018-03-08 21:29 GMT+02:00 Eddy Petrișor : > 2018-03-06 22:21 GMT+02:00 Jonathan Nieder : >> >> (cc list snipped) >> Hi, >> >> Eddy Petrișor wrote: >> >> > Cc: [a lot of people] >> >> Can you say a little about how this cc list was cre

Is context/directory sensitive config possible or even a god idea?

2018-03-09 Thread Eddy Petrișor
nsure the expected strategy is used, and rebase is the preferred behaviour for pull, instead of merge) -- Eddy Petrișor

Fwd: [RFC PATCH] git-submodule.sh:cmd_update: if submodule branch exists, fetch that instead of default

2018-03-29 Thread Eddy Petrișor
mar., 27 mar. 2018, 02:07 Stefan Beller a scris: > > [snipped the cc list as well] > > On Tue, Mar 6, 2018 at 12:06 PM Eddy Petrișor > wrote: > > > Signed-off-by: Eddy Petrișor > > --- > > Did this go anywhere? > (I just came back from a longer vacation

Re: [RFC PATCH v2] git-submodule.sh:cmd_update: if submodule branch exists, fetch that instead of default

2018-03-29 Thread Eddy Petrișor
(+list) 2018-03-30 1:55 GMT+03:00 : > From: Eddy Petrișor > > There are projects such as llvm/clang which use several repositories, and they > might be forked for providing support for various features such as adding > Redox > awareness to the toolchain. This typically mean

[RFC PATCH v3 2/2] t7406: add test for non-default branch in submodule

2018-04-03 Thread Eddy Petrișor
From: Eddy Petrișor If a submodule uses a non-default branch and the branch info is versioned, on submodule update --recursive --init the correct branch should be checked out. Signed-off-by: Eddy Petrișor --- t/t7406-submodule-update.sh | 54 + 1

[RFC PATCH v3 1/2] git-submodule.sh:cmd_update: if submodule branch exists, fetch that instead of default

2018-04-03 Thread Eddy Petrișor
From: Eddy Petrișor There are projects such as llvm/clang which use several repositories, and they might be forked for providing support for various features such as adding Redox awareness to the toolchain. This typically means the superproject will use another branch than master, occasionally

Re: [RFC PATCH v3 2/2] t7406: add test for non-default branch in submodule

2018-04-03 Thread Eddy Petrișor
. Help would be appreciated. 2018-04-04 1:20 GMT+03:00 Eddy Petrișor : > From: Eddy Petrișor > > If a submodule uses a non-default branch and the branch info is versioned, on > submodule update --recursive --init the correct branch should be checked out. > > Signed-off

Re: [RFC PATCH v3 2/2] t7406: add test for non-default branch in submodule

2018-04-04 Thread Eddy Petrișor
2018-04-04 21:36 GMT+03:00 Stefan Beller : > On Tue, Apr 3, 2018 at 3:26 PM, Eddy Petrișor wrote: >> Notes: >> I am aware this test is not probably the best one and maybe I >> should have first one test that does a one level non-default, before >> trying a test

[RFC PATCH v4 9/9] fixup:t7406:change branches in submodules after the link is done

2018-04-18 Thread Eddy Petrișor
From: Eddy Petrișor Signed-off-by: Eddy Petrișor --- t/t7406-submodule-update.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh index f44872143..68c25ce0f 100755 --- a/t/t7406-submodule-update.sh +++ b/t/t7406

[RFC PATCH v4 1/9] git-submodule.sh:cmd_update: if submodule branch exists, fetch that instead of default

2018-04-18 Thread Eddy Petrișor
From: Eddy Petrișor There are projects such as llvm/clang which use several repositories, and they might be forked for providing support for various features such as adding Redox awareness to the toolchain. This typically means the superproject will use another branch than master, occasionally

[RFC PATCH v4 3/9] fixup:t7406: use test_commit instead of echo/add/commit as suggested by Stefan Beller

2018-04-18 Thread Eddy Petrișor
From: Eddy Petrișor Signed-off-by: Eddy Petrișor --- t/t7406-submodule-update.sh | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh index 7b65f1dd1..7fb370991 100755 --- a/t/t7406-submodule-update.sh

[RFC PATCH v4 7/9] fixup:t7406:supr5 commit is done before submodules chaining

2018-04-18 Thread Eddy Petrișor
From: Eddy Petrișor Signed-off-by: Eddy Petrișor --- t/t7406-submodule-update.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh index 32995e272..18328be73 100755 --- a/t/t7406-submodule-update.sh +++ b/t/t7406

[RFC PATCH v4 5/9] fixup:t7406:cleanup chained submodules after test is done

2018-04-18 Thread Eddy Petrișor
From: Eddy Petrișor Signed-off-by: Eddy Petrișor --- t/t7406-submodule-update.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh index 974f949df..c5b412c46 100755 --- a/t/t7406-submodule-update.sh +++ b/t/t7406

[RFC PATCH v4 8/9] fixup:t7406:use super_w instead of the existing super

2018-04-18 Thread Eddy Petrișor
From: Eddy Petrișor Signed-off-by: Eddy Petrișor --- t/t7406-submodule-update.sh | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh index 18328be73..f44872143 100755 --- a/t/t7406-submodule-update.sh +++ b/t

[RFC PATCH v4 2/9] t7406: add test for non-default branch in submodule

2018-04-18 Thread Eddy Petrișor
From: Eddy Petrișor If a submodule uses a non-default branch and the branch info is versioned, on submodule update --recursive --init the correct branch should be checked out. Signed-off-by: Eddy Petrișor --- t/t7406-submodule-update.sh | 54 + 1

[RFC PATCH v4 6/9] fixup:t7406:don't call init after add, is redundant

2018-04-18 Thread Eddy Petrișor
From: Eddy Petrișor Signed-off-by: Eddy Petrișor --- t/t7406-submodule-update.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh index c5b412c46..32995e272 100755 --- a/t/t7406-submodule-update.sh +++ b/t/t7406

[RFC PATCH v4 4/9] fixup:t7404:use 'git -C' instead of cd .. && git

2018-04-18 Thread Eddy Petrișor
From: Eddy Petrișor Signed-off-by: Eddy Petrișor --- t/t7406-submodule-update.sh | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh index 7fb370991..974f949df 100755 --- a/t/t7406-submodule-update.sh +++ b/t/t7406

Re: [RFC PATCH v4 1/9] git-submodule.sh:cmd_update: if submodule branch exists, fetch that instead of default

2018-04-18 Thread Eddy Petrișor
prefix. > I think the end result looks good, but that is best reviewed as one > piece instead of 9 patches. -- Eddy Petrișor

Re: [RFC PATCH v3 2/2] t7406: add test for non-default branch in submodule

2018-04-18 Thread Eddy Petrișor
2018-04-05 0:41 GMT+03:00 Stefan Beller : > On Wed, Apr 4, 2018 at 1:37 PM, Eddy Petrișor wrote: > >>> you plan to later submit as one patch including both the change as well as >>> the test. >> >> Yes, I did not forget about having a single patch. Will d