Re: [PATCH v2.5 2/2] tag: prevent nested tags

2019-04-11 Thread Eckhard Maaß
On Thu, Apr 04, 2019 at 08:27:22AM -0400, Jeff King wrote: > IMHO the difference between those cases is that it is very easy to type > something natural to get a tag of tag, like: > > git tag -m foo mytag > # oops, try again > git tag -m bar -f mytag mytag Could it be that the semantics of

Re: Merge commit diff results are confusing and inconsistent

2019-05-03 Thread Eckhard Maaß
On Fri, May 03, 2019 at 10:55:54AM -0500, Robert Dailey wrote: > I have a merge commit. HEAD is currently pointing at this merge > commit. To be exact, HEAD points to master, which points to the merge > commit. My goal is to diff only the changes in the merge commit (stuff > committed directly in t

Re: Merge commit diff results are confusing and inconsistent

2019-05-06 Thread Eckhard Maaß
ations are mostly intended to be as a user, based on what is > observable, and based on intent. I'll clarify in the quotes below... I doubt that what is observable is what you described. > > On Fri, May 3, 2019 at 2:12 PM Eckhard Maaß > wrote: > > Hold on. Basically, there is no

Re: Merge commit diff results are confusing and inconsistent

2019-05-07 Thread Eckhard Maaß
On Tue, May 07, 2019 at 10:58:49AM -0400, Denton Liu wrote: > For more details, this code[2] just blindly diffs the first two > endpoints returned preceding `repo_init_revisions`. If you throw in more than two endpoints, the result is a combined diff with respect to the first commit. You can have

Re: Tracking parent branches in Git

2019-07-01 Thread Eckhard Maaß
On Mon, Jul 01, 2019 at 12:48:16PM -0700, Bryan Turner wrote: > Since branches are ephemeral names and have no intrinsic metadata of > their own (unlike, say, annotated tags or commits), I suspect > implementing something like this may be more complicated than it might > initially appear, especiall

Re: [RFC PATCH] Introduce "precious" file concept

2018-11-26 Thread Eckhard Maaß
On Mon, Nov 12, 2018 at 11:22:09PM +, brian m. carlson wrote: > This is going to totally hose automation. My last job had files which > might move from tracked to untracked (a file that had become generated), > and long-running CI and build systems would need to be able to check out > one stat

Re: [Possible GIT Bug]

2018-09-10 Thread Eckhard Maaß
On Mon, Sep 10, 2018 at 09:03:10AM -0700, Junio C Hamano wrote: > It is neither but if I have to pick one between the two, it is much > closer to the former than the latter. The primary source of this is > that we have only *one* pathspec given to the diff machinery, but in > order to implement yo

Re: [PATCH v2 0/1] Make 'git commit' not accidentally lose staged content

2018-09-18 Thread Eckhard Maaß
On Tue, Sep 18, 2018 at 12:41:30PM -0700, Jacob Keller wrote: > I think having both is good. There are a lot of ways to accidentally > throw away work, and it's pretty frustrating to have it happen. But > the reflog is also somewhat complicated, and I've definitely seen a > lot of developers who've

Re: How to delete files and directories from git commit history?

2018-06-12 Thread Eckhard Maaß
On Tue, Jun 12, 2018 at 03:44:13PM -0400, Steve Litt wrote: > git filter-branch --tree-filter 'rm -rf docs/propdir' HEAD ... > What command do I do to remove all mention of doc/propdir and its > files from my git history? Are you sure that you pruned all branches? I would have expected a command l

Re: [PATCH v3 11/14] switch-branch: only allow explicit detached HEAD

2019-03-10 Thread Eckhard Maaß
On Thu, Nov 29, 2018 at 10:58:46PM +0100, Nguyễn Thái Ngọc Duy wrote: > + if (!opts->implicit_detach && > + !opts->new_branch && > + !opts->new_branch_force && > + new_branch_info->name && > + !new_branch_info->path) > + die(_("a branch is expected, g

Re: [PATCH v3 17/21] switch: no implicit dwim, use --guess to dwim

2019-03-13 Thread Eckhard Maaß
On Fri, Mar 08, 2019 at 04:57:48PM +0700, Nguyễn Thái Ngọc Duy wrote: > Similar to automatic detach, this behavior could be confusing because > it can sometimes create a new branch without a user asking it to, > especially when the user is still not aware about this feature. > > In the future, per

Re: [PATCH v1 1/2] merge: Add merge.renames config setting

2018-04-22 Thread Eckhard Maaß
On Fri, Apr 20, 2018 at 11:34:25AM -0700, Elijah Newren wrote: > Sorry, I think I wasn't being clear. The documentation for the config > options for e.g. diff.renameLimit, fetch.prune, log.abbrevCommit, and > merge.ff all mention the equivalent command line parameters. Your > patch doesn't do tha

Re: [PATCH v1 1/2] merge: Add merge.renames config setting

2018-04-23 Thread Eckhard Maaß
On Mon, Apr 23, 2018 at 09:15:09AM -0400, Ben Peart wrote: > In commit 2a2ac926547 when merge.renamelimit was added, it was decided to > have separate settings for merge and diff to give users the ability to > control that behavior. In this particular case, it will default to the > value of diff.r

Re: [PATCH v3 2/3] merge: Add merge.renames config setting

2018-04-27 Thread Eckhard Maaß
On Fri, Apr 27, 2018 at 11:23:56AM +0900, Junio C Hamano wrote: > I think demoting from copy to rename-only is a good idea, at least > for now, because I do not believe we have figured out what we want > to happen when we detect copied files are involved in a merge. Does anyone know some threads c

Re: [PATCH v3 2/3] merge: Add merge.renames config setting

2018-04-30 Thread Eckhard Maaß
On Fri, Apr 27, 2018 at 01:23:20PM -0700, Elijah Newren wrote: > I doubt it has ever been discussed before this thread. But, if you're > curious, I'll try to dump a few thoughts. Thank you, I try to dump some of mine, too. Maybe let me first stress that for me copy detection without --find-copies

Re: [PATCH v2] wt-status: use rename settings from init_diff_ui_defaults

2018-05-01 Thread Eckhard Maaß
On Tue, May 01, 2018 at 01:00:54PM +0200, Ævar Arnfjörð Bjarmason wrote: > So didn't we use diff heuristics to begin with, and then regressed? I've > only given this a skimming, but it's useful to have that sort of > historical context mentioned explicitly with commit ids. Sorry for not making thi

Re: [PATCH v2] wt-status: use rename settings from init_diff_ui_defaults

2018-05-01 Thread Eckhard Maaß
On Tue, May 01, 2018 at 01:09:06PM +0200, Matthieu Moy wrote: > That init_diff_ui_defaults() should indeed have been before > git_config() from the beginning. My bad, I'm the one who > misplaced it apparently :-(. Should I have done this "bug fix" in a separate commit or mention it in the commit m

Re: [PATCH v2] wt-status: use rename settings from init_diff_ui_defaults

2018-05-01 Thread Eckhard Maaß
On Tue, May 01, 2018 at 02:23:51PM +0200, Matthieu Moy wrote: > I'm fine with it as-is. Before your "fix", the config was ignored > because overwritten by init_diff_ui_defaults() after reading the > config, so effect of your change is indeed what the commit message > describes. > > I'm often think

Re: [PATCH v2] wt-status: use rename settings from init_diff_ui_defaults

2018-05-02 Thread Eckhard Maaß
On Tue, May 01, 2018 at 05:08:27PM -0700, Elijah Newren wrote: > Eckhard, can you add some comments to your commit message mentioning > the email pointed to by Junio about break detection and rename > detection being unsafe to use together, as well as the inconsistencies > in break detection betwee

Re: [PATCH v3] add status config and command line options for rename detection

2018-05-12 Thread Eckhard Maaß
On Fri, May 11, 2018 at 12:56:39PM +, Ben Peart wrote: > After performing a merge that has conflicts git status will, by default, > attempt to detect renames which causes many objects to be examined. In a > virtualized repo, those objects do not exist locally so the rename logic > triggers the