Re: update_linked_gitdir writes relative path to .git/worktrees//gitdir

2016-02-07 Thread Duy Nguyen
On Mon, Feb 8, 2016 at 8:04 AM, Matt McCutchen wrote: > On Sun, 2016-02-07 at 15:56 -0800, Junio C Hamano wrote: >> Matt McCutchen writes: >> >> > I noticed that when update_linked_gitdir chooses to update >> > .git/worktrees//gitdir, the path it writes is relative, at >> > least >> > under some

Re: git show doesn't work on file names with square brackets

2016-02-07 Thread Duy Nguyen
On Sun, Feb 7, 2016 at 10:11 PM, Kirill Likhodedov wrote: > Hi Duy, > >> It's from 28fcc0b (pathspec: avoid the need of "--" when wildcard is >> used - 2015-05-02) > > v2.5.0 is the first release which contains 28fcc0b. > I can confirm that older versions of Git work correctly without “--“: > > #

Re: [PATCH 2/8] pack-objects: produce a stable pack when --skip is given

2016-02-07 Thread Duy Nguyen
On Sat, Feb 6, 2016 at 7:48 AM, Junio C Hamano wrote: >> You noticed that tying the behavior only happens when the user asks >> for it, right? I don't expect people to do resumable fetch/clone by >> default. There are tradeoffs to make and they decide it, we offer >> options. So, it does not reall

Re: RFC: Resumable clone based on hybrid "smart" and "dumb" HTTP

2016-02-11 Thread Duy Nguyen
On Thu, Feb 11, 2016 at 4:01 AM, Jonathan Nieder wrote: > > > I really like this design. I'm tempted to implement it (since it > lacks a bunch of the downsides of clone.bundle). A bit disappointed we still do not address resumable fetch. But I'm happy that it makes people excited and one of

Re: Git config depth option?

2016-02-11 Thread Duy Nguyen
On Thu, Feb 11, 2016 at 12:57 AM, Gary Mort wrote: > I checked the documentation and scanned through the source code for clone: > https://github.com/git/git/blob/master/builtin/clone.c > > And nothing jumps out at me as a way to specify a default depth using > a global git configuration file. I s

Re: [PATCH v2 00/25] More flexibility in making shallow clones

2016-02-11 Thread Duy Nguyen
On Tue, Feb 9, 2016 at 4:45 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> This series brings three new options to shallow clone/fetch, to let >> you specify cut point by time, or by excluding some refs, or to let >> you extend shallow boundary by commits. >> >> The series is now

Re: [PATCH] git-completion.bash: always swallow error output of for-each-ref

2016-02-12 Thread Duy Nguyen
On Sat, Feb 13, 2016 at 6:46 AM, Jeff King wrote: > On Sat, Feb 13, 2016 at 12:43:00AM +0100, SZEDER Gábor wrote: > >> >> Quoting SZEDER Gábor : >> >> >Now, if 'git for-each-ref' could understand '**' globbing, not just >> >fnmatch... >> >> Oh, look, though the manpage says: >> >> ... >> I

Re: [PATCH v4 20/21] refs: add LMDB refs storage backend

2016-02-14 Thread Duy Nguyen
On Sat, Feb 6, 2016 at 2:44 AM, David Turner wrote: > +static char *get_refdb_path(const char *base) > +{ > + static struct strbuf path_buf = STRBUF_INIT; > + strbuf_reset(&path_buf); > + strbuf_addf(&path_buf, "%s/refdb", base); > + return path_buf.buf; > +} ... > +static

Re: [PATCH v2 09/25] upload-pack: tighten number parsing at "deepen" lines

2016-02-14 Thread Duy Nguyen
On Fri, Feb 5, 2016 at 6:48 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> Signed-off-by: Nguyễn Thái Ngọc Duy >> --- > > Hmm, so "deepen 10-by-the-way-let-me-tell-you-something-else" was an > acceptable input that some (third-party) version of "git fetch" > could have used, but

Re: [PATCH v2 20/25] upload-pack: support define shallow boundary by excluding revisions

2016-02-14 Thread Duy Nguyen
On Fri, Feb 5, 2016 at 12:05 PM, Eric Sunshine wrote: > On Thu, Feb 4, 2016 at 4:03 AM, Nguyễn Thái Ngọc Duy > wrote: >> @@ -732,7 +743,7 @@ static void receive_needs(void) >> if (depth == 0 && !deepen_rev_list && shallows.nr == 0) >> return; >> if (depth > 0 && d

Re: [PATCH v2 21/25] fetch: define shallow boundary with --shallow-exclude

2016-02-14 Thread Duy Nguyen
On Fri, Feb 5, 2016 at 12:26 PM, Eric Sunshine wrote: > On Thu, Feb 4, 2016 at 4:03 AM, Nguyễn Thái Ngọc Duy > wrote: >> Signed-off-by: Nguyễn Thái Ngọc Duy >> --- >> diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c >> @@ -109,6 +109,16 @@ int cmd_fetch_pack(int argc, const char **argv,

Re: [PATCH v2 18/25] t5500, t5539: tests for shallow depth since a specific date

2016-02-14 Thread Duy Nguyen
On Tue, Feb 9, 2016 at 4:24 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> + cd shallow-since && >> + GIT_COMMITTER_DATE="1 +0700" git commit --allow-empty -m one && >> + GIT_COMMITTER_DATE="2 +0700" git commit --allow-empty -m two && >> + GIT_COMMI

Re: [PATCH v2 14/25] shallow.c: implement a generic shallow boundary finder based on rev-list

2016-02-15 Thread Duy Nguyen
On Tue, Feb 9, 2016 at 4:09 AM, Junio C Hamano wrote: >> + is_repository_shallow(); /* make sure shallows are read */ >> + >> + init_revisions(&revs, NULL); >> + save_commit_buffer = 0; >> + setup_revisions(ac, av, &revs, NULL); >> + >> + /* Mark all reachable commits as NOT_SH

Re: [PATCH v2 21/25] fetch: define shallow boundary with --shallow-exclude

2016-02-15 Thread Duy Nguyen
On Mon, Feb 15, 2016 at 12:52:26AM -0500, Eric Sunshine wrote: > Yes, dropping 'const' was implied. I didn't examine it too deeply, but > it did not appear as if there would be any major fallout from dropping > 'const'. It feels a bit cleaner to keep it all self-contained than to > have that somewh

Re: git worktree fails to recreate existing branch even with -B

2016-02-15 Thread Duy Nguyen
On Tue, Feb 09, 2016 at 05:54:01PM +0300, Kirill Likhodedov wrote: > Git doesn’t allow me to execute > git worktree add -B > where already exists in the repository. > > The command prints the following: > Preparing (identifier ) > fatal: Refusing to point HEAD outside of refs/ >

Re: [PATCH v4 20/21] refs: add LMDB refs storage backend

2016-02-15 Thread Duy Nguyen
On Sun, Feb 14, 2016 at 7:04 PM, Duy Nguyen wrote: > On Sat, Feb 6, 2016 at 2:44 AM, David Turner wrote: >> +static char *get_refdb_path(const char *base) >> +{ >> + static struct strbuf path_buf = STRBUF_INIT; >> + strbuf_reset(&path_buf); >> +

Re: [PATCH 1/2] worktree: fix "add -B"

2016-02-15 Thread Duy Nguyen
On Tue, Feb 16, 2016 at 6:53 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> Current code does not update "symref" when -B is used. This string >> contains the new HEAD. Because it's empty "git worktree add -B" fails at >> symbolic-ref step. >> >> Because branch creation is already

Re: [PATCH 1/4] dir.c: fix match_pathname()

2016-02-15 Thread Duy Nguyen
On Tue, Feb 16, 2016 at 6:29 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> Given the pattern "1/2/3/4" and the path "1/2/3/4/f", the pattern >> prefix is "1/2/3/4". We will compare and remove the prefix from both >> pattern and path and come to this code >> >> /* >>

Re: [PATCH 3/4] dir.c: support marking some patterns already matched

2016-02-15 Thread Duy Nguyen
On Tue, Feb 16, 2016 at 6:47 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> Given path "a" and the pattern "a", it's matched. But if we throw path >> "a/b" to pattern "a", the code fails to realize that if "a" matches >> "a" then "a/b" should also be matched. >> >> When the patter

Re: GSoC 2016: applications open, deadline = Fri, 19/2

2016-02-17 Thread Duy Nguyen
On Wed, Feb 17, 2016 at 5:34 PM, Matthieu Moy wrote: > Stefan Beller writes: > >> I'd be interested to co-mentor a sh->C conversion. >> >> I think the git-rebase*.sh is a good start. >> >> $ wc -l git-rebase*.sh >> 101 git-rebase--am.sh >> 1296 git-rebase--interactive.sh >> 167 git-rebase--m

Re: [PATCH 0/3] Turn git-rebase--*.sh to external helpers

2016-02-17 Thread Duy Nguyen
On Wed, Feb 17, 2016 at 9:22 PM, Johannes Schindelin wrote: > I already started a different route locally (nothing to show yet, mostly > because I have to write emails and try to triage the bug tracker instead > of doing real work *grmbl*): add a rebase--helper and off-load heavy-duty > work from

Re: [PATCH v2 10/26] wrapper.c: allow to create an empty file with write_file()

2016-02-17 Thread Duy Nguyen
On Thu, Feb 18, 2016 at 5:29 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> This is used later on to create empty .git/worktrees/xxx/locked when >> "git worktree lock" is called with no reason given. >> >> Signed-off-by: Nguyễn Thái Ngọc Duy >> --- >> wrapper.c | 2 +- >> 1 file

Re: [PATCH v5 25/27] refs: add LMDB refs storage backend

2016-02-18 Thread Duy Nguyen
Caveat: I did not study how to use lmdb. I just guessed what it does based on function names. I don't know much about refs handling either (especially since the transaction thing is introduced) > diff --git a/Documentation/technical/refs-lmdb-backend.txt > b/Documentation/technical/refs-lmdb-back

Re: [PATCH v5 25/27] refs: add LMDB refs storage backend

2016-02-18 Thread Duy Nguyen
On Fri, Feb 19, 2016 at 3:23 AM, David Turner wrote: >> > +static int read_per_worktree_ref(const char *submodule, const char >> > *refname, >> > +struct MDB_val *val, int >> > *needs_free) >> >> From what I read, I suspect these _per_worktree functions will be >> ident

Re: GSoC 2016: applications open, deadline = Fri, 19/2

2016-02-18 Thread Duy Nguyen
On Thu, Feb 18, 2016 at 1:58 AM, Matthieu Moy wrote: > Feel free to start writting an idea for > http://git.github.io/SoC-2016-Ideas/. It'd be nice to have a few more > ideas before Friday. We can polish them later if needed. Probably too late now, anyway.. with David's multiple ref backend work,

Re: GSoC 2016: applications open, deadline = Fri, 19/2

2016-02-18 Thread Duy Nguyen
On Fri, Feb 19, 2016 at 10:20 AM, Junio C Hamano wrote: > Duy Nguyen writes: > >> Probably too late now, anyway.. with David's multiple ref backend >> work, we could have a third, no-dependency backend. We can use index >> format to store refs. Then we can avoi

Re: [PATCH v2 14/25] shallow.c: implement a generic shallow boundary finder based on rev-list

2016-02-19 Thread Duy Nguyen
On Mon, Feb 08, 2016 at 01:09:24PM -0800, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > > > Instead of a custom commit walker like get_shallow_commits(), this new > > function uses rev-list to mark NOT_SHALLOW to all reachable commits, > > except borders. The definition of reachable is

Re: GSoC 2016: applications open, deadline = Fri, 19/2

2016-02-19 Thread Duy Nguyen
On Fri, Feb 19, 2016 at 2:17 PM, Matthieu Moy wrote: >> with David's multiple ref backend work, we could have a third, >> no-dependency backend. We can use index format to store refs. > > This sounds like an interesting but ambitious project for a GSoC. There > are a lot of new stuff to understand

Re: [PATCH v5 25/27] refs: add LMDB refs storage backend

2016-02-19 Thread Duy Nguyen
> On Fri, 2016-02-19 at 09:54 +0700, Duy Nguyen wrote: >> On Fri, Feb 19, 2016 at 3:23 AM, David Turner < >> dtur...@twopensource.com> wrote: >> > > > +static int read_per_worktree_ref(const char *submodule, const >> > > > char >> >

Re: [PATCH v5 12/27] refs: forbid cross-backend ref renames

2016-02-19 Thread Duy Nguyen
On Thu, Feb 18, 2016 at 12:17 PM, David Turner wrote: > This would be pretty weird, but since it will break, we should prevent > it. > > Signed-off-by: David Turner > --- > refs.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/refs.c b/refs.c > index f5754f2..8eb04da 100644 > ---

Re: [PATCH v5 25/27] refs: add LMDB refs storage backend

2016-02-20 Thread Duy Nguyen
On Thu, Feb 18, 2016 at 12:17 PM, David Turner wrote: > LMDB has a few features that make it suitable for usage in git: > ... I'm reading lmdb documents and hitting the caveat section [1]. Random thoughts * "There is normally no pure read-only mode, since readers need write access to locks and

Re: [PATCH v5 25/27] refs: add LMDB refs storage backend

2016-02-20 Thread Duy Nguyen
On Fri, Feb 19, 2016 at 3:23 AM, David Turner wrote: > On Thu, 2016-02-18 at 15:50 +0700, Duy Nguyen wrote: > > [snip] > > Thanks; applied the above > >> This permission makes me wonder if we need adjust_shared_perm() here >> and some other places. > >

Re: GSoC 2016: applications open, deadline = Fri, 19/2

2016-02-22 Thread Duy Nguyen
On Sat, Feb 13, 2016 at 6:21 PM, Matthieu Moy wrote: > Less urgent, but we need to add more stuff to be credible: > > ... > > http://git.github.io/SoC-2016-Microprojects/ => I just did s/2015/2016/. > I think most projects are not valid anymore, and we need new ones. > > To all: please contribute

Re: [PATCH] GSoC Micoproject: Hunt down signed int flags

2016-02-22 Thread Duy Nguyen
On Sun, Feb 21, 2016 at 6:13 PM, Saurav Sachidanand wrote: > This is patch is for a suggested micro project for GSoC 2016; namely, > that of searching for a field of a struct that is of signed integral > type and used as a collection of multiple bits, and converting it to > an unsigned type if the

Re: GSoC 2016: Microproject

2016-02-22 Thread Duy Nguyen
On Mon, Feb 22, 2016 at 5:12 PM, Mehul Jain wrote: > On Mon, Feb 22, 2016 at 12:22 AM, Matthieu Moy > wrote: >> The simplest way to get back on track for you is probably to start over >> with a fresh clone, or (warning: destructive operations): use git clean >> to remove untracked files. > > Hell

Re: GSoC 2016: Microproject

2016-02-22 Thread Duy Nguyen
On Mon, Feb 22, 2016 at 5:30 PM, Mehul Jain wrote: > On Mon, Feb 22, 2016 at 3:50 PM, Duy Nguyen wrote: >> You may have an http server installed but not suitable for these >> tests. Try running one test file alone with -v -i, e.g. >> ./t5539-fetch-http-shallow.sh -v -

Re: [PATCH 3/3] Correct conditions to free textconv result data

2016-02-22 Thread Duy Nguyen
On Mon, Feb 22, 2016 at 7:52 PM, Nguyễn Thái Ngọc Duy wrote: > fill_textconv() have four code paths to return a new buffer. I forgot to add. Thanks to -Wwrite-strings pointing to '*outbuf = ""' line in this function. I wouldn't notice otherwise. -- Duy -- To unsubscribe from this list: send the

Re: [PATCH] diff: clarify textconv interface

2016-02-22 Thread Duy Nguyen
On Tue, Feb 23, 2016 at 1:28 AM, Jeff King wrote: > On Mon, Feb 22, 2016 at 01:06:45PM -0500, Jeff King wrote: > >> I have a feeling you were confused by the fact that fill_textconv() >> does: > > Looking over it, I agree this is a pretty confusing interface that grew > out of control over time.

Re: [PATCH 3/3] Correct conditions to free textconv result data

2016-02-22 Thread Duy Nguyen
On Tue, Feb 23, 2016 at 1:12 AM, Jeff King wrote: > On Mon, Feb 22, 2016 at 01:06:46PM -0500, Jeff King wrote: > >> Is there a case I'm missing here where we actually leak memory or try to >> free non-allocated memory? I didn't see it. > > By the way, I saw only patches 2/3 and 3/3 on the list. So

Re: Git Daemon Dummy: 301 Redirects for git:// to https://

2016-02-23 Thread Duy Nguyen
On Tue, Feb 23, 2016 at 1:15 PM, Jeff King wrote: > I looked into it once, but was unable to find any reasonably sized > explanation of how to implement either the server or client side of > websockets. :) Wikipedia explained handshake in four paragraphs. Then you only have to chew about ten page

Re: whither merge-tree?

2016-02-23 Thread Duy Nguyen
On Tue, Feb 23, 2016 at 7:36 PM, Johannes Schindelin wrote: > We could encourage more voices by issuing a warning when merge-tree is > called, e.g.: > > warning: merge-tree is unsupported (please contact > git@vger.kernel.org if you use it actively) Maybe motivate them to

Re: [PATCH] git config: do not create .git/ if it does not exist yet

2016-02-24 Thread Duy Nguyen
On Wed, Feb 24, 2016 at 3:26 PM, Jeff King wrote: > On Wed, Feb 24, 2016 at 08:47:00AM +0100, Johannes Schindelin wrote: > >> It is a pilot error to call `git config section.key value` outside of >> any Git worktree. >> >> Let's report that error instead of creating the .git/ directory and >> writ

Re: [PATCH v2] git config: report when trying to modify a non-existing repo config

2016-02-24 Thread Duy Nguyen
On Wed, Feb 24, 2016 at 01:48:11PM +0100, Johannes Schindelin wrote: > + die("not in a git directory"); Maybe wrap this string with _() for translation? Then we can pile this patch on top to fix the rest in builtin/config.c. -- 8< -- Subject: [PATCH] builtin/config.c: mark strings for

Re: [PATCH v2] git config: report when trying to modify a non-existing repo config

2016-02-24 Thread Duy Nguyen
On Wed, Feb 24, 2016 at 8:26 PM, Johannes Schindelin wrote: > Hi Duy, > > On Wed, 24 Feb 2016, Duy Nguyen wrote: > >> On Wed, Feb 24, 2016 at 01:48:11PM +0100, Johannes Schindelin wrote: >> > + die("not in a git directory"); >> >> Maybe w

Re: Rebase performance

2016-02-24 Thread Duy Nguyen
On Thu, Feb 25, 2016 at 5:09 AM, Christian Couder wrote: > Another possibility would be to libify the "git apply" functionality > and then to use the libified "git apply" in run_apply() instead of > launching a separate "git apply" process. One benefit from this is > that we could probably get rid

Re: using git-diff as a diff replacement?

2016-02-24 Thread Duy Nguyen
On Thu, Feb 25, 2016 at 5:21 AM, Jacob Keller wrote: > Hey, > > I know that running "git diff " when outside a git > project will result in a normal diff being run. I happen to prefer the > diff algorithm and diff output of "git diff" but there does not seem > to be a way to have this behavior fr

Re: Rebase performance

2016-02-24 Thread Duy Nguyen
On Thu, Feb 25, 2016 at 10:02 AM, Junio C Hamano wrote: > Duy Nguyen writes: > >> On Thu, Feb 25, 2016 at 5:09 AM, Christian Couder >> wrote: >>> Another possibility would be to libify the "git apply" functionality >>> and then to use the

Re: Rebase performance

2016-02-25 Thread Duy Nguyen
On Thu, Feb 25, 2016 at 7:50 AM, Duy Nguyen wrote: > On Thu, Feb 25, 2016 at 5:09 AM, Christian Couder > wrote: >> Another possibility would be to libify the "git apply" functionality >> and then to use the libified "git apply" in run_apply() instead

Re: [PATCH v5 25/27] refs: add LMDB refs storage backend

2016-02-25 Thread Duy Nguyen
On Thu, Feb 25, 2016 at 3:43 AM, David Turner wrote: >> > > > > I'm not sure I get this comment. D/F conflicts are no longer >> > > > > a >> > > > > thing >> > > > > for lmdb backend, right? >> > > > >> > > > I'm trying to avoid the lmdb backend creating a set of refs >> > > > that >> > > > the >>

Re: [PATCH v5 25/27] refs: add LMDB refs storage backend

2016-02-25 Thread Duy Nguyen
On Thu, Feb 25, 2016 at 3:37 AM, David Turner wrote: > On Sat, 2016-02-20 at 15:59 +0700, Duy Nguyen wrote: >> On Thu, Feb 18, 2016 at 12:17 PM, David Turner < >> dtur...@twopensource.com> wrote: >> > LMDB has a few features that make it suitable for usage in git: &

Re: [PATCH] unpack-trees: do not delete i-t-a entries in worktree even when forced

2016-02-25 Thread Duy Nguyen
On Thu, Feb 25, 2016 at 6:23 AM, Junio C Hamano wrote: > Thinking about it more, I have to say that I do not agree with the > basic premise of this patch. I-T-A is not "may want to commit, but > they are untracked" at all. It is "I know I want to add, I just > cannot yet decide the exact content

Re: [PATCH v6 00/32] refs backend

2016-02-25 Thread Duy Nguyen
A couple of build warnings I found, haven't really read the code yet. These two can easily be fixed refs/lmdb-backend.c: In function 'lmdb_read_raw_ref': refs/lmdb-backend.c:554:16: warning: unused variable 'err' [-Wunused-variable] struct strbuf err = STRBUF_INIT; ^ refs/lmdb-ba

Re: [PATCH v6 00/32] refs backend

2016-02-25 Thread Duy Nguyen
On Fri, Feb 26, 2016 at 2:27 AM, David Turner wrote: > but -Wshadow produces a ton of complaints on the rest of git's > code. We should probably fix those. I know, but what I wrote was meant for new code only (e.g. make refs/lmdb-backend.o CFLAGS=-Wshadow is clean). I think renaming the global

Re: [PATCH] strbuf_write: omit system call when length is zero

2016-02-25 Thread Duy Nguyen
On Fri, Feb 26, 2016 at 5:34 AM, Stefan Beller wrote: > In case the length of the buffer is zero, we do not need to call the > fwrite system call as a performance improvement. fwrite is a libc call, not system call. Are you sure it always calls write() (assuming buffering is off)? > > Signed-off

Re: Fwd: git clone does not respect command line options

2016-02-26 Thread Duy Nguyen
On Fri, Feb 26, 2016 at 3:24 PM, Jeff King wrote: > As an alternative, it would be nice to have some config syntax for > "clear the list". Maybe something like an empty string, which I think > has no meaning for the current multi-valued variables (at least not for > credential helpers or refspecs)

Re: [PATCH v2] add DEVELOPER makefile knob to check for acknowledged warnings

2016-02-26 Thread Duy Nguyen
On Thu, Feb 25, 2016 at 3:42 PM, wrote: > +ifdef DEVELOPER > + CFLAGS += -Werror \ > + -Wdeclaration-after-statement \ > + -Wno-format-zero-length \ > + -Wold-style-definition \ > +

Re: [PATCH v2] add DEVELOPER makefile knob to check for acknowledged warnings

2016-02-26 Thread Duy Nguyen
On Fri, Feb 26, 2016 at 4:30 PM, Lars Schneider wrote: > >> On 26 Feb 2016, at 10:26, Duy Nguyen wrote: >> >> On Thu, Feb 25, 2016 at 3:42 PM, wrote: >>> +ifdef DEVELOPER >>> + CFLAGS += -Werror \ >>> +

Re: [PATCH 0/2] recursive submodules: paths are hard

2016-02-26 Thread Duy Nguyen
On Sat, Feb 27, 2016 at 3:51 AM, Stefan Beller wrote: > I think we may need to enable Git to pass in 'negative' pathes for the prefix, > i.e. > Although operating on this repository, your reference for displaying paths > should be '../untracked' for the example above, when the submodule is in

Re: [PATCH/RFD 3/6] rev-list: list all heads with --all

2016-02-26 Thread Duy Nguyen
On Fri, Feb 26, 2016 at 11:39 PM, Michael J Gruber wrote: > HEAD is a worktree specific sysmref, so that a repository with multiple > worktrees can have multiple HEADs, or HEADs in a worktree different from > the current worktree. > > So far, "rev-parse --all" adds only the HEAD from the current w

Re: [PATCH 1/2] submodule: port resolve_relative_url from shell to C

2016-02-27 Thread Duy Nguyen
On Fri, Feb 12, 2016 at 03:39:15PM -0800, Stefan Beller wrote: > Later on we want to automatically call `git submodule init` from > other commands, such that the users don't have to initialize the > submodule themselves. As these other commands are written in C > already, we'd need the init functi

Re: [PATCHv4 2/2] submodule: port init from shell to C

2016-02-27 Thread Duy Nguyen
On Thu, Jan 28, 2016 at 9:30 AM, Stefan Beller wrote: > diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c > index 13583d9..689c354 100644 > --- a/builtin/submodule--helper.c > +++ b/builtin/submodule--helper.c > +static int module_init(int argc, const char **argv, const char *

Re: [PATCHv19 09/11] git submodule update: have a dedicated helper for cloning

2016-02-27 Thread Duy Nguyen
On Fri, Feb 26, 2016 at 6:48 AM, Stefan Beller wrote: > +static int prepare_to_clone_next_submodule(const struct cache_entry *ce, > + struct child_process *child, > + struct submodule_update_clone *suc, > +

Re: Trouble Cloning Git remote repository

2016-02-27 Thread Duy Nguyen
On Sat, Feb 27, 2016 at 6:03 AM, Fred's Personal wrote: > $ git clone -v ssh://user1@Host2/srv/centralrepo > Cloning into 'centralrepo'... Lines from $HOME/.bashrc > + export > PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games > :/usr/local/games > + > PATH=/usr/

Re: [PATCH 00/22] Mark more strings for translation

2016-02-27 Thread Duy Nguyen
On Sun, Feb 28, 2016 at 12:34 AM, Junio C Hamano wrote: > We'd still want the fixes to apply on top of relevant topics if we > could, as the fix to the topic itself (with or without i18n fixes), > when we discover that it has a huge flaw not desirable in v2.8.0, > might be to revert the whole thin

Re: [PATCH v2] add DEVELOPER makefile knob to check for acknowledged warnings

2016-02-28 Thread Duy Nguyen
On Sun, Feb 28, 2016 at 5:35 PM, Lars Schneider wrote: > On 26 Feb 2016, at 10:33, Duy Nguyen wrote: >> Probably misunderstanding. I meant something like this >> >> CFLAGS += -Werror >> CFLAGS += -Wdecl.. >> CFLAGS += -Wno-form.. > > Oh. I just realized th

Re: [PATCH 02/22] builtin/blame.c: mark strings for translation

2016-02-28 Thread Duy Nguyen
On Mon, Feb 29, 2016 at 1:57 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> Signed-off-by: Nguyễn Thái Ngọc Duy >> --- >> builtin/blame.c | 58 >> - >> 1 file changed, 29 insertions(+), 29 deletions(-) > > I think most of

Re: [RFC/PATCH] lockfile: improve error message when lockfile exists

2016-02-28 Thread Duy Nguyen
On Mon, Feb 29, 2016 at 3:11 AM, Matthieu Moy wrote: > diff --git a/lockfile.c b/lockfile.c > index 80d056d..a7d6175 100644 > --- a/lockfile.c > +++ b/lockfile.c > @@ -150,9 +150,11 @@ void unable_to_lock_message(const char *path, int err, > struct strbuf *buf) > { > if (err == EEXIST) {

Re: Trouble Cloning Git remote repository

2016-02-28 Thread Duy Nguyen
+ user1@Host2 git-upload-pack /srv/centralrepo > bash: user1@Host2: command not found > fatal: Could not read from remote repository. > > Please make sure you have the correct access rights > and the repository exists. > > > Regards, > Fred > > freddie...@optonli

Re: [PATCH v7 31/33] refs: add LMDB refs storage backend

2016-02-29 Thread Duy Nguyen
On Tue, Mar 1, 2016 at 7:53 AM, David Turner wrote: > +Weaknesses: > +--- > + > +The reflog format is somewhat inefficient: a binary format could store > +reflog date/time information in somewhat less space. This raises an interesting question. What if we want to change lmdb format in fut

Re: [PATCH v7 31/33] refs: add LMDB refs storage backend

2016-02-29 Thread Duy Nguyen
On Tue, Mar 1, 2016 at 8:35 AM, David Turner wrote: > On Tue, 2016-03-01 at 08:31 +0700, Duy Nguyen wrote: >> On Tue, Mar 1, 2016 at 7:53 AM, David Turner < >> dtur...@twopensource.com> wrote: >> > +Weaknesses: >> > +--- >> > + >>

Re: [PATCH v7 01/33] setup: call setup_git_directory_gently before accessing refs

2016-03-01 Thread Duy Nguyen
On Tue, Mar 1, 2016 at 3:35 PM, Jeff King wrote: > On Mon, Feb 29, 2016 at 07:52:34PM -0500, David Turner wrote: > >> Usually, git calls some form of setup_git_directory at startup. But >> sometimes, it doesn't. Usually, that's OK because it's not really >> using the repository. But in some cas

Re: [PATCH 14/22] refs/files-backend.c: mark strings for translation

2016-03-01 Thread Duy Nguyen
On Tue, Mar 1, 2016 at 1:43 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> Signed-off-by: Nguyễn Thái Ngọc Duy >> --- > > I'd really prefer to avoid any code churn on this file before the > dust settles for David's and Michael's series (the former is in > 'pu', the latter is not

Re: Resumable git clone?

2016-03-01 Thread Duy Nguyen
On Wed, Mar 2, 2016 at 8:30 AM, Josh Triplett wrote: > If you clone a repository, and the connection drops, the next attempt > will have to start from scratch. This can add significant time and > expense if you're on a low-bandwidth or metered connection trying to > clone something like Linux. >

Re: Resumable git clone?

2016-03-01 Thread Duy Nguyen
On Wed, Mar 2, 2016 at 1:31 PM, Junio C Hamano wrote: > Al Viro writes: > >> FWIW, I wasn't proposing to recreate the remaining bits of that _pack_; >> just do the normal pull with one addition: start with sending the list >> of sha1 of objects you are about to send and let the recepient reply >>

Re: Resumable git clone?

2016-03-01 Thread Duy Nguyen
On Wed, Mar 2, 2016 at 2:37 PM, Duy Nguyen wrote: >> So in order to salvage some transfer out of 2.4MB, the hypothetical >> Al protocol would first have the upload-pack give 20*1396 = 28kB > > It could be 10*1396 or less Oops somehow I read previous mails as client sends SH

Re: Resumable git clone?

2016-03-02 Thread Duy Nguyen
On Wed, Mar 2, 2016 at 9:30 AM, Al Viro wrote: > IIRC, the objection had been that the organisation of the pack will lead > to many cases when deltas are transferred *first*, with base object not > getting there prior to disconnect. I suspect that fraction of the objects > getting through would s

Re: Resumable git clone?

2016-03-02 Thread Duy Nguyen
On Wed, Mar 2, 2016 at 3:13 PM, Josh Triplett wrote: > On Wed, Mar 02, 2016 at 02:30:24AM +, Al Viro wrote: >> On Tue, Mar 01, 2016 at 05:40:28PM -0800, Stefan Beller wrote: >> >> > So throwing away half finished stuff while keeping the front load? >> >> Throw away the object that got truncate

Re: Resumable git clone?

2016-03-02 Thread Duy Nguyen
On Wed, Mar 2, 2016 at 3:31 PM, Junio C Hamano wrote: > Josh Triplett writes: > >> I don't think it's worth the trouble and ambiguity to send abbreviated >> object names over the wire. > > Yup. My unscientific experiment was to show that the list would be > far smaller than the actual transfer a

Re: [PATCH v2] builtin/receive-pack.c: use parse_options API

2016-03-02 Thread Duy Nguyen
On Wed, Mar 2, 2016 at 3:21 AM, Sidhant Sharma [:tk] wrote: > + struct option options[] = { > + OPT__QUIET(&quiet, N_("quiet")), > + OPT_HIDDEN_BOOL(0, "stateless-rpc", &stateless_rpc, NULL), > + OPT_HIDDEN_BOOL(0, "advertise-refs", &advertise_refs,

Re: "./t0001-init.sh --valgrind" is broken

2016-03-02 Thread Duy Nguyen
On Thu, Mar 3, 2016 at 7:07 AM, Christian Couder wrote: > Hi, > > It looks like commit 57ea7123c86771f47f34e7d92d1822d8b429897a (git.c: > make sure we do not leak GIT_* to alias scripts, Dec 20 14:50:19 2015) > broke "./t0001-init.sh --valgrind". Just wanted to confirm the problem. I will look at

Re: [PATCH v2 4/4] bundle v3: the beginning

2016-03-02 Thread Duy Nguyen
On Thu, Mar 3, 2016 at 3:32 AM, Junio C Hamano wrote: > - After arranging that packfile to be downloadable over popular >transfer methods used for serving static files (such as HTTP or >HTTPS) that are easily resumable as $URL/pack-$name.pack, a v3 >bundle file (call it $name.bndl) ca

Re: [PATCH v2 4/4] bundle v3: the beginning

2016-03-02 Thread Duy Nguyen
On Thu, Mar 3, 2016 at 9:57 AM, Junio C Hamano wrote: > Duy Nguyen writes: > >> would it be >> ok if we introduced a minimal resumable download service via >> git-daemon to enable this feature with very little setup? Like >> git-shell, you can only download certa

Re: "./t0001-init.sh --valgrind" is broken

2016-03-03 Thread Duy Nguyen
+the-other-Johannes who added valgrind support. On Thu, Mar 3, 2016 at 1:55 PM, Johannes Sixt wrote: > 8< > Subject: [PATCH] t0001: fix GIT_* environment variable check under --valgrind > > When a test case is run without --valgrind, the wrap-for-bin.sh > helper script inserts the envir

Re: "./t0001-init.sh --valgrind" is broken

2016-03-03 Thread Duy Nguyen
On Thu, Mar 3, 2016 at 7:09 PM, Duy Nguyen wrote: > But it's probably better that we inject valgrind command > from inside bin-wrappers script, the same way we inject gdb, I think. For the best of both worlds, we should recreate bin-wrappers in test-lib.sh (i.e. the valgrind w

Re: [PATCH 03/10] lazily load core.sharedrepository

2016-03-03 Thread Duy Nguyen
On Tue, Mar 1, 2016 at 9:39 PM, Jeff King wrote: > + if (need_shared_repository_from_config) { > + const char *var = "core.sharedrepository"; > + const char *value; > + if (!git_config_get_value(var, &value)) > + the_shared_repo

Re: [PATCH 04/10] check_repository_format_gently: stop using git_config_early

2016-03-03 Thread Duy Nguyen
On Tue, Mar 1, 2016 at 9:40 PM, Jeff King wrote: > There's a chicken-and-egg problem with using the regular > git_config during the repository setup process. We get > around it here by using a special interface that lets us > specify the per-repo config, and avoid calling > git_pathdup(). > > But

Re: [PATCH 06/10] setup: refactor repo format reading and verification

2016-03-03 Thread Duy Nguyen
On Tue, Mar 1, 2016 at 9:42 PM, Jeff King wrote: > - for (i = 0; i < unknown_extensions.nr; i++) > - warning("unknown repository extension: %s", > - unknown_extensions.items[i].string); > - *nongit_ok = -1; > -

Re: Change in .gitignore handling: intended or bug?

2016-03-03 Thread Duy Nguyen
On Fri, Mar 4, 2016 at 9:11 AM, Charles Strahan wrote: > Hello, > > I've found a change in the way .gitignore works, and I'm not sure if > it's a bug > or intended. Can't look into this just yet. Quick question, what's the git version you're currently running? -- Duy -- To unsubscribe from this

Re: Change in .gitignore handling: intended or bug?

2016-03-04 Thread Duy Nguyen
On Fri, Mar 4, 2016 at 6:56 PM, Kevin Daudt wrote: > Verified that it's different in 2.7.0, but 2.7.2 gives expected output. Thanks. 2.7.1 reverts the faulty commit from 2.7.0 that generated two other regression reports before this one. I guess it's all good then (except for the people still on 2

Re: Change in .gitignore handling: intended or bug?

2016-03-04 Thread Duy Nguyen
On Sat, Mar 5, 2016 at 12:28 AM, Junio C Hamano wrote: > Duy Nguyen writes: > >> On Fri, Mar 4, 2016 at 6:56 PM, Kevin Daudt wrote: >>> Verified that it's different in 2.7.0, but 2.7.2 gives expected output. >> >> Thanks. 2.7.1 reverts the faulty commit

Re: Change in .gitignore handling: intended or bug?

2016-03-04 Thread Duy Nguyen
typo fixes On Sat, Mar 5, 2016 at 7:43 AM, Duy Nguyen wrote: > On Sat, Mar 5, 2016 at 12:28 AM, Junio C Hamano wrote: >> Duy Nguyen writes: >> >>> On Fri, Mar 4, 2016 at 6:56 PM, Kevin Daudt wrote: >>>> Verified that it's different in 2.7.0, but 2.

Re: Resumable clone

2016-03-05 Thread Duy Nguyen
On Sat, Mar 5, 2016 at 4:23 PM, Kevin Wern wrote: > Hey, all, > > A while ago, I noticed that if a clone is interrupted, it has to be > restarted completely. When I looked up the issue, I saw that someone > suggested resumable clones as a feature as early as 2007. It doesn't > seem like any progr

Re: Resumable clone

2016-03-06 Thread Duy Nguyen
On Sun, Mar 6, 2016 at 2:59 PM, Johannes Schindelin wrote: > First of all: my main gripe with the discussed approach is that it uses > bundles. I know, I introduced bundles, but they just seem too klunky and > too static for the resumable clone feature. One thing Junio didn't mention in his summa

Re: Resumable clone

2016-03-06 Thread Duy Nguyen
On Sun, Mar 6, 2016 at 3:49 PM, Duy Nguyen wrote: > One thing Junio didn't mention in his summary is the use of pack > bitmap [1]. > > [1] http://thread.gmane.org/gmane.comp.version-control.git/288205/focus=288222 Oops, wrong link. Should be this one http://

Re: [BUG?] fetch into shallow sends a large number of objects

2016-03-07 Thread Duy Nguyen
On Tue, Mar 8, 2016 at 6:47 AM, Junio C Hamano wrote: > Jeff King writes: > >> I don't know how the client invoked git, but we can guess what happened >> and simulate with: >> >> git tag shallow ecd7ea6033fe8a05d5c21f3a54355fded6942659 >> git tag old 067f265bb512c95b22b83ccd121b9facbddcf6b1 >

Re: Change in .gitignore handling: intended or bug?

2016-03-08 Thread Duy Nguyen
On Tue, Mar 8, 2016 at 1:14 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> We need documentation update to settle this one before 2.8 final >> ships, as we seem to be seeing more and more end-user confusion on >> the list. I tried to come up with a trimmed-down example, which is >> show

Re: Resumable clone

2016-03-08 Thread Duy Nguyen
On Tue, Mar 8, 2016 at 10:33 AM, Kevin Wern wrote: > Hey Junio and Duy, > > Thank you for your thorough responses! I'm new to git dev, so it's > extremely helpful. > >> - The server side endpoint does not have to be, and I think it >> should not be, implemented as an extension to the current >> up

Re: [BUG?] fetch into shallow sends a large number of objects

2016-03-08 Thread Duy Nguyen
On Tue, Mar 8, 2016 at 7:14 PM, Jeff King wrote: > ... > > So I think the solution to both is that we need to do a _separate_ > traversal with all of the positive tips we're going to send, and the > parents of any shallow commits the client has, to find their fork points > (i.e., merge bases). And

Re: [BUG?] fetch into shallow sends a large number of objects

2016-03-08 Thread Duy Nguyen
On Tue, Mar 8, 2016 at 8:30 PM, Jeff King wrote: > On Tue, Mar 08, 2016 at 08:25:24AM -0500, Jeff King wrote: > >> > Good news. We have the mechanism in place, I think. >> > get_shallow_commits_by_rev_list() (from 'pu') will produce the right >> > shallow points for sending back to the client if y

Re: Change in .gitignore handling: intended or bug?

2016-03-08 Thread Duy Nguyen
On Wed, Mar 9, 2016 at 1:10 AM, Junio C Hamano wrote: > So what do we want to do for the upcoming release? I don't know. Befoire 2.8.0, all three matching cases are broken. With the current changes on 2.8.0, one case is fixed with the other cases broken. I guess it can create even more confusion.

<    3   4   5   6   7   8   9   10   11   12   >