[PATCH] http: cast result to FILE *

g standard functions that may ultimately be macros. Signed-off-by: Dan McGregor --- http.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/http.c b/http.c index 954bebf684..8b9476b151 100644 --- a/http.c +++ b/http.c @@ -1996,12 +1996,12 @@ static int http_request_reauth(const

Re: [PATCH] http: cast result to FILE *

On February 4, 2019 12:10:54 p.m. CST, Junio C Hamano wrote: >Duy Nguyen writes: > >>> The disadvantage, of course, would be that other call sites would >not >>> benefit from a manual auditing whether the argument has side effects >(and >>> thus, whether a macro using the argument multiple time

[PATCH v2] git-compat-util: undefine fileno if defined

fineo as a macro also have a function defined. Undefine the macro on these systems so that the function is used. Signed-off-by: Dan McGregor --- git-compat-util.h | 9 + 1 file changed, 9 insertions(+) diff --git a/git-compat-util.h b/git-compat-util.h index 29a19902aa..b5489bbcf2 100644

Re: [PATCH v2] git-compat-util: undefine fileno if defined

On February 12, 2019 7:45:37 a.m. CST, Duy Nguyen wrote: >On Fri, Feb 08, 2019 at 08:36:21PM -0600, Dan McGregor wrote: >> Commit 8dd2e88a92 ("http: support file handles for HTTP_KEEP_ERROR", >> 2019-01-10) introduced an implicit assumption that rewind, fileno, >and