Hi all,
I submitted a patch on 2019/4/23 with the title "[PATCH] status: add
an empty line when there is no hint". However, it didn't get any
review. Should I create an issue somewhere before submitting it? What
should I do to get my patch reviewed? Thanks.
Best,
John Lin
Hi Phil,
Thank you for the review! I will fix the test cases and submit a new
version of my patch.
Best,
John Lin
Phil Hord 於 2019年4月30日 週二 上午11:12寫道：
>
> You should probably add some test that demonstrates what your change
> intends to do. For that matter, though, your test already breaks at
Hi Phillip,
Phillip Wood 於 2019年4月30日 週二 下午7:15寫道：
>
> Hi John
>
> On 30/04/2019 07:02, John Lin wrote:
> > When typing "git status", there is an empty line between
> > the "Changes not staged for commit:" block and the list
> > of changed files.
>
> I'm a bit confused by this as you change a sta
Hi Brian,
brian m. carlson 於 2019年5月2日 週四 上午7:45寫道：
>
> On Tue, Apr 30, 2019 at 12:15:37PM +0100, Phillip Wood wrote:
> > Hi John
> >
> > On 30/04/2019 07:02, John Lin wrote:
> > > When typing "git status", there is an empty line between
> > > the "Changes not staged for commit:" block and the li
Hi Brian,
brian m. carlson 於 2019年5月3日 週五 上午7:15寫道：
>
> On Thu, May 02, 2019 at 08:35:23AM +0800, 林自均 wrote:
> > Thank you for the support! I'll be very happy if my patch can get into
> > the code base. Is there any improvement I can make for this patch?
>
> The pa
Hi Junio,
林自均 於 2019年5月3日 週五 下午12:15寫道：
>
> Hi Brian,
>
> brian m. carlson 於 2019年5月3日 週五 上午7:15寫道：
> >
> > On Thu, May 02, 2019 at 08:35:23AM +0800, 林自均 wrote:
> > > Thank you for the support! I'll be very happy if my patch can get into
> > > the
Hi Junio,
Junio C Hamano 於 2019年5月13日 週一 下午1:51寫道：
>
> 林自均 writes:
>
> > Hi Junio,
> >> ...
> > Could you please give me some advice on my patch? Thank you.
>
> I tend to agree with what Phillip said in
> .
>
> If the difference between &qu
Hi Junio,
Junio C Hamano 於 2019年5月14日 週二 下午3:33寫道：
>
> "brian m. carlson" writes:
>
> > On Mon, May 13, 2019 at 02:51:37PM +0900, Junio C Hamano wrote:
> >> If the difference between "status" and "commit" bothers you so much,
> >> i.e.
> >>
> >> When typing "git status", there is an empty li
Hi Junio,
Junio C Hamano 於 2019年5月15日 週三 上午8:48寫道：
>
> 林自均 writes:
>
> > I was not talking about the messages in the editor session. I was
> > talking about "git commit" without "git add" anything.
> >
> > For example:
> >
> >
Hi Junio,
林自均 於 2019年5月15日 週三 上午11:02寫道：
>
> Hi Junio,
>
> Junio C Hamano 於 2019年5月15日 週三 上午8:48寫道：
> >
> > 林自均 writes:
> >
> > > I was not talking about the messages in the editor session. I was
> > > talking about "git commit
Hi Junio,
John Lin via GitGitGadget 於 2019年5月15日 週三 下午6:54寫道：
>
> From: John Lin
>
> Before this patch, there is inconsistency between the status
> messages with hints and the ones without hints: there is an
> empty line between the title and the file list if hints are
> presented, but there isn
Hi Junio,
Junio C Hamano 於 2019年5月29日 週三 上午4:41寫道：
>
> 林自均 writes:
>
> > Hi Junio,
> >
> > John Lin via GitGitGadget 於 2019年5月15日 週三 下午6:54寫道：
> >>
> >> From: John Lin
> >>
> >> Before this patch, there is inconsistency between
Hi Johannes,
Johannes Schindelin 於 2019年5月29日 週三 下午7:51寫道：
>
> Hi John Lin,
>
> You could already rebase it on top of
> https://github.com/gitgitgadget/git/tree/nd/switch-and-restore, say so in
> your cover letter, and send a new iteration.
Thanks for the suggestion. I already rebase on your
nd/
i John Lin,
>
> On Sat, 1 Jun 2019, 林自均 wrote:
>
> > Johannes Schindelin 於 2019年5月29日 週三
> > 下午7:51寫道：
> > >
> > > You could already rebase it on top of
> > > https://github.com/gitgitgadget/git/tree/nd/switch-and-restore, say so in
> > > your
14 matches
Mail list logo
