The exit code of the upstream in a pipe is ignored thus we should avoid
using it. By writing out the output of the git command to a file, we can
test the exit codes of both the commands.
Signed-off-by: Boxuan Li
---
Thanks to Eric Sunshine's review, I've removed spaces after '>'
and changed 'actu
Thanks for replying. Do you know how the query you mentioned ("Do we have a
file named "file.txt" on disk?") is implemented in git?
I'd suggest to use the C++ Windows API function FindFirstFileW() and then
manually compare the result with the queried file name, like:
bool fileExists(const WCH
The documentation doesn't seem to be clear about which characters are allowed
as branch names.
We have been using umlauts and apostrophes in our branch names, and both are
having issues:
- apostrophe:
git removes the apostrophes from the branch name when creating/pushing a
branch.
In our T
In revisions.txt, an optional rev argument was not distinguised.
Instead, a user had to continue and read the description in order to
learn that the argument was optional.
Since the [] notation for an optional argument is common-knowledge in
the Git documentation, mark optional arguments with [] s
Thanks again for the comments, Andreas! I've incorporated all of them
into this reroll.
---
Changes since v2:
* Marked more optional arguments with []
* Added Andreas' "revisions.txt: remove ambibuity between :
and :" patch
Changes since v1:
* Added patch to fix instances of "rev" to ""
* Ma
In revisions.txt, there were some instances of a rev argument being
written as "rev". However, since they didn't mean the string literal,
write "", instead.
Signed-off-by: Denton Liu
---
Documentation/revisions.txt | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Docum
In revisions.txt, the '^' form is mentioned but the '~' form
is missing. Although both forms are essentially equivalent (they each
get the first parent of the specified revision), we should mention the
latter for completeness. Make this change.
Signed-off-by: Denton Liu
---
Documentation/revisio
From: Andreas Heiduk
The revision ':README' is mentioned as an example for ':'
but the explanation forwards to the '::' syntax. At the same
time '::' did not mark the ':' as optional.
Signed-off-by: Andreas Heiduk
Signed-off-by: Denton Liu
---
Just for clarification, the correct procedure is t
Sorry, I specified the wrong --in-reply-to. The correct parent message
should be this[1].
[1]: https://public-inbox.org/git/cover.1556367012.git.liu.den...@gmail.com/
On Sun, May 05, 2019 at 12:06:54PM -0400, Denton Liu wrote:
> Thanks again for the comments, Andreas! I've incorporated all of the
In Git's tests, there is typically no space between the redirection
operator and the filename. Remove these spaces.
Since output is silenced when running without `-v` and debugging
output is useful with `-v`, remove redirections to /dev/null.
Change here-docs from `<<\EOF` to `<<-\EOF` so that th
Currently, format-patch only accepts branch..description as a
branch-specific configuration variable. However, there are many other
options which would be useful to have on a branch-by-branch basis,
namely cover letter subject and To: and Cc: headers.
Teach format-patch to recognise these branch-s
If a user wishes to keep track of whom to Cc: on individual patchsets,
they must manually keep track of each recipient and fill it in with the
`--cc` option on git-format-patch each time. However, on the Git mailing
list, Cc:'s are typically never dropped. As a result, it would be nice
to have a me
In the future, we'll need to use `read_branch_config` as a generic base
for other branch-config reading functions. Extract it from
`read_branch_desc` so that it can be reused later.
Signed-off-by: Denton Liu
---
branch.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git
In git-format-patch.txt, we were missing some key user information.
First of all, using the `--to` and `--cc` options don't override
`format.to` and `format.cc` variables, respectively. They add on to each
other. Document this.
In addition, document the special value of `--base=auto`.
Finally, wh
In a future patch, we need to perform the addition of To: and Cc:
to extra_headers after the branch_name logic. Simply transpose this
logic later in the function so that this happens. (This patch is best
viewed with `git diff --color-moved`.)
Note that this logic only depends on the `git_config` a
In a future patch, we'll need to take one string_list and append it to
the end of another. Create the `string_list_append_all` function which
does this.
Signed-off-by: Denton Liu
---
string-list.c | 9 +
string-list.h | 7 +++
2 files changed, 16 insertions(+)
diff --git a/string-li
We used to populate the subject of the cover letter generated by
git-format-patch with "*** SUBJECT HERE ***". However, if a user submits
multiple patchsets, they may want to keep a consistent subject between
rerolls.
If git-format-patch is run on a branch that has
`branch..coverSubject` defined,
On Wednesday, 1 May 2019 22:35:45 CEST Jeff King wrote:
> On Wed, May 01, 2019 at 05:11:38PM +0700, Duy Nguyen wrote:
>
> > On Wed, May 1, 2019 at 1:10 AM Priscila Gutierres
> > wrote:
> > >
> > > Hi
> > > I want to contribute to git by creating and/or translating
> > > documentation. Where may I
On Sat, May 4, 2019 at 10:28 PM Junio C Hamano wrote:
>
> Jeff King writes:
>
> > I think spatch is smart enough not to hit the same header multiple
> > times. But the problem is that we invoke it once per file, so it
> > actually processes cache.h many times. That's slow, but also produces
> > b
On Fri, May 3, 2019 at 11:09 AM Jeff King wrote:
>
> On Fri, May 03, 2019 at 04:42:11PM +0200, SZEDER Gábor wrote:
>
> > > Since you *could* include it, I now assume that Coccinelle does not need
> > > to follow the `#include`s (otherwise, it would have complained about not
> > > finding the `wind
On Sun, May 05, 2019 at 12:27:31PM +0200, Ax Da wrote:
> The documentation doesn't seem to be clear about which characters are allowed
> as branch names.
>
> We have been using umlauts and apostrophes in our branch names, and both are
> having issues:
>
> - apostrophe:
> git removes the apost
Hi Everyone,
I have a PowerMac I use for testing. It provides several testing
differentiators, like OS X 10.5, Bash 3.2, GCC 4.0.1, Apple cc-tools
linker, and big-endian PowerPC. (I think Gentoo provides a Linux image
for the hardware, but I don't use it).
The Git libraries and programs build fin
Hi!
Reading the manual, I realized that "it is the way it is (it works as
documented)", but to me it's surprising, meaning: I feel it's wrong:
(git-2.16.4)
I have staged several files, and then I do "git add -interactive file" to add
some selected changes from file.
After that a "git diff --cach
Actually things are worse: When I tried to fix the comment for the unexpected
commit at least using "git commit --amend", more files were committed!
>>> Ulrich Windl 05.05.19 22.02 Uhr >>>
Hi!
Reading the manual, I realized that "it is the way it is (it works as
documented)", but to me it's sur
On Sun, May 05, 2019 at 03:42:45PM -0400, Jeffrey Walton wrote:
> I have a PowerMac I use for testing. It provides several testing
> differentiators, like OS X 10.5, Bash 3.2, GCC 4.0.1, Apple cc-tools
> linker, and big-endian PowerPC. (I think Gentoo provides a Linux image
> for the hardware, but
On Mai 05 2019, "Ulrich Windl" wrote:
> After that a "git diff --cached file" just shows the changes added
> interactively, but when I "git add file" to commit those changes), even the
> unstaged changes from file are committed.
Did you really mean "git add" here? It doesn't commit, it adds t
On Sun, May 5, 2019 at 3:43 PM Jeffrey Walton wrote:
> I have a PowerMac I use for testing. [...]
> make -C t/ all
> readline() on unopened filehandle test_must_fail
> run_sub_test_lib_test at check-non-portable-shell.pl line 34.
> Modification of a read-only value attempted at
> check-non-
--
Dear Friend,
Greetings and how are you today?
I'm sorry if this message is found in the spam of your email box as
that will certainly be a network mishap and I want us to discuss
about the sum of Forty Million Dollars discovered in my office and
I'll give you more details when I hear from
Name: 办#發#票#,微-电/微：134﹣1861,89,58，张
Email: git@vger.kernel.org
Comments: 办#發#票#,微-电/微：134﹣1861,89,58，张
On Sun, May 5, 2019 at 11:16 AM brian m. carlson
wrote:
>
> On Sun, May 05, 2019 at 12:27:31PM +0200, Ax Da wrote:
> > The documentation doesn't seem to be clear about which characters are
> > allowed as branch names.
> >
> > We have been using umlauts and apostrophes in our branch names, and bot
On Sun, May 05, 2019 at 02:25:59PM +0900, Junio C Hamano wrote:
> Jeff King writes:
>
> > FWIW, I agree with you here. These patches are not making anything worse
> > (and may even make them better, since we'd probably need to swap out the
> > BLOCKSIZE constant for a run-time "blocksize" variab
On Sun, May 05, 2019 at 11:08:35AM -0700, Jacob Keller wrote:
> > Jacob Keller's patches to collapse this to a single invocation do fix it
> > (and I've used them selectively in the past rather than cleaning up the
> > resulting patch manually ;) ).
> >
> > Sort of tangential to your point, I gues
32 matches
Mail list logo
