[GSOC]:query regarding microproject

I am planning to do a microproject on using unsigned integral type for collection of bits.If anyone else has not taken it up,I would like to work on it.

How to determine the order of commit

Hi, Suppose I have "git format-patch" two commit from a repository like following: git format-patch -1 cf1c9ccba730 git format-patch -1 d1a2930d8a99 Now, how to determine the commit order of these two patch in repository?

[PATCH] doc/rebase: extend examples to show continuing branches

Currently, all of the examples for "man git-rebase" show rebasing from a branch that has had no further development, which might mislead readers into thinking that that is a necessary condition for rebasing, so tweak the examples to show further development on such a branch to clarify that. Sign

Re: GSoC 2019: Git's application submitted

On Mon, Feb 4, 2019 at 4:17 PM Christian Couder wrote: > > Hi everyone, > > There are now ideas, micro-projects and organization application pages > for GSoC 2019 on https://git.github.io/ > > It would be nice to have a few more project ideas. Not sure if it's too late now. Anyway this could be s

[PATCH v4 0/2] worktree add: sanitize worktree names

v4 refactors check_refname_component() so that we could do more accurate substitution (and leave fewer traps). Performance of sanitize_worktree_refname() goes back to horrible again. But since it's not really a big deal (no body is going to add 200 worktrees per second), I don't feel like we shoul

[PATCH v4 1/2] refs.c: refactor check_refname_component()

The core logic of this function is factored out to provide more information when the refname is invalid: what part that is and exact what is wrong with it. This will be useful for a coming function that has to turn a string into a valid refname component. Signed-off-by: Nguyễn Thái Ngọc Duy ---

[PATCH v4 2/2] worktree add: sanitize worktree names

Worktree names are based on $(basename $GIT_WORK_TREE). They aren't significant until 3a3b9d8cde (refs: new ref types to make per-worktree refs visible to all worktrees - 2018-10-21), where worktree name could be part of a refname and must follow refname rules. Update 'worktree add' code to remove

Re: GSoC 2019: Git's application submitted

On Tue, Mar 5, 2019 at 7:04 PM Duy Nguyen wrote: > Not sure if it's too late now. Anyway this could be something fun to > do: support C-based tests in our test suite. > > ... > > I'm pretty sure I had some fun with this idea and made some prototype > but I couldn't find it. If I do, I'll post the

[PATCH 07/20] diff-parseopt: convert --full-index

Signed-off-by: Nguyễn Thái Ngọc Duy --- diff.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/diff.c b/diff.c index 214728c892..3a13ba37fd 100644 --- a/diff.c +++ b/diff.c @@ -5131,6 +5131,8 @@ static void prep_parse_options(struct diff_options *options)

[PATCH 06/20] diff-parseopt: convert --binary

Signed-off-by: Nguyễn Thái Ngọc Duy --- Documentation/diff-options.txt | 2 +- diff.c | 21 - 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt index 915f2fec8b..6810c94fea 1

[PATCH 02/20] diff-parseopt: convert --patience

Signed-off-by: Nguyễn Thái Ngọc Duy --- diff.c | 37 + 1 file changed, 25 insertions(+), 12 deletions(-) diff --git a/diff.c b/diff.c index c4cd84f1b3..7899c7cc06 100644 --- a/diff.c +++ b/diff.c @@ -4960,6 +4960,26 @@ static enum parse_opt_result diff_opt_out

[PATCH 04/20] diff-parseopt: convert --diff-algorithm

Signed-off-by: Nguyễn Thái Ngọc Duy --- diff.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/diff.c b/diff.c index 7432702fd8..8d08795f9c 100644 --- a/diff.c +++ b/diff.c @@ -4891,6 +4891,24 @@ static int diff_opt_compact_summary(const str

[PATCH 00/20] nd/diff-parseopt part 3

The next part of nd/diff-parseopt to continue converting more diff options to parseopt. Based on nd/diff-parseopt-2. Part 4 will hopefully finish the diff.c part and we'll move on to 4-5 more parts on revision.c. Nguyễn Thái Ngọc Duy (20): diff-parseopt: convert --[no-]indent-heuristic diff-p

[PATCH 01/20] diff-parseopt: convert --[no-]indent-heuristic

Signed-off-by: Nguyễn Thái Ngọc Duy --- diff.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/diff.c b/diff.c index a63ee4a44d..c4cd84f1b3 100644 --- a/diff.c +++ b/diff.c @@ -5124,6 +5124,9 @@ static void prep_parse_options(struct diff_options *options)

[PATCH 05/20] diff-parseopt: convert --anchored

Signed-off-by: Nguyễn Thái Ngọc Duy --- diff.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/diff.c b/diff.c index 8d08795f9c..5195526db9 100644 --- a/diff.c +++ b/diff.c @@ -4839,6 +4839,19 @@ static int parse_objfind_opt(struct diff_options *opt

[PATCH 03/20] diff-parseopt: convert --histogram

Signed-off-by: Nguyễn Thái Ngọc Duy --- diff.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/diff.c b/diff.c index 7899c7cc06..7432702fd8 100644 --- a/diff.c +++ b/diff.c @@ -5151,6 +5151,9 @@ static void prep_parse_options(struct diff_options *options)

[PATCH 09/20] diff-parseopt: convert -R

Signed-off-by: Nguyễn Thái Ngọc Duy --- diff.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/diff.c b/diff.c index 51d22f63fa..689dc11684 100644 --- a/diff.c +++ b/diff.c @@ -5216,6 +5216,8 @@ static void prep_parse_options(struct diff_options *options)

[PATCH 08/20] diff-parseopt: convert -a|--text

Signed-off-by: Nguyễn Thái Ngọc Duy --- diff.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/diff.c b/diff.c index 3a13ba37fd..51d22f63fa 100644 --- a/diff.c +++ b/diff.c @@ -5214,6 +5214,8 @@ static void prep_parse_options(struct diff_options *options)

[PATCH 14/20] diff-parseopt: convert --color-words

Signed-off-by: Nguyễn Thái Ngọc Duy --- diff.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/diff.c b/diff.c index 634981723b..5180c2f5a9 100644 --- a/diff.c +++ b/diff.c @@ -4901,6 +4901,18 @@ static int diff_opt_char(const struct option *opt,

[PATCH 10/20] diff-parseopt: convert --[no-]follow

Signed-off-by: Nguyễn Thái Ngọc Duy --- diff.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/diff.c b/diff.c index 689dc11684..ad813ea418 100644 --- a/diff.c +++ b/diff.c @@ -4986,6 +4986,21 @@ static int diff_opt_find_renames(const struct option

[PATCH 13/20] diff-parseopt: convert --word-diff-regex

Signed-off-by: Nguyễn Thái Ngọc Duy --- diff.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/diff.c b/diff.c index 14c057f3df..634981723b 100644 --- a/diff.c +++ b/diff.c @@ -5092,6 +5092,18 @@ static int diff_opt_word_diff(const struct option *opt,

[PATCH 11/20] diff-parseopt: convert --[no-]color

Signed-off-by: Nguyễn Thái Ngọc Duy --- diff.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/diff.c b/diff.c index ad813ea418..bb36d507ec 100644 --- a/diff.c +++ b/diff.c @@ -5148,6 +5148,8 @@ static void prep_parse_options(struct diff_options *options)

[PATCH 12/20] diff-parseopt: convert --word-diff

Signed-off-by: Nguyễn Thái Ngọc Duy --- diff.c | 47 +-- 1 file changed, 29 insertions(+), 18 deletions(-) diff --git a/diff.c b/diff.c index bb36d507ec..14c057f3df 100644 --- a/diff.c +++ b/diff.c @@ -5066,6 +5066,32 @@ static int diff_opt_unified(con

[PATCH 15/20] diff-parseopt: convert --exit-code

Signed-off-by: Nguyễn Thái Ngọc Duy --- diff.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/diff.c b/diff.c index 5180c2f5a9..3f80e06de5 100644 --- a/diff.c +++ b/diff.c @@ -5297,6 +5297,8 @@ static void prep_parse_options(struct diff_options *options)

[PATCH 18/20] diff-parseopt: convert --textconv

Signed-off-by: Nguyễn Thái Ngọc Duy --- diff.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/diff.c b/diff.c index b460fa010b..a27bca527d 100644 --- a/diff.c +++ b/diff.c @@ -5062,6 +5062,21 @@ static int diff_opt_relative(const struct option *opt,

[PATCH 17/20] diff-parseopt: convert --ext-diff

Signed-off-by: Nguyễn Thái Ngọc Duy --- diff.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/diff.c b/diff.c index bd15269346..b460fa010b 100644 --- a/diff.c +++ b/diff.c @@ -5301,6 +5301,8 @@ static void prep_parse_options(struct diff_options *options)

[PATCH 16/20] diff-parseopt: convert --quiet

Signed-off-by: Nguyễn Thái Ngọc Duy --- diff.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/diff.c b/diff.c index 3f80e06de5..bd15269346 100644 --- a/diff.c +++ b/diff.c @@ -5299,6 +5299,8 @@ static void prep_parse_options(struct diff_options *options)

[PATCH 20/20] diff-parseopt: convert --submodule

Signed-off-by: Nguyễn Thái Ngọc Duy --- diff.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/diff.c b/diff.c index 6fd6106963..ce118bb326 100644 --- a/diff.c +++ b/diff.c @@ -4721,14 +4721,6 @@ static int parse_dirstat_opt(struct diff_options

[PATCH 19/20] diff-parseopt: convert --ignore-submodules

Signed-off-by: Nguyễn Thái Ngọc Duy --- diff.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/diff.c b/diff.c index a27bca527d..6fd6106963 100644 --- a/diff.c +++ b/diff.c @@ -5013,6 +5013,19 @@ static int diff_opt_follow(const struct option *opt,

Re: How to determine the order of commit

Hi, On Tue, Mar 5, 2019 at 10:00 AM wuzhouhui wrote: > > Suppose I have "git format-patch" two commit from a repository like > following: > > git format-patch -1 cf1c9ccba730 > git format-patch -1 d1a2930d8a99 > > Now, how to determine the commit order of these two patch in repository? Do yo

Re: [GSoC][PATCH v3 1/3] test functions: add function `test_file_not_empty`

Eric Sunshine writes: >> +test_file_not_empty () { >> + if ! test -s "$1" >> + then >> + echo "'$1' is not a non-empty file." > > Although not incorrect, the double-negative is hard to digest. I had > to read it a few times to convince myself that it matched the intent >

Re: [GSoC][PATCH v3 2/3] t3600: modernize style

Eric Sunshine writes: > This test is unusual in that it first cd's into a subdirectory and > then cd's back out with "cd ..". And, while the use of subshells is > correct to ensure that all 'cd' commands are undone at the end of the > test (whether successful or not), the entire construction is >

Re: Questions on GSoC 2019 Ideas

On Tue, Mar 5, 2019 at 11:51 AM Jeff King wrote: > > processing power from multiple cores, but about _not_ blocking. I > > think one example use case here is parallel checkout. While one thread > > is blocked by pack access code for whatever reason, the others can > > still continue doing other st

Re: worth enhancing "man git-rebase" to show non-HEAD examples?

"Robert P. J. Day" writes: > one of the things i've noticed about the examples in "man > git-rebase" is that they invariably show rebasing relative to a > branch point that has not moved. for example, there's this example: > >o---o---o---o---o master > \ > o---

Re: worth enhancing "man git-rebase" to show non-HEAD examples?

On Tue, 5 Mar 2019, Junio C Hamano wrote: > "Robert P. J. Day" writes: > > > one of the things i've noticed about the examples in "man > > git-rebase" is that they invariably show rebasing relative to a > > branch point that has not moved. for example, there's this example: > > > >o---o

Re: How to determine the order of commit

> On Mar 5, 2019, at 8:39 PM, Christian Couder > wrote: > > Hi, > > On Tue, Mar 5, 2019 at 10:00 AM wuzhouhui > wrote: >> >> Suppose I have "git format-patch" two commit from a repository like >> following: >> >> git format-patch -1 cf1c9ccba730 >> git format-patch -1 d1a2930d8a99 >> >

Re: [RFC PATCH 0/4] Add alias option to git branch

Kenneth Cochran writes: > From c1bad54b29ae1c1d8548d248f6ecaa5959e55f7b Mon Sep 17 00:00:00 2001 > From: Kenneth Cochran > Date: Mon, 4 Mar 2019 09:40:22 -0600 > Subject: [RFC PATCH 0/4] Add alias option to git branch > Cc: Sahil Dua , > Duy Nguyen , > Jeff King Avoid using these in-bo

Re: [GSoc][PATCH v3 1/3] test functions: add function `test_file_not_empty`

Hello Eric On 2019-03-04 19:17:50 -0500 Eric Sunshine wrote: > On Mon, Mar 4, 2019 at 7:08 AM Rohit Ashiwal > wrote: > > if ! test -s "$1" > > then > > echo "'$1' is not a non-empty file." > > Although not incorrect, the double-negative is hard to digest. I had > to read it a few times to c

Re: [PATCH] rev-list: allow cached objects in existence check

Jeff King writes: > This fixes a regression in 7c0fe330d5 (rev-list: handle missing tree > objects properly, 2018-10-05) where rev-list will now complain about the > empty tree when it doesn't physically exist on disk. > > Before that commit, we relied on the traversal code in list-objects.c to >

Re: [PATCH] rev-list: allow cached objects in existence check

Jeff King writes: >> Or teach git-blame to have its own pretend mechanism, and remove the >> pretend mechanism from sha1-file.c. > > I think that would be ideal, but I'm not sure if it's feasible due to > the layering of the various modules. Sorry, but I do not get why we want command-line speci

Re: [GSoC][PATCH v3 3/3] t3600: use helpers to replace test -d/f/e/s

Hey Eric On 2019-03-05 0:42 Eric Sunshine wrote: > As with the commit message of 2/3, many of the words in this message > are separated by multiple spaced. Please fold out the excess so there > is only a single space between words. > > Also, no need to say "previously" since readers know that the

Re: How to determine the order of commit

Christian Couder writes: > Hi, > > On Tue, Mar 5, 2019 at 10:00 AM wuzhouhui > wrote: >> >> Suppose I have "git format-patch" two commit from a repository like >> following: >> >> git format-patch -1 cf1c9ccba730 >> git format-patch -1 d1a2930d8a99 >> >> Now, how to determine the commit ord

Re: [GSoC][PATCH v3 3/3] t3600: use helpers to replace test -d/f/e/s

On Tue, Mar 5, 2019 at 8:43 AM Rohit Ashiwal wrote: > On 2019-03-05 0:42 Eric Sunshine wrote: > > As with the commit message of 2/3, many of the words in this message > > are separated by multiple spaced. Please fold out the excess so there > > is only a single space between words. > > > > Also,

Re: [PATCH] doc/rebase: extend examples to show continuing branches

"Robert P. J. Day" writes: > Currently, all of the examples for "man git-rebase" show rebasing from > a branch that has had no further development, which might mislead > readers into thinking that that is a necessary condition for rebasing, > so tweak the examples to show further development on s

Re: [PATCH] doc/rebase: extend examples to show continuing branches

On Tue, 5 Mar 2019, Junio C Hamano wrote: > "Robert P. J. Day" writes: > > > Currently, all of the examples for "man git-rebase" show rebasing from > > a branch that has had no further development, which might mislead > > readers into thinking that that is a necessary condition for rebasing, > >

Re: [GSoC][PATCH v2 3/3] t3600: use helpers to replace test -d/f/e/s

Eric I was asking if this patch is good enough to be added to the existing code? Does this patch look good? Regards Rohit

Re: [GSoC][PATCH v2 3/3] t3600: use helpers to replace test -d/f/e/s

On Tue, Mar 5, 2019 at 9:22 AM Rohit Ashiwal wrote: > I was asking if this patch is good enough to be added to the > existing code? Does this patch look good? I didn't review the patch with a critical-enough eye to be able to say that every change maintains fidelity with the original code. As men

Re: [PATCH 1/1] Makefile: use `git ls-files` to list header files, if possible

Hi Junio, On Tue, 5 Mar 2019, Junio C Hamano wrote: > Jeff King writes: > > > This makes sense to me, though as you noted elsewhere, it doesn't fix > > the gcrypt problem, since that file unconditionally wants to look at the > > system gcrypt.h (and we control at the Makefile level whether we >

Re: [PATCH 16/20] diff-parseopt: convert --quiet

On Tue, Mar 5, 2019 at 7:32 AM Nguyễn Thái Ngọc Duy wrote: > diff --git a/diff.c b/diff.c > @@ -5299,6 +5299,8 @@ static void prep_parse_options(struct diff_options > *options) > + OPT_BOOL(0, "quiet", &options->flags.quick, > +N_("disable all output of the p

[PATCH v4] commit-tree: utilize parse-options api

Rather than parse options manually, which is both difficult to read and error prone, parse options supplied to commit-tree using the parse-options api. It was discovered that the --no-gpg-sign option was documented but not implemented in commit 70ddbd7767 (commit-tree: add missing --gpg-sign flag,

Re: [PATCH] builtin/config.c: don't print a newline with --color

Hi Peff, On Sun, 3 Mar 2019, Jeff King wrote: > On Sat, Mar 02, 2019 at 09:25:28PM +0100, Johannes Schindelin wrote: > > > > This bug has survived because there was never a test that would have > > > caught it. The old test used 'test_decode_color', which checks that its > > > input begins with

Re: [RFC PATCH 0/4] Add alias option to git branch

On Tue, Mar 5, 2019 at 7:21 AM Junio C Hamano wrote: > > Kenneth Cochran writes: > > > From c1bad54b29ae1c1d8548d248f6ecaa5959e55f7b Mon Sep 17 00:00:00 2001 > > From: Kenneth Cochran > > Date: Mon, 4 Mar 2019 09:40:22 -0600 > > Subject: [RFC PATCH 0/4] Add alias option to git branch > > Cc: Sah

Re: Can't build first git commit

Thank you Jeff I'll have news within few days!!! Il giorno lun, 04/03/2019 alle 15.40 -0500, Jeff King ha scritto: > On Mon, Mar 04, 2019 at 08:58:37PM +0100, Fabio Aiuto wrote: > > > I'm trying to build first commit of git made by Linus. I mean the > > one > > named e83c5163316f89bfbde7d9ab23..

[PATCH] git-reset.txt: clarify documentation

git-reset.txt contained a missing "a" and "wrt". Fix the missing "a" for correctness and replace "wrt" with "with respect to" so that the documentation is not so cryptic. Signed-off-by: Denton Liu --- Documentation/git-reset.txt | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) d

Re: Can't build first git commit

On Mon, Mar 04, 2019 at 03:40:07PM -0500, Jeff King wrote: > You can patch the Makefile, or just override it like: > > make LIBS='-lcrypto -lz' > > which builds for me on current Debian unstable. I don't think you can > actually fetch with that old build, but I used periodically check that > G

[PATCH v8 04/18] sequencer: refactor transform_todos() to work on a todo_list

This refactors transform_todos() to work on a todo_list. The function is renamed todo_list_transform(). As rebase -p still need to check the todo list from the disk, a new function is introduced, transform_todo_file(). It is still used by complete_action() and edit_todo_list() for now, but they

[PATCH v8 01/18] sequencer: changes in parse_insn_buffer()

This clears the number of items of a todo_list before parsing it to allow to parse the same list multiple times without issues. As its items are not dynamically allocated, or don’t need to allocate memory, no additionnal memory management is required here. Furthermore, if a line is invalid, the t

[PATCH v8 02/18] sequencer: make the todo_list structure public

This makes the structures todo_list and todo_item, and the functions todo_list_release() and parse_insn_buffer(), accessible outside of sequencer.c. Signed-off-by: Alban Gruin --- No changes since v7. sequencer.c | 69 ++--- sequencer.h | 50 +

[PATCH v8 09/18] sequencer: make sequencer_make_script() write its script to a strbuf

This makes sequencer_make_script() write its script to a strbuf (ie. the buffer of a todo_list) instead of a FILE. This reduce the amount of read/write made by rebase interactive. Signed-off-by: Alban Gruin --- No changes since v7. builtin/rebase--interactive.c | 13 ++- sequencer.c

[PATCH v8 00/18] sequencer: refactor functions working on a todo_list

At the center of the "interactive" part of the interactive rebase lies the todo list. When the user starts an interactive rebase, a todo list is generated, presented to the user (who then edits it using a text editor), read back, and then is checked and processed before the actual rebase takes pla

[PATCH v8 03/18] sequencer: remove the 'arg' field from todo_item

The 'arg' field of todo_item used to store the address of the first byte of the parameter of a command in a todo list. It was associated with the length of the parameter (the 'arg_len' field). This replaces the 'arg' field by 'arg_offset'. This new field does not store the address of the paramet

[PATCH v8 05/18] sequencer: introduce todo_list_write_to_file()

This introduces a new function to recreate the text of a todo list from its commands and write it to a file. This will be useful as the next few commits will change the use of the buffer in struct todo_list so it will no longer be a mirror of the file on disk. This functionality already exists in

[PATCH v8 07/18] sequencer: refactor sequencer_add_exec_commands() to work on a todo_list

This refactors sequencer_add_exec_commands() to work on a todo_list to avoid redundant reads and writes to the disk. Instead of inserting the `exec' commands between the other commands and re-parsing the buffer at the end, they are appended to the buffer once, and a new list of items is created.

[PATCH v8 06/18] sequencer: refactor check_todo_list() to work on a todo_list

This refactors check_todo_list() to work on a todo_list to avoid redundant reads and writes to the disk. The function is renamed todo_list_check(). The parsing of the two todo lists is left to the caller. As rebase -p still need to check the todo list from the disk, a new function is introduced,

[PATCH v8 08/18] sequencer: refactor rearrange_squash() to work on a todo_list

This refactors rearrange_squash() to work on a todo_list to avoid redundant reads and writes. The function is renamed todo_list_rearrange_squash(). The old version created a new buffer, which was directly written to the disk. This new version creates a new item list by just copying items from th

[PATCH v8 13/18] sequencer: refactor skip_unnecessary_picks() to work on a todo_list

This refactors skip_unnecessary_picks() to work on a todo_list. As this function is only called by complete_action() (and thus is not used by rebase -p), the file-handling logic is completely dropped here. Instead of truncating the todo list’s buffer, the items are moved to the beginning of the l

[PATCH v8 17/18] sequencer: use edit_todo_list() in complete_action()

This changes complete_action() to use edit_todo_list(), now that it can handle the initial edit of the todo list. Signed-off-by: Alban Gruin --- No changes since v7. sequencer.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/sequencer.c b/sequencer.c

[PATCH v8 11/18] rebase--interactive: move sequencer_add_exec_commands()

As sequencer_add_exec_commands() is only needed inside of rebase--interactive.c for `rebase -p', it is moved there from sequencer.c. The parameter r (repository) is dropped along the way. Signed-off-by: Alban Gruin --- New commit, but was a part of "rebase--interactive: move several functions to

[PATCH v8 18/18] rebase--interactive: move transform_todo_file()

As transform_todo_file() is only needed inside of rebase--interactive.c for `rebase -p', it is moved there from sequencer.c. The parameter r (repository) is dropped along the way. Signed-off-by: Alban Gruin --- New commit, but was a part of "rebase--interactive: move several functions to rebase-

[PATCH v8 12/18] rebase--interactive: move rearrange_squash_in_todo_file()

As rearrange_squash_in_todo_file() is only needed inside of rebase--interactive.c for `rebase -p', it is moved there from sequencer.c. The parameter r (repository) is dropped along the way, and the error handling is slightly improved. Signed-off-by: Alban Gruin --- New commit, but was a part of

[PATCH v8 10/18] sequencer: change complete_action() to use the refactored functions

complete_action() used functions that read the todo-list file, made some changes to it, and wrote it back to the disk. The previous commits were dedicated to separate the part that deals with the file from the actual logic of these functions. Now that this is done, we can call directly the "logic

[PATCH v8 14/18] rebase-interactive: use todo_list_write_to_file() in edit_todo_list()

Just like complete_action(), edit_todo_list() used a function (transform_todo_file()) that read the todo list from the disk and wrote it back, resulting in useless disk accesses. This changes edit_todo_list() to call directly todo_list_write_to_file() instead. Signed-off-by: Alban Gruin --- No c

[PATCH v8 16/18] rebase-interactive: rewrite edit_todo_list() to handle the initial edit

edit_todo_list() is changed to work on a todo_list, and to handle the initial edition of the todo list (ie. making a backup of the todo list). It does not check for dropped commits yet, as todo_list_check() does not take the commits that have already been processed by the rebase (ie. the todo list

[PATCH v8 15/18] rebase-interactive: append_todo_help() changes

This moves the writing of the comment "Rebase $shortrevisions onto $shortonto ($command_count commands)" from todo_list_write_to_file() to append_todo_help(). shortrevisions, shortonto, and command_count are passed as parameters to append_todo_help(). During the initial edit of the todo list, sho

Re: [PATCH] rev-list: allow cached objects in existence check

On Tue, Mar 05, 2019 at 10:33:13PM +0900, Junio C Hamano wrote: > Jeff King writes: > > >> Or teach git-blame to have its own pretend mechanism, and remove the > >> pretend mechanism from sha1-file.c. > > > > I think that would be ideal, but I'm not sure if it's feasible due to > > the layering

Re: [GSOC]:query regarding microproject

Hi, On 03/05, Sushma Unnibhavi wrote: > I am planning to do a microproject on using unsigned integral type > for collection of bits.If anyone else has not taken it up,I would > like to work on it. Welcome to the Git project! We generally do not assign micro-projects to someone in particular. If

[PATCH] Doc: fix misleading asciidoc formating

The end of sentence in "x." at the begining of a line misleads ascidoctor into interpreting it as the start of numbered sub-list. Signed-off-by: Jean-Noël Avila --- Documentation/technical/directory-rename-detection.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Docu

Re: [PATCH 1/1] Makefile: use `git ls-files` to list header files, if possible

Johannes Schindelin writes: >> After a normal build, with dynamic dependency checking on, we would >> have sufficient information to figure it out. Would that help? > > Yes, *if* the dynamic dependency checking is in effect (read: if we are > compiling with GCC). > > However, I think that one of

Re: [PATCH] git-reset.txt: clarify documentation

Denton Liu writes: > git-reset.txt contained a missing "a" and "wrt". Fix the missing "a" for > correctness and replace "wrt" with "with respect to" so that the > documentation is not so cryptic. Could you try again without unrelated reflowing of the text? Thanks. > > Signed-off-by: Denton Liu

Re: [PATCH] Doc: fix misleading asciidoc formating

On Tue, Mar 05, 2019 at 10:44:23PM +0100, Jean-Noël Avila wrote: > The end of sentence in "x." at the begining of a line misleads > ascidoctor into interpreting it as the start of numbered sub-list. Because I'd been wanting to play with doc-diff and asciidoctor, I tried looking at the rendered di

Re: [PATCH] git-reset.txt: clarify documentation

Hi Junio, On Wed, Mar 06, 2019 at 07:30:40AM +0900, Junio C Hamano wrote: > Denton Liu writes: > > > git-reset.txt contained a missing "a" and "wrt". Fix the missing "a" for > > correctness and replace "wrt" with "with respect to" so that the > > documentation is not so cryptic. > > Could you t

Re: [PATCH] Doc: fix misleading asciidoc formating

Jean-Noël Avila writes: > The end of sentence in "x." at the begining of a line misleads > ascidoctor into interpreting it as the start of numbered sub-list. Wow. That's tricky. One thing that makes me wonder is how you found it, as I do not think this file is part of the set of Documentation/

Re: [PATCH] git-reset.txt: clarify documentation

Denton Liu writes: > Should reflowing the text be done in a separate patch or should it just > not be done at all and just be considered noise? Of course when the rewrite is so extensive that the two versions of the whole paragraph needs to be carefully read and compared to judge if the change i

Re: [PATCH] Doc: fix misleading asciidoc formating

Jeff King writes: > Did you notice this when building locally, or on the asciidoctor-built > pages at git-scm.com? Does git-scm.com even have this file rendered? I do not think we glob for technical/*.txt in any of our Makefiles; instead we have a list of ready-to-be-consumed TECH_DOCS listed e

Re: [PATCH 1/1] curl: anonymize URLs in error messages and warnings

Hi Peff, On Tue, 5 Mar 2019, Jeff King wrote: > On Mon, Mar 04, 2019 at 07:33:46AM -0800, Johannes Schindelin via > GitGitGadget wrote: > > > @@ -442,17 +443,23 @@ static struct discovery *discover_refs(const char > > *service, int for_push) > > break; > > case HTTP_MISSING_TAR

Re: [PATCH] Doc: fix misleading asciidoc formating

On Wed, Mar 06, 2019 at 07:54:20AM +0900, Junio C Hamano wrote: > Jeff King writes: > > > Did you notice this when building locally, or on the asciidoctor-built > > pages at git-scm.com? > > Does git-scm.com even have this file rendered? I do not think we > glob for technical/*.txt in any of o

Re: Questions on GSoC 2019 Ideas

First of all, I must apologize for not replying during these last days. I'm traveling and I rarely get a connection here. But I'll be back March 11th. On Sun, Mar 3, 2019 at 4:18 AM Christian Couder wrote: > > On Sat, Mar 2, 2019 at 4:09 PM Thomas Gummerer wrote: > > > > I'm a bit wary of a too

Re: [PATCH 1/1] Makefile: use `git ls-files` to list header files, if possible

On Tue, Mar 05, 2019 at 02:50:11PM +0900, Junio C Hamano wrote: > Jeff King writes: > > > This makes sense to me, though as you noted elsewhere, it doesn't fix > > the gcrypt problem, since that file unconditionally wants to look at the > > system gcrypt.h (and we control at the Makefile level w

Re: [PATCH] Doc: fix misleading asciidoc formating

On Tue, Mar 05, 2019 at 06:02:27PM -0500, Jeff King wrote: > On Wed, Mar 06, 2019 at 07:54:20AM +0900, Junio C Hamano wrote: > > > Jeff King writes: > > > > > Did you notice this when building locally, or on the asciidoctor-built > > > pages at git-scm.com? > > > > Does git-scm.com even have t

[PATCH 0/1] remote-curl: mark all error messages for translation

As suggested by Jeff King in a nearby thread. Johannes Schindelin (1): remote-curl: mark all error messages for translation remote-curl.c | 50 +- 1 file changed, 25 insertions(+), 25 deletions(-) base-commit: c1284b21f2436de24c9559fcc5f4badb04

[PATCH 1/1] remote-curl: mark all error messages for translation

From: Johannes Schindelin Suggested by Jeff King. Signed-off-by: Johannes Schindelin --- remote-curl.c | 50 +- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/remote-curl.c b/remote-curl.c index 6be3cb5918..06f091d862 100644 ---

[PATCH v2] git-reset.txt: clarify documentation

git-reset.txt contained a missing "a" and "wrt". Fix the missing "a" for correctness and replace "wrt" with "with respect to" so that the documentation is not so cryptic. Signed-off-by: Denton Liu --- My mistake, I fired off the email before it was ready. --- Documentation/git-reset.txt | 3 ++

Re:

Hey Eric On Tue, 5 Mar 2019 09:57:40 -0500 Eric Sunshine wrote: > This patch, due to its length and repetitive nature, falls under the > category of being tedious to review, which makes it all the more > likely that a reviewer will overlook a problem. Yes, I clearly understand that this patch ha

Re: Git log print commits between a revision range (inclusive)

As Junio mentioned, "A..B" means all commits reachable from B except those reachable from A. Understanding this is just a way to say "B --not A" is important to know you can take advantage of: `--boundary` Output excluded boundary commits. Boundary commits are prefixed with -. In other words,

Re: [PATCH] Doc: fix misleading asciidoc formating

Jeff King writes: > TBH, I still have mixed feelings on rendering these technical docs with > asciidoc at all. It seems like few enough people bother to render them > that bugs persist for a long time. It kind of seems like make-work > getting them to format correctly. I thought about resisting

Re: [PATCH 0/1] remote-curl: mark all error messages for translation

"Johannes Schindelin via GitGitGadget" writes: > As suggested by Jeff King in a nearby thread. > > Johannes Schindelin (1): > remote-curl: mark all error messages for translation Does this come on top or below the anonymize patch, or it does not matter which goes first? > > remote-curl.c | 5

Re: Questions on GSoC 2019 Ideas

This exercise of estimating a good spot to gain performance with parallelism at git seems more difficult than I thought, firstly. Also, I'm not that familiar yet with git packing (neither with the sections of it that could benefit from parallelism). So could anyone point me some good references on

Re: [PATCH 0/1] remote-curl: mark all error messages for translation

Junio C Hamano writes: > "Johannes Schindelin via GitGitGadget" > writes: > >> As suggested by Jeff King in a nearby thread. >> >> Johannes Schindelin (1): >> remote-curl: mark all error messages for translation > > Does this come on top or below the anonymize patch, or it does not > matter wh

Re: Git log print commits between a revision range (inclusive)

Rafael Ascensão writes: > As Junio mentioned, "A..B" means all commits reachable from B except those > reachable from A. Understanding this is just a way to say "B --not A" is > important to know you can take advantage of: > > `--boundary` > Output excluded boundary commits. Boundary commits

Re: is it "git gc --prune=now" or "git gc --prune=all"?

Jeff King writes: > ... I do think the documentation > should recommend "now". Possibly builtin/gc.c should be smarter about > recognizing "all" in the conditional you quoted, too, though I don't > know that it's all that important (especially if we tweak the > documentation). Yup, as the placeh

  1   2   >