[PATCH 9/9] xdiff-interface: drop parse_hunk_header()

2018-11-01 Thread Jeff King
This function was used only for parsing the hunk headers generated by xdiff. Now that we can use hunk callbacks to get that information directly, it has outlived its usefulness. Note to anyone who wants to resurrect it: the "len" parameter was totally unused, meaning that the function could read p

Re: [PATCH v3 5/8] push: add an advice on unqualified push

2018-11-01 Thread Jeff King
On Mon, Oct 29, 2018 at 02:14:02PM +0900, Junio C Hamano wrote: > Any failure in the &&-chain (or the last grep) would not terminate > the for loop, so for the purpose of determining the success of this > test_expect_success, the last "blob" iteration is the only thing > that matters. > > Which i

Re: [PATCH v3 0/8] fixes for unqualified push

2018-11-01 Thread Jeff King
On Fri, Oct 26, 2018 at 11:07:33PM +, Ævar Arnfjörð Bjarmason wrote: > After sending out v2 I noticed I didn't update the examples in a > couple of the commit messages, and figured I'd finish this up by > adding a patch to document how this works in the "git-push" > manpage. This behavior has

<    1   2