Re: [PATCH] zlib.c: use size_t for size

On Fri, Oct 12, 2018 at 04:07:25PM +0900, Junio C Hamano wrote: > diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c > index e6316d294d..b9ca04eb8a 100644 > --- a/builtin/pack-objects.c > +++ b/builtin/pack-objects.c > @@ -266,15 +266,15 @@ static void copy_pack_data(struct hashfile *f,

Re: [PATCH] zlib.c: use size_t for size

On Fri, Oct 12, 2018 at 10:38:45PM -0400, Jeff King wrote: > So right now let's imagine that off_t is 64-bit, and "unsigned long" is > 32-bit (e.g., 32-bit system, or an IL32P64 model like Windows). We'll > repeatedly ask use_pack() for a window, and it will tell us how many > bytes we have in "av

Re: [PATCH v2 1/1] zlib.c: use size_t for size

[] > Neither v1 nor v2 of this patch compiles on 32 bit Linux; see > > https://travis-ci.org/git/git/jobs/440514375#L628 > > The fixup patch below makes it compile on 32 bit and the test suite > passes as well, but I didn't thoroughly review the changes; I only > wanted to get 'pu' build again.

git issue with builds on Travis-CI

There is a problem on travis-ci with doing builds on Pull Requests with multiple jobs. For each job it will build off the FETCH_HEAD. The problem is that if the FETCH_HEAD changes while the build is running (due to a commit), the subsequent jobs will build off the new FETCH_HEAD. This results in lo

<    1   2