Re: [PATCH] pack-objects: fix performance issues on packing large deltas

On Sat, Jul 21, 2018 at 6:07 AM Duy Nguyen wrote: > > However, I'm just concentrating on a beefy machine; it may be that v6 > > drastically outperforms v2 on weaker hardware? Can others measure a > > lower memory usage for v6 than v2? > > I'll try it with massif on linux.git, but this is a very w

Re: [PATCH] pack-objects: fix performance issues on packing large deltas

On Sat, Jul 21, 2018 at 8:56 AM Elijah Newren wrote: > > -- 8< -- > ... > > diff --git a/pack-objects.h b/pack-objects.h > > index 9f977ae800..11890e7217 100644 > > --- a/pack-objects.h > > +++ b/pack-objects.h > > @@ -15,7 +15,7 @@ > ... > > @@ -353,37 +354,26 @@ static inline void oe_set_size(st

Re: [PATCH 1/2] t3507: add a testcase showing failure with sparse checkout

On Sat, Jul 21, 2018 at 2:34 AM Elijah Newren wrote: > diff --git a/t/t3507-cherry-pick-conflict.sh b/t/t3507-cherry-pick-conflict.sh > @@ -392,4 +392,17 @@ test_expect_success 'commit --amend -s places the > sign-off at the right place' ' > +test_expect_failure 'failed cherry-pick with sparse-ch

Re: [PATCH v2 01/23] Update messages in preparation for i18n

On Thu, Jul 19, 2018 at 8:18 PM Junio C Hamano wrote: > > --- a/config.c > > +++ b/config.c > > @@ -461,7 +461,7 @@ int git_config_from_parameters(config_fn_t fn, void > > *data) > > envw = xstrdup(env); > > > > if (sq_dequote_to_argv(envw, &argv, &nr, &alloc) < 0) { > > -

[PATCH v3 09/23] config.c: mark more strings for translation

Signed-off-by: Nguyễn Thái Ngọc Duy --- config.c | 72 +++ t/t1305-config-include.sh | 2 +- 2 files changed, 37 insertions(+), 37 deletions(-) diff --git a/config.c b/config.c index a57e3056ef..736b9f23f7 100644 --- a/config.c +++ b/config.c

[PATCH v3 00/23] Mark more strings for translation

v3 fixes up some other things that Junio spotted. branch-diff diff --git a/builtin/config.c b/builtin/config.c index 3c26df6c48..5761a2c4ac 100644 --- a/builtin/config.c +++ b/builtin/config.c @@ -626,7 +626,7 @@ int cmd_config(int argc, const char **argv, const char *prefix)

[PATCH v3 11/23] convert.c: mark more strings for translation

Signed-off-by: Nguyễn Thái Ngọc Duy --- convert.c | 38 -- t/t0021-conversion.sh | 2 +- 2 files changed, 21 insertions(+), 19 deletions(-) diff --git a/convert.c b/convert.c index f47e60022e..e53911d4f8 100644 --- a/convert.c +++ b/convert.c @@ -

[PATCH v3 19/23] replace-object.c: mark more strings for translation

Signed-off-by: Nguyễn Thái Ngọc Duy --- replace-object.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/replace-object.c b/replace-object.c index 801b5c1678..ddc1546b8c 100644 --- a/replace-object.c +++ b/replace-object.c @@ -17,7 +17,7 @@ static int register_replace_re

[PATCH v3 23/23] transport-helper.c: mark more strings for translation

Signed-off-by: Nguyễn Thái Ngọc Duy --- t/t5801-remote-helpers.sh | 8 ++-- transport-helper.c| 87 --- 2 files changed, 48 insertions(+), 47 deletions(-) diff --git a/t/t5801-remote-helpers.sh b/t/t5801-remote-helpers.sh index 88c7f158ef..e3bc53b0c7

[PATCH v3 17/23] refs.c: mark more strings for translation

Signed-off-by: Nguyễn Thái Ngọc Duy --- refs.c| 40 +-- t/t1400-update-ref.sh | 20 +++--- t/t1404-update-ref-errors.sh | 4 +-- t/t3210-pack-refs.sh | 2 +- t/t3310-notes-merge-manual-reso

[PATCH v3 18/23] refspec.c: mark more strings for translation

Signed-off-by: Nguyễn Thái Ngọc Duy --- refspec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/refspec.c b/refspec.c index c66351743b..f529092fd6 100644 --- a/refspec.c +++ b/refspec.c @@ -134,7 +134,7 @@ void refspec_item_init_or_die(struct refspec_item *item, const char

[PATCH v3 05/23] builtin/grep.c: mark strings for translation

Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/grep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/grep.c b/builtin/grep.c index 9774920999..58f941e951 100644 --- a/builtin/grep.c +++ b/builtin/grep.c @@ -489,7 +489,7 @@ static int grep_cache(struct grep_opt *opt,

[PATCH v3 03/23] archive-zip.c: mark more strings for translation

Signed-off-by: Nguyễn Thái Ngọc Duy --- archive-zip.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/archive-zip.c b/archive-zip.c index 48d843489c..7ad46d8854 100644 --- a/archive-zip.c +++ b/archive-zip.c @@ -309,11 +309,11 @@ static int write_zip_entry(struc

[PATCH v3 20/23] sequencer.c: mark more strings for translation

Signed-off-by: Nguyễn Thái Ngọc Duy --- sequencer.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/sequencer.c b/sequencer.c index 6b6162d194..f7c2f2422d 100644 --- a/sequencer.c +++ b/sequencer.c @@ -716,7 +716,7 @@ static const char *read_author

[PATCH v3 01/23] Update messages in preparation for i18n

Many messages will be marked for translation in the following commits. This commit updates some of them to be more consistent and reduce diff noise in those commits. Changes are - keep the first letter of die(), error() and warning() in lowercase - no full stop in die(), error() or warning() if it

[PATCH v3 04/23] builtin/config.c: mark more strings for translation

Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/config.c | 48 +-- t/t1308-config-set.sh | 2 +- 2 files changed, 25 insertions(+), 25 deletions(-) diff --git a/builtin/config.c b/builtin/config.c index a09ead5bc8..5761a2c4ac 100644 --- a/builtin/con

[PATCH v3 12/23] dir.c: mark more strings for translation

Signed-off-by: Nguyễn Thái Ngọc Duy --- dir.c| 6 +++--- t/t3005-ls-files-relative.sh | 4 ++-- t/t7400-submodule-basic.sh | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dir.c b/dir.c index e1a2e1cffb..7c6e7a0a37 100644 --- a/dir.c +++ b/dir.c @@

[PATCH v3 10/23] connect.c: mark more strings for translation

Signed-off-by: Nguyễn Thái Ngọc Duy --- connect.c | 74 +++ t/t5570-git-daemon.sh | 6 ++-- 2 files changed, 42 insertions(+), 38 deletions(-) diff --git a/connect.c b/connect.c index 308475b7eb..94547e5056 100644 --- a/connect.c +++ b/connect

[PATCH v3 08/23] commit-graph.c: mark more strings for translation

Signed-off-by: Nguyễn Thái Ngọc Duy --- commit-graph.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/commit-graph.c b/commit-graph.c index b63a1fc85e..c8d521923c 100644 --- a/commit-graph.c +++ b/commit-graph.c @@ -77,28 +77,28 @@ struct commit_graph *

[PATCH v3 02/23] archive-tar.c: mark more strings for translation

Signed-off-by: Nguyễn Thái Ngọc Duy --- archive-tar.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/archive-tar.c b/archive-tar.c index b6f58ddf38..68e72d9176 100644 --- a/archive-tar.c +++ b/archive-tar.c @@ -121,7 +121,7 @@ static int stream_blocked(const stru

[PATCH v3 07/23] builtin/replace.c: mark more strings for translation

Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/replace.c | 74 +++ 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/builtin/replace.c b/builtin/replace.c index 5926ad11de..e879ace277 100644 --- a/builtin/replace.c +++ b/builtin/replace.c

[PATCH v3 16/23] pkt-line.c: mark more strings for translation

Signed-off-by: Nguyễn Thái Ngọc Duy --- pkt-line.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/pkt-line.c b/pkt-line.c index 941e41dfc1..04d10bbd03 100644 --- a/pkt-line.c +++ b/pkt-line.c @@ -101,7 +101,7 @@ int packet_flush_gently(int fd) {

[PATCH v3 15/23] object.c: mark more strings for translation

Signed-off-by: Nguyễn Thái Ngọc Duy --- object.c| 10 +- t/t1450-fsck.sh | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/object.c b/object.c index 10d167825e..477e686da7 100644 --- a/object.c +++ b/object.c @@ -49,7 +49,7 @@ int type_from_string_gently(cons

[PATCH v3 14/23] exec-cmd.c: mark more strings for translation

Signed-off-by: Nguyễn Thái Ngọc Duy --- exec-cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exec-cmd.c b/exec-cmd.c index 02d31ee897..4f81f44310 100644 --- a/exec-cmd.c +++ b/exec-cmd.c @@ -358,7 +358,7 @@ int execl_git_cmd(const char *cmd, ...) } va_end

[PATCH v3 06/23] builtin/pack-objects.c: mark more strings for translation

Most of these are straight forward. GETTEXT_POISON does catch the last string in cmd_pack_objects(), but since this is --progress output, it's not supposed to be machine-readable. Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/pack-objects.c | 102 + t/t5

[PATCH v3 21/23] sha1-file.c: mark more strings for translation

Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-file.c | 104 ++-- 1 file changed, 52 insertions(+), 52 deletions(-) diff --git a/sha1-file.c b/sha1-file.c index ed7ac73fa9..92c27583db 100644 --- a/sha1-file.c +++ b/sha1-file.c @@ -378,8 +378,8 @@ sta

[PATCH v3 13/23] environment.c: mark more strings for translation

Signed-off-by: Nguyễn Thái Ngọc Duy --- environment.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/environment.c b/environment.c index 2a6de2330b..d129c4adc5 100644 --- a/environment.c +++ b/environment.c @@ -147,7 +147,7 @@ static char *expand_namespace(const char *raw

[PATCH v3 22/23] transport.c: mark more strings for translation

Signed-off-by: Nguyễn Thái Ngọc Duy --- transport.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/transport.c b/transport.c index 9fcc33915a..516a83b7f6 100644 --- a/transport.c +++ b/transport.c @@ -139,7 +139,7 @@ static struct ref *get_refs_from_bundle(st

Re: [PATCH 00/12] Kill the_index part2, header file cleanup

On Sat, Jun 30, 2018 at 11:20 AM Nguyễn Thái Ngọc Duy wrote: > > Like part 1 this is also boring. I wanted to drop these 'extern' > everywhere actually, so before I touched any header file in this > series, I did a clean up first. This is the result (and to reduce diff > noise later) Junio, part1

BONJOUR. VOUS POUVEZ ÊTRE NOTRE PARTENAIRE D'AFFAIRES ???????

Bonjour, Nous représentons des investisseurs privés sérieux d’Europe, des Émirats Arabes Unis et l’Afrique, qui recherchent de bonnes et rentables des projets qu’ils pourraient financer en tant que partenaire et ils offrent également prêt pour répondre aux besoins particuliers des projets rentables

[PATCH] fixup! builtin/rebase: support running "git rebase "

The macro GIT_PATH_FUNC expands to a function definition that ends with a closing brace. The extra semicolon produces a warning when compiling with -pedantic. Signed-off-by: Beat Bolli --- Junio, this applies on top of pk/rebase-in-c. Thanks, Beat builtin/rebase.c | 4 ++-- 1 file changed, 2

Re: [PATCH 1/2] t3507: add a testcase showing failure with sparse checkout

On 7/21/2018 2:34 AM, Elijah Newren wrote: From: Ben Peart Signed-off-by: Elijah Newren --- Testcase provided by Ben, so committing with him as the author. Just need a sign off from him. Thanks Elijah, consider it Signed-off-by: Ben Peart t/t3507-cherry-pick-conflict.sh | 13

HELLO.

HELLO. This might come to you as a surprise, especially since we have never met or discuss before, basically the message might sound strange but it is factual in reality if only you care to listen to me. The truth is that I should have notified you first through a more confidential means, (ev

RE: MY NAME IS MRS BELLA YOSTIN MOHAMMAD

Hello Dear. My Name is Mrs. Bella Yostin Mohammad, I got your contact from a business directory search and I decided to contact you directly. well am originally from South Africa, but based in London, i am searching for a reliable and honest and understanding person to go into partnership in invest

[PATCH] Makefile: add a DEVOPTS flag to get pedantic compilation

In the interest of code hygiene, make it easier to compile Git with the flag -pedantic. Pure pedantic compilation results in one warning per use of the translation macro `N_`, therefore also disable the parenthesising of i18n strings with -DUSE_PARENS_AROUND_GETTEXT_N=0 to show only real warnings.

[ANNOUNCE] tig-2.4.0

Hi, I'm pleased to announce Tig version 2.4.0 with improvements to UTF-8 handling and compatibility with Git as well as a ton of bug fixes, What is Tig? Tig is an ncurses-based text-mode interface for git. It functions mainly as a Git repository browser, but can also assist in stagi

Re: [PATCH] Makefile: add a DEVOPTS flag to get pedantic compilation

On Sat, Jul 21 2018, Beat Bolli wrote: > In the interest of code hygiene, make it easier to compile Git with the > flag -pedantic. > > Pure pedantic compilation results in one warning per use of the > translation macro `N_`, therefore also disable the parenthesising of > i18n strings with -DUSE_

Re: Hash algorithm analysis

On Fri, Jul 20 2018, brian m. carlson wrote: > On Mon, Jun 11, 2018 at 12:29:42PM -0700, Jonathan Nieder wrote: >> My understanding of the discussion so far: >> >> Keccak team encourages us[1] to consider a variant like K12 instead of >> SHA3. >> >> AGL explains[2] that the algorithms considered

Good day

Good day, I am Mdm. SUI Yang, Chief Financial Officer of the Bank of China I am looking for a manager / investment partner who will work with me for a joint venture. Contact me in my private email for more details. email (suiyan...@gmail.com) Waiting to hear from you. Thank you, Mdm SUI Yang

Re: Hash algorithm analysis

On Sat, Jul 21, 2018 at 09:52:05PM +0200, Ævar Arnfjörð Bjarmason wrote: > > On Fri, Jul 20 2018, brian m. carlson wrote: > > I know this discussion has sort of petered out, but I'd like to see if > > we can revive it. I'm writing index v3 and having a decision would help > > me write tests for i

[PATCH v2] Makefile: add a DEVOPTS flag to get pedantic compilation

In the interest of code hygiene, make it easier to compile Git with the flag -pedantic. Pure pedantic compilation with GCC 7.3 results in one warning per use of the translation macro `N_`: warning: array initialized from parenthesized string constant [-Wpedantic] Therefore also disable the p

Re: [PATCH 0/2] Re: [PATCH v3 14/20] diff: add an internal option to dual-color diffs of diffs

Hi Stefan, On Tue, 10 Jul 2018, Stefan Beller wrote: > This is developed on top of 4a68b95ce2a6 (your series here) > > This is an attempt to explain the previous email better, > specially the second (yet unfinished) patch, but the resulting > emit_line_0 is way clearer in my mind, dropping the '

Re: [PATCH v3 16/20] range-diff --dual-color: work around bogus white-space warning

Hi Stefan, On Tue, 10 Jul 2018, Stefan Beller wrote: > On Tue, Jul 10, 2018 at 3:08 AM Johannes Schindelin > wrote: > > > > On Mon, 9 Jul 2018, Junio C Hamano wrote: > > > > > I also wonder if we should be feeding the context lines to ws.c > > > machinery in the first place though. > > > > It *i

Re: refs/notes/amlog problems, was Re: [PATCH v3 01/20] linear-assignment: a function to solve least-cost assignment problems

Hi Junio, On Fri, 20 Jul 2018, Junio C Hamano wrote: > Johannes Schindelin writes: > > > AFAICT there is at least one scenario where you run `rebase -i`, the notes > > get updated, and of course the *reverse mapping* does *not* get updated: > > It turns out that I never had a rewrite hook; the

Re: refs/notes/amlog problems, was Re: [PATCH v3 01/20] linear-assignment: a function to solve least-cost assignment problems

Hi, On Fri, 20 Jul 2018, Stefan Beller wrote: > +cc list > On Fri, Jul 20, 2018 at 2:29 PM Junio C Hamano wrote: > > ... which means that it does not matter if I have an elaborate rewrite hook > > that constantly updates the reverse mapping or if the reverse mapping is > > made immediately befor

[PATCH v4 04/21] range-diff: improve the order of the shown commits

From: Johannes Schindelin This patch lets `git range-diff` use the same order as tbdiff. The idea is simple: for left-to-right readers, it is natural to assume that the `git range-diff` is performed between an older vs a newer version of the branch. As such, the user is probably more interested

[PATCH v4 03/21] range-diff: first rudimentary implementation

From: Johannes Schindelin At this stage, `git range-diff` can determine corresponding commits of two related commit ranges. This makes use of the recently introduced implementation of the linear assignment algorithm. The core of this patch is a straight port of the ideas of tbdiff, the apparentl

[PATCH v4 10/21] range-diff: do not show "function names" in hunk headers

From: Johannes Schindelin We are comparing complete, formatted commit messages with patches. There are no function names here, so stop looking for them. Signed-off-by: Johannes Schindelin --- range-diff.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/range-diff.c b/range-diff.c ind

[PATCH v4 09/21] range-diff: adjust the output of the commit pairs

From: Johannes Schindelin This change brings `git range-diff` yet another step closer to feature parity with tbdiff: it now shows the oneline, too, and indicates with `=` when the commits have identical diffs. Signed-off-by: Johannes Schindelin --- range-diff.c | 64 +++

[PATCH v4 14/21] diff: add an internal option to dual-color diffs of diffs

From: Johannes Schindelin When diffing diffs, it can be quite daunting to figure out what the heck is going on, as there are nested +/- signs. Let's make this easier by adding a flag in diff_options that allows color-coding the outer diff sign with inverted colors, so that the preimage and posti

[PATCH v4 08/21] range-diff: suppress the diff headers

From: Johannes Schindelin When showing the diff between corresponding patches of the two branch versions, we have to make up a fake filename to run the diff machinery. That filename does not carry any meaningful information, hence tbdiff suppresses it. So we should, too. Signed-off-by: Johannes

[PATCH v4 12/21] range-diff: use color for the commit pairs

From: Johannes Schindelin Arguably the most important part of `git range-diff`'s output is the list of commits in the two branches, together with their relationships. For that reason, tbdiff introduced color-coding that is pretty intuitive, especially for unchanged patches (all dim yellow, like

[PATCH v4 01/21] linear-assignment: a function to solve least-cost assignment problems

From: Johannes Schindelin The problem solved by the code introduced in this commit goes like this: given two sets of items, and a cost matrix which says how much it "costs" to assign any given item of the first set to any given item of the second, assign all items (except when the sets have diffe

[PATCH v4 02/21] Introduce `range-diff` to compare iterations of a topic branch

From: Johannes Schindelin This command does not do a whole lot so far, apart from showing a usage that is oddly similar to that of `git tbdiff`. And for a good reason: the next commits will turn `range-branch` into a full-blown replacement for `tbdiff`. At this point, we ignore tbdiff's color op

[PATCH v4 11/21] range-diff: add tests

From: Thomas Rast These are essentially lifted from https://github.com/trast/tbdiff, with light touch-ups to account for the command now being names `git range-diff`. Apart from renaming `tbdiff` to `range-diff`, only one test case needed to be adjusted: 11 - 'changed message'. The underlying r

[PATCH v4 00/21] Add `range-diff`, a `tbdiff` lookalike

The incredibly useful [`git-tbdiff`](https://github.com/trast/tbdiff) tool to compare patch series (say, to see what changed between two iterations sent to the Git mailing list) is slightly less useful for this developer due to the fact that it requires the `hungarian` and `numpy` Python package

[PATCH v4 18/21] completion: support `git range-diff`

From: Johannes Schindelin Tab completion of `git range-diff` is very convenient, especially given that the revision arguments to specify the commit ranges to compare are typically more complex than, say, what is normally passed to `git log`. Signed-off-by: Johannes Schindelin --- contrib/compl

[PATCH v4 15/21] range-diff: offer to dual-color the diffs

From: Johannes Schindelin When showing what changed between old and new commits, we show a diff of the patches. This diff is a diff between diffs, therefore there are nested +/- signs, and it can be relatively hard to understand what is going on. With the --dual-color option, the preimage and th

[PATCH v4 17/21] range-diff: populate the man page

From: Johannes Schindelin The bulk of this patch consists of a heavily butchered version of tbdiff's README written by Thomas Rast and Thomas Gummerer, lifted from https://github.com/trast/tbdiff. Signed-off-by: Johannes Schindelin --- Documentation/git-range-diff.txt | 229 +++

[PATCH v4 07/21] range-diff: indent the diffs just like tbdiff

From: Johannes Schindelin The main information in the `range-diff` view comes from the list of matching and non-matching commits, the diffs are additional information. Indenting them helps with the reading flow. Signed-off-by: Johannes Schindelin --- builtin/range-diff.c | 10 ++ 1 fil

[PATCH v4 05/21] range-diff: also show the diff between patches

From: Johannes Schindelin Just like tbdiff, we now show the diff between matching patches. This is a "diff of two diffs", so it can be a bit daunting to read for the beginner. An alternative would be to display an interdiff, i.e. the hypothetical diff which is the result of first reverting the o

[PATCH v4 19/21] range-diff: left-pad patch numbers

From: Johannes Schindelin As pointed out by Elijah Newren, tbdiff has this neat little alignment trick where it outputs the commit pairs with patch numbers that are padded to the maximal patch number's width: 1: cafedead = 1: acefade first patch [...] 314: beefeada <

[PATCH v4 06/21] range-diff: right-trim commit messages

From: Johannes Schindelin When comparing commit messages, we need to keep in mind that they are indented by four spaces. That is, empty lines are no longer empty, but have "trailing whitespace". When displaying them in color, that results in those nagging red lines. Let's just right-trim the lin

[PATCH v4 13/21] color: add the meta color GIT_COLOR_REVERSE

From: Johannes Schindelin This "color" simply reverts background and foreground. It will be used in the upcoming "dual color" mode of `git range-diff`, where we will reverse colors for the -/+ markers and the fragment headers of the "outer" diff. Signed-off-by: Johannes Schindelin --- color.h

[PATCH v4 16/21] range-diff --dual-color: fix bogus white-space warning

From: Johannes Schindelin When displaying a diff of diffs, it is possible that there is an outer `+` before a context line. That happens when the context changed between old and new commit. When that context line starts with a tab (after the space that marks it as context line), our diff machiner

[PATCH v4 21/21] range-diff: use dim/bold cues to improve dual color mode

From: Johannes Schindelin It *is* a confusing thing to look at a diff of diffs. All too easy is it to mix up whether the -/+ markers refer to the "inner" or the "outer" diff, i.e. whether a `+` indicates that a line was added by either the old or the new diff (or both), or whether the new diff do

[PATCH v4 20/21] range-diff: make --dual-color the default mode

From: Johannes Schindelin After using this command extensively for the last two months, this developer came to the conclusion that even if the dual color mode still leaves a lot of room for confusion about what was actually changed, the non-dual color mode is substantially worse in that regard.

Re: [PATCH v3 09/20] range-diff: adjust the output of the commit pairs

Hi Stefan, On Fri, 20 Jul 2018, Stefan Beller wrote: > > 1. To roll again. > > > > A player who rolls two sixes can reroll the dice for an additional > > turn. > > This is where I had my AHA moment! > (Consider my software development process as chaotic as a dice roll > So re

Re: Hash algorithm analysis

Hi Brian, On Fri, 20 Jul 2018, brian m. carlson wrote: > On Mon, Jun 11, 2018 at 12:29:42PM -0700, Jonathan Nieder wrote: > > My understanding of the discussion so far: > > > > Keccak team encourages us[1] to consider a variant like K12 instead of > > SHA3. > > > > AGL explains[2] that the algo

Re: Hash algorithm analysis

On Sat, Jul 21, 2018 at 3:39 PM Johannes Schindelin wrote: > > Do you really want to value contributors' opinion more than > cryptographers'? I mean, that's exactly what got us into this hard-coded > SHA-1 mess in the first place. Don't be silly. Other real cryptographers consider SHA256 to be a

Re: Hash algorithm analysis

On Sun, Jul 22, 2018 at 12:38:41AM +0200, Johannes Schindelin wrote: > Do you really want to value contributors' opinion more than > cryptographers'? I mean, that's exactly what got us into this hard-coded > SHA-1 mess in the first place. I agree (believe me, of all people, I agree) that hard-codi

Re: [PATCH] fixup! builtin/rebase: support running "git rebase "

Hi, On Sat, Jul 21, 2018 at 6:36 PM Beat Bolli wrote: > > The macro GIT_PATH_FUNC expands to a function definition that ends with > a closing brace. The extra semicolon produces a warning when compiling > with -pedantic. > > Signed-off-by: Beat Bolli > --- > > Junio, this applies on top of pk/re

Re: [PATCH v4 11/21] range-diff: add tests

On Sat, Jul 21, 2018 at 6:05 PM Thomas Rast via GitGitGadget wrote: > These are essentially lifted from https://github.com/trast/tbdiff, with > light touch-ups to account for the command now being names `git s/names/named/ > range-diff`. > > Apart from renaming `tbdiff` to `range-diff`, only one

[RFC PATCH 2/5] Add delta-islands.{c,h}

From: Jeff King Hosting providers that allow users to "fork" existing repos want as much as possible those forks to use a small amount of disk space. Using alternates to keep all the objects from all the forks into a unique central repo is way to do that, but it can have some drawbacks. Especial

[RFC PATCH 5/5] t: add t9930-delta-islands.sh

From: Jeff King Signed-off-by: Jeff King Signed-off-by: Christian Couder --- t/t9930-delta-islands.sh | 143 +++ 1 file changed, 143 insertions(+) create mode 100755 t/t9930-delta-islands.sh diff --git a/t/t9930-delta-islands.sh b/t/t9930-delta-islands.sh

[RFC PATCH 1/5] packfile: make get_delta_base() non static

From: Jeff King As get_delta_base() will be used outside 'packfile.c' in a following commit, let's make it non static and let's declare it in 'packfile.h'. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- packfile.c | 10 +- packfile.h | 3 +++ 2 files changed, 8 insertio

[RFC PATCH 0/5] Add delta islands support

This patch series is upstreaming work made by GitHub and available in: https://github.com/peff/git/commits/jk/delta-islands The patch in the above branch has been split into 5 patches with their own new commit message, but no other change has been made. I kept Peff as the author and took the lib

[RFC PATCH 3/5] pack-objects: add delta-islands support

From: Jeff King Implement support for delta islands in git pack-objects and document how delta islands work in "Documentation/git-pack-objects.txt". Signed-off-by: Jeff King Signed-off-by: Christian Couder --- Documentation/git-pack-objects.txt | 88 +++ builtin/pack-objects.

[RFC PATCH 4/5] repack: add delta-islands support

From: Jeff King Implement simple support for --delta-islands option and repack.useDeltaIslands config variable in git repack. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- Documentation/config.txt | 4 Documentation/git-repack.txt | 5 + builtin/repack.c

Re: [PATCH v4 18/21] completion: support `git range-diff`

On Sat, Jul 21, 2018 at 6:05 PM Johannes Schindelin via GitGitGadget wrote: > Tab completion of `git range-diff` is very convenient, especially > given that the revision arguments to specify the commit ranges to > compare are typically more complex than, say, what is normally passed > to `git log`

Re: [PATCH] pack-objects: fix performance issues on packing large deltas

On Fri, Jul 20, 2018 at 9:47 PM, Duy Nguyen wrote: > On Fri, Jul 20, 2018 at 10:43:25AM -0700, Elijah Newren wrote: >> Out of curiosity, would it be possible to use the delta_size_ field >> for deltas that are small enough, and only use an external data >> structure (perhaps a hash rather than an

Re: [PATCH] pack-objects: fix performance issues on packing large deltas

On Sun, Jul 22, 2018 at 8:22 AM Elijah Newren wrote: > > On Fri, Jul 20, 2018 at 9:47 PM, Duy Nguyen wrote: > > On Fri, Jul 20, 2018 at 10:43:25AM -0700, Elijah Newren wrote: > >> Out of curiosity, would it be possible to use the delta_size_ field > >> for deltas that are small enough, and only u