Re: [PATCH] xdiff: reduce indent heuristic overhead

On 06/29/2018 10:28 PM, Stefan Beller wrote: > [...] > Adds some threshold to avoid expensive cases, like: > > ``` > #!python > open('a', 'w').write(" \n" * 100) > open('b', 'w').write(" \n" * 101) > ``` > > The indent heuristic is O(N * 20) (N = 100) for t

Feature request : "git fsck" should show the percentage of completeness in step "Checking connectivity:"

as "git fsck" does it already for "Checking objects:" Is this a valid feature request? -- Toralf PGP C4EACDDE 0076E94E

Re: Use of new .gitattributes working-tree-encoding attribute across different platform types

On Thu, Jun 28, 2018 at 01:27:07PM -0400, Jeff King wrote: > Yeah, that was along the lines that I was thinking. I wonder if anybody > would ever need two such auto-encodings, though. Probably not. But > another way to think about it would be to allow something like: > > working-tree-encoding=fo

Re: send-email: change the default value of sendmail.validate

On Fri, Jun 29, 2018 at 03:07:51PM -0400, Drew DeVault wrote: > The purpose of this configuration option is to prevent your emails from > blowing up on SMTP servers (rather than Extended SMTP servers). However, > I find it often confuses people whose patches are otherwise correct, and > they don't

Re: send-email: change the default value of sendmail.validate

On 2018-07-01 6:15 PM, brian m. carlson wrote: > Can you say a bit more about the exact error message you're seeing? "patch contains a line longer than 998 characters" A recent occasion when this came up was when someone attempted to send me a patch which included a base64-encoded data URI, whic

git@vger.kernel.org

Signed-off-by: Eric Sunshine --- t/t-basic.sh | 2 +- t/t0003-attributes.sh | 24 t/t0021-conversion.sh | 4 ++-- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/t/t-basic.sh b/t/t-basic.sh index af61d083b4..34859fe4a5 100755 --- a/t/t0

[PATCH 07/25] t5406: use write_script() instead of birthing shell script manually

Take advantage of write_script() to abstract-away details of shell script creation, thus allowing the reader to focus on script content. Readability benefits, particularly in this case, since the script body was buried in a noisy one-liner subshell responsible for emitting boilerplate and body. Si

[PATCH 10/25] t7201: drop pointless "exit 0" at end of subshell

This test employs a for-loop inside a subshell and correctly aborts the loop and fails the test overall (via "exit 1") if any iteration of the for-loop fails. Otherwise, it exits the subshell with an explicit but entirely unnecessary "exit 0", presumably to indicate that all iterations of the loop

git@vger.kernel.org

Signed-off-by: Eric Sunshine --- t/t1004-read-tree-m-u-wf.sh | 8 t/t1005-read-tree-reset.sh | 10 +- t/t1020-subdirectory.sh | 2 +- t/t1050-large.sh| 6 +++--- t/t1411-reflog-show.sh | 6 +++--- t/t1512-rev-parse

[PATCH 08/25] t5505: modernize and simplify hard-to-digest test

This test uses a subshell within a subshell but is formatted in such a way as to suggests that the inner subshell is a sibling rather than a child, which makes it difficult to digest the test's structure and intent. Worse, the inner subshell performs cleanup of actions from earlier in the test, ho

[PATCH 11/25] t7400: fix broken "submodule add/reconfigure --force" test

This test has been dysfunctional since it was added by 619acfc78c (submodule add: extend force flag to add existing repos, 2016-10-06), however, two problems early in the test went unnoticed due to a broken &&-chain later in the test. First, it tries configuring the submodule with repository "bogu

git@vger.kernel.org

Signed-off-by: Eric Sunshine --- t/t7001-mv.sh | 2 +- t/t7201-co.sh | 40 +- t/t7400-submodule-basic.sh | 2 +- t/t7406-submodule-update.sh| 6 ++-- t/t7408-submodule-reference.sh | 2 +- t/t7501-commit.sh | 52 ++

[PATCH 04/25] t: drop unnecessary terminating semicolon in subshell

Signed-off-by: Eric Sunshine --- t/t3102-ls-tree-wildcards.sh| 2 +- t/t4010-diff-pathspec.sh| 4 ++-- t/t9400-git-cvsserver-server.sh | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/t/t3102-ls-tree-wildcards.sh b/t/t3102-ls-tree-wildcards.sh index e804377f1c..1

git@vger.kernel.org

This series fixes several buggy tests which went undetected due to broken &&-chains in subshells, modernizes some tests to take advantage of test functions (test_might_fail(), test_write_lines(), etc.), and fixes a lot of broken &&-chains in subshells. It applies atop 'master'. Happily, there are n

[PATCH 01/25] t: use test_might_fail() instead of manipulating exit code manually

These tests manually coerce the exit code of invoked commands to "success" when they don't care if the command succeeds or fails since failure of those commands should not cause the test to fail overall. In doing so, they intentionally break the &&-chain. Modernize by replacing manual exit code man

git@vger.kernel.org

These tests intentionally break the &&-chain after using 'unset' since they don't know if 'unset' will succeed or fail and don't want a local 'unset' failure to fail the test overall. We can do better by using sane_unset(), which can be linked into the &&-chain as usual. Signed-off-by: Eric Sunshi

[PATCH 12/25] t7810: use test_expect_code() instead of hand-rolled comparison

This test manually checks the exit code of git-grep for a particular value. In doing so, it intentionally breaks the &&-chain. Modernize the test by taking advantage of test_expect_code() and a normal &&-chain. Signed-off-by: Eric Sunshine --- t/t7810-grep.sh | 7 +++ 1 file changed, 3 inser

git@vger.kernel.org

Signed-off-by: Eric Sunshine --- t/t9001-send-email.sh | 6 +++--- t/t9100-git-svn-basic.sh | 2 +- t/t9101-git-svn-props.sh | 2 +- t/t9122-git-svn-author.sh | 6 +++--- t/t9129-git-svn-i18n-commitencoding.

[PATCH 05/25] t/lib-submodule-update: fix "absorbing" test

This test has been dysfunctional since it was added by 259f3ee296 (lib-submodule-update.sh: define tests for recursing into submodules, 2017-03-14), however, the problem went unnoticed due to a broken &&-chain. The test wants to verify that replacing a submodule containing a .git directory will ab

git@vger.kernel.org

Signed-off-by: Eric Sunshine --- t/t9119-git-svn-info.sh | 120 1 file changed, 60 insertions(+), 60 deletions(-) diff --git a/t/t9119-git-svn-info.sh b/t/t9119-git-svn-info.sh index 88241baee3..8201c3e808 100755 --- a/t/t9119-git-svn-info.sh +++ b/t/t911

[PATCH 02/25] t: use test_write_lines() instead of series of 'echo' commands

These tests employ a noisy subshell (with missing &&-chain) to feed input into Git commands or files: (echo a; echo b; echo c) | git some-command ... Simplify by taking advantage of test_write_lines(): test_write_lines a b c | git some-command ... Signed-off-by: Eric Sunshine --- t/t0

git@vger.kernel.org

Signed-off-by: Eric Sunshine --- t/t5300-pack-object.sh | 2 +- t/t5302-pack-index.sh | 2 +- t/t5401-update-hooks.sh| 4 ++-- t/t5500-fetch-pack.sh | 2 +- t/t5505-remote.sh | 2 +- t/t5512-ls-remote.sh | 4 ++-- t/t5516-fetch-push.s

git@vger.kernel.org

Signed-off-by: Eric Sunshine --- t/t2103-update-index-ignore-missing.sh | 2 +- t/t2202-add-addremove.sh | 14 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/t/t2103-update-index-ignore-missing.sh b/t/t2103-update-index-ignore-missing.sh index 332694

git@vger.kernel.org

Signed-off-by: Eric Sunshine --- t/t6010-merge-base.sh| 2 +- t/t6029-merge-subtree.sh | 16 t/t6036-recursive-corner-cases.sh| 6 +++--- t/t6042-merge-rename-corner-cases.sh | 8 t/t6043-merge-rename-directories.sh | 2 +- 5 files ch

[PATCH 09/25] t6036: fix broken "merge fails but has appropriate contents" tests

These tests reference non-existent object "c" when they really mean to be referencing "C", however, these errors went unnoticed due to a broken &&-chain later in the tests. Fix these errors, as well as the broken &&-chains behind which they hid. Reviewed-by: Elijah Newren Signed-off-by: Eric Suns

[PATCH 13/25] t9001: fix broken "invoke hook" test

This test has been dysfunctional since it was added by 6489660b4b (send-email: support validate hook, 2017-05-12), however, the problem went unnoticed due to a broken &&-chain late in the test. The test wants to verify that a non-zero exit code from the 'sendemail-validate' hook causes git-send-em

[PATCH 06/25] t5405: use test_must_fail() instead of checking exit code manually

This test expects "git push" to fail, thus it manually inverts that local expected failure into a successful exit code for the test overall. In doing so, it intentionally breaks the &&-chain. Modernize by replacing manual exit code management with test_must_fail() and a normal &&-chain. Signed-off

git@vger.kernel.org

Signed-off-by: Eric Sunshine --- t/t4001-diff-rename.sh | 2 +- t/t4024-diff-optimize-common.sh | 16 t/t4025-hunk-header.sh | 8 t/t4041-diff-submodule-option.sh | 4 ++-- t/t4060-diff-submodule-opt

git@vger.kernel.org

Signed-off-by: Eric Sunshine --- t/t3030-merge-recursive.sh | 340 ++--- 1 file changed, 170 insertions(+), 170 deletions(-) diff --git a/t/t3030-merge-recursive.sh b/t/t3030-merge-recursive.sh index 3563e77b37..ff641b348a 100755 --- a/t/t3030-merge-recursive.sh +

[PATCH 14/25] t9814: simplify convoluted check that command correctly errors out

This test uses a convoluted method to verify that "p4 help" errors out when asked for help about an unknown command. In doing so, it intentionally breaks the &&-chain. Simplify by employing the typical "! command" idiom and a normal &&-chain instead. Signed-off-by: Eric Sunshine --- t/t9814-git-

git@vger.kernel.org

Signed-off-by: Eric Sunshine --- t/t3000-ls-files-others.sh | 2 +- t/t3006-ls-files-long.sh| 2 +- t/t3008-ls-files-lazy-init-name-hash.sh | 8 t/t3050-subprojects-fetch.sh| 8 t/t3210-pack-refs.sh| 4 ++-- t/t3301-no

Re: send-email: change the default value of sendmail.validate

On Sun, Jul 01, 2018 at 08:17:53PM -0400, Drew DeVault wrote: > On 2018-07-01 6:15 PM, brian m. carlson wrote: > > Are you suggesting that we not limit lines to 998 octets? I've seen > > lots of mail servers that do reject mail over 998 octets. I've > > configured Postfix to do so because being

Re: send-email: change the default value of sendmail.validate

I seem to be mistaken about the degree to which this is standardized and supported. The Debian argument cinches it for me. Quoted printable is probably the right way to go, then.