Re: [PATCH/RFC] setup: update error message to be more meaningful

2017-07-30 Thread Kaartic Sivaraam
On Sat, 2017-07-29 at 09:10 -0700, Junio C Hamano wrote: > Kaartic Sivaraam writes: > > > > That's interesting. In that case, I'll go with the suggested statement, > > happily! > > It is not interesting at all. It actually is disturbing that you > had the notion that these are "valid" command l

Re: [PATCH/RFC] setup: update error message to be more meaningful

2017-07-30 Thread Kaartic Sivaraam
On Sun, 2017-07-30 at 16:17 +0530, Kaartic Sivaraam wrote: > On Sat, 2017-07-29 at 09:10 -0700, Junio C Hamano wrote: > > We perhaps need to somehow make sure new users won't be led to the > > misunderstanding. Improving our documentation is a good first step. > > That's something I could help wi

[PATCH 1/2] doc: fix small issues in SubmittingPatches

2017-07-30 Thread Kaartic Sivaraam
Signed-off-by: Kaartic Sivaraam --- Documentation/SubmittingPatches | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 558d465b6..9d0dab08d 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation

[PATCH 2/2] doc: add another way to identify if a patch has been merged

2017-07-30 Thread Kaartic Sivaraam
Signed-off-by: Kaartic Sivaraam --- I'm not sure if the first one (pull --rebase) is still required and hence leaving it as such. Let me know if it could be removed. Documentation/SubmittingPatches | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/SubmittingPatches b/Docum

[PATCH] branch: change the error messages to be more meaningful

2017-07-30 Thread Kaartic Sivaraam
The error messages shown when the branch command is misused by supplying it wrong number of parameters wasn't meaningful. That's because it used the the phrase "too many branches" assuming all parameters to be "valid" branch names. It's not always the case as exemplified below, $ git branc

[PATCH] remote: split and simplify messages

2017-07-30 Thread Kaartic Sivaraam
Splitting a single sentence across multiple lines could degrade readability. Further, long messages are likely to be ignored by users. Split the sentences and simplify it to improve their readability. Signed-off-by: Kaartic Sivaraam --- remote.c | 18 - t/t2020-checkou

Wrong thread

2017-07-30 Thread Kaartic Sivaraam
Sorry, sent it to the wrong thread. Please, ignore this patch. -- Kaartic

[PATCH] branch: change the error messages to be more meaningful

2017-07-30 Thread Kaartic Sivaraam
The error messages shown when the branch command is misused by supplying it wrong number of parameters wasn't meaningful. That's because it used the the phrase "too many branches" assuming all parameters to be "valid" branch names. It's not always the case as exemplified below, $ git branc

Re: [PATCH 02/15] submodule: don't use submodule_from_name

2017-07-30 Thread Jens Lehmann
Am 26.07.2017 um 23:06 schrieb Junio C Hamano: Stefan Beller writes: Rereading the archives, there was quite some discussion on the design of these patches, but these lines of code did not get any attention https://public-inbox.org/git/4cdb3063.5010...@web.de/ I cc'd Jens in the hope of

Contact with Latinamerica

2017-07-30 Thread Christopher Díaz
Hi, My name is Christopher Díaz Riveros, I'm a software development student in Lima, Peru. For some time now I have been supporting my Linux community, Gentoo Linux, and I have discovered a wide world of possibilities in open source. I tell you this because it has been so much benefit in my train

Re: [PATCH 1/2] doc: fix small issues in SubmittingPatches

2017-07-30 Thread Philip Oakley
From: "Kaartic Sivaraam" minor nit: It's nice, for these single character changes, to give a clue in the commit message as to what to look for. E.g. Quote the command, and remove duplicated space character -- Philip. Signed-off-by: Kaartic Sivaraam --- Documentation/SubmittingPatches | 4

A repository that contains List of all free and non-free Git books

2017-07-30 Thread Gholamreza Sabery
I gathered together a list that contains all free and non-free Git books. Here you can see it: https://github.com/ghrst/git-books

Re: Expected behavior of "git check-ignore"...

2017-07-30 Thread Philip Oakley
From: "Junio C Hamano" Sent: Thursday, July 27, 2017 6:05 PM John Szakmeister writes: On Mon, Jul 24, 2017 at 3:23 PM, Junio C Hamano wrote: [snip] I am reasonably sure that the command started its life as a pure debugging aid. The treatment of the negation _might_ impose conflicting goal

Re: [PATCH 1/2] doc: fix small issues in SubmittingPatches

2017-07-30 Thread Kaartic Sivaraam
On Sun, 2017-07-30 at 15:49 +0100, Philip Oakley wrote: > From: "Kaartic Sivaraam" > > minor nit: It's nice, for these single character changes, to give a clue in > the commit message as to what to look for. > > E.g. > > Quote the command, and remove duplicated space character > Fixed it. Wil

[PATCH 1/2] doc: fix small issues in SubmittingPatches

2017-07-30 Thread Kaartic Sivaraam
Replace the dashed version of a command with undashed version and quote it. Further, remove duplicated space character. Signed-off-by: Kaartic Sivaraam --- Documentation/SubmittingPatches | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/SubmittingPatches b/D

Re: Contact with Latinamerica

2017-07-30 Thread Philip Oakley
From: "Christopher Díaz" My name is Christopher Díaz Riveros, I'm a software development student in Lima, Peru. For some time now I have been supporting my Linux community, Gentoo Linux, and I have discovered a wide world of possibilities in open source. I tell you this because it has been so

Re: [PATCH 2/2] t6500: mark tests as SHA1 reliant

2017-07-30 Thread Junio C Hamano
"brian m. carlson" writes: > One approach I had considered taking is having a helper of some sort > that wrapped a simple key/value store. We could pass the wrapper the > SHA-1 value (or, if necessary, an arbitrary key) and have it return the > proper value based on the given hash function. > >

Re: [PATCH 02/15] submodule: don't use submodule_from_name

2017-07-30 Thread Junio C Hamano
Jens Lehmann writes: >> I wonder if we should barf loudly if there shouldn't be a submodule >> at that path, i.e. >> >> if (!submodule) >> die("there is no submodule defined for path '%s'"...); >> >> though. > > Not sure if you want to die() or just issue a warning(), but yes.

Re: [PATCH 2/2] t6500: mark tests as SHA1 reliant

2017-07-30 Thread brian m. carlson
On Sun, Jul 30, 2017 at 02:21:50PM -0700, Junio C Hamano wrote: > "brian m. carlson" writes: > > > One approach I had considered taking is having a helper of some sort > > that wrapped a simple key/value store. We could pass the wrapper the > > SHA-1 value (or, if necessary, an arbitrary key) an

Re: [PATCH 2/2] t6500: mark tests as SHA1 reliant

2017-07-30 Thread brian m. carlson
On Sun, Jul 30, 2017 at 11:00:19PM +, brian m. carlson wrote: > Yes, basically, but a bit more generally. There will always be cases in > which we need to specify an object ID or an arbitrary string and the > behavior will need to vary based on the hash. That can be something > like, in this

Re: Contact with Latinamerica

2017-07-30 Thread Andrew Ardill
On 31 July 2017 at 04:01, Philip Oakley wrote: > From: "Christopher Díaz" > >> As one of the main problems when getting involved with a community here >> is the barrier of english language, and few are able to have fluent >> conversations in that language, as it is a bit intimidating for most to

Re: Contact with Latinamerica

2017-07-30 Thread Christopher Díaz
>  >  > Another idea, and I don't think anyone has done this yet, would be to > localise news posts coming out of projects. >  That's awesome Andrew, thanks a lot for the idea, it could be very good to have such a media where all the news about projects could be easily found! Indeed that's somethi

Its me Ruth

2017-07-30 Thread Ruth Mawere
-- Hello Dear, Its me Ruth, did you receive my previous email? please write me back immediately to let me know, i wait to hear back from you, kisses. Hallo Liebe, Es ist mir Ruth, hast du meine vorherige E-Mail erhalten? Bitte schreibe mir sofort zurück, um mich wissen zu lassen, ich warte

Re: [PATCH v2 05/10] git.c: provide setup_auto_pager()

2017-07-30 Thread Jeff King
On Mon, Jul 17, 2017 at 10:10:47PM +0200, Martin Ågren wrote: > The previous patch introduced a way for builtins to declare that they > will take responsibility for handling the `pager.foo`-config item. (See > the commit message of that patch for why that could be useful.) > > Provide setup_auto_

Re: [PATCH v2 06/10] t7006: add tests for how git tag paginates

2017-07-30 Thread Jeff King
On Mon, Jul 17, 2017 at 10:10:48PM +0200, Martin Ågren wrote: > diff --git a/t/t7006-pager.sh b/t/t7006-pager.sh > index 20b4d83c2..e7430bc93 100755 > --- a/t/t7006-pager.sh > +++ b/t/t7006-pager.sh > @@ -134,6 +134,74 @@ test_expect_success TTY 'configuration can enable pager > (from subdir)' '

Re: [PATCH v2 08/10] tag: respect `pager.tag` in list-mode only

2017-07-30 Thread Jeff King
On Mon, Jul 17, 2017 at 10:10:50PM +0200, Martin Ågren wrote: > test_expect_success TTY 'git tag -a respects --paginate' ' > test_when_finished "git tag -d newtag" && > rm -f paginated.out && > - test_terminal git -c pager.tag=false --paginate \ > - tag -am message new

Re: [PATCH v2 10/10] git.c: ignore pager.* when launching builtin as dashed external

2017-07-30 Thread Jeff King
On Mon, Jul 17, 2017 at 10:10:52PM +0200, Martin Ågren wrote: > When running, e.g., `git -c alias.bar=foo bar`, we expand the alias and > execute `git-foo` as a dashed external. This is true even if git foo is > a builtin. That is on purpose, and is motivated in a comment which was > added in comm

Re: [PATCH v2 00/10] tag: only respect `pager.tag` in list-mode

2017-07-30 Thread Jeff King
On Sun, Jul 23, 2017 at 08:17:42PM +0200, Martin Ågren wrote: > On 21 July 2017 at 00:27, Junio C Hamano wrote: > > I tend to agree with you that 1-3/10 may be better off being a > > single patch (or 3/10 dropped, as Brandon is working on losing it > > nearby). I would have expected 7-8/10 to be

Re: reftable [v4]: new ref storage format

2017-07-30 Thread Shawn Pearce
4th iteration of the reftable storage format. You can read a rendered version of this here: https://googlers.googlesource.com/sop/jgit/+/reftable/Documentation/technical/reftable.md Significant changes from v3: - Incorporated Michael Haggerty's update_index concept for reflog. - Explicitly docume