Re: [PATCH v3 4/9] ref-filter: add support to sort by version

2015-07-19 Thread Eric Sunshine
On Sat, Jul 18, 2015 at 3:12 PM, Karthik Nayak wrote: > Add support to sort by version using the "v:refname" and > "version:refname" option. This is achieved by using the > 'version_cmp()' function as the comparing function for qsort. To agree with the actual code: s/version_cmp/versioncmp/ > Th

Re: [msysGit] [PATCH v2 08/16] engine.pl: ignore invalidcontinue.obj which is known to MSVC

2015-07-19 Thread Eric Sunshine
On Sun, Jul 19, 2015 at 4:08 PM, Philip Oakley wrote: > Commit 4b623d8 (MSVC: link in invalidcontinue.obj for better > POSIX compatibility, 2014-03-29) is not processed correctly > by the buildsystem. Ignore it. What does "not processed correctly" mean? For a person reading the commit message, bu

Re: [msysGit] [PATCH v2 10/16] engine.pl: delete the captured stderr file if empty

2015-07-19 Thread Eric Sunshine
On Sun, Jul 19, 2015 at 4:08 PM, Philip Oakley wrote: > Keep the build clean of extraneous files if it is indeed clean. > Otherwise leave the msvc-build-makedryerrors.txt file both as > a flag for any CI system or for manual debugging. > > Note that the file will contain the new values of the GIT_

[PATCH v2 2/5] Documentation/git-worktree: fix incorrect reference to file "locked"

2015-07-19 Thread Eric Sunshine
From: Michael Haggerty The administrative file to suppress pruning is named "locked", not "lock". [es: don't touch unrelated "git worktree lock" command; reword commit message] Signed-off-by: Michael Haggerty Signed-off-by: Eric Sunshine --- Documentation/git-worktree.txt | 2 +- 1 file chan

[PATCH v2 0/5] mh: worktree-related doc fixes

2015-07-19 Thread Eric Sunshine
This re-roll of Michael Haggerty's worktree-related documentation tweaks[1] takes my review comments into account and adds one new patch. A v1 to v2 interdiff is included below. Changes since v1: patch 1/5: fix additional instances of "worktree" -> "working tree" patch 2/5: don't rename "git wor

[PATCH v2 1/5] Documentation/git-worktree: consistently use term "linked working tree"

2015-07-19 Thread Eric Sunshine
From: Michael Haggerty Sometimes linked working trees were called "linked working directories" or "linked worktrees". Always refer to them as "linked working trees" for consistency. [es: fix additional occurrences] Signed-off-by: Michael Haggerty Signed-off-by: Eric Sunshine --- Documentatio

[PATCH v2 5/5] config: rename "gc.pruneWorktreesExpire" to "gc.worktreePruneExpire"

2015-07-19 Thread Eric Sunshine
As of df0b6cf (worktree: new place for "git prune --worktrees", 2015-06-29), linked worktree pruning functionality moved from "git prune --worktrees" to "git worktree prune". Rename the associated configuration variable accordingly. Signed-off-by: Eric Sunshine --- I'm not convinced this is wort

[PATCH v2 3/5] Documentation/config: fix stale "git prune --worktree" reference

2015-07-19 Thread Eric Sunshine
From: Michael Haggerty This should have been changed to "git worktree prune" by df0b6cf (worktree: new place for "git prune --worktrees", 2015-06-29) [es: reword commit message] Signed-off-by: Michael Haggerty Signed-off-by: Eric Sunshine --- Documentation/config.txt | 2 +- 1 file changed,

[PATCH v2 4/5] Documentation/git-worktree: wordsmith worktree-related manpages

2015-07-19 Thread Eric Sunshine
From: Michael Haggerty [es: reword .git/worktrees and .git/worktrees//locked descriptions] Signed-off-by: Michael Haggerty Signed-off-by: Eric Sunshine --- Documentation/config.txt | 8 Documentation/gitrepository-layout.txt | 16 2 files changed, 12 i

Re: How to use --cc-cmd in git-send-email?

2015-07-19 Thread Philip Oakley
From: "Eric Sunshine" On Sun, Jul 19, 2015 at 6:02 PM, Philip Oakley wrote: I've been using git-send-email with repeated individual --cc="email address" parameters on the command line. I tried putting all the addresses, one per line, into a file 'cc-cmd', so I could use if for the --cc-cmd

Re: How to use --cc-cmd in git-send-email?

2015-07-19 Thread Eric Sunshine
On Mon, Jul 20, 2015 at 2:01 AM, Philip Oakley wrote: > From: "Eric Sunshine" >> git-send-email invokes the cc-cmd like this: >> >>$cc-cmd $patchfilename >> >> so, when you used 'cat cc-cmd' as the value of --cc-cmd, your invocation >> became: >> >>cat cc-cmd $patchfilename >> >> and sinc

Re: [msysGit] [PATCH v2 08/16] engine.pl: ignore invalidcontinue.obj which is known to MSVC

2015-07-19 Thread Philip Oakley
From: "Eric Sunshine" Sent: Monday, July 20, 2015 2:54 AM On Sun, Jul 19, 2015 at 4:08 PM, Philip Oakley wrote: Commit 4b623d8 (MSVC: link in invalidcontinue.obj for better POSIX compatibility, 2014-03-29) is not processed correctly by the buildsystem. Ignore it. What does "not processed cor

Re: [msysGit] [PATCH v2 10/16] engine.pl: delete the captured stderr file if empty

2015-07-19 Thread Philip Oakley
From: "Eric Sunshine" On Sun, Jul 19, 2015 at 4:08 PM, Philip Oakley wrote: Keep the build clean of extraneous files if it is indeed clean. Otherwise leave the msvc-build-makedryerrors.txt file both as a flag for any CI system or for manual debugging. Note that the file will contain the new v

Re: [PATCH v3 5/9] ref-filter: add option to match literal pattern

2015-07-19 Thread Eric Sunshine
On Sat, Jul 18, 2015 at 3:12 PM, Karthik Nayak wrote: > Since 'ref-filter' only has an option to match path names add an > option for plain fnmatch pattern-matching. > > This is to support the pattern matching options which are used in `git > tag -l` and `git branch -l` where we can match patterns

Re: [msysGit] [PATCH v2 10/16] engine.pl: delete the captured stderr file if empty

2015-07-19 Thread Eric Sunshine
On Mon, Jul 20, 2015 at 2:16 AM, Philip Oakley wrote: > From: "Eric Sunshine" >> On Sun, Jul 19, 2015 at 4:08 PM, Philip Oakley >> wrote: >>> Keep the build clean of extraneous files if it is indeed clean. >>> Otherwise leave the msvc-build-makedryerrors.txt file both as >>> a flag for any CI sy

<    1   2