fixup for 05/10: plug leak

2014-07-28 Thread René Scharfe
Noticed-by: Jeff King --- abspath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/abspath.c b/abspath.c index 16e7fa2..6aa328f 100644 --- a/abspath.c +++ b/abspath.c @@ -58,7 +58,7 @@ static const char *real_path_internal(const char *path, int die_on_error)

Re: git diff-tree commit detail bug in 2.0.2 and 2.0.3

2014-07-28 Thread Junio C Hamano
Junio C Hamano writes: >>> Yeah, I'm fine with a straight revert, too (I think it is fine to keep >>> in master, though). I think jk/alloc-commit-id is built right on top of >>> the original commit-slab topic, so it should be easy to do either way. >>> >>> Thanks for dealing with it. >> >> Whate

stash-p broken?

2014-07-28 Thread Michael Migdol
I recently upgraded from Ubuntu 13.10 to Ubuntu 14.04. After doing so, "git stash -p" stopped working. (It apparently is ignoring the -p parameter). I'm not sure what version I was using previously, but after some experimentation, I see that: version 1.7.12.2 : stash -p DOES work version 1.9.3

Re: stash-p broken?

2014-07-28 Thread Michael Migdol
Sorry for error -- I meant: git stash list -p, not git stash -p. On Mon, Jul 28, 2014 at 5:38 PM, Michael Migdol wrote: > I recently upgraded from Ubuntu 13.10 to Ubuntu 14.04. After doing so, > "git stash -p" stopped working. (It apparently is ignoring the -p > parameter). I'm not sure what v

Re: git diff-tree commit detail bug in 2.0.2 and 2.0.3

2014-07-28 Thread Bryan Turner
On Tue, Jul 29, 2014 at 10:11 AM, Junio C Hamano wrote: > Junio C Hamano writes: > Yeah, I'm fine with a straight revert, too (I think it is fine to keep in master, though). I think jk/alloc-commit-id is built right on top of the original commit-slab topic, so it should be easy to

Re: stash-p broken?

2014-07-28 Thread brian m. carlson
On Mon, Jul 28, 2014 at 05:56:28PM -0700, Michael Migdol wrote: > Sorry for error -- I meant: git stash list -p, not git stash -p. > > On Mon, Jul 28, 2014 at 5:38 PM, Michael Migdol > wrote: > > I recently upgraded from Ubuntu 13.10 to Ubuntu 14.04. After doing so, > > "git stash -p" stopped w

[PATCH] use a hashmap to make remotes faster

2014-07-28 Thread patrick.reyno...@github.com
Remotes are stored as an array, so looking one up or adding one without duplication is an O(n) operation. Reading an entire config file full of remotes is O(n^2) in the number of remotes. For a repository with tens of thousands of remotes, the running time can hit multiple minutes. Hash tables a

Re: [PATCH 0/5] coverity mixed bag

2014-07-28 Thread Stefan Beller
On 24.07.2014 06:39, Jeff King wrote: > Since Stefan has recently started feeding git builds to coverity, I > spent a few minutes poking through the results. There are tons of false > positives, so there is some work to be done there with tweaking our > coverity models. But there are some real issu

Re: "error: Tweaking file descriptors doesn't work with this MSVCRT.dll" on wine

2014-07-28 Thread Torsten Bögershausen
On 07/28/2014 12:39 PM, Duy Nguyen wrote: I know wine is kind of second citizen but is there a cheap trick to make it work on wine? Reverting fcd428f (Win32: fix broken pipe detection - 2012-03-01) could result in conflicts in compat that I'm not comfortable resolving. I don't have Windows at hom

Re: git add -i failed in 2.0.3

2014-07-28 Thread Torsten Bögershausen
On 07/27/2014 05:26 PM, Guang Chen wrote: I use brew upgrade git to this version on OSX. And when I use git add -i, it says: Which version did you use before? Was it installed with brew as well ? Can't locate Git.pm in @INC (@INC contains: @@@/git/2.0.3/lib/perl5/site_perl /Applications/Xcod

Re: stash-p broken?

2014-07-28 Thread Øystein Walle
brian m. carlson crustytoothpaste.net> writes: > > On Mon, Jul 28, 2014 at 05:56:28PM -0700, Michael Migdol wrote: > > Sorry for error -- I meant: git stash list -p, not git stash -p. > > > > On Mon, Jul 28, 2014 at 5:38 PM, Michael Migdol migdol.net> wrote: > > > I recently upgraded from Ubun

Re: git add -i failed in 2.0.3

2014-07-28 Thread Guang Chen
I used 1.9.2 before, it was installed with brew as well. I didn’t found Git.pm under /usr/local/Cellar/git/, /usr/local/Cellar/git/2.0.3/, and I looked at /usr/local/Cellar/git/1.9.2/, there isn’t a Git.pm either. type perl says: perl is /usr/bin/perl Additionally, perl --version says: This is

<    1   2