In order for non-win32 platforms to be able to use poll.c, #ifdef the
inclusion of two header files in the same manner as it's done elsewhere
in git.
Signed-off-by: Joachim Schmitz
---
compat/poll/poll.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/compat/poll/poll.
This way it just got added to gnulib too the other day.
Signed-off-by: Joachim Schmitz
---
compat/poll/poll.c | 5 +
1 file changed, 4 insertions(+)
diff --git a/compat/poll/poll.c b/compat/poll/poll.c
index e4b8319..10a204e 100644
--- a/compat/poll/poll.c
+++ b/compat/poll/poll.c
@@ -306,6
If poll() is used as a milli-second sleep, like in help.c, by passing a NULL
in the 1st and a 0 in the 2nd arg, it exits with EFAULT.
As per Paolo Bonzini, the original author, this is a bug and to be fixed
like
in this commit, which is not to exit if the 2nd arg is 0. It got fixed in
gnulib in
> From: Joachim Schmitz [mailto:j...@schmitz-digital.de]
> Sent: Saturday, September 15, 2012 7:15 PM
> To: 'Junio C Hamano'
> Cc: 'git@vger.kernel.org'
> Subject: RE: What's cooking in git.git (Sep 2012, #05; Fri, 14)
>
> > From: Junio C Hamano [mailto:gits...@pobox.com]
> > Sent: Saturday, Septe
On 17/09/12 05:50, Junio C Hamano wrote:
Luke Diamand writes:
On 16/09/12 07:05, Junio C Hamano wrote:
Luke Diamand writes:
Looks good to me, ack.
Thanks; is this an ack for the entire series, or are you expecting
further back-and-forth with Pete before the whole thing is ready?
An ac
On 09/15/2012 06:18 PM, Ramsay Jones wrote:
>
> In particular, sparse complains as follows:
>
> SP test-string-list.c
> test-string-list.c:10:6: warning: symbol 'parse_string_list' was not \
> declared. Should it be static?
> test-string-list.c:18:6: warning: symbol 'write
Hi Eric et al,
Michael G. Schwern wrote:
> Then later it can be canonicalized automatically rather than everywhere
> its used.
>
> Later patch will make other things use it.
Wow am I slow. I've finally got around to starting to parse these
patches to apply to a 1.7.10.y tree so they can (hopefu
From: Michael G. Schwern
Date: Fri, 27 Jul 2012 13:00:48 -0700
Each Git::SVN handle has a (base) URL and a (relative) path pointing
to the top-level directory of the branch it handles. Introduce a
getter and setter for the path as preparation for automatically
canonicalizing it when reading or w
From: Michael G. Schwern
Date: Fri, 27 Jul 2012 13:00:48 -0700
This patch only touches the simplest cases that simply read the
Git::SVN field rather than assigning to or applying a substitution to
it.
Code to change found by searching for the term {path}.
[jn: extracted from a larger patch]
Si
From: Michael G. Schwern
Date: Fri, 27 Jul 2012 13:00:48 -0700
This patch only touches cases where the path field is written to using
$gs->{path}. Cases where the path is set directly in a hash literal
will be addressed separately.
[jn: split from a larger patch]
Signed-off-by: Eric Wong
Sign
From: Michael G. Schwern
Date: Fri, 27 Jul 2012 13:00:48 -0700
If some day the setter is taught to canonicalize paths, make sure the
path gets canonicalized at construction time, too.
[jn: split from a larger patch]
Signed-off-by: Eric Wong
Signed-off-by: Jonathan Nieder
---
perl/Git/SVN.pm
All users of $gs->{path} should have been converted to use the
accessor by now. Check our work by renaming the underlying variable
to break callers that try to use it directly.
Signed-off-by: Jonathan Nieder
---
perl/Git/SVN.pm |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
vi0...@gmail.com writes:
>From: Vitaly _Vi Shukela
>
>Make Ctrl+U for unstaging and Ctrl+J for reverting selection behave
>more like Ctrl+T for adding.
>
>They were working only when one area was focused (diff or commit message),
>now they should work everywhere.
>
>Signed-off-by: Vitaly _Vi Shuk
Hi Enrico,
Repositories as old and large as ASF are the reason I created svn-fe.
git-svn is known to choke on these repositories.
If you have plenty of bandwidth, it might well be faster to:
* Grab an ASF archive (16GB)
* Use svn-fe to import the entire tree into git.
* Use a simple script to ext
Junio C Hamano writes:
>Beat Bolli writes:
>
>> No po update needed, as this string is untranslated.
>>
>> Signed-off-by: Beat Bolli
>> ---
>> git-gui/lib/commit.tcl |2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/git-gui/lib/commit.tcl b/git-gui/lib/commit.tcl
>
Signed-off-by: Adam Spiers
---
builtin/check-attr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/check-attr.c b/builtin/check-attr.c
index e1ff575..075d01d 100644
--- a/builtin/check-attr.c
+++ b/builtin/check-attr.c
@@ -9,7 +9,7 @@ static int cached_attrs;
static
1. Change the color of individual known breakages from bold green to
bold yellow. This seems more appropriate when considering the
universal traffic lights coloring scheme, where green conveys the
impression that everything's OK, and amber that something's not
quite right.
2. Likewise
Junio C Hamano writes:
>Beat Bolli writes:
>
>> Adding __git_ps1() to one's bash prompt displays various repo status
>> info after each command. After committing a git cherry-pick -n using
>> git-gui, the prompt still contains the "|CHERRY-PICKING" flag.
>>
>> Delete the file causing this flag w
On Sun, Sep 16, 2012 at 3:13 PM, Ralf Thielow wrote:
> + if (option_mirror || !option_bare) {
> + strbuf_reset(&value);
I think we should use a new strbuf local variable here to avoid
resetting this. At least reviewers don't have to check if this
statememt causes any effect la
On Mon, Sep 17, 2012 at 7:06 PM, Nguyen Thai Ngoc Duy wrote:
> --mirror --single-branch combination does not look right. The "heads/"
> part is missing..
It also does not look right for cloning a tag:
$ LANG=C ./git clone --single-branch --branch=v1.7.0 .git abc
Cloning into 'abc'...
done.
Note:
2012/9/15 Junio C Hamano :
> Junio C Hamano writes:
>
>> Elia Pinto writes:
>>
>>> Recent versions of Linux libc (later than 5.4.23) and glibc (2.x)
>>> include a malloc() implementation which is tunable via environment
>>> variables. When MALLOC_CHECK_ is set, a special (less efficient)
>>> impl
On 09/10/2012 10:56 PM, Junio C Hamano wrote:
> Michael Haggerty writes:
>> diff --git a/fetch-pack.h b/fetch-pack.h
>> index 1dbe90f..a6a8a73 100644
>> --- a/fetch-pack.h
>> +++ b/fetch-pack.h
>> @@ -1,6 +1,8 @@
>> #ifndef FETCH_PACK_H
>> #define FETCH_PACK_H
>>
>> +#include "string-list.h"
>
> -Original Message-
> From: Junio C Hamano [mailto:gits...@pobox.com]
> Sent: Friday, September 14, 2012 4:24 PM
> To: Michael J Gruber
> Cc: Johannes Sixt; Mestnik, Michael J - Eagan, MN -
> Contractor; git@vger.kernel.org
> Subject: Re: Using Format/export-subst Howto.
>
> Michael J
On Sun, Sep 16, 2012 at 10:54:57PM -0700, Junio C Hamano wrote:
> Yeah, popt.h it is. It is a bit distasteful that we have a build
> dependency only to build test-* helper on something that we do not
> even have runtime dependency on.
Perhaps this squash-in? It kills libpopt and removes the "#inc
Add Ada xfuncname and wordRegex patterns to the list of builtin
patterns.
Signed-off-by: Adrian Johnson
---
On 17/09/12 14:29, Junio C Hamano wrote:
> You could add test vectors to check if the built-in xfuncname
> catches beginning of functions in Ada correctly if you wanted to,
> but I think ob
On 09/11/2012 12:10 AM, Junio C Hamano wrote:
> Michael Haggerty writes:
>
>>> OK. As long as the sort order matches the order string-list
>>> internally uses for its bisection search, it won't be a problem,
>>> then.
>>
>> The sorting is crucial but there is no bisection involved. The sorted
>
Hi Thomas,
Thomas Rast wrote:
> The only bug right now is that $GIT_TEST_CMP is needed for test_cmp to
> work.
What bug? You're exporting it, right?
> test_perf 'test-lib-functions correctly loaded in subshells' '
> : >a &&
> - test_path_is_file a
> + test_path_is_file a &&
On Mon, Sep 17, 2012 at 2:06 PM, Nguyen Thai Ngoc Duy wrote:
> On Sun, Sep 16, 2012 at 3:13 PM, Ralf Thielow wrote:
>> + if (option_mirror || !option_bare) {
>> + strbuf_reset(&value);
>
> I think we should use a new strbuf local variable here to avoid
> resetting this. At lea
Junio C Hamano venit, vidit, dixit 14.09.2012 23:23:
> Michael J Gruber writes:
>
>> you need to "rm file && git checkout file"). If the user has to
>> update $Id$ to match the current sha1 (by remembering to do a more
>> forceful checkout than checkout -f) then one half of that feature
>> is use
> -Original Message-
> From: Michael J Gruber [mailto:g...@drmicha.warpmail.net]
> Sent: Monday, September 17, 2012 8:17 AM
> To: Junio C Hamano
> Cc: Johannes Sixt; Mestnik, Michael J - Eagan, MN -
> Contractor; git@vger.kernel.org
> Subject: Re: Using Format/export-subst Howto.
>
> Ju
Mestnik, Michael J - Eagan, MN - Contractor venit, vidit, dixit
17.09.2012 14:12:
>
>> -Original Message-
>> From: Junio C Hamano [mailto:gits...@pobox.com]
>> Sent: Friday, September 14, 2012 4:24 PM
>> To: Michael J Gruber
>> Cc: Johannes Sixt; Mestnik, Michael J - Eagan, MN -
>> Contr
Hi,
The following test in t1304-default-acl.sh fails for me on the latest master:
test_expect_success SETFACL 'Objects creation does not break ACLs with
restrictive umask' '
# SHA1 for empty blob
check_perms_and_acl
.git/objects/e6/9de29bb2d1d6434b8b29ae775ad8c2e48c5391
'
It fai
On Monday, September 17, 2012 00:03:29 Junio C Hamano wrote:
> An alternative would be to lose the "8" (or `tabwidth`) from that
> description. I've always thought that the description of `tabwidth`
> is clear enough that "8" in the patch is not a hardcoded non-overridable
> value but is merely a
Mestnik, Michael J - Eagan, MN - Contractor venit, vidit, dixit
17.09.2012 16:08:
>
>> -Original Message-
>> From: Michael J Gruber [mailto:g...@drmicha.warpmail.net]
>> Sent: Monday, September 17, 2012 8:45 AM
>> To: Mestnik, Michael J - Eagan, MN - Contractor
>> Cc: Junio C Hamano; Joha
From: "Wesley J. Landaker"
Update the documentation of the core.whitespace option
"indent-with-non-tab" to correctly reflect that it catches the use of
spaces instead of the equivalent tabs, rather than a fixed number.
Signed-off-by: Wesley J. Landaker
---
Documentation/config.txt |5 +++--
> -Original Message-
> From: Michael J Gruber [mailto:g...@drmicha.warpmail.net]
> Sent: Monday, September 17, 2012 8:45 AM
> To: Mestnik, Michael J - Eagan, MN - Contractor
> Cc: Junio C Hamano; Johannes Sixt; git@vger.kernel.org
> Subject: Re: Using Format/export-subst Howto.
>
> Mestn
Ramkumar Ramachandra writes:
> # file: .git/objects/e6/9de29bb2d1d6434b8b29ae775ad8c2e48c5391
> # owner: ramkum
> # group: domain^users
> user::r--
> user:root:rwx #effective:r--
> user:kseygold:rwx #effective:r--
> group::---
> mask::r--
> other::---
>
> I'm not sure who or what kseygold
Hi Matthieu,
Matthieu Moy wrote:
> Do you have any user with this login (finger kseygold)? I suspect you
> have two usernames with the same user ID.
Login: kseygold Name: Seybold
Directory: /home/likewise-open/ANT/kseygold Shell: /bin/zsh
Office: Kelly
Last login Tue
Given the git project policy that *.c files that include header files
are responsible for including everything the headers they include
need, there is no need for fetch-pack.h to include string-list.h
itself. As for the files that include fetch-pack.h:
* builtin/clone.c and builtin/fetch-pack.c
Junio pointed out that the sort order currently used by string_list
could be considered to be an implementation detail internal to
string_list. But the sort order is already visible to the outside
world (e.g., via iteration or via print_string_list()), so it
shouldn't be changed willy-nilly. Ther
Ramkumar Ramachandra writes:
> Hi Matthieu,
>
> Matthieu Moy wrote:
>> Do you have any user with this login (finger kseygold)? I suspect you
>> have two usernames with the same user ID.
>
> Login: kseygold Name: Seybold
> Directory: /home/likewise-open/ANT/kseygold She
Ramkumar Ramachandra writes:
> Hi Matthieu,
>
> Matthieu Moy wrote:
>> Do you have any user with this login (finger kseygold)? I suspect you
>> have two usernames with the same user ID.
>
> Login: kseygold Name: Seybold
What about "id kseygold; id ramkum"?
Andreas.
--
Hi Andreas,
Andreas Schwab wrote:
> Ramkumar Ramachandra writes:
>
>> Hi Matthieu,
>>
>> Matthieu Moy wrote:
>>> Do you have any user with this login (finger kseygold)? I suspect you
>>> have two usernames with the same user ID.
>>
>> Login: kseygold Name: Seybold
>
> What
Ramkumar Ramachandra writes:
> Hi again,
>
> Matthieu Moy wrote:
>> Does this user have the same UID as your usual user
>> (id kseygold; id $LOGNAME)?
>
> Yes. What do you propose we do about the test?
On a GNU system, something like this should do the trick:
--- a/t/t1304-default-acl.sh
+++ b
> -Original Message-
> From: Michael J Gruber [mailto:g...@drmicha.warpmail.net]
> Sent: Monday, September 17, 2012 9:21 AM
> To: Mestnik, Michael J - Eagan, MN - Contractor
> Cc: Junio C Hamano; Johannes Sixt; git@vger.kernel.org
> Subject: Re: Using Format/export-subst Howto.
>
> Mestn
On Sun, 2012-09-16 at 19:45 +0800, Paul Wise wrote:
> bzr: git-remote-bzr is part of bzr-git but it is quite buggy,
> hopefully this will improve over time though.
I've now learned that the main upstream for bzr-git is slowly stepping
down from his involvement in Bazaar and Bazaar packaging, so i
Matthieu Moy writes:
> Ramkumar Ramachandra writes:
>
>> Hi again,
>>
>> Matthieu Moy wrote:
>>> Does this user have the same UID as your usual user
>>> (id kseygold; id $LOGNAME)?
>>
>> Yes. What do you propose we do about the test?
>
> On a GNU system, something like this should do the trick:
Junio C Hamano writes:
> I haven't been paying attention, but does that mean on that system,
> a total stranger kseygold can write, modify, and remove whatever Ram
> owns? I am hoping that is not the case.
I can see two reasons for having the same UID for two login names:
1) the sysadmin reall
When tests were run without building git, the following error message
was displayed:
.: 54: Can't open /path/to/git/source/t/../GIT-BUILD-OPTIONS
Change this to display a more user-friendly error message:
error: you do not seem to have built git yet.
Signed-off-by: Ramkumar Ramachandra
Signed-off-by: Ramkumar Ramachandra
---
t/perf/.gitignore |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/t/perf/.gitignore b/t/perf/.gitignore
index 50f5cc1..0061cbc 100644
--- a/t/perf/.gitignore
+++ b/t/perf/.gitignore
@@ -1,2 +1,3 @@
-build/
-test-results/
+/build
Ramkumar Ramachandra writes:
> Hi Andreas,
>
> Andreas Schwab wrote:
>> Ramkumar Ramachandra writes:
>>
>>> Hi Matthieu,
>>>
>>> Matthieu Moy wrote:
Do you have any user with this login (finger kseygold)? I suspect you
have two usernames with the same user ID.
>>>
>>> Login: kseygold
Tomas Cohen Arazi writes:
> Hi, I'm not sure it is a bug, but we used:
>
> git config --global format.headers "Content-Type: text/plain;
> charset=\"utf-8\""
>
> and recently (perhaps an Ubuntu default setup issue) the content-type
> is being automatically set, the result is that patches contain
Nguyen Thai Ngoc Duy writes:
> On Sun, Sep 16, 2012 at 10:54:57PM -0700, Junio C Hamano wrote:
>> Yeah, popt.h it is. It is a bit distasteful that we have a build
>> dependency only to build test-* helper on something that we do not
>> even have runtime dependency on.
>
> Perhaps this squash-in?
On Mon, Sep 17, 2012 at 10:31:07PM +0530, Ramkumar Ramachandra wrote:
> I tried running `make valgind` inside t/ and got:
>
> bug in test framework: multiple prerequisite tags do not work reliably
>
> which means that even the basic tests don't pass. Am I doing something wrong?
No, that sh
"Wesley J. Landaker" writes:
> From: "Wesley J. Landaker"
>
> Update the documentation of the core.whitespace option
> "indent-with-non-tab" to correctly reflect that it catches the use of
> spaces instead of the equivalent tabs, rather than a fixed number.
>
> Signed-off-by: Wesley J. Landaker
Hi Peff,
Jeff King wrote:
> No, that should work (and it does work here). I assume you can pass
> t without --valgrind?
Yes. Here's the output from running it with --valgrind. I'm digging
deeper to see what went wrong.
make_valgrind_symlink:6: permission denied:
/home/artagnon/src/git/t/..
On Mon, Sep 17, 2012 at 10:53:18PM +0530, Ramkumar Ramachandra wrote:
> Hi Peff,
>
> Jeff King wrote:
> > No, that should work (and it does work here). I assume you can pass
> > t without --valgrind?
>
> Yes. Here's the output from running it with --valgrind. I'm digging
> deeper to see wh
Am 14.09.2012 19:28, schrieb Johannes Sixt:
> Am 14.09.2012 18:58, schrieb Erik Faye-Lund:
>> tput () {
>> case "$1" in
>> bold)
>> -echo -ne "\033[1m" ;;
>> +printf "\033[1m" ;;
>> setaf)
>> -ec
On Sun, Sep 16, 2012 at 10:24:04PM -0700, Junio C Hamano wrote:
> Mischa POSLAWSKY writes:
>
> > Matching the default file prefix b/ does not yield any results if config
> > option diff.noprefix or diff.mnemonicprefix is enabled.
> >
> > Signed-off-by: Mischa POSLAWSKY
> > ---
> > Very useful s
Hi again,
Jeff King wrote:
> That's certainly odd. It sounds like the valgrind setup is broken for
> you. Can you run:
>
> sh -x t-basic.sh --valgrind
>
> and see what's happening near those weird errors?
Not helpful:
+ . ./test-lib.sh
+ mkdir -p test-results
+ basename t-basic.sh .sh
On Mon, Sep 17, 2012 at 11:09:27PM +0530, Ramkumar Ramachandra wrote:
> Hi again,
>
> Jeff King wrote:
> > That's certainly odd. It sounds like the valgrind setup is broken for
> > you. Can you run:
> >
> > sh -x t-basic.sh --valgrind
> >
> > and see what's happening near those weird errors
Am 17.09.2012 19:44, schrieb Jeff King:
> Oh, bleh. Stupid automatic --tee for valgrind. Try this:
>
> SHELL="/usr/bin/zsh -x" ./t-basic.sh --valgrind
>
> I am also doing my tests with "dash" as my shell. You might try setting
> your SHELL to /bin/sh to see if it makes a difference.
Should
On Mon, Sep 17, 2012 at 07:55:24PM +0200, Johannes Sixt wrote:
> Am 17.09.2012 19:44, schrieb Jeff King:
> > Oh, bleh. Stupid automatic --tee for valgrind. Try this:
> >
> > SHELL="/usr/bin/zsh -x" ./t-basic.sh --valgrind
> >
> > I am also doing my tests with "dash" as my shell. You might
Matthieu Moy wrote:
Junio C Hamano writes:
I haven't been paying attention, but does that mean on that system,
a total stranger kseygold can write, modify, and remove whatever Ram
owns? I am hoping that is not the case.
I can see two reasons for having the same UID for two login names:
1)
mv: cannot stat `perl.mak': No such file or directory
mv: cannot move `perl.mak' to `perl.mak.old': No such file or directory
Writing perl.mak for Git
Writing MYMETA.yml
Writing perl.mak for Git
Writing MYMETA.yml
Writing perl.mak for Git
Writing MYMETA.yml
make[2]: *** [perl.mak] Error 1
make[1]:
Hi,
Jeff King wrote:
> Oh, bleh. Stupid automatic --tee for valgrind. Try this:
>
> SHELL="/usr/bin/zsh -x" ./t-basic.sh --valgrind
I got tons of output, but found it unhelpful. Any other ideas?
Ram
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message
On Mon, Sep 17, 2012 at 11:19:35PM +0530, Ramkumar Ramachandra wrote:
> +./test-lib.sh:477> file=/home/artagnon/src/git/t/../git-instaweb
> +./test-lib.sh:479> make_valgrind_symlink
> /home/artagnon/src/git/t/../git-instaweb
> +make_valgrind_symlink:5> test -x /home/artagnon/src/git/t/../git-insta
After running "git clone --single", the resulting repository has the
usual default "+refs/heads/*:refs/remotes/origin/*" wildcard fetch
refspec installed, which means that a subsequent "git fetch" will
end up grabbing all the other branches.
Update the fetch refspec to cover only the singly cloned
On Mon, Sep 17, 2012 at 08:13:35PM +0200, Alex Riesen wrote:
> mv: cannot stat `perl.mak': No such file or directory
> mv: cannot move `perl.mak' to `perl.mak.old': No such file or directory
> [...]
> I wasn't able to reproduce it, so this message is the only thing I have.
> It was the first compi
Jeff King writes:
> On Sun, Sep 16, 2012 at 10:24:04PM -0700, Junio C Hamano wrote:
>
>> Mischa POSLAWSKY writes:
>>
>> > Matching the default file prefix b/ does not yield any results if config
>> > option diff.noprefix or diff.mnemonicprefix is enabled.
>> >
>> > Signed-off-by: Mischa POSLAWS
Nguyen Thai Ngoc Duy writes:
> --mirror --single-branch combination does not look right. The "heads/"
> part is missing..
What does it supposed to do in the first place? "mirror" is
primarily about grabbing everything without leaving stuff out, and
"single" is about grabbing only one thing with
Nguyen Thai Ngoc Duy writes:
> On Mon, Sep 17, 2012 at 7:06 PM, Nguyen Thai Ngoc Duy
> wrote:
>> --mirror --single-branch combination does not look right. The "heads/"
>> part is missing..
>
> It also does not look right for cloning a tag:
>
> $ LANG=C ./git clone --single-branch --branch=v1.7.
On Mon, Sep 17, 2012 at 12:50:37PM +0100, Adam Spiers wrote:
> The end result of these changes is that:
>
> - red is _only_ used for things which have gone unexpectedly wrong:
> test failures, unexpected test passes, and failures with the
> framework,
>
> - yellow is _only_ used for
Ralf Thielow writes:
> - handle --mirror option (test added)
Handle how? I personally think erroring out is the right way to
handle it, but if we care about people who have been misusing the
combination of single and mirror, the second best way would be to
imply "mirror" and "single" combinatio
On Sun, Sep 16, 2012 at 09:48:43PM +0200, Erik Faye-Lund wrote:
> >> git-upload-pack: error while loading shared libraries: libiconv.so.2:
> >> cannot open shared object file: No such file or directory
> >> fatal: The remote end hung up unexpectedly
>
> [...]
>
> No. This is not a Git for Windows
Michael J Gruber writes:
> Junio C Hamano venit, vidit, dixit 15.09.2012 00:26:
>> Junio C Hamano writes:
>>
>>> Michael J Gruber writes:
>>>
you need to "rm file && git checkout file"). If the user has to
update $Id$ to match the current sha1 (by remembering to do a
more force
Elia Pinto writes:
>> - That "165" thing I mentioned earlier.
>
> Thank you so much for the comments, that's fine. A single
> consideration for MALLOC_PERTURB.
>
> You can use any value between 1..255 for MALLOC_PERTURB_
> That chooses the byte that glibc will use to memset all freed buffers.
>
Matthieu Moy writes:
> Junio C Hamano writes:
>
>> I haven't been paying attention, but does that mean on that system,
>> a total stranger kseygold can write, modify, and remove whatever Ram
>> owns? I am hoping that is not the case.
>
> I can see two reasons for having the same UID for two log
> If I had to guess, I'd say it was ssh, the library is installed in a
> non-standard place (e.g., because he built them as a regular user and
> put them in his home directory), and LD_LIBRARY_PATH does not get set
> properly by ssh for the incoming ssh session.
This would be my guess as well. If
Michael Haggerty writes:
> It is interesting that you consider the sort order of string_list to be
> somewhat of an internal implementation detail. I had thought of its
> current behavior as being the obvious thing and considered it part of
> the API's contract. For example, the current sort or
Ramkumar Ramachandra writes:
> Hi Paul,
>
> Paul Wise wrote:
>> svn: there was a gsoc project for this but it was never merged:
>>
>> http://git.wiki.kernel.org/index.php/SoC2011Projects#Remote_helper_for_Subversion_and_git-svn
>
> I wouldn't give up on that yet. What is the status of fa/remote-h
Adam Spiers writes:
> Signed-off-by: Adam Spiers
> ---
> builtin/check-attr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/check-attr.c b/builtin/check-attr.c
> index e1ff575..075d01d 100644
> --- a/builtin/check-attr.c
> +++ b/builtin/check-attr.c
> @@ -9,7
Adam Spiers writes:
> 1. Change the color of individual known breakages from bold green to
>bold yellow. This seems more appropriate when considering the
>universal traffic lights coloring scheme, where green conveys the
>impression that everything's OK, and amber that something's no
Ramkumar Ramachandra writes:
> When tests were run without building git, the following error message
> was displayed:
>
> .: 54: Can't open /path/to/git/source/t/../GIT-BUILD-OPTIONS
>
> Change this to display a more user-friendly error message:
>
> error: you do not seem to have built g
I really wanted to take a look at this series, but with the broken
patches I cannot.
Try again, please, perhaps first sending patches to yourself and
make sure they come out without losing leading SP for context lines
and such.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe
On Mon, Sep 17, 2012 at 10:18 PM, Junio C Hamano wrote:
> Ralf Thielow writes:
>
>> - handle --mirror option (test added)
>
> Handle how? I personally think erroring out is the right way to
> handle it, but if we care about people who have been misusing the
> combination of single and mirror, th
Here's now my updated series of patches to make the win32 implementation of
poll() available to other platforms:
1 - make poll available for other platforms lacking it by moving it into a
separate directory and adjusting Makefile
2 - fix some win32 specific dependencies in poll.c by #ifdef the in
move poll.[ch] out of compat/win32/ into compat/poll/ and adjust
Makefile with the changed paths. Adding comments to Makefile about
how/when to enable it and add logic for this
Signed-off-by: Joachim Schmitz
---
Makefile | 20 +++-
compat/{win32 => poll}/poll
Michael Haggerty writes:
> Junio pointed out that the sort order currently used by string_list
> could be considered to be an implementation detail internal to
> string_list. But the sort order is already visible to the outside
> world (e.g., via iteration or via print_string_list()), so it
> sh
In order for non-win32 platforms to be able to use poll.c, #ifdef the
inclusion of two header files properly
Signed-off-by: Joachim Schmitz
---
compat/poll/poll.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/compat/poll/poll.c b/compat/poll/poll.c
index 9e7a25c..e4
If poll() is used as a milli-second sleep, like in help.c, by passing a NULL
in the 1st and a 0 in the 2nd arg, it exits with EFAULT.
As per Paolo Bonzini, the original author, this is a bug and to be fixed
Like in this commit, which is not to exit if the 2nd arg is 0. It got fixed
In gnulib in t
This way it just got added to gnulib too the other day.
Signed-off-by: Joachim Schmitz
---
compat/poll/poll.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/compat/poll/poll.c b/compat/poll/poll.c
index e4b8319..10a204e 100644
--- a/compat/poll/poll.c
+++ b/compat/poll/poll.c
@@ -306,6
Ramkumar Ramachandra writes:
> Signed-off-by: Ramkumar Ramachandra
> ---
> t/perf/.gitignore |5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/t/perf/.gitignore b/t/perf/.gitignore
> index 50f5cc1..0061cbc 100644
> --- a/t/perf/.gitignore
> +++ b/t/perf/.gitignor
Joachim Schmitz wrote:
Here's now my updated series of patches to make the win32 implementation
of poll() available to other platforms:
1 - make poll available for other platforms lacking it by moving it into
a separate directory and adjusting Makefile
2 - fix some win32 specific dependencies in
Ralf Thielow writes:
>>> - install correct refspec if the value of --branch is a tag (test added)
>>
>> What is the definition of "correct"? I see the documentation says
>> "--branch can also take tags and treat them like detached HEAD", and
>> even though I _think_ allowing tags was a huge mist
From: "Junio C Hamano"
Philip Oakley writes:
Avoid confusion in compound sentence about the start of the commit
set
and the depth measure. Use two sentences.
Dropping the first ',' after "positive depth" does not seem to make
it any easier to read (I personally think it makes it a lot hard
From: "Junio C Hamano"
Philip Oakley writes:
Include the gitignore link with the paired gitrepository-
layout link.
Signed-off-by: Philip Oakley
---
without the gitignore link users are unlikely to realise the
significance of the repository layout link, nor what to look for
within it
diff
Michael Haggerty writes:
> But how far should this policy be taken? It seems to me that strict
> adherence to the policy would dictate that *.h files should *never*
> include other git project files.
I wouldn't call that a "policy". It's something we think about when
adding a new "#include" to
On Mon, Sep 17, 2012 at 03:10:07PM -0700, Junio C Hamano wrote:
> Michael Haggerty writes:
>
> > But how far should this policy be taken? It seems to me that strict
> > adherence to the policy would dictate that *.h files should *never*
> > include other git project files.
>
> I wouldn't call
From: "Junio C Hamano"
Matthieu Moy writes:
Philip Oakley writes:
--- a/Documentation/git-clean.txt
+++ b/Documentation/git-clean.txt
@@ -63,6 +63,12 @@ OPTIONS
Remove only files ignored by git. This may be useful to rebuild
everything from scratch, but keep manually created files.
+SE
1 - 100 of 137 matches
Mail list logo
