On Wed, Sep 26, 2018 at 12:16:16PM -0700, Junio C Hamano wrote:
> Junio C Hamano writes:
> > I quote >"$file" (but not var=$var) because the CodingGuidelines
> > tells me to:
> >
> > - Redirection operators should be written with space before, but no
> >space after them. In other words, wri
On 2018-09-26 21:16, Junio C Hamano wrote:
> While at it, update the way to creatd these scripts to use the
s/creatd/create/
Or rewording as "... update the way these scripts are created ..."
> write_script wrapper, so that we do not have to worry about writing
> the she-bang line and making the
Junio C Hamano writes:
> SZEDER Gábor writes:
>
>> Having said all that, I didn't omit the quotes in 4362da078e with the
>> above in mind; in fact I tend to use quotes even when they are
>> unnecessary (e.g. in variable assignments: var="$1"), because unquoted
>> variables and command substituti
SZEDER Gábor writes:
> Having said all that, I didn't omit the quotes in 4362da078e with the
> above in mind; in fact I tend to use quotes even when they are
> unnecessary (e.g. in variable assignments: var="$1"), because unquoted
> variables and command substitutions freak me out before I can th
On Wed, 26 Sep 2018 at 13:59, Eric Sunshine wrote:
> This description of the behavior is misleading (actually, actively
> wrong).
Hmm, that's bad, my apologies.
> echo foo bar >cow
> echo >cow foo bar
> echo foo >cow bar
>
> That is, they all create a file named "cow" with content "f
On Wed, Sep 26, 2018 at 11:52:42AM +0200, Martin Ågren wrote:
> On Wed, 26 Sep 2018 at 11:00, Alexander Pyhalov wrote:
> > As for sign-off, do I understand correctly that you just want to know
> > that I'm the original author of the code? Yes, it's so.
>
> Right. Plus that you agree that the code
On Wed, Sep 26, 2018 at 5:53 AM Martin Ågren wrote:
> I came up with the following commit message. What do you think about it?
>
> t7005-editor: quote filename to fix whitespace-issue
>
> Commit 4362da078e (t7005-editor: get rid of the SPACES_IN_FILENAMES
> prereq, 2018-05-14) removed
2018-09-26 12:52 GMT+03:00 Martin Ågren :
> On Wed, 26 Sep 2018 at 11:00, Alexander Pyhalov wrote:
>> As for sign-off, do I understand correctly that you just want to know
>> that I'm the original author of the code? Yes, it's so.
>
> Right. Plus that you agree that the code (the commit) may be
>
On Wed, 26 Sep 2018 at 11:00, Alexander Pyhalov wrote:
> As for sign-off, do I understand correctly that you just want to know
> that I'm the original author of the code? Yes, it's so.
Right. Plus that you agree that the code (the commit) may be
redistributed basically forever.
> I see this on O
Hi.
As for sign-off, do I understand correctly that you just want to know
that I'm the original author of the code? Yes, it's so.
I see this on OpenIndiana in
https://github.com/OpenIndiana/oi-userland/pull/4456 , when running
test suite.
Not sure why it wasn't noticed earlier, as 'trash directory
Hi Alexander,
Welcome to the list!
On Wed, 26 Sep 2018 at 08:54, Alexander Pyhalov wrote:
> On updating git to 2.19 we've suddenly got t7005-editor.sh test failures.
> The issue seems to be that generated "e space.sh" file can't handle
> files with spaces.
> Instead of 'echo space >$1' it should
On updating git to 2.19 we've suddenly got t7005-editor.sh test failures.
The issue seems to be that generated "e space.sh" file can't handle
files with spaces.
Instead of 'echo space >$1' it should be 'echo space > "$1"' or git
editor fails when gets file with spaces in name.
The patch is simple:
12 matches
Mail list logo
