Re: t5562: gzip -k is not portable

2018-06-20 Thread Torsten Bögershausen
On Wed, Jun 20, 2018 at 08:40:06AM -0400, Jeff King wrote: > On Wed, Jun 20, 2018 at 08:13:06AM +0200, Torsten Bögershausen wrote: > > > Good eyes, thanks. > > The "-f -c" combo works: > > > > - gzip -k fetch_body && > > + gzip -f -c fetch_body >fetch_body.gz && > > test_copy_

Re: t5562: gzip -k is not portable

2018-06-20 Thread Jeff King
On Wed, Jun 20, 2018 at 08:13:06AM +0200, Torsten Bögershausen wrote: > Good eyes, thanks. > The "-f -c" combo works: > > - gzip -k fetch_body && > + gzip -f -c fetch_body >fetch_body.gz && > test_copy_bytes 10 fetch_body.gz.trunc && > - gzip -k push_body && > + gz

Re: t5562: gzip -k is not portable

2018-06-19 Thread Torsten Bögershausen
On Tue, Jun 19, 2018 at 04:53:10PM -0400, Jeff King wrote: > On Tue, Jun 19, 2018 at 10:40:16PM +0200, Torsten Bögershausen wrote: > > > > > > > On 06/19/2018 08:22 PM, Eric Sunshine wrote: > > > On Tue, Jun 19, 2018 at 2:06 PM Junio C Hamano wrote: > > > > Torsten Bögershausen writes: > > > >

Re: t5562: gzip -k is not portable

2018-06-19 Thread Rodrigo Campos
On Tue, Jun 19, 2018 at 07:25:15PM +0200, Torsten Bögershausen wrote: > Hej Max, > > t5562 fails here under MacOS: > "gzip -k"  is not portable. What do you mean with is not portable? I wrote the patch for gzip[1]. That was in 2013, and is included since version 1.6 IIUC: $ git tag --co

Re: t5562: gzip -k is not portable

2018-06-19 Thread Rodrigo Campos
On Tue, Jun 19, 2018 at 10:40:16PM +0200, Torsten Bögershausen wrote: > > > On 06/19/2018 08:22 PM, Eric Sunshine wrote: > > On Tue, Jun 19, 2018 at 2:06 PM Junio C Hamano wrote: > > > Torsten Bögershausen writes: > > > > t5562 fails here under MacOS: > > > > "gzip -k" is not portable. > > Ver

Re: t5562: gzip -k is not portable

2018-06-19 Thread Jeff King
On Tue, Jun 19, 2018 at 10:40:16PM +0200, Torsten Bögershausen wrote: > > > On 06/19/2018 08:22 PM, Eric Sunshine wrote: > > On Tue, Jun 19, 2018 at 2:06 PM Junio C Hamano wrote: > > > Torsten Bögershausen writes: > > > > t5562 fails here under MacOS: > > > > "gzip -k" is not portable. > > Ve

Re: t5562: gzip -k is not portable

2018-06-19 Thread Torsten Bögershausen
On 06/19/2018 08:22 PM, Eric Sunshine wrote: On Tue, Jun 19, 2018 at 2:06 PM Junio C Hamano wrote: Torsten Bögershausen writes: t5562 fails here under MacOS: "gzip -k" is not portable. Very odd. Stock /usr/bin/gzip on my MacOS 10.12.6 _does_ recognize -k, and the test does pass. This i

Re: t5562: gzip -k is not portable

2018-06-19 Thread Eric Sunshine
On Tue, Jun 19, 2018 at 2:06 PM Junio C Hamano wrote: > Torsten Bögershausen writes: > > t5562 fails here under MacOS: > > "gzip -k" is not portable. Very odd. Stock /usr/bin/gzip on my MacOS 10.12.6 _does_ recognize -k, and the test does pass. > Sigh. Perhaps -c would help. Or do BSD implem

Re: t5562: gzip -k is not portable

2018-06-19 Thread Junio C Hamano
Torsten Bögershausen writes: > Hej Max, > > t5562 fails here under MacOS: > "gzip -k"  is not portable. Sigh. Perhaps -c would help. Or do BSD implementations also lack -c? t/t5562-http-backend-content-length.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t5562-

t5562: gzip -k is not portable

2018-06-19 Thread Torsten Bögershausen
Hej Max, t5562 fails here under MacOS: "gzip -k"  is not portable. The following works (there may be better solutions, I didn't dig into the test code) diff --git a/t/t5562-http-backend-content-length.sh b/t/t5562-http-backend-content-length.sh index 8040d80e04..7befe3885c 100755 --- a/t/t5