On Tue, May 10, 2016 at 03:44:32PM +0200, Armin Kunaschik wrote:
> I'm building on a quite current AIX 6.1 where /bin/sh defaults to /bin/ksh
> which is a posix shell (ksh88).
> Using /bin/bash doesn't work because SHELL_PATH is only used in
> git scripts but not in any t* test scripts.
If you ru
Sorry for any duplicate mails, the list blocked my html mail.
Note to self: Don't use GMail on a tablet.
On Mon, May 9, 2016 at 11:35 PM, Eric Sunshine wrote:
>>
>> Hmph, do we have a broken &&-chain?
>
> I don't know. Unfortunately, Armin didn't provide much information in
> his initial email, s
On Mon, May 9, 2016 at 4:45 PM, Junio C Hamano wrote:
> Eric Sunshine writes:
>> On Mon, May 9, 2016 at 2:56 PM, Junio C Hamano wrote:
>>> Something like this follows Documentation/SubmittingPatches [...]
>>>
>>> -- >8 --
>>> From: Armin Kunaschik
>>> Subject: t4151: make sure argument to 'test
Eric Sunshine writes:
> On Mon, May 9, 2016 at 2:56 PM, Junio C Hamano wrote:
>> Something like this follows Documentation/SubmittingPatches [...]
>>
>> -- >8 --
>> From: Armin Kunaschik
>> Subject: t4151: make sure argument to 'test -z' is given
>>
>> 88d50724 (am --skip: revert changes introd
On Mon, May 9, 2016 at 2:56 PM, Junio C Hamano wrote:
> Something like this follows Documentation/SubmittingPatches [...]
>
> -- >8 --
> From: Armin Kunaschik
> Subject: t4151: make sure argument to 'test -z' is given
>
> 88d50724 (am --skip: revert changes introduced by failed 3way merge,
> 2015
On Mon, May 9, 2016 at 11:56 AM, Junio C Hamano wrote:
> Something like this follows Documentation/SubmittingPatches, except
> that it further needs your Sign-off before mine, which I can forge
> if you say it is OK.
The sign-off is a simple line at the end of the explanation for
the patch, which
Something like this follows Documentation/SubmittingPatches, except
that it further needs your Sign-off before mine, which I can forge
if you say it is OK.
Thanks for a report and an analysis of the issue.
-- >8 --
From: Armin Kunaschik
Subject: t4151: make sure argument to 'test -z' is given
8
I'm currently concentrating on finding problems with my setup... this
is already a tough job :-)
I'm a git beginner, and Documentation/SubmittingPatches would keep me
busy for a week.
So anybody feel free to submit this thingy.
Armin
--
To unsubscribe from this list: send the line "unsubscribe git
[please don't top-post on this list]
On Mon, May 9, 2016 at 12:35 PM, Armin Kunaschik
wrote:
> Sorry, this was my first patch to the list. I'll do better :-)
> You are right about the "wc -l" parts. Maybe I was a bit over
> pessimistic. Throw away my last mail.
Done :-)
> In my case test 9 ran
Sorry, this was my first patch to the list. I'll do better :-)
You are right about the "wc -l" parts. Maybe I was a bit over
pessimistic. Throw away my last mail.
In my case test 9 ran unsuccessful because of an empty "git ls-files -u"
This reduces the diff to this one (hopefully the right way now
On Mon, May 9, 2016 at 12:22 PM, Eric Sunshine wrote:
> On Mon, May 9, 2016 at 12:09 PM, Armin Kunaschik
> wrote:
>> *** t4151-am-abort.sh Mon May 9 17:51:44 2016
>> --- t4151-am-abort.sh.orig Fri Apr 29 23:37:00 2016
>> ! test 3 -eq "$(git ls-files -u | wc -l)" &&
>> ! test 3
On Mon, May 9, 2016 at 12:09 PM, Armin Kunaschik
wrote:
> skipping through some failed tests I found more (smaller) problems
> inside the test... when test arguments are empty they need to be
> quoted (quite a lot test in this sentence).
>
> Error is like
> t4151-am-abort.sh[5]: test: argument exp
Hi there,
skipping through some failed tests I found more (smaller) problems
inside the test... when test arguments are empty they need to be
quoted (quite a lot test in this sentence).
Error is like
t4151-am-abort.sh[5]: test: argument expected
My patch:
*** t4151-am-abort.sh Mon May 9 17:5
13 matches
Mail list logo