Re: t3010 broken by 2eac2a4

2013-08-23 Thread Jeff King
On Fri, Aug 23, 2013 at 10:15:55AM -0700, Junio C Hamano wrote: > When 5102c617 (Add case insensitivity support for directories when > using git status, 2010-10-03) added the directories to the name-hash > with trailing slash, there was only a single name hash table to > which both real cache entr

Re: t3010 broken by 2eac2a4

2013-08-23 Thread Junio C Hamano
Eric Sunshine writes: > On Fri, Aug 23, 2013 at 1:36 AM, Junio C Hamano wrote: >> Eric Sunshine writes: >> >>> I sent a patch [1] which resolves the problem, although the solution >>> is not especially pretty (due to some ugliness in the existing >>> implementation). >> >> Yeah, thanks. >> >> I

Re: t3010 broken by 2eac2a4

2013-08-23 Thread Eric Sunshine
On Fri, Aug 23, 2013 at 1:36 AM, Junio C Hamano wrote: > Eric Sunshine writes: > >> I sent a patch [1] which resolves the problem, although the solution >> is not especially pretty (due to some ugliness in the existing >> implementation). > > Yeah, thanks. > > I tend to agree with you that fixing

Re: t3010 broken by 2eac2a4

2013-08-22 Thread Junio C Hamano
Eric Sunshine writes: > I sent a patch [1] which resolves the problem, although the solution > is not especially pretty (due to some ugliness in the existing > implementation). Yeah, thanks. I tend to agree with you that fixing the "icase" callee not to rely on having the trailing slash (which

Re: t3010 broken by 2eac2a4

2013-08-22 Thread Eric Sunshine
On Thu, Aug 22, 2013 at 7:15 PM, Eric Sunshine wrote: > On Thu, Aug 22, 2013 at 7:12 PM, Junio C Hamano wrote: >> Eric Sunshine writes: >> >>> Status update: For the 'pathx' directory created by the t3010 test, >>> directory_exists_in_index() returns false on OSX, but true is returned >>> on Lin

Re: t3010 broken by 2eac2a4

2013-08-22 Thread Eric Sunshine
On Thu, Aug 22, 2013 at 7:12 PM, Junio C Hamano wrote: > Eric Sunshine writes: > >> Status update: For the 'pathx' directory created by the t3010 test, >> directory_exists_in_index() returns false on OSX, but true is returned >> on Linux. > > Because a regular pathx/ju is in the index at that poi

Re: t3010 broken by 2eac2a4

2013-08-22 Thread Junio C Hamano
Eric Sunshine writes: > Status update: For the 'pathx' directory created by the t3010 test, > directory_exists_in_index() returns false on OSX, but true is returned > on Linux. Because a regular pathx/ju is in the index at that point, the correct answer directory_exists_in_index() should give fo

Re: t3010 broken by 2eac2a4

2013-08-22 Thread Eric Sunshine
On Thu, Aug 22, 2013 at 5:59 PM, Eric Sunshine wrote: > On Thu, Aug 22, 2013 at 5:43 PM, Junio C Hamano wrote: >> Eric Sunshine writes: >>> On Thu, Aug 22, 2013 at 5:32 PM, Junio C Hamano wrote: Now, I am curious how it breaks on OS X. My suspition is that "ignore_case" may have

Re: t3010 broken by 2eac2a4

2013-08-22 Thread Eric Sunshine
On Thu, Aug 22, 2013 at 5:43 PM, Junio C Hamano wrote: > Eric Sunshine writes: >> On Thu, Aug 22, 2013 at 5:32 PM, Junio C Hamano wrote: >>> Now, I am curious how it breaks on OS X. >>> >>> My suspition is that "ignore_case" may have something to do with it, >>> but what 2eac2a4c (ls-files -k: a

Re: t3010 broken by 2eac2a4

2013-08-22 Thread Junio C Hamano
Eric Sunshine writes: > On Thu, Aug 22, 2013 at 5:32 PM, Junio C Hamano wrote: >> Eric Sunshine writes: >> >>> On Thu, Aug 22, 2013 at 5:16 PM, Junio C Hamano wrote: Eric Sunshine writes: > I can confirm this failure on OS X, however,... >>> >>> Thanks for the explanation. >> >>

Re: t3010 broken by 2eac2a4

2013-08-22 Thread Eric Sunshine
On Thu, Aug 22, 2013 at 5:32 PM, Junio C Hamano wrote: > Eric Sunshine writes: > >> On Thu, Aug 22, 2013 at 5:16 PM, Junio C Hamano wrote: >>> Eric Sunshine writes: >>> I can confirm this failure on OS X, however,... >> >> Thanks for the explanation. > > Now, I am curious how it breaks on

Re: t3010 broken by 2eac2a4

2013-08-22 Thread Junio C Hamano
Eric Sunshine writes: > On Thu, Aug 22, 2013 at 5:16 PM, Junio C Hamano wrote: >> Eric Sunshine writes: >> >>> I can confirm this failure on OS X, however,... > > Thanks for the explanation. Now, I am curious how it breaks on OS X. My suspition is that "ignore_case" may have something to do w

Re: t3010 broken by 2eac2a4

2013-08-22 Thread Eric Sunshine
On Thu, Aug 22, 2013 at 5:16 PM, Junio C Hamano wrote: > Eric Sunshine writes: > >> I can confirm this failure on OS X, however, I am somewhat confused by >> the follow-up t3010 changes in 3c56875176390eee. Are the t3010 changes >> supposed to fail without 2eac2a4cc4bdc8d7 applied? For me, on Lin

Re: t3010 broken by 2eac2a4

2013-08-22 Thread Junio C Hamano
Eric Sunshine writes: > I can confirm this failure on OS X, however, I am somewhat confused by > the follow-up t3010 changes in 3c56875176390eee. Are the t3010 changes > supposed to fail without 2eac2a4cc4bdc8d7 applied? For me, on Linux, > the tests succeed whether 2eac2a4cc4bdc8d7 is applied or

Re: t3010 broken by 2eac2a4

2013-08-22 Thread Eric Sunshine
On Wed, Aug 21, 2013 at 5:41 PM, Junio C Hamano wrote: > Brian Gernhardt writes: > >> With 2eac2a4: "ls-files -k: a directory only can be killed if the index has >> a non-directory" applied, t3010 fails test 3 "validate git ls-files -k >> output". It ends up missing the pathx/ju/nk file. >> >>

Re: t3010 broken by 2eac2a4

2013-08-21 Thread Junio C Hamano
Brian Gernhardt writes: > With 2eac2a4: "ls-files -k: a directory only can be killed if the index has a > non-directory" applied, t3010 fails test 3 "validate git ls-files -k output". > It ends up missing the pathx/ju/nk file. > > OS X 10.8.4 > Xcode 4.6.3 > clang "Apple LLVM version 4.2 (clan

t3010 broken by 2eac2a4

2013-08-21 Thread Brian Gernhardt
With 2eac2a4: "ls-files -k: a directory only can be killed if the index has a non-directory" applied, t3010 fails test 3 "validate git ls-files -k output". It ends up missing the pathx/ju/nk file. OS X 10.8.4 Xcode 4.6.3 clang "Apple LLVM version 4.2 (clang-425.0.28) (based on LLVM 3.2svn)" ~