On Wed, May 11, 2016 at 03:28:35PM +0200, Johannes Schindelin wrote:
> Looks obviously correct to me.
Thanks.
> I had a look at our other shell scripts and it looks as if there is only
> one more candidate for this issue: git-bisect.sh has a couple of 'for arg
> in "$@"' constructs. But from a c
Hi,
On Tue, 10 May 2016, Jeff King wrote:
> On Tue, May 10, 2016 at 01:53:56PM -0700, Junio C Hamano wrote:
>
> > Jeff King writes:
> >
> > > I think it is clear why it works. If $strategy_opts is empty, then the
> > > code we generate looks like:
> > >
> > > for strategy_opt in
> > > do
>
On Tue, May 10, 2016 at 01:53:56PM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > I think it is clear why it works. If $strategy_opts is empty, then the
> > code we generate looks like:
> >
> > for strategy_opt in
> > do
> > ...
> > done
>
> Ah, of course. Thanks.
Here
On Tue, May 10, 2016 at 12:11:59PM -0700, Junio C Hamano wrote:
> Armin Kunaschik writes:
>
> > I fail to see why eval is really necessary here.
>
> It is necessary to work correctly with any strategy option with $IFS
> in it, I would think. The calling script "git-rebase" accumulates
> --stra
Jeff King writes:
> I think it is clear why it works. If $strategy_opts is empty, then the
> code we generate looks like:
>
> for strategy_opt in
> do
> ...
> done
Ah, of course. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message t
Armin Kunaschik writes:
> I fail to see why eval is really necessary here.
It is necessary to work correctly with any strategy option with $IFS
in it, I would think. The calling script "git-rebase" accumulates
--strategy-option values after passing each of them through
"rev-parse --sq-quote" fo
Hello,
I noticed in my environment (AIX, ksh) that all rebase tests don't work.
git-rebase terminates with
git-rebase[6]: Syntax error at line 3 : `newline or ;' is not expected.
Digging deeper I found the problem in git-rebase--interactive line 85
strategy_args=${strategy:+--strategy=$strategy}
7 matches
Mail list logo
