Re: [PATCH v2 5/5] fetch: Make --jobs control submodules and remotes

2019-08-14 Thread Palmer Dabbelt
On Wed, 14 Aug 2019 01:32:45 PDT (-0700), szeder@gmail.com wrote: On Mon, Aug 12, 2019 at 02:34:48PM -0700, Palmer Dabbelt wrote: diff --git a/builtin/fetch.c b/builtin/fetch.c index 67d001f3f78b..41498e9efb3b 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -114,6 +114,20 @@ static int

Re: [PATCH v2 5/5] fetch: Make --jobs control submodules and remotes

2019-08-14 Thread Junio C Hamano
SZEDER Gábor writes: > On Mon, Aug 12, 2019 at 02:34:48PM -0700, Palmer Dabbelt wrote: >> diff --git a/builtin/fetch.c b/builtin/fetch.c >> index 67d001f3f78b..41498e9efb3b 100644 >> --- a/builtin/fetch.c >> +++ b/builtin/fetch.c >> @@ -114,6 +114,20 @@ static int git_fetch_config(const char *k,

Re: [PATCH v2 5/5] fetch: Make --jobs control submodules and remotes

2019-08-14 Thread SZEDER Gábor
On Mon, Aug 12, 2019 at 02:34:48PM -0700, Palmer Dabbelt wrote: > diff --git a/builtin/fetch.c b/builtin/fetch.c > index 67d001f3f78b..41498e9efb3b 100644 > --- a/builtin/fetch.c > +++ b/builtin/fetch.c > @@ -114,6 +114,20 @@ static int git_fetch_config(const char *k, const char > *v, void *cb) >

Re: [PATCH v2 5/5] fetch: Make --jobs control submodules and remotes

2019-08-13 Thread Palmer Dabbelt
jobs to be used when fetching from multiple remotes as well. This patch simply changes the --jobs argument parsing code to set both max_children_for_{submodules,fetch}, as well as noting this new behavior in the documentation. Signed-off-by: Palmer Dabbelt --- I very much miss in this

Re: [PATCH v2 5/5] fetch: Make --jobs control submodules and remotes

2019-08-13 Thread Palmer Dabbelt
multiple remotes as well. This patch simply changes the --jobs argument parsing code to set both max_children_for_{submodules,fetch}, as well as noting this new behavior in the documentation. That's a sensible, if overly careful, transition plan. This patch cannot be queued together wit

Re: [PATCH v2 5/5] fetch: Make --jobs control submodules and remotes

2019-08-13 Thread Junio C Hamano
Palmer Dabbelt writes: > The existing --jobs argument was defined to control the number of jobs > used for submodule fetching, but it makes more sense to have this > argument control the number of jobs to be used when fetching from > multiple remotes as well. > > This patch

Re: [PATCH v2 5/5] fetch: Make --jobs control submodules and remotes

2019-08-13 Thread Johannes Schindelin
Hi, On Mon, 12 Aug 2019, Palmer Dabbelt wrote: > The existing --jobs argument was defined to control the number of jobs > used for submodule fetching, but it makes more sense to have this > argument control the number of jobs to be used when fetching from > multiple remotes as we

[PATCH v2 5/5] fetch: Make --jobs control submodules and remotes

2019-08-12 Thread Palmer Dabbelt
The existing --jobs argument was defined to control the number of jobs used for submodule fetching, but it makes more sense to have this argument control the number of jobs to be used when fetching from multiple remotes as well. This patch simply changes the --jobs argument parsing code to set

[PATCH v2 0/5] fetch: Extend --jobs to multiple remotes

2019-08-12 Thread Palmer Dabbelt
there was going to be a deprecation period. I've written the patch set such that the final patch can easily be dropped to avoid changing existing behavior. I'm also happy to re-spin this to just make --jobs control remotes and drop the --fetch-jobs and --submodule-fetch-jobs arguments, which

Re: [PATCH] fetch: add "--parallel", which fetches all remotes in parallel

2019-07-19 Thread Junio C Hamano
Johannes Schindelin writes: > I have to admit that I'd _much_ rather see the strategy of > `fetch_populated_submodules()` emulated, where it uses the > `run_processes_parallel_tr2()` function to perform the actual fetches. Good. Thanks for chiming in.

Re: [PATCH] fetch: add "--parallel", which fetches all remotes in parallel

2019-07-19 Thread Johannes Schindelin
Hi Junio, On Thu, 18 Jul 2019, Junio C Hamano wrote: > Palmer Dabbelt writes: > > > * As I was writing the documentation I found "fetch --jobs". It seems > > like I should use that instead of adding a new argrument, but I wasn't > > sure. > > Why not? What makes you feel it is a bad idea t

Re: [PATCH] fetch: add "--parallel", which fetches all remotes in parallel

2019-07-18 Thread Junio C Hamano
Palmer Dabbelt writes: > * I'm not sure if it's safe to access the .git database from multiple > processes at the same time. It is supposed to, and also you are supposed to keep it that way ;-) > * As I was writing the documentation I found "fetch --jobs". It seems > like I should use that

[PATCH] fetch: add "--parallel", which fetches all remotes in parallel

2019-07-16 Thread Palmer Dabbelt
I have a handful of repositories with a bunch of remotes and this week I'm on an internet connection with a high bandwidth high latency connection to those remotes. This results in "fetch --all" being painfully slow: 3-4 seconds per remote, all at almost zero link utilization (pres

Re: Multiple urls for remotes?

2019-06-26 Thread brian m. carlson
On 2019-06-26 at 23:52:47, Mike Hommey wrote: > Hi, > > I was surprised to figure out that urls/pushurls set up for remotes can > be set multiple times, and that those urls end up being used > sequentially. Yes, this is actually a feature. It's useful when you want to push to

Multiple urls for remotes?

2019-06-26 Thread Mike Hommey
Hi, I was surprised to figure out that urls/pushurls set up for remotes can be set multiple times, and that those urls end up being used sequentially. Sadly, this has the side effect that one cannot override the config from the command line, as the url is then added as an extra url, which is

[PATCH v6 00/15] Many promisor remotes

2019-06-25 Thread Christian Couder
last year, which were a follow up from previous series. See the links section for more information. The goal of this patch series is to make it possible to have and to fetch missing objects from multiple remotes instead of only one. For now the fetch order is the order of the remotes in the conf

[PATCH v6 11/15] partial-clone: add multiple remotes in the doc

2019-06-25 Thread Christian Couder
h various objects if they know that they are going offline. +remote or other promisor remotes be available for on-demand fetching +of missing objects. This may or may not be problematic for the user. +For example, if the user can stay within the pre-selected subset of +the source tree, they may

[PATCH v6 10/15] t0410: test fetching from many promisor remotes

2019-06-25 Thread Christian Couder
From: Christian Couder This shows that it is now possible to fetch objects from more than one promisor remote, and that fetching from a new promisor remote can configure it as one. Helped-by: SZEDER Gábor Signed-off-by: Christian Couder --- t/t0410-partial-clone.sh | 49 ++

[PATCH v6 03/15] Add initial support for many promisor remotes

2019-06-25 Thread Christian Couder
From: Christian Couder The promisor-remote.{c,h} files will contain functions to manage many promisor remotes. We expect that there will not be a lot of promisor remotes, so it is ok to use a simple linked list to manage them. Helped-by: Jeff King Helped-by: SZEDER Gábor Signed-off-by

Re: [PATCH] fetch: only run 'gc' once when fetching multiple remotes

2019-06-20 Thread Jeff King
On Thu, Jun 20, 2019 at 05:11:03PM +0700, Duy Nguyen wrote: > > Another option would be to just pass "-c gc.auto=0" to the child > > processes to inhibit auto-gc. But maybe it makes sense to have a nicer > > interface (after all, somebody else could be doing the same "let's do a > > bunch of fetch

Re: [PATCH] fetch: only run 'gc' once when fetching multiple remotes

2019-06-20 Thread Duy Nguyen
On Thu, Jun 20, 2019 at 1:59 AM Jeff King wrote: > I was surprised that we needed a new command-line option here, but I > guess the sub-fetch processes really have no idea that they're > subservient to a multi-remote fetch (they do get "--append", but of > course somebody could specify that indepe

Re: [PATCH] fetch: only run 'gc' once when fetching multiple remotes

2019-06-19 Thread Jeff King
On Wed, Jun 19, 2019 at 04:46:30PM +0700, Nguyễn Thái Ngọc Duy wrote: > In multiple remotes mode, git-fetch is launched for n-1 remotes and the > last remote is handled by the current process. Each of these processes > will in turn run 'gc' at the end. > > This is not

[PATCH] fetch: only run 'gc' once when fetching multiple remotes

2019-06-19 Thread Nguyễn Thái Ngọc Duy
In multiple remotes mode, git-fetch is launched for n-1 remotes and the last remote is handled by the current process. Each of these processes will in turn run 'gc' at the end. This is not really a problem because even if multiple 'gc --auto' is run at the same time we still

Re: [RFC/PATCH] refs: tone down the dwimmery in refname_match() for {heads,tags,remotes}/*

2019-05-27 Thread Paolo Bonzini
On 27/05/19 17:39, Junio C Hamano wrote: > I do not think lightweight vs annotated should be the issue. The > tag that the requestor asks to be pulled (from repository ../b) > should be what the requestor has locally when writing the request > (in repository .). Even if both tags at remote and lo

Re: [RFC/PATCH] refs: tone down the dwimmery in refname_match() for {heads,tags,remotes}/*

2019-05-27 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > It mostly (and I believe always should) works by looking at whether > "someref" is a named ref, and e.g. looking at whether it's "master". We > then see that it lives in "refs/heads/master" locally, and thus > correspondingly add a "refs/heads/" to your "tags/fo

Re: [RFC/PATCH] refs: tone down the dwimmery in refname_match() for {heads,tags,remotes}/*

2019-05-27 Thread Ævar Arnfjörð Bjarmason
if we errored on that you might have just done "+HEAD:refs/tags/for-linus" and ended up with the same thing. As an aside, in *general* tags, unlike branches, don't have "remote tracking". That's something we'd eventually want, but we're nowhere near the refstore a

Re: [RFC/PATCH] refs: tone down the dwimmery in refname_match() for {heads,tags,remotes}/*

2019-05-27 Thread Paolo Bonzini
On 27/05/19 00:54, Ævar Arnfjörð Bjarmason wrote: > This resulted in a case[1] where someone on LKML did: > > git push kvm +HEAD:tags/for-linus > > Which would have created a new "tags/for-linus" branch in their "kvm" > repository, except because they happened to have an existing > "refs/tags

[RFC/PATCH] refs: tone down the dwimmery in refname_match() for {heads,tags,remotes}/*

2019-05-26 Thread Ævar Arnfjörð Bjarmason
_name_len = strlen(abbrev_name); const int num_rules = NUM_REV_PARSE_RULES; - for (p = ref_rev_parse_rules; *p; p++) + for (p = ref_rev_parse_rules; *p; p++) { + if (!strcmp(*p, "refs/%.*s") && + (starts_with(abbrev_name

[PATCH 08/19] rev-parseopt: convert --remotes

2019-05-08 Thread Nguyễn Thái Ngọc Duy
struct ref_store*refs = revs->pseudo_refs; + + BUG_ON_OPT_NEG(unset); + if (arg) { + struct all_refs_cb cb; + + init_all_refs_cb(&cb, revs, flags); + for_each_glob_ref_in(handle_one_ref, arg, "r

Re: [PATCH v5 00/16] Many promisor remotes

2019-04-15 Thread Christian Couder
On Mon, Apr 15, 2019 at 12:30 PM Junio C Hamano wrote: > > Junio C Hamano writes: > > > Christian Couder writes: > > > >> This patch series is based on: > >> > >> 763fb763b8 (Merge branch 'jt/batch-fetch-blobs-in-diff' into jch, > >> 2019-04-08) > >> > >> to avoid issues with jt/batch-fetch-blo

Re: [PATCH v5 00/16] Many promisor remotes

2019-04-15 Thread Christian Couder
On Mon, Apr 15, 2019 at 11:27 AM Junio C Hamano wrote: > > Christian Couder writes: > > > This patch series is based on: > > > > 763fb763b8 (Merge branch 'jt/batch-fetch-blobs-in-diff' into jch, > > 2019-04-08) > > > > to avoid issues with jt/batch-fetch-blobs-in-diff. > > Yuck. As an experienc

Re: [PATCH v5 00/16] Many promisor remotes

2019-04-15 Thread Junio C Hamano
Junio C Hamano writes: > Christian Couder writes: > >> This patch series is based on: >> >> 763fb763b8 (Merge branch 'jt/batch-fetch-blobs-in-diff' into jch, 2019-04-08) >> >> to avoid issues with jt/batch-fetch-blobs-in-diff. > ... > If you really need to depend on another topic or two, please

Re: [PATCH v5 00/16] Many promisor remotes

2019-04-15 Thread Junio C Hamano
Christian Couder writes: > This patch series is based on: > > 763fb763b8 (Merge branch 'jt/batch-fetch-blobs-in-diff' into jch, 2019-04-08) > > to avoid issues with jt/batch-fetch-blobs-in-diff. Yuck. As an experienced contributor, you should know better than that by now to do that. A merge in

[PATCH v5 11/16] t0410: test fetching from many promisor remotes

2019-04-09 Thread Christian Couder
From: Christian Couder This shows that it is now possible to fetch objects from more than one promisor remote, and that fetching from a new promisor remote can configure it as one. Helped-by: SZEDER Gábor Signed-off-by: Christian Couder --- t/t0410-partial-clone.sh | 49 ++

[PATCH v5 12/16] partial-clone: add multiple remotes in the doc

2019-04-09 Thread Christian Couder
h various objects if they know that they are going offline. +remote or other promisor remotes be available for on-demand fetching +of missing objects. This may or may not be problematic for the user. +For example, if the user can stay within the pre-selected subset of +the source tree, they may

[PATCH v5 03/16] Add initial support for many promisor remotes

2019-04-09 Thread Christian Couder
From: Christian Couder The promisor-remote.{c,h} files will contain functions to manage many promisor remotes. We expect that there will not be a lot of promisor remotes, so it is ok to use a simple linked list to manage them. Helped-by: Jeff King Helped-by: SZEDER Gábor Signed-off-by

[PATCH v5 00/16] Many promisor remotes

2019-04-09 Thread Christian Couder
t year, which were a follow up from previous series. See the links section for more information. The goal of this patch series is to make it possible to have and to fetch missing objects from multiple remotes instead of only one. For now the fetch order is the order of the remotes in the config, e

Re: [PATCH v4 00/11] Many promisor remotes

2019-04-05 Thread Johannes Schindelin
Hi Junio, On Thu, 4 Apr 2019, Junio C Hamano wrote: > Christian Couder writes: > > > This path series is a follow up from the "remote odb" patch series > > that I sent last year, which were a follow up from previous > > series. See the links section for more information. > > When this topic gets

Re: [PATCH v4 09/11] t0410: test fetching from many promisor remotes

2019-04-04 Thread SZEDER Gábor
On Mon, Apr 01, 2019 at 06:40:43PM +0200, Christian Couder wrote: > From: Christian Couder > > This shows that it is now possible to fetch objects from more > than one promisor remote, and that fetching from a new > promisor remote can configure it as one. > > Signed-off-by: Christian Couder >

Re: [PATCH v4 02/11] Add initial support for many promisor remotes

2019-04-04 Thread Christian Couder
On Thu, Apr 4, 2019 at 12:08 AM SZEDER Gábor wrote: > > On Mon, Apr 01, 2019 at 06:40:36PM +0200, Christian Couder wrote: > > diff --git a/promisor-remote.c b/promisor-remote.c > > new file mode 100644 > > index 00..0c768210ee > > --- /dev/null > > +++ b/promisor-remote.c > > @@ -0,0 +1,92

Re: [PATCH v4 00/11] Many promisor remotes

2019-04-04 Thread Christian Couder
On Thu, Apr 4, 2019 at 9:23 AM Junio C Hamano wrote: > > Christian Couder writes: > > > This path series is a follow up from the "remote odb" patch series > > that I sent last year, which were a follow up from previous > > series. See the links section for more information. > > When this topic ge

Re: [PATCH v4 00/11] Many promisor remotes

2019-04-04 Thread Junio C Hamano
Christian Couder writes: > This path series is a follow up from the "remote odb" patch series > that I sent last year, which were a follow up from previous > series. See the links section for more information. When this topic gets merged with the "diff: batch fetching of missing blobs" topic, th

Re: [PATCH v4 02/11] Add initial support for many promisor remotes

2019-04-03 Thread SZEDER Gábor
On Mon, Apr 01, 2019 at 06:40:36PM +0200, Christian Couder wrote: > diff --git a/promisor-remote.c b/promisor-remote.c > new file mode 100644 > index 00..0c768210ee > --- /dev/null > +++ b/promisor-remote.c > @@ -0,0 +1,92 @@ > +#include "cache.h" > +#include "promisor-remote.h" > +#include

[PATCH v4 10/11] partial-clone: add multiple remotes in the doc

2019-04-01 Thread Christian Couder
misor remote as "promisor packfiles". +- An object may be missing due to a partial clone or fetch, or missing + due to repository corruption. To differentiate these cases, the + local repository specially indicates such filtered packfiles + obtained from promisor remotes as &quo

Re: [PATCH v3 02/11] Add initial support for many promisor remotes

2019-04-01 Thread Christian Couder
remote.XXX config entries. > > + */ > > +struct promisor_remote { > > + const char *remote_name; > > + struct promisor_remote *next; > > +}; > > Would it make the management of storage easier to make it > > struct promisor_remote { > s

[PATCH v4 09/11] t0410: test fetching from many promisor remotes

2019-04-01 Thread Christian Couder
From: Christian Couder This shows that it is now possible to fetch objects from more than one promisor remote, and that fetching from a new promisor remote can configure it as one. Signed-off-by: Christian Couder --- t/t0410-partial-clone.sh | 47 +++- 1 fil

[PATCH v4 00/11] Many promisor remotes

2019-04-01 Thread Christian Couder
This path series is a follow up from the "remote odb" patch series that I sent last year, which were a follow up from previous series. See the links section for more information. The goal of this patch series is to make it possible to have and to fetch missing objects from multip

[PATCH v4 02/11] Add initial support for many promisor remotes

2019-04-01 Thread Christian Couder
From: Christian Couder The promisor-remote.{c,h} files will contain functions to manage many promisor remotes. We expect that there will not be a lot of promisor remotes, so it is ok to use a simple linked list to manage them. Helped-by: Jeff King Signed-off-by: Christian Couder

Re: [PATCH v3 02/11] Add initial support for many promisor remotes

2019-03-12 Thread Junio C Hamano
Junio C Hamano writes: > What is the rule for these promisor names? Disregard this part (and only this part). The values are not names, but just "is this thing a promisor" boolean.

Re: [PATCH v3 02/11] Add initial support for many promisor remotes

2019-03-12 Thread Junio C Hamano
[remote "origin"] url = ... promisor = frotz promisor = nitfol [remote "mirror"} url = ... promisor = frotz promisor = Frotz promisor = nit fol would the two "frotz&qu

[PATCH v3 10/11] partial-clone: add multiple remotes in the doc

2019-03-12 Thread Christian Couder
misor remote as "promisor packfiles". +- An object may be missing due to a partial clone or fetch, or missing + due to repository corruption. To differentiate these cases, the + local repository specially indicates such filtered packfiles + obtained from promisor remotes as &quo

[PATCH v3 09/11] t0410: test fetching from many promisor remotes

2019-03-12 Thread Christian Couder
From: Christian Couder This shows that it is now possible to fetch objects from more than one promisor remote, and that fetching from a new promisor remote can configure it as one. Signed-off-by: Christian Couder --- t/t0410-partial-clone.sh | 47 +++- 1 fil

[PATCH v3 02/11] Add initial support for many promisor remotes

2019-03-12 Thread Christian Couder
From: Christian Couder The promisor-remote.{c,h} files will contain functions to manage many promisor remotes. We expect that there will not be a lot of promisor remotes, so it is ok to use a simple linked list to manage them. Helped-by: Jeff King Signed-off-by: Christian Couder

[PATCH v3 00/11] Many promisor remotes

2019-03-12 Thread Christian Couder
This path series is a follow up from the "remote odb" patch series that I sent last year, which were a follow up from previous series. See the links section for more information. The goal of this patch series is to make it possible to have and to fetch missing objects from multip

[PATCH v2 00/13] Many promisor remotes

2019-01-22 Thread Christian Couder
This path series is a follow up from the "remote odb" patch series that I sent last year, which were a follow up from previous series. See the links section for more information. The goal of this patch series is to make it possible to have and to fetch missing objects from multip

[PATCH v2 04/13] Add initial support for many promisor remotes

2019-01-22 Thread Christian Couder
From: Christian Couder The promisor-remote.{c,h} files will contain functions to manage many promisor remotes. We expect that there will not be a lot of promisor remotes, so it is ok to use a simple linked list to manage them. Helped-by: Jeff King Signed-off-by: Christian Couder

[PATCH v2 11/13] t0410: test fetching from many promisor remotes

2019-01-22 Thread Christian Couder
From: Christian Couder This shows that it is now possible to fetch objects from more than one promisor remote, and that fetching from a new promisor remote can configure it as one. Signed-off-by: Christian Couder --- t/t0410-partial-clone.sh | 47 +++- 1 fil

[PATCH v2 12/13] partial-clone: add multiple remotes in the doc

2019-01-22 Thread Christian Couder
misor remote as "promisor packfiles". +- An object may be missing due to a partial clone or fetch, or missing + due to repository corruption. To differentiate these cases, the + local repository specially indicates such filtered packfiles + obtained from promisor remotes as &quo

[PATCH v1 8/8] t0410: test fetching from many promisor remotes

2018-12-10 Thread Christian Couder
From: Christian Couder This shows that it is now possible to fetch objects from more than one promisor remote. Signed-off-by: Christian Couder --- t/t0410-partial-clone.sh | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/t/t0410-partial-clone.sh b/t/

[PATCH v1 0/8] Many promisor remotes

2018-12-10 Thread Christian Couder
m multiple remotes instead of only one. For now the fetch order is the order of the remotes in the config. I selected the name "Promisor remote" over "Partial clone remote" because it is shorter and because it is not only about cloning. The existing extensions.partialclone is respe

[PATCH v1 2/8] Add initial support for many promisor remotes

2018-12-10 Thread Christian Couder
From: Christian Couder The promisor-remote.{c,h} files will contain functions to manage many promisor remotes. We expect that there will not be a lot of promisor remotes, so it is ok to use a simple linked list to manage them. Helped-by: Jeff King Signed-off-by: Christian Couder

Re: [PATCH 1/2] refs: show --exclude failure with --branches/tags/remotes=glob

2018-11-13 Thread Johannes Schindelin
Hi Junio, On Tue, 13 Nov 2018, Junio C Hamano wrote: > Rafael Ascensão writes: > > > The documentation of `--exclude=` option from rev-list and rev-parse > > explicitly states that exclude patterns *should not* start with 'refs/' > > when used with `-

Re: [PATCH 1/2] refs: show --exclude failure with --branches/tags/remotes=glob

2018-11-12 Thread Junio C Hamano
Rafael Ascensão writes: > The documentation of `--exclude=` option from rev-list and rev-parse > explicitly states that exclude patterns *should not* start with 'refs/' > when used with `--branches`, `--tags` or `--remotes`. > > However, following this advice resul

[PATCH 1/2] refs: show --exclude failure with --branches/tags/remotes=glob

2018-11-12 Thread Rafael Ascensão
The documentation of `--exclude=` option from rev-list and rev-parse explicitly states that exclude patterns *should not* start with 'refs/' when used with `--branches`, `--tags` or `--remotes`. However, following this advice results in refereces not being excluded if the next `

Re: [PATCH v3 7/8] push: add DWYM support for "git push refs/remotes/...:"

2018-11-05 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > After all sometimes "other" is just the repo on my laptop or server. I > shouldn't need to jump through hoops to re-push stuff from my "other" > repo anymore than from the local repo. > > Yes refs/remotes/* isn't gu

Re: [PATCH v3 7/8] push: add DWYM support for "git push refs/remotes/...:"

2018-11-05 Thread Ævar Arnfjörð Bjarmason
e other hand, I do not think I mind all that much if a src that >>> is a tag object to automatically go to refs/tags/ (having a tag >>> object in refs/remotes/** is rare enough to matter in the first >>> place). >> >> Yeah maybe this is going too far. I don

Re: [PATCH v3 7/8] push: add DWYM support for "git push refs/remotes/...:"

2018-10-31 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: >> On the other hand, I do not think I mind all that much if a src that >> is a tag object to automatically go to refs/tags/ (having a tag >> object in refs/remotes/** is rare enough to matter in the first >> place). > > Yeah maybe

Re: [PATCH v3 7/8] push: add DWYM support for "git push refs/remotes/...:"

2018-10-29 Thread Ævar Arnfjörð Bjarmason
On Mon, Oct 29 2018, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> Add DWYM support for pushing a ref in refs/remotes/* when the > > I think most people call it do-what-*I*-mean, not do-what-you-mean. FWIW I picked this up from the perl list where both are

Re: [PATCH v3 7/8] push: add DWYM support for "git push refs/remotes/...:"

2018-10-29 Thread Ævar Arnfjörð Bjarmason
On Mon, Oct 29 2018, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> This is the first use of the %N$ style of printf format in >> the *.[ch] files in our codebase. It's supported by POSIX[2] and >> there's existing uses for it in po/*.po files,... > > For now, I'll eject this fro

Re: [PATCH v3 7/8] push: add DWYM support for "git push refs/remotes/...:"

2018-10-29 Thread Junio C Hamano
Junio C Hamano writes: > Ævar Arnfjörð Bjarmason writes: > >> This is the first use of the %N$ style of printf format in >> the *.[ch] files in our codebase. It's supported by POSIX[2] and >> there's existing uses for it in po/*.po files,... > > For now, I'll eject this from 'pu', as I had spen

Re: [PATCH v3 7/8] push: add DWYM support for "git push refs/remotes/...:"

2018-10-29 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > This is the first use of the %N$ style of printf format in > the *.[ch] files in our codebase. It's supported by POSIX[2] and > there's existing uses for it in po/*.po files,... For now, I'll eject this from 'pu', as I had spent way too much time trying to make

Re: [PATCH v3 7/8] push: add DWYM support for "git push refs/remotes/...:"

2018-10-28 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Add DWYM support for pushing a ref in refs/remotes/* when the I think most people call it do-what-*I*-mean, not do-what-you-mean. > ref is unqualified. Now instead of erroring out we support e.g.: > > $ ./git-push avar refs/remotes/origin/mas

[PATCH 58/78] config.txt: move remotes.* to a separate file

2018-10-26 Thread Nguyễn Thái Ngọc Duy
index b7aafdbf17..9aa849ce8b 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -395,9 +395,7 @@ include::config/receive.txt[] include::config/remote.txt[] -remotes.:: - The list of remotes which are fetched by "git remote update - ". See linkgit:gi

[PATCH v3 7/8] push: add DWYM support for "git push refs/remotes/...:"

2018-10-26 Thread Ævar Arnfjörð Bjarmason
Add DWYM support for pushing a ref in refs/remotes/* when the ref is unqualified. Now instead of erroring out we support e.g.: $ ./git-push avar refs/remotes/origin/master:upstream-master -n To github.com:avar/git.git * [new branch]origin/master -> upstream-mas

[PATCH v2 7/7] push: add DWYM support for "git push refs/remotes/...:"

2018-10-26 Thread Ævar Arnfjörð Bjarmason
Add DWYM support for pushing a ref in refs/remotes/* when the ref is unqualified, e.g.: git push origin refs/remotes/origin/master:upstream-master Before this we wouldn't know what do do with refs/remotes/origin/master, now we'll look it up and discover that it's a commit (or

[PATCH 44/59] config.txt: move remotes.* to a separate file

2018-10-20 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Documentation/config.txt | 4 +--- Documentation/remotes-config.txt | 3 +++ 2 files changed, 4 insertions(+), 3 deletions(-) create mode 100644 Documentation/remotes-config.txt diff --git a/Documentation/config.txt b/Documentation/config.txt

[PATCHv2 2/3] git-p4: unshelve into refs/remotes/p4-unshelved, not refs/remotes/p4/unshelved

2018-10-15 Thread Luke Diamand
The branch detection code looks for branches under refs/remotes/p4/... and can end up getting confused if there are unshelved changes in there as well. This happens in the function p4BranchesInGit(). Instead, put the unshelved changes into refs/remotes/p4-unshelved/. Signed-off-by: Luke Diamand

Re: [PATCHv1 2/3] git-p4: unshelve into refs/remotes/p4-unshelved, not refs/remotes/p4/unshelved

2018-10-15 Thread Luke Diamand
On Fri, 12 Oct 2018 at 19:19, Luke Diamand wrote: > > On Fri, 12 Oct 2018 at 14:45, Junio C Hamano wrote: > > > > Luke Diamand writes: > > > > > The branch detection code looks for branches under refs/remotes/p4/... > > > and can end up getting

Re: [PATCHv1 2/3] git-p4: unshelve into refs/remotes/p4-unshelved, not refs/remotes/p4/unshelved

2018-10-12 Thread Luke Diamand
On Fri, 12 Oct 2018 at 14:45, Junio C Hamano wrote: > > Luke Diamand writes: > > > The branch detection code looks for branches under refs/remotes/p4/... > > and can end up getting confused if there are unshelved changes in > > there as well. This happens in t

Re: [PATCHv1 2/3] git-p4: unshelve into refs/remotes/p4-unshelved, not refs/remotes/p4/unshelved

2018-10-12 Thread Junio C Hamano
Luke Diamand writes: > The branch detection code looks for branches under refs/remotes/p4/... > and can end up getting confused if there are unshelved changes in > there as well. This happens in the function p4BranchesInGit(). > > Instead, put the unshelved changes into refs/remot

[PATCHv1 2/3] git-p4: unshelve into refs/remotes/p4-unshelved, not refs/remotes/p4/unshelved

2018-10-11 Thread Luke Diamand
The branch detection code looks for branches under refs/remotes/p4/... and can end up getting confused if there are unshelved changes in there as well. This happens in the function p4BranchesInGit(). Instead, put the unshelved changes into refs/remotes/p4-unshelved/. Signed-off-by: Luke Diamand

Re: [PATCH v5 7/8] t0410: test fetching from many promisor remotes

2018-09-28 Thread Christian Couder
On Fri, Sep 28, 2018 at 12:35 PM SZEDER Gábor wrote: > > On Tue, Sep 25, 2018 at 01:53:40PM +0200, Christian Couder wrote: > > + IDX=$(cat promisorlist | sed "s/promisor$/idx/") && > > You could drop the unnecessary 'cat', 'sed' is capable to open a file > on its own. > > > + git verify-p

Re: [PATCH v5 7/8] t0410: test fetching from many promisor remotes

2018-09-28 Thread SZEDER Gábor
On Tue, Sep 25, 2018 at 01:53:40PM +0200, Christian Couder wrote: > From: Christian Couder > > Signed-off-by: Christian Couder > Signed-off-by: Junio C Hamano > --- > t/t0410-partial-clone.sh | 24 +++- > 1 file changed, 23 insertions(+), 1 deletion(-) > > diff --git a/t/t

[PATCH v5 7/8] t0410: test fetching from many promisor remotes

2018-09-25 Thread Christian Couder
From: Christian Couder Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano --- t/t0410-partial-clone.sh | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/t/t0410-partial-clone.sh b/t/t0410-partial-clone.sh index 8b32be6417..3fbd8d919e 100755

[PATCH v4 8/9] t0410: test fetching from many promisor remotes

2018-08-01 Thread Christian Couder
From: Christian Couder Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano --- t/t0410-partial-clone.sh | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/t/t0410-partial-clone.sh b/t/t0410-partial-clone.sh index 71a9b9a3e8..9d513ebf57 100755

Re: Proposed approaches to supporting HTTP remotes in "git archive"

2018-07-29 Thread René Scharfe
Am 28.07.2018 um 00:32 schrieb Junio C Hamano: > Josh Steadmon writes: > >> # Supporting HTTP remotes in "git archive" >> >> We would like to allow remote archiving from HTTP servers. There are a >> few possible implementations to be discussed: >> &g

Re: Proposed approaches to supporting HTTP remotes in "git archive"

2018-07-28 Thread brian m. carlson
er will generate the > archive which is then delivered to the client. > > ### Benefits > > * Matches existing "git archive" behavior for other remotes. > > * Requires less bandwidth to send a compressed archive than a shallow > clone. > >

Re: Proposed approaches to supporting HTTP remotes in "git archive"

2018-07-27 Thread Junio C Hamano
Josh Steadmon writes: > # Supporting HTTP remotes in "git archive" > > We would like to allow remote archiving from HTTP servers. There are a > few possible implementations to be discussed: > > ## Shallow clone to temporary repo > > This approach builds o

Re: Proposed approaches to supporting HTTP remotes in "git archive"

2018-07-27 Thread Jonathan Nieder
(just cc-ing René Scharfe, archive expert; Peff; Dscho; Franck Bui-Huu to see how his creation is evolving. Using the correct address for René this time. Sorry for the noise.) Josh Steadmon wrote: > # Supporting HTTP remotes in "git archive" > > We would like to allow remote

Re: Proposed approaches to supporting HTTP remotes in "git archive"

2018-07-27 Thread Jonathan Nieder
(just cc-ing René Scharfe, archive expert; Peff; Dscho; Franck Bui-Huu to see how his creation is evolving) Josh Steadmon wrote: > # Supporting HTTP remotes in "git archive" > > We would like to allow remote archiving from HTTP servers. There are a > few possible implement

Proposed approaches to supporting HTTP remotes in "git archive"

2018-07-27 Thread Josh Steadmon
# Supporting HTTP remotes in "git archive" We would like to allow remote archiving from HTTP servers. There are a few possible implementations to be discussed: ## Shallow clone to temporary repo This approach builds on existing endpoints. Clients will connect to the remote server&#x

[PATCH v3 8/9] t0410: test fetching from many promisor remotes

2018-07-13 Thread Christian Couder
From: Christian Couder Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano --- t/t0410-partial-clone.sh | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/t/t0410-partial-clone.sh b/t/t0410-partial-clone.sh index 71a9b9a3e8..9d513ebf57 100755

[PATCH v2 8/9] t0410: test fetching from many promisor remotes

2018-06-30 Thread Christian Couder
Signed-off-by: Christian Couder --- t/t0410-partial-clone.sh | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/t/t0410-partial-clone.sh b/t/t0410-partial-clone.sh index 71a9b9a3e8..9d513ebf57 100755 --- a/t/t0410-partial-clone.sh +++ b/t/t0410-partial-cl

[PATCH v1 08/11] t0410: test fetching from many promisor remotes

2018-06-23 Thread Christian Couder
Signed-off-by: Christian Couder --- t/t0410-partial-clone.sh | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/t/t0410-partial-clone.sh b/t/t0410-partial-clone.sh index 6af4712da8..4a7a662512 100755 --- a/t/t0410-partial-clone.sh +++ b/t/t0410-partial-cl

[PATCH v1 8/8] t0410: test fetching from many promisor remotes

2018-05-13 Thread Christian Couder
Signed-off-by: Christian Couder --- t/t0410-partial-clone.sh | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/t/t0410-partial-clone.sh b/t/t0410-partial-clone.sh index 6af4712da8..4a7a662512 100755 --- a/t/t0410-partial-clone.sh +++ b/t/t0410-partial-cl

Re: [PATCH v2 00/36] Promisor remotes and external ODB support

2018-03-19 Thread Junio C Hamano
patch series. > > This integration makes it possible to have many promisor and partial > clone remotes (instead of just one) with possibly different partial > clone filters, though that is not tested yet. > > I am not sure that the "external odb" name is still the best,

[PATCH v2 00/36] Promisor remotes and external ODB support

2018-03-19 Thread Christian Couder
. So the integration is much more complete now (though not fully complete), and this integration happens quite early in the patch series. This integration makes it possible to have many promisor and partial clone remotes (instead of just one) with possibly different partial clone filters, though that

[PATCH 00/40] Promisor remotes and external ODB support

2018-01-03 Thread Christian Couder
This is an early patch series that start to merge the jh/fsck-promisors patch series (which is currently in pu) with the external odb patch series. The merge is not complete and there is still work needed, but all the tests pass and in my opinion this shows that it is a good way forward to share t

[PATCH v2] describe: teach --match to handle branches and remotes

2017-09-19 Thread Max Kirillov
the + pattern, excluding respectively "refs/heads/" and "refs/remotes/" + prefix; references of other types are never considered. If given + multiple times, a list of patterns will be accumulated, and tags + matching any of the patterns will be considered. Use

Re: [PATCH] describe: teach --match to handle branches and remotes

2017-09-19 Thread Max Kirillov
On Tue, Sep 19, 2017 at 08:52:24AM +0900, Junio C Hamano wrote: > I think you can use skip_prefix() to avoid counting the length of > the prefix yourself, i.e. Thanks, will use it. > The hardcoded +10 for "is_tag" case assumes that anything other than > "refs/tags/something" would ever be used to

  1   2   3   4   >