Re: missing handling of "No newline at end of file" in git am

2017-02-20 Thread Eric Wong
Olaf Hering wrote: > On Tue, Feb 14, Olaf Hering wrote: > > > How would I debug it? > > One line is supposed to be longer than 998 chars, but something along > the way truncated it and corrupted the patch. 998 sounds like the SMTP limit. Perhaps git format-patch should emit binary diffs in tha

Re: missing handling of "No newline at end of file" in git am

2017-02-15 Thread Olaf Hering
On Tue, Feb 14, Olaf Hering wrote: > How would I debug it? One line is supposed to be longer than 998 chars, but something along the way truncated it and corrupted the patch. No idea why the error today is different from the error yesterday. 'git pull' has to be used in this case. Olaf signatu

Re: missing handling of "No newline at end of file" in git am

2017-02-14 Thread Olaf Hering
Am Tue, 14 Feb 2017 12:40:36 -0800 schrieb Junio C Hamano : > Olaf Hering writes: > > > How is git send-email and git am supposed to handle a text file > > which lacks a newline at the very end? This is about git 2.11.0. > > I think this has always worked, though. For me it complains in line

Re: missing handling of "No newline at end of file" in git am

2017-02-14 Thread Jeff King
On Tue, Feb 14, 2017 at 09:11:04PM +0100, Olaf Hering wrote: > How is git send-email and git am supposed to handle a text file which > lacks a newline at the very end? This is about git 2.11.0. That workflow should handle this case, and the resulting applied patch should not have a newline. > Ri

Re: missing handling of "No newline at end of file" in git am

2017-02-14 Thread Junio C Hamano
Olaf Hering writes: > How is git send-email and git am supposed to handle a text file which > lacks a newline at the very end? This is about git 2.11.0. I think this has always worked, though. $ cd /var/tmp/x $ git init am-incomplete-line $ cd am-incomplete-line/ $ echo one line

missing handling of "No newline at end of file" in git am

2017-02-14 Thread Olaf Hering
How is git send-email and git am supposed to handle a text file which lacks a newline at the very end? This is about git 2.11.0. Right now the patch in an email generated with 'git send-email' ends with '\ No newline at end of file', which 'git am' can not handle. To me it looks like whatever var