Re: gitconfig includes

2016-11-30 Thread Eli Barzilay
On Wed, Nov 30, 2016 at 2:06 PM, Jeff King wrote: > > I'm not sure what your script does exactly, but in general I think the > right thing for most scripts is _not_ to use a specific-file option > like --global. > > If the script is looking up a config value on behalf of a user, it > probably make

Re: gitconfig includes

2016-11-30 Thread Jeff King
On Wed, Nov 30, 2016 at 01:54:35PM -0500, Eli Barzilay wrote: > I don't have any strong opinion, but FWIW, the use case I have for this > is as follows: I sync my ~/.gitconfig between my own machine and a work > machine. On the work machine though, I like people to have work emails, > and I wrote

Re: gitconfig includes

2016-11-30 Thread Eli Barzilay
On Tue, Nov 29, 2016 at 4:50 PM, Junio C Hamano wrote: > Jeff King writes: > >> I think it's arguable whether "--global" should behave the same. > > I know you know this and I am writing this message for others. > > I admit that I wondered if "a single file" ought to cover these > short-hand nota

Re: gitconfig includes

2016-11-29 Thread Junio C Hamano
Jeff King writes: > I think it's arguable whether "--global" should behave the same. I know you know this and I am writing this message for others. I admit that I wondered if "a single file" ought to cover these short-hand notations like --global and --local while re-reading the log message of

Re: gitconfig includes

2016-11-29 Thread Jeff King
On Tue, Nov 29, 2016 at 02:53:08PM -0500, Eli Barzilay wrote: > > This already is documented, and I think it is clear enough. > > > >--[no-]includes > > Respect include.* directives in config files when > > looking up values. Defaults to off when a spec

Re: gitconfig includes

2016-11-29 Thread Eli Barzilay
On Tue, Nov 29, 2016 at 2:46 PM, Junio C Hamano wrote: > Eli Barzilay writes: > >> So this is at least a documentation issue,... > > This already is documented, and I think it is clear enough. > >--[no-]includes > Respect include.* directives in config files when >

Re: gitconfig includes

2016-11-29 Thread Junio C Hamano
Eli Barzilay writes: > So this is at least a documentation issue,... This already is documented, and I think it is clear enough. --[no-]includes Respect include.* directives in config files when looking up values. Defaults to off when a

gitconfig includes

2016-11-29 Thread Eli Barzilay
I just noticed something weird: if I have this in my ~/.gitconfig: [x] x = global [include] path = .gitconfig.more and .gitconfig.more has [x] x = more then I get: 1. git config x.x => more 2. git config --global x.x => global 3.