On Fri, Feb 19, 2016 at 9:33 AM, Junio C Hamano wrote:
> Jeff King writes:
>
>> That being said, I am not sure this is the right solution. In the thread
>> I linked earlier[1], Jens indicated he would prefer not to blindly share
>> config with the submodules, and I think I agree. Or are you propo
Jeff King writes:
> That being said, I am not sure this is the right solution. In the thread
> I linked earlier[1], Jens indicated he would prefer not to blindly share
> config with the submodules, and I think I agree. Or are you proposing to
> pick and choose the keys in GIT_CONFIG_PARAMETERS, a
On Thu, Feb 18, 2016 at 11:46 PM, Jeff King wrote:
> To trigger a credential fetch in actual use, you have to clone over
> http. See the credential tests in t5550, for example.
>
I'll look at these.
>> As for how to whitelist config to share with the submodule I am really
>> not 100% sure, since
On Thu, Feb 18, 2016 at 11:29:09PM -0800, Jacob Keller wrote:
> I would prefer to either.. blacklist stuff like core.worktree, or
> whitelist a bunch of stuff that makes sense. In this case though, I
> would prefer to have an explicit test of credential.helper, but I
> don't know if any of our tes
On Thu, Feb 18, 2016 at 8:30 PM, Jeff King wrote:
> On Thu, Feb 18, 2016 at 05:15:54PM -0800, Jacob Keller wrote:
>
>> I am looking at this more and I am stuck as to how best to provide a
>> test case.
>>
>> I think the problem as stated above is pretty straight forward, we
>> just want to stop cl
On Thu, Feb 18, 2016 at 05:15:54PM -0800, Jacob Keller wrote:
> I am looking at this more and I am stuck as to how best to provide a
> test case.
>
> I think the problem as stated above is pretty straight forward, we
> just want to stop clearing GIT_CONFIG_PARAMETERS but I can't find an
> easy wa
On Sun, Feb 7, 2016 at 7:44 PM, Jacob Keller wrote:
> On Sun, Feb 7, 2016 at 5:48 AM, Marc Strapetz
> wrote:
>> On 07.02.2016 05:41, Jacob Keller wrote:
>>>
>>> On Wed, Feb 3, 2016 at 3:44 PM, Jacob Keller
>>> wrote:
Ok so I am not sure we even really need to use "-c" option in
g
On Sun, Feb 7, 2016 at 5:48 AM, Marc Strapetz wrote:
> On 07.02.2016 05:41, Jacob Keller wrote:
>>
>> On Wed, Feb 3, 2016 at 3:44 PM, Jacob Keller
>> wrote:
>>>
>>> Ok so I am not sure we even really need to use "-c" option in
>>> git-clone considering that we can just use the same flow we do for
On 07.02.2016 05:41, Jacob Keller wrote:
On Wed, Feb 3, 2016 at 3:44 PM, Jacob Keller wrote:
Ok so I am not sure we even really need to use "-c" option in
git-clone considering that we can just use the same flow we do for
setting core.worktree values. I'll propose a patch with you two Cc'ed,
wh
On Wed, Feb 3, 2016 at 3:44 PM, Jacob Keller wrote:
> Ok so I am not sure we even really need to use "-c" option in
> git-clone considering that we can just use the same flow we do for
> setting core.worktree values. I'll propose a patch with you two Cc'ed,
> which I think fixes the issue. There m
On Tue, Feb 2, 2016 at 8:25 PM, Jeff King wrote:
> On Tue, Feb 02, 2016 at 06:13:14PM +0100, Marc Strapetz wrote:
>
>> git -c credential.helper=helper submodule update --init submodule
>>
>> does not invoke "helper", but falls back to the default strategies.
>> When configuring in ~/.gitconfig:
>>
On 03.02.2016 08:35, Jacob Keller wrote:
On Tue, Feb 2, 2016 at 8:25 PM, Jeff King wrote:
I think the problem is that when git "switches" to working in the
submodule repository, it clears the environment, which includes any "-c"
command switches. This makes sense for some situations, but not fo
On Tue, Feb 2, 2016 at 8:25 PM, Jeff King wrote:
> I think the problem is that when git "switches" to working in the
> submodule repository, it clears the environment, which includes any "-c"
> command switches. This makes sense for some situations, but not for
> others. This thread shows a simila
On Tue, Feb 02, 2016 at 06:13:14PM +0100, Marc Strapetz wrote:
> git -c credential.helper=helper submodule update --init submodule
>
> does not invoke "helper", but falls back to the default strategies.
> When configuring in ~/.gitconfig:
>
> [credential]
> helper=helper
>
> git submodule upd
git -c credential.helper=helper submodule update --init submodule
does not invoke "helper", but falls back to the default strategies.
When configuring in ~/.gitconfig:
[credential]
helper=helper
git submodule update --init submodule
works fine. This behavior is somewhat unexpected -- is this
15 matches
Mail list logo
