Re: git reveals a bug in (some versions) BSD diff

2005-08-15 Thread Johannes Schindelin
Hi, On Sat, 13 Aug 2005, Brad Roberts wrote: > I'm seeing this on a standard os/x 10.3.9 install which seems to have an > old, but still GNU based, diff. > > $ which diff > /usr/bin/diff > > $ diff --version > diff - GNU diffutils version 2.7 That is exactly the same as with 10.2.8. > [...]

Re: git reveals a bug in (some versions) BSD diff

2005-08-13 Thread Brad Roberts
I'm seeing this on a standard os/x 10.3.9 install which seems to have an old, but still GNU based, diff. $ which diff /usr/bin/diff $ diff --version diff - GNU diffutils version 2.7 $ sh ./t4101-apply-nonl.sh * ok 1: apply diff between 0 and 1 * ok 2: apply diff between 0 and 2 * ok 3: app

Re: git reveals a bug in (some versions) BSD diff

2005-08-12 Thread Junio C Hamano
Johannes Schindelin <[EMAIL PROTECTED]> writes: > I'd prefer to deprecate that diff program by telling so in the test. > Something along the lines "blabla. If this fails, chances are you have a > borked diff. Try GNU diff..." Wouldn't it give the people with broken diff a false impression that

Re: git reveals a bug in (some versions) BSD diff

2005-08-12 Thread Johannes Schindelin
Hi, On Fri, 12 Aug 2005, Junio C Hamano wrote: > Johannes Schindelin <[EMAIL PROTECTED]> writes: > > > Note the missing "\ No newline at end of file". The same happens on > > sourceforge's compile farm's OS 10.1 server, but not on its OS 10.2 > > server. > > > > How to go about that? Silently

Re: git reveals a bug in (some versions) BSD diff

2005-08-12 Thread Junio C Hamano
Johannes Schindelin <[EMAIL PROTECTED]> writes: > Note the missing "\ No newline at end of file". The same happens on > sourceforge's compile farm's OS 10.1 server, but not on its OS 10.2 > server. > > How to go about that? Silently ignore the missing line in apply.c? Force > users to update th

git reveals a bug in (some versions) BSD diff

2005-08-12 Thread Johannes Schindelin
Hi, big was my surprise when my daily routine of "git pull" && "make test" failed. "git bisect" revealed that commit 8e832e: "String comparison of test is done with '=', not '=='." was the culprit. But it isn't. The version of diff present on my iBook (OS 10.2.8) does not work properly in this