Re: git pull --upload-pack reversion in git 2.5.0

2015-07-31 Thread Junio C Hamano
Junio C Hamano writes: > On Thu, Jul 30, 2015 at 11:31 AM, Joey Hess wrote: >> I think this comes down to a lack of quoting where git-pull runs >> git-fetch. Before eb2a8d9ed3fca2ba2f617b704992d483605f3bb6, >> "$@" was passed through to git-fetch, but now there is a $upload_pack >> which is pass

Re: git pull --upload-pack reversion in git 2.5.0

2015-07-30 Thread Junio C Hamano
On Thu, Jul 30, 2015 at 11:31 AM, Joey Hess wrote: > I think this comes down to a lack of quoting where git-pull runs > git-fetch. Before eb2a8d9ed3fca2ba2f617b704992d483605f3bb6, > "$@" was passed through to git-fetch, but now there is a $upload_pack > which is passed without being quoted. Yes,

Re: git pull --upload-pack reversion in git 2.5.0

2015-07-30 Thread Joey Hess
I think this comes down to a lack of quoting where git-pull runs git-fetch. Before eb2a8d9ed3fca2ba2f617b704992d483605f3bb6, "$@" was passed through to git-fetch, but now there is a $upload_pack which is passed without being quoted. -- see shy jo signature.asc Description: Digital signature

Re: git pull --upload-pack reversion in git 2.5.0

2015-07-30 Thread Matthieu Moy
Joey Hess writes: > In git 2.1.4, I can run: git pull --upload-pack 'echo --foo' > > This also seems to work in 2.4.6, but in 2.5.0, the option parser > does something weird, apparently looking inside the quoted parameter > and parsing parameters in there: > > error: unknown option `foo' > usage:

git pull --upload-pack reversion in git 2.5.0

2015-07-30 Thread Joey Hess
In git 2.1.4, I can run: git pull --upload-pack 'echo --foo' This also seems to work in 2.4.6, but in 2.5.0, the option parser does something weird, apparently looking inside the quoted parameter and parsing parameters in there: error: unknown option `foo' usage: git fetch [] [ [...]] Needless t