Re: git config --get-urlmatch does not set exit code 1 when no match is found

2016-03-01 Thread Jeff King
On Mon, Feb 29, 2016 at 06:38:28PM +0530, Guilherme wrote: > @Peff Thank you for the heads up. > > I'm trying to find out if there are any credential helpers configured > in the system that will be running tests. On the dedicated test > machines that is not a problem but the developer machines ar

Re: git config --get-urlmatch does not set exit code 1 when no match is found

2016-02-29 Thread Guilherme
@Peff Thank you for the heads up. I'm trying to find out if there are any credential helpers configured in the system that will be running tests. On the dedicated test machines that is not a problem but the developer machines are. Should I already post a pre-emptive email asking about the corner

Re: git config --get-urlmatch does not set exit code 1 when no match is found

2016-02-29 Thread Jeff King
On Sun, Feb 28, 2016 at 10:09:12AM +0530, Guilherme wrote: > My current woes are with multi-valued configuration values. More > specifically credential.helper > > The documentation of git config says that when a value is not matched > it should return 1. > > To reproduce make sure that credentia

Re: [PATCH 0/3] Re: git config --get-urlmatch does not set exit code 1 when no match is found

2016-02-28 Thread Junio C Hamano
John Keeping writes: > Here's a series that changes the behaviour of "git config --get-urlmatch" > when no appropriate key is found as well as a couple of improvements to > the documentation while we're here. Sounds sensible. It does change the behaviour, but it is inevitable that a bugfix has

[PATCH 0/3] Re: git config --get-urlmatch does not set exit code 1 when no match is found

2016-02-28 Thread John Keeping
On Sun, Feb 28, 2016 at 10:45:57AM +, John Keeping wrote: > It looks to me like a simple bug that --get-urlmatch doesn't return 1 if > the key isn't found, but git-config(1) isn't entirely clear. The > overall documentation on exit codes at the end of DESCRIPTION says that > exit code 1 means:

Re: git config --get-urlmatch does not set exit code 1 when no match is found

2016-02-28 Thread John Keeping
On Sun, Feb 28, 2016 at 10:45:57AM +, John Keeping wrote: > On Sun, Feb 28, 2016 at 10:09:12AM +0530, Guilherme wrote: > > My current woes are with multi-valued configuration values. More > > specifically credential.helper > > > > The documentation of git config says that when a value is not m

Re: git config --get-urlmatch does not set exit code 1 when no match is found

2016-02-28 Thread John Keeping
On Sun, Feb 28, 2016 at 10:09:12AM +0530, Guilherme wrote: > My current woes are with multi-valued configuration values. More > specifically credential.helper > > The documentation of git config says that when a value is not matched > it should return 1. > > To reproduce make sure that credential

git config --get-urlmatch does not set exit code 1 when no match is found

2016-02-27 Thread Guilherme
Hello, My current woes are with multi-valued configuration values. More specifically credential.helper The documentation of git config says that when a value is not matched it should return 1. To reproduce make sure that credential.helper is not set. git config --get-urlmatch credential.helper