Re: git add -p—splitting hunks, limit is too large

2016-09-04 Thread Johannes Schindelin
Hi Peff, On Fri, 2 Sep 2016, Jeff King wrote: > The good news (or maybe the bad) is that "add -p" is implemented > entirely in Perl. :) Yeah, you would definitely not call this "good news" if you were in my shoes. There is no question that it has grown way too unwieldy and that we (once again,

Re: git add -p—splitting hunks, limit is too large

2016-09-04 Thread Johannes Schindelin
Hi Beau, On Fri, 2 Sep 2016, Beau Martinez wrote: > Hi git developers and community, > > I'd like to inquire as to why `git add -p` can only split hunks so > much. The limit is too large; why can't you split until each hunk is > only a line? I often have to run `edit` and split them manually > m

Re: git add -p—splitting hunks, limit is too large

2016-09-02 Thread Christian Neukirchen
Jeff King writes: > Splitting to single lines means you need to remember to add the matched > pairs, which might be arbitrarily far apart. That's not really any > different than dumping the hunk in your editor, but I find there that > it's easy to rearrange and group things as appropriate. My m

Re: git add -p—splitting hunks, limit is too large

2016-09-02 Thread Jeff King
On Fri, Sep 02, 2016 at 03:36:58PM +0100, Beau Martinez wrote: > I'd like to inquire as to why `git add -p` can only split hunks so > much. The limit is too large; why can't you split until each hunk is > only a line? I often have to run `edit` and split them manually > myself. There's some previ

git add -p—splitting hunks, limit is too large

2016-09-02 Thread Beau Martinez
Hi git developers and community, I'd like to inquire as to why `git add -p` can only split hunks so much. The limit is too large; why can't you split until each hunk is only a line? I often have to run `edit` and split them manually myself. I'd like to contribute a patch to change it, although my