Linus Torvalds writes:
> and the reason seems to be that the '\n' at the end got dropped as the
> old code was very confusing (the old code had two different '\n' cases
> for the "show filename or not").
>
> I think the right fix is this whitespace-damaged trivial one-liner:
>
> diff --git a/di
On Wed, Sep 27, 2017 at 2:02 PM, Linus Torvalds
wrote:
> On Wed, Sep 27, 2017 at 1:40 PM, Stefan Beller wrote:
>>
>> I disagree with this analysis, as the fix you propose adds the
>> new line unconditionally, i.e. this code path would be broken
>> regardless of "show filename or not".
>
> Right.
On Wed, Sep 27, 2017 at 1:40 PM, Stefan Beller wrote:
>
> I disagree with this analysis, as the fix you propose adds the
> new line unconditionally, i.e. this code path would be broken
> regardless of "show filename or not".
Right. Because it is what we want.
The old code (before that commit) us
On Wed, Sep 27, 2017 at 11:15 AM, Linus Torvalds
wrote:
> (ok, linewrapping in this email may make that look wrong - but the
> "mode change" land the "create mode" are both on the same line.
Thanks for the bug report.
> and the reason seems to be that the '\n' at the end got dropped as the
> ol
Current git shows file-mode changes incorrectly in the diffstat
summary, as I just noted from a pull request I did on the kernel.
The pull request *should* have resulted in a summary like this:
...
21 files changed, 247 insertions(+), 67 deletions(-)
mode change 100644 => 100755 tools/te
5 matches
Mail list logo
