Re: Remove old forgotten command: whatchanged

2013-08-13 Thread Junio C Hamano
Matthieu Moy writes: > Junio C Hamano writes: > >> +changes. You can emulate `git log` with a trivial script that pipes > > I'd say "You can emulate `git log` and `git log -p`" here, but I'm fine > with your version too. By `git log`, I meant "`git log` with its various options", as it felt un

Re: Remove old forgotten command: whatchanged

2013-08-13 Thread Matthieu Moy
Junio C Hamano writes: > +changes. You can emulate `git log` with a trivial script that pipes I'd say "You can emulate `git log` and `git log -p`" here, but I'm fine with your version too. > -[NOTE] > -Most likely, you are not directly using the core > -Git Plumbing commands, but using Porcela

Re: Remove old forgotten command: whatchanged

2013-08-09 Thread Junio C Hamano
Matthieu Moy writes: > Junio C Hamano writes: > >> It is meant to teach them "if you want to do your own 'git log', you >> can do so with 'rev-list' piped to 'diff-tree --stdin'". Changing >> 'whatchanged' to 'log' in the latter statement is an improvement, >> but dropping 'can be done by combi

Re: Remove old forgotten command: whatchanged

2013-08-09 Thread Matthieu Moy
Junio C Hamano writes: > It is meant to teach them "if you want to do your own 'git log', you > can do so with 'rev-list' piped to 'diff-tree --stdin'". Changing > 'whatchanged' to 'log' in the latter statement is an improvement, > but dropping 'can be done by combining rev-list and diff-tree' g

Re: Remove old forgotten command: whatchanged

2013-08-08 Thread Junio C Hamano
>> The above section primarily explains the use of diff-tree and it was >> appropriate back when git-whatchanged was a script. The intent of >> the whole document, not just this section, was to tickle the >> curiousity of the users and encourage them to see how the above >> "much more powerful" wh

Re: Remove old forgotten command: whatchanged

2013-08-08 Thread Damien Robert
Junio C Hamano wrote in message <7v61vg9eht@alter.siamese.dyndns.org>: > The "tutorial" was written in fairly early days of Git's history, in > order to primarily help those who want to use the plumbing command > to script their own Porcelain commands. As it says at the very > beginning, the

Re: Remove old forgotten command: whatchanged

2013-08-08 Thread Junio C Hamano
Matthieu Moy writes: > Damien Robert writes: > >> Matthieu Moy wrote in message : that confuses users. >>> >>> ... but I do agree that the doc is really confusing. It would be much >>> better if the doc could be reduced to: >>> >>> "This is a synonym for linkgit:git-log[1] --raw --some -

Re: Remove old forgotten command: whatchanged

2013-08-08 Thread Junio C Hamano
Damien Robert writes: > Matthieu Moy wrote in message : >>> that confuses users. >> >> ... but I do agree that the doc is really confusing. It would be much >> better if the doc could be reduced to: >> >> "This is a synonym for linkgit:git-log[1] --raw --some --other ---options. >> Please refe

Re: Remove old forgotten command: whatchanged

2013-08-08 Thread John Keeping
On Thu, Aug 08, 2013 at 08:06:09PM +0200, Matthieu Moy wrote: > --- a/Documentation/gitcore-tutorial.txt > +++ b/Documentation/gitcore-tutorial.txt > @@ -532,12 +532,7 @@ commit, and you can tell it to show a whole series of > diffs. > Alternatively, you can tell it to be "silent", and not show t

Re: Remove old forgotten command: whatchanged

2013-08-08 Thread Ramkumar Ramachandra
Damien Robert wrote: > If I may chime in as a user By all means. Do not feel inhibited to state your problems because you are a "user": we are all users; we eventually became contributors because we found certain things that needed fixing, and fixed them little by little. -- To unsubscribe from th

Re: Remove old forgotten command: whatchanged

2013-08-08 Thread Matthieu Moy
Damien Robert writes: > Matthieu Moy wrote in message : >>> that confuses users. >> >> ... but I do agree that the doc is really confusing. It would be much >> better if the doc could be reduced to: >> >> "This is a synonym for linkgit:git-log[1] --raw --some --other ---options. >> Please refe

Re: Remove old forgotten command: whatchanged

2013-08-08 Thread Damien Robert
Matthieu Moy wrote in message : >> that confuses users. > > ... but I do agree that the doc is really confusing. It would be much > better if the doc could be reduced to: > > "This is a synonym for linkgit:git-log[1] --raw --some --other ---options. > Please refer to the documentation of that co

Re: Remove old forgotten command: whatchanged

2013-08-08 Thread Junio C Hamano
Matthieu Moy writes: > I'd say either this, or add the missing features to "git log" to make my > suggestion possible (after all, if some people like "git whatchanged", > then maybe the feature would be of interest to "git log" users ?). There is no _missing feature_ per se. whatchanged by defa

Re: Remove old forgotten command: whatchanged

2013-08-08 Thread Matthieu Moy
Ramkumar Ramachandra writes: > Matthieu Moy wrote: >> ... but I do agree that the doc is really confusing. It would be much >> better if the doc could be reduced to: >> >> "This is a synonym for linkgit:git-log[1] --raw --some --other ---options. >> Please refer to the documentation of that comma

Re: Remove old forgotten command: whatchanged

2013-08-08 Thread Ramkumar Ramachandra
Matthieu Moy wrote: > ... but I do agree that the doc is really confusing. It would be much > better if the doc could be reduced to: > > "This is a synonym for linkgit:git-log[1] --raw --some --other ---options. > Please refer to the documentation of that command." I don't think there's an exact c

Re: Remove old forgotten command: whatchanged

2013-08-08 Thread Matthieu Moy
Ramkumar Ramachandra writes: > Junio C Hamano wrote: >> The only thing it does is to scratch an irrelevant itch by people >> who peek the codebase and find an old command whose existence does >> not even hurt them. They may have too much time on their hand, but >> that is not an excuse to waste

Re: Remove old forgotten command: whatchanged

2013-08-07 Thread Junio C Hamano
Stefan Beller writes: > Well if we make sure the whatchanged command can easily be reproduced > with the log command, we could add the missing parameters to it, hence > no change for the user. (git whatchanged == git log --raw --no-merges or > git log --wc [to be done yet]). > > So I did not mean

Re: Remove old forgotten command: whatchanged

2013-08-07 Thread Ramkumar Ramachandra
Junio C Hamano wrote: > The only thing it does is to scratch an irrelevant itch by people > who peek the codebase and find an old command whose existence does > not even hurt them. They may have too much time on their hand, but > that is not an excuse to waste other people's time by adding extra >

Re: Remove old forgotten command: whatchanged

2013-08-07 Thread Stefan Beller
On 08/07/2013 07:50 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> I'd deprecate it first for a year or such and remove it then. >> In the meantime we could implement already remove the code >> and change it to: >> >> + int cmd_whatchanged(int argc, const char **argv, const char *prefix)

Re: Remove old forgotten command: whatchanged

2013-08-07 Thread Kyle J. McKay
On Aug 7, 2013, at 11:31, John Keeping wrote: On Wed, Aug 07, 2013 at 11:01:57AM -0700, Kyle J. McKay wrote: On Aug 7, 2013, at 09:00, Ramkumar Ramachandra wrote: Hi, This is the difference between whatchanged and log: diff --git a/whatchanged b/log index fa1b223..004d9aa 100644 --- a/tmp/wha

Re: Remove old forgotten command: whatchanged

2013-08-07 Thread John Keeping
On Wed, Aug 07, 2013 at 11:01:57AM -0700, Kyle J. McKay wrote: > On Aug 7, 2013, at 09:00, Ramkumar Ramachandra wrote: > > Hi, > > > > This is the difference between whatchanged and log: > > > > diff --git a/whatchanged b/log > > index fa1b223..004d9aa 100644 > > --- a/tmp/whatchanged > > +++ b/tmp

Re: Remove old forgotten command: whatchanged

2013-08-07 Thread Kyle J. McKay
On Aug 7, 2013, at 09:00, Ramkumar Ramachandra wrote: Hi, This is the difference between whatchanged and log: diff --git a/whatchanged b/log index fa1b223..004d9aa 100644 --- a/tmp/whatchanged +++ b/tmp/log @@ -1,4 +1,4 @@ -int cmd_whatchanged(int argc, const char **argv, const char *prefix) +i

Re: Remove old forgotten command: whatchanged

2013-08-07 Thread Junio C Hamano
Stefan Beller writes: > I'd deprecate it first for a year or such and remove it then. > In the meantime we could implement already remove the code > and change it to: > > + int cmd_whatchanged(int argc, const char **argv, const char *prefix) > + { > + return cmd_log(argc, argv, prefix) > + }

Re: Remove old forgotten command: whatchanged

2013-08-07 Thread Stefan Beller
On 08/07/2013 06:00 PM, Ramkumar Ramachandra wrote: > Hi, > > This is the difference between whatchanged and log: > > diff --git a/whatchanged b/log > index fa1b223..004d9aa 100644 > --- a/tmp/whatchanged > +++ b/tmp/log > @@ -1,4 +1,4 @@ > -int cmd_whatchanged(int argc, const char **argv, const

Remove old forgotten command: whatchanged

2013-08-07 Thread Ramkumar Ramachandra
Hi, This is the difference between whatchanged and log: diff --git a/whatchanged b/log index fa1b223..004d9aa 100644 --- a/tmp/whatchanged +++ b/tmp/log @@ -1,4 +1,4 @@ -int cmd_whatchanged(int argc, const char **argv, const char *prefix) +int cmd_log(int argc, const char **argv, const char *pref